blender/blender
blender/blender
192
605
Fork 949
Code Issues 6.4k Pull Requests 1.1k Projects 22 Wiki Activity

Exact boolean modifier causes assert when adding existing item to set #83630

New Issue
Closed
opened 2020-12-10 14:29:47 +01:00 by Robert Guetzkow · 5 comments
Robert Guetzkow commented 2020-12-10 14:29:47 +01:00
Member
Copy Link

System Information
Operating system: Windows-10-10.0.19041-SP0 64 Bits
Graphics card: GeForce GTX 1080 Ti/PCIe/SSE2 NVIDIA Corporation 4.5.0 NVIDIA 457.30

Blender Version
Broken: version: 2.92.0 Alpha, branch: master, commit date: 2020-12-10 09:23, hash: e795ba1529
Worked: ?

Short description of error
The Boolean modifier may attempt to add duplicate keys to a set in a way that triggers an assert in debug builds of Blender. The function blender::meshintersect::Cell::add_patch uses add_new, which in turn call add_new__impl that expects the key to be new and not previously added to the set. In case the key already exists in the set an assert is triggered.

Exact steps for others to reproduce the error

  • Open the attached file.
  • Render it.

boolean-set-assert.blend

_BLI_assert_abort() Line 51	C
blender::Set<int,4,blender::PythonProbingStrategy<1,0>,blender::DefaultHash<int>,blender::DefaultEquality,blender::SimpleSetSlot<int>,blender::GuardedAllocator>::add_new__impl<int const &>(const int & key, const unsigned __int64 hash) Line 693	C++
blender::Set<int,4,blender::PythonProbingStrategy<1,0>,blender::DefaultHash<int>,blender::DefaultEquality,blender::SimpleSetSlot<int>,blender::GuardedAllocator>::add_new(const int & key) Line 245	C++
blender::meshintersect::Cell::add_patch(int p) Line 405	C++
blender::meshintersect::find_cells_from_edge(const blender::meshintersect::IMesh & tm, const blender::meshintersect::TriMeshTopology & tmtopo, blender::meshintersect::PatchesInfo & pinfo, blender::meshintersect::CellsInfo & cinfo, const blender::meshintersect::Edge e) Line 1141	C++
blender::meshintersect::find_cells(const blender::meshintersect::IMesh & tm, const blender::meshintersect::TriMeshTopology & tmtopo, blender::meshintersect::PatchesInfo & pinfo) Line 1193	C++
blender::meshintersect::boolean_trimesh(blender::meshintersect::IMesh & tm_in, blender::meshintersect::BoolOpType op, int nshapes, std::function<int __cdecl(int)> shape_fn, bool use_self, blender::meshintersect::IMeshArena * arena) Line 3372	C++
blender::meshintersect::boolean_mesh(blender::meshintersect::IMesh & imesh, blender::meshintersect::BoolOpType op, int nshapes, std::function<int __cdecl(int)> shape_fn, bool use_self, blender::meshintersect::IMesh * imesh_triangulated, blender::meshintersect::IMeshArena * arena) Line 3488	C++
blender::meshintersect::bmesh_boolean(BMesh * bm, BMLoop *- [x] * looptris, const int looptris_tot, int(*)(BMFace *, void *) test_fn, void * user_data, int nshapes, const bool use_self, const bool use_separate_all, const bool keep_hidden, const blender::meshintersect::BoolOpType boolean_mode) Line 391	C++
BM_mesh_boolean(BMesh * bm, BMLoop *- [x] * looptris, const int looptris_tot, int(*)(BMFace *, void *) test_fn, void * user_data, const int nshapes, const bool use_self, const bool keep_hidden, const int boolean_mode) Line 453	C++
BMD_mesh_intersection(BMesh * bm, ModifierData * md, const ModifierEvalContext * ctx, Mesh * mesh_operand_ob, Object * object, Object * operand_ob, bool is_flip) Line 420	C
modifyMesh(ModifierData * md, const ModifierEvalContext * ctx, Mesh * mesh) Line 677	C
BKE_modifier_modify_mesh(ModifierData * md, const ModifierEvalContext * ctx, Mesh * me) Line 1055	C
mesh_calc_modifiers(Depsgraph * depsgraph, Scene * scene, Object * ob, int useDeform, const bool need_mapping, const CustomData_MeshMasks * dataMask, const int index, const bool use_cache, const bool allow_shared_mesh, Mesh * * r_deform, Mesh * * r_final) Line 1183	C
mesh_build_data(Depsgraph * depsgraph, Scene * scene, Object * ob, const CustomData_MeshMasks * dataMask, const bool need_mapping) Line 1806	C
makeDerivedMesh(Depsgraph * depsgraph, Scene * scene, Object * ob, BMEditMesh * em, const CustomData_MeshMasks * dataMask) Line 1927	C
BKE_object_handle_data_update(Depsgraph * depsgraph, Scene * scene, Object * ob) Line 194	C
BKE_object_eval_uber_data(Depsgraph * depsgraph, Scene * scene, Object * ob) Line 385	C
 	[External Code]	
blender::deg::`anonymous namespace'::evaluate_node(const blender::deg::`anonymous-namespace'::DepsgraphEvalState * state, blender::deg::OperationNode * operation_node) Line 115	C++
blender::deg::`anonymous namespace'::deg_task_run_func(TaskPool * pool, void * taskdata) Line 127	C++
Task::()::__l2::<Lambdafunktion>() Line 118	C++
tbb::interface7::internal::delegated_function<void <Lambdafunktion>(void) const ,void>::operator()() Line 94	C++
 	[External Code]	
tbb::interface7::internal::isolate_impl<void,void <Lambdafunktion>(void) const>(const Task::()::__l2::void <Lambdafunktion>(void) & f) Line 161	C++
tbb::interface7::this_task_arena::isolate<void <Lambdafunktion>(void)>(const Task::()::__l2::void <Lambdafunktion>(void) & f) Line 396	C++
Task::operator()() Line 122	C++
tbb::internal::function_task<Task>::execute() Line 1049	C++
 	[External Code]
**System Information** Operating system: Windows-10-10.0.19041-SP0 64 Bits Graphics card: GeForce GTX 1080 Ti/PCIe/SSE2 NVIDIA Corporation 4.5.0 NVIDIA 457.30 **Blender Version** Broken: version: 2.92.0 Alpha, branch: master, commit date: 2020-12-10 09:23, hash: `e795ba1529` Worked: ? **Short description of error** The Boolean modifier may attempt to add duplicate keys to a set in a way that triggers an assert in debug builds of Blender. The function `blender::meshintersect::Cell::add_patch` uses `add_new`, which in turn call `add_new__impl` that expects the key to be new and not previously added to the set. In case the key already exists in the set an assert is triggered. **Exact steps for others to reproduce the error** - Open the attached file. - Render it. [boolean-set-assert.blend](https://archive.blender.org/developer/F9500167/boolean-set-assert.blend) ```lines _BLI_assert_abort() Line 51 C blender::Set<int,4,blender::PythonProbingStrategy<1,0>,blender::DefaultHash<int>,blender::DefaultEquality,blender::SimpleSetSlot<int>,blender::GuardedAllocator>::add_new__impl<int const &>(const int & key, const unsigned __int64 hash) Line 693 C++ blender::Set<int,4,blender::PythonProbingStrategy<1,0>,blender::DefaultHash<int>,blender::DefaultEquality,blender::SimpleSetSlot<int>,blender::GuardedAllocator>::add_new(const int & key) Line 245 C++ blender::meshintersect::Cell::add_patch(int p) Line 405 C++ blender::meshintersect::find_cells_from_edge(const blender::meshintersect::IMesh & tm, const blender::meshintersect::TriMeshTopology & tmtopo, blender::meshintersect::PatchesInfo & pinfo, blender::meshintersect::CellsInfo & cinfo, const blender::meshintersect::Edge e) Line 1141 C++ blender::meshintersect::find_cells(const blender::meshintersect::IMesh & tm, const blender::meshintersect::TriMeshTopology & tmtopo, blender::meshintersect::PatchesInfo & pinfo) Line 1193 C++ blender::meshintersect::boolean_trimesh(blender::meshintersect::IMesh & tm_in, blender::meshintersect::BoolOpType op, int nshapes, std::function<int __cdecl(int)> shape_fn, bool use_self, blender::meshintersect::IMeshArena * arena) Line 3372 C++ blender::meshintersect::boolean_mesh(blender::meshintersect::IMesh & imesh, blender::meshintersect::BoolOpType op, int nshapes, std::function<int __cdecl(int)> shape_fn, bool use_self, blender::meshintersect::IMesh * imesh_triangulated, blender::meshintersect::IMeshArena * arena) Line 3488 C++ blender::meshintersect::bmesh_boolean(BMesh * bm, BMLoop *- [x] * looptris, const int looptris_tot, int(*)(BMFace *, void *) test_fn, void * user_data, int nshapes, const bool use_self, const bool use_separate_all, const bool keep_hidden, const blender::meshintersect::BoolOpType boolean_mode) Line 391 C++ BM_mesh_boolean(BMesh * bm, BMLoop *- [x] * looptris, const int looptris_tot, int(*)(BMFace *, void *) test_fn, void * user_data, const int nshapes, const bool use_self, const bool keep_hidden, const int boolean_mode) Line 453 C++ BMD_mesh_intersection(BMesh * bm, ModifierData * md, const ModifierEvalContext * ctx, Mesh * mesh_operand_ob, Object * object, Object * operand_ob, bool is_flip) Line 420 C modifyMesh(ModifierData * md, const ModifierEvalContext * ctx, Mesh * mesh) Line 677 C BKE_modifier_modify_mesh(ModifierData * md, const ModifierEvalContext * ctx, Mesh * me) Line 1055 C mesh_calc_modifiers(Depsgraph * depsgraph, Scene * scene, Object * ob, int useDeform, const bool need_mapping, const CustomData_MeshMasks * dataMask, const int index, const bool use_cache, const bool allow_shared_mesh, Mesh * * r_deform, Mesh * * r_final) Line 1183 C mesh_build_data(Depsgraph * depsgraph, Scene * scene, Object * ob, const CustomData_MeshMasks * dataMask, const bool need_mapping) Line 1806 C makeDerivedMesh(Depsgraph * depsgraph, Scene * scene, Object * ob, BMEditMesh * em, const CustomData_MeshMasks * dataMask) Line 1927 C BKE_object_handle_data_update(Depsgraph * depsgraph, Scene * scene, Object * ob) Line 194 C BKE_object_eval_uber_data(Depsgraph * depsgraph, Scene * scene, Object * ob) Line 385 C [External Code] blender::deg::`anonymous namespace'::evaluate_node(const blender::deg::`anonymous-namespace'::DepsgraphEvalState * state, blender::deg::OperationNode * operation_node) Line 115 C++ blender::deg::`anonymous namespace'::deg_task_run_func(TaskPool * pool, void * taskdata) Line 127 C++ Task::()::__l2::<Lambdafunktion>() Line 118 C++ tbb::interface7::internal::delegated_function<void <Lambdafunktion>(void) const ,void>::operator()() Line 94 C++ [External Code] tbb::interface7::internal::isolate_impl<void,void <Lambdafunktion>(void) const>(const Task::()::__l2::void <Lambdafunktion>(void) & f) Line 161 C++ tbb::interface7::this_task_arena::isolate<void <Lambdafunktion>(void)>(const Task::()::__l2::void <Lambdafunktion>(void) & f) Line 396 C++ Task::operator()() Line 122 C++ tbb::internal::function_task<Task>::execute() Line 1049 C++ [External Code] ```
Robert Guetzkow commented 2020-12-10 14:29:47 +01:00
Author
Member
Copy Link

Added subscriber: @rjg

Added subscriber: @rjg
Robert Guetzkow commented 2020-12-10 14:31:13 +01:00
Author
Member
Copy Link

Added subscriber: @howardt

Added subscriber: @howardt
Robert Guetzkow commented 2020-12-10 14:33:02 +01:00
Author
Member
Copy Link

Changed status from 'Needs Triage' to: 'Confirmed'

Changed status from 'Needs Triage' to: 'Confirmed'
blender-admin commented 2020-12-10 15:11:43 +01:00
Copy Link

This issue was referenced by 1d447dcd19

This issue was referenced by 1d447dcd19120ed2fd14511589220438ce1904bc
Howard Trickey commented 2020-12-10 15:18:40 +01:00
Member
Copy Link

Changed status from 'Confirmed' to: 'Resolved'

Changed status from 'Confirmed' to: 'Resolved'
Howard Trickey self-assigned this 2020-12-10 15:18:40 +01:00
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
Interest
Alembic
Interest
Animation & Rigging
Interest
Asset System
Asset datablocks, libraries, browser and shelf
Interest
Audio
Interest
Automated Testing
Interest
BlendFile
Interest
Blender Asset Bundle
Interest
Code Documentation
Code comments, Python/RNA API descriptions
Interest
Collada
Interest
Compatibility
Backward and forward compatibility
Interest
Compositing
Interest
Core
Interest
Cycles
Interest
Dependency Graph
Interest
Development Management
Interest
EEVEE
Interest
FBX
FBX I/O related topics
Interest
Freestyle
Interest
Geometry Nodes
Interest
Grease Pencil
Interest
ID Management
Interest
Images & Movies
Interest
Import Export
Interest
Line Art
Interest
Masking
Interest
Metal
Interest
Modeling
Interest
Modifiers
Interest
Motion Tracking
Interest
Nodes & Physics
Interest
OpenGL
Interest
Overlay
Interest
Overrides
Interest
Performance
Interest
Physics
Interest
Pipeline & IO
Interest
Platforms & Builds
Interest
Python API
Interest
Render & Cycles
Interest
Render Pipeline
Interest
Sculpt, Paint & Texture
Interest
Text Editor
Interest
Translations
Interest
Triaging
Interest
USD
Interest
UV Editing
Interest
Undo
Interest
User Interface
Interest
VFX & Video
Interest
Video Sequencer
Interest
Viewport & EEVEE
Interest
Virtual Reality
Interest
Vulkan
Interest
Wayland
Wayland windowing on Unix
Interest
Workbench
Interest
glTF
glTF format I/O topics
Interest: X11
Xorg/X11 windowing
Legacy
Asset Browser Project
Archived
Legacy
Blender 2.8 Project
Archived
Legacy
Milestone 1: Basic, Local Asset Browser
Archived
Legacy
OpenGL Error
Archived
Meta
Good First Issue
Meta
Papercut
Meta
Retrospective
Meta
Security
Related to security, see policy: https://developer.blender.org/docs/handbook/bug_reports/vulnerability_reports/
Module
Animation & Rigging
Module
Asset System
Module
Core
Module
Development Management
Module
Grease Pencil
Module
Modeling
Module
Nodes & Physics
Module
Pipeline & IO
Module
Platforms & Builds
Module
Python API
Module
Render & Cycles
Module
Sculpt, Paint & Texture
Module
Triaging
Module
User Interface
Module
VFX & Video
Module
Viewport & EEVEE
Platform
FreeBSD
Platform
Linux
Platform
Windows
Platform
macOS
Severity
High
Severity
Low
Severity
Normal
Severity
Unbreak Now!
Status
Archived
Status
Confirmed
Status
Duplicate
Status
Needs Info from Developers
Status
Needs Information from User
Status
Needs Triage
Status
Resolved
Type
Bug
Type
Design
Type
Known Issue
Type
Patch
Archived
Type
Report
Archived
Type
To Do
No Label
Interest
Modeling
Module
Modeling
Severity
Normal
Status
Resolved
Type
Report
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
Hoshinova James-McCarthy-4 Sebastian-Herholz casey-bianco-davis gandalf3 Blendify Aaron Carlisle quantimoney Aditya Y Jeppu Alaska Alaska angavrilov Alexander Gavrilov frogstomp Aleš Jelovčan amelief Amélie Fondevilla elubie Andrea Weikert Andy_Goralczyk Andy Goralczyk ankitm Ankit Meel Anthony-Roberts Anthony Roberts antoniov Antonio Vazquez aras_p Aras Pranckevicius Arnd Arnd Marijnissen bartvdbraak Bart van der Braak mont29 Bastien Montagne blender-bot Blender Bot bnagirniak Bogdan Nagirniak BClark Brad Clark brecht Brecht Van Lommel BrianSavery Brian Savery (AMD) ideasman42 Campbell Barton CharlesWardlaw Charles Wardlaw CharlieJolly Charlie Jolly Chris_Blackbourn Chris Blackbourn lateasusual Chris Clyne (Lateasusual) ChrisLend Christoph Lendenfeld HobbesOS Cian Jinks fclem Clément Foucault cmbasnett Colin Basnett Kdaf Colin Marmond dfelinto Dalai Felinto pioverfour Damien Picard DanielBystedt Daniel Bystedt pepe-school-land Daniel Martinez Lara zanqdo Daniel Salazar Mets Demeter Dzadik erik85 Erik Abrahamsson EAW Evan Wilson filedescriptor Falk David fsiddi Francesco Siddi GaiaClary Gaia Clary DagerD Georgiy Markelov mano-wii Germano Cavalcante zazizizou Habib Gahbiche HooglyBoogly Hans Goudey Harley Harley Acheson weasel Henrik D. Hjalti Hjalti Hjálmarsson howardt Howard Trickey nirved-1 Hristo Gueorguiev mod_moder Iliya Katushenock brita Inês Almeida JacquesLucke Jacques Lucke Jason-Fielder Jason Fielder JasonSchleifer Jason schleifer Jebbly Jeffrey Liu Jeroen-Bakker Jeroen Bakker deadpin Jesse Yurkovich neXyon Joerg Mueller eliphaz John Kiril Swenson guitargeek Johnny Matthews Brainzman Jonas Holzman JoniMercado Jonatan Mercado JorgeBernalMartinez Jorge Bernal JosephEagar Joseph Eagar JoshuaLeung Joshua Leung Bone-Studio Juan Gea jpbouza-4 Juan Pablo Bouza JulianEisel Julian Eisel JulienDuroure Julien Duroure JulienKaspar Julien Kaspar kevindietrich Kévin Dietrich lone_noel Leon Schittek LucianoMunoz Luciano Muñoz Sessarego LukasStockner Lukas Stockner LukasTonne Lukas Tönne LunaRood Luna Rood MaiLavelle Mai Lavelle EosFoxx Marion Stalke Baardaap Martijn Versteegh scorpion81 Martin Felke mendio Matias Mendiola Matt-McLin Matt McLin MetinSeven Metin Seven wave Michael B Johnson Michael-Jones Michael Jones (Apple) makowalski Michael Kowalski pragma37 Miguel Pozo nrupsis Nate Rupsis jesterking Nathan Letwory nathanvegdahl Nathan Vegdahl PrototypeNM1 Nicholas Rishel nickberckley Nika Kutsniashvili Sirgienko Nikita Sirgienko OmarEmaraDev Omar Emara pablovazquez Pablo Vazquez PaoloAcampora Paolo Acampora PascalSchon Pascal Schön pmoursnv Patrick Mours muxed-reality Peter Kim lichtwerk Philipp Oeser P2design Pierrick PICAUT PratikPB2123 Pratik Borhade Limarest Ramil Roosileht farsthary Raul Fernandez Hernandez LazyDodo Ray molenkamp iss Richard Antalik rjg Robert Guetzkow salipour Sahar A. Kashi Sayak-Biswas Sayak Biswas Sean-Kim Sean Kim sherholz Sebastian Herholz sebastian_k Sebastian Koenig ZedDB Sebastian Parborg sebbas Sebastián Barschkis Sergey Sergey Sharybin IRIEShinsuke Shinsuke Irie sidd017 Siddhartha Jejurkar SietseB Sietse Brouwer SimonThommes Simon Thommes SonnyCampbell_Unity Sonny Campbell Stefan_Werner Stefan Werner Lockal Sv. Lockal dr.sybren Sybren A. Stüvel ThomasDinges Thomas Dinges Ton Ton Roosendaal BassamKurdali Ursula kurdali Vasyl-Pidhirskyi Vasyl Pidhirskyi WannesMalfait Wannes Malfait wbmoss_dev Wayde Moss weizhen Weizhen Huang leesonw William Leeson xavierh Xavier Hallade jenkm Yevgeny Makarov ChengduLittleA YimingWu gfxcoder jon denning
No Assignees Howard Trickey
3 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: blender/blender#83630
No description provided.
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?