VSE: snapping source strip right handle will incorrectly offset attached transform strip keyframes #84705

New Issue

Olivier Jolly · 2021-01-14T12:06:08+01:00

Olivier Jolly commented

2021-01-14 12:06:08 +01:00

System Information
Operating system: Debian 10
Graphics card: Radeon HD 7950 + GeForce GTX 1060

Blender Version
Broken: 2.90.0
Worked: 2.83.3

Short description of error

When extending a strip via snapping of its right handle, if it had an effect strip with keyframes, those keyframes are incorrectly offset beyond the source strip boundaries.

Exact steps for others to reproduce the error
With the attached .blend file, press shift + S to snap the right handle of the source strip to the playhead. It will change the transform strip keyframes to be incorrect.

I also attached a crude PoC patch which fixed my own use case. It's in no case intended to be usable as it is but just a hint at the piece of code probably responsible for the incorrect behaviour.

blender_vse_bug_transform_strip_offset_when_extending_source.blend

blender_vse_bug_transform_strip_offset_when_extending_source.patch

**System Information** Operating system: Debian 10 Graphics card: Radeon HD 7950 + GeForce GTX 1060 **Blender Version** Broken: 2.90.0 Worked: 2.83.3 **Short description of error** When extending a strip via snapping of its right handle, if it had an effect strip with keyframes, those keyframes are incorrectly offset beyond the source strip boundaries. **Exact steps for others to reproduce the error** With the attached .blend file, press shift + S to snap the right handle of the source strip to the playhead. It will change the transform strip keyframes to be incorrect. I also attached a crude PoC patch which fixed my own use case. It's in no case intended to be usable as it is but just a hint at the piece of code probably responsible for the incorrect behaviour. [blender_vse_bug_transform_strip_offset_when_extending_source.blend](https://archive.blender.org/developer/F9578493/blender_vse_bug_transform_strip_offset_when_extending_source.blend) [blender_vse_bug_transform_strip_offset_when_extending_source.patch](https://archive.blender.org/developer/F9578494/blender_vse_bug_transform_strip_offset_when_extending_source.patch) ![Capture d’écran du 2021-01-14 11-48-57.png](https://archive.blender.org/developer/F9578484/Capture_d_écran_du_2021-01-14_11-48-57.png) ![Capture d’écran du 2021-01-14 11-50-10.png](https://archive.blender.org/developer/F9578486/Capture_d_écran_du_2021-01-14_11-50-10.png)

Olivier Jolly commented

2021-01-14 12:06:08 +01:00

Added subscriber: @zeograd

Germano Cavalcante commented

2021-01-14 21:47:53 +01:00

Added subscriber: @mano-wii

Germano Cavalcante commented

2021-01-14 21:47:53 +01:00

Changed status from 'Needs Triage' to: 'Confirmed'

Germano Cavalcante commented

2021-01-14 21:47:53 +01:00

I can confirm the problem, in fact I don't think the snap on just one side of the strip should affect the f-curve. The behavior would combine better with that of transform.
For a better review of the patch, I recommend submitting it through the https://developer.blender.org/differential/diff/create/

I can confirm the problem, in fact I don't think the snap on just one side of the strip should affect the f-curve. The behavior would combine better with that of transform. For a better review of the patch, I recommend submitting it through the https://developer.blender.org/differential/diff/create/

Olivier Jolly commented

2021-01-14 22:55:31 +01:00

I've created D10116 as advised. I also included the fact that either handle snapping won't change the related strip keyframes.

I've created [D10116](https://archive.blender.org/developer/D10116) as advised. I also included the fact that either handle snapping won't change the related strip keyframes.

blender-admin commented

2021-01-25 05:51:36 +01:00

This issue was referenced by 5501a5de32

This issue was referenced by 5501a5de32db99a944fc6edfb02e3ba2d07de772

Richard Antalik commented

2021-01-25 06:00:43 +01:00

Changed status from 'Confirmed' to: 'Resolved'

Richard Antalik closed this issue

2021-01-25 06:00:43 +01:00

Richard Antalik self-assigned this 2021-01-25 06:00:43 +01:00

Sign in to join this conversation.

No Label

Download

What's New

Blender Studio

Manual

Developers Blog

Documentation

Benchmark

Blender Conference

Development Fund

One-time Donations

VSE: snapping source strip right handle will incorrectly offset attached transform strip keyframes #84705