Generic gizmo tweak - remapping enable/ disable precision #85383

New Issue

Hologram · 2021-02-04T19:40:03+01:00

Hologram commented

2021-02-04 19:40:03 +01:00

Blender Version
Tested in: 2.83.0 and 2.91.2
Operating system Windows 10.

Short description of error
When remapping enable/disable precision mode in the Generic Gizmo Modal map from Shift to either alt, A, or Grless () it does not enable precision mode. Note, these are the only three other buttons I have tested.
This is likely to occur on other keymaps too, see mapping in the screenshot below. Since the right shift key is the default key and hasn't been remapped, it still enables precision mode, so the mode is working on my end. Just not the remapping of the keys.

Exact steps for others to reproduce the error
Move the default cube, hit the assigned hotkey to enable/ disable precision and you'll see that it does not have any influence, whereas it still does when using the right shift button.

**Blender Version** Tested in: 2.83.0 and 2.91.2 Operating system Windows 10. **Short description of error** When remapping enable/disable precision mode in the Generic Gizmo Modal map from Shift to either alt, A, or Grless (\) it does not enable precision mode. Note, these are the only three other buttons I have tested. This is likely to occur on other keymaps too, see mapping in the screenshot below. Since the right shift key is the default key and hasn't been remapped, it still enables precision mode, so the mode is working on my end. Just not the remapping of the keys. ![afbeelding.png](https://archive.blender.org/developer/F9632998/afbeelding.png) **Exact steps for others to reproduce the error** Move the default cube, hit the assigned hotkey to enable/ disable precision and you'll see that it does not have any influence, whereas it still does when using the right shift button.

Hologram commented

2021-02-04 19:40:03 +01:00

Added subscriber: @Hologram

Germano Cavalcante commented

2021-02-05 22:33:46 +01:00

Added subscriber: @mano-wii

Germano Cavalcante commented

2021-02-05 22:33:46 +01:00

Keymodifiers other than Ctrl, Shift, Alt, OSkey are treated differently.
There is a way to get around this limitation in simple keymaps. See #68621 (Keymap: custom key modifiers work inconsistently).
But I'm not sure how it works on modal keymaps.

Keymodifiers other than `Ctrl, Shift, Alt, OSkey` are treated differently. There is a way to get around this limitation in simple keymaps. See #68621 (Keymap: custom key modifiers work inconsistently). But I'm not sure how it works on modal keymaps.

Germano Cavalcante commented

2021-02-09 16:04:28 +01:00

Changed status from 'Needs Triage' to: 'Archived'

Germano Cavalcante closed this issue

2021-02-09 16:04:28 +01:00

Germano Cavalcante commented

2021-02-09 16:04:28 +01:00

There is confusion in this report.
In the steps to reproduce the bug you mentioned moving the Cube.
In that case you're looking at the wrong keymap.
The keymaps that affect the modal tool of the move are called "Transform Modal Map".

However, the precision key modal is unfortunately hardcoded. Cannot be customized by the user :\

I don't think it needs to be hardcoded, I will investigate the code.

But I am closing this report as it is not clear what the real bug is since the steps to reproduce the bug show one thing and the description shows another.

There is confusion in this report. In the steps to reproduce the bug you mentioned moving the Cube. In that case you're looking at the wrong keymap. The keymaps that affect the modal tool of the move are called "`Transform Modal Map`". However, the precision key modal is unfortunately hardcoded. Cannot be customized by the user :\ I don't think it needs to be hardcoded, I will investigate the code. But I am closing this report as it is not clear what the real bug is since the steps to reproduce the bug show one thing and the description shows another.

Hologram commented

2021-02-09 16:09:38 +01:00

The confusion is probably stemming from the unavailability of the precision mode within the Transform modal map.
So I presumed this entry within the gizmo tweak modal map was the same thing.
In that case it is indeed likely that by adding the precision mode as user-configurable keymap under the Transform modal map, the issue is fixed.
Could you report back here if you managed to remove the hard-coded limitation?

The confusion is probably stemming from the unavailability of the precision mode within the Transform modal map. So I presumed this entry within the gizmo tweak modal map was the same thing. In that case it is indeed likely that by adding the precision mode as user-configurable keymap under the Transform modal map, the issue is fixed. Could you report back here if you managed to remove the hard-coded limitation?

Germano Cavalcante commented

2021-02-09 16:35:01 +01:00

The hard-coded limitation has been removed ;)

I am confident that change is safe, but generally this type of change has some unpredictable side effects in other modal keymaps.
I did several tests, but if any problems arise in this area, please report.

The hard-coded limitation has been removed ;) I am confident that change is safe, but generally this type of change has some unpredictable side effects in other modal keymaps. I did several tests, but if any problems arise in this area, please report.

Hologram commented

2021-02-09 16:38:52 +01:00

That's quick, thanks! I'll be sure to properly test this (and report if necessary) after the next release.

Hologram commented

2021-02-28 10:13:04 +01:00

@mano-wii I just tested the enable/ disable precision remapping in 2.92 for the generic gizmo tweak:

Any other key than shift still won't enable/ disable precision, whereas precision is enabled/ disabled using Right shift (since I didn't modify this).
Just to confirm was the fix added to 2.92?

@mano-wii I just tested the enable/ disable precision remapping in 2.92 for the generic gizmo tweak: ![afbeelding.png](https://archive.blender.org/developer/F9851238/afbeelding.png) Any other key than shift still won't enable/ disable precision, whereas precision is enabled/ disabled using Right shift (since I didn't modify this). Just to confirm was the fix added to 2.92?

Sign in to join this conversation.

No Label

Download

What's New

Blender Studio

Manual

Developers Blog

Documentation

Benchmark

Blender Conference

Development Fund

One-time Donations

Generic gizmo tweak - remapping enable/ disable precision #85383