Rigify: slow face rig generation #85643

New Issue

Mikhail Vigovskiy · 2021-02-15T04:04:36+01:00

Mikhail Vigovskiy commented

2021-02-15 04:04:36 +01:00

Is there any reason for super_face rig to use legacy copy_bone function? I changed it to new one that doesn't do any mode switches and haven't found any issues with the generated rig, but it made rig generation much faster.

diff --git a/rigify/rigs/faces/super_face.py b/rigify/rigs/faces/super_face.py
index 6cf2cd35..152f81ae 100644
--- a/rigify/rigs/faces/super_face.py
+++ b/rigify/rigs/faces/super_face.py
@@ -1,6 +1,6 @@
 import bpy, re
 from   mathutils      import Vector
-from   ...utils       import copy_bone, flip_bone
+from   ...utils       import copy_bone_simple as copy_bone, flip_bone
 from   ...utils       import org, strip_org, make_deformer_name, connected_children_names, make_mechanism_name
 from   ...utils       import create_widget
 from   ...utils.mechanism import make_property

Is there any reason for super_face rig to use legacy copy_bone function? I changed it to new one that doesn't do any mode switches and haven't found any issues with the generated rig, but it made rig generation much faster. ``` diff --git a/rigify/rigs/faces/super_face.py b/rigify/rigs/faces/super_face.py index 6cf2cd35..152f81ae 100644 --- a/rigify/rigs/faces/super_face.py +++ b/rigify/rigs/faces/super_face.py @@ -1,6 +1,6 @@ import bpy, re from mathutils import Vector -from ...utils import copy_bone, flip_bone +from ...utils import copy_bone_simple as copy_bone, flip_bone from ...utils import org, strip_org, make_deformer_name, connected_children_names, make_mechanism_name from ...utils import create_widget from ...utils.mechanism import make_property ```

Mikhail Vigovskiy commented

2021-02-15 04:04:36 +01:00

Added subscriber: @upliner

Mikhail Vigovskiy commented

2021-02-15 22:47:43 +01:00

I've already implemented better solution for this problem. When I test it enough I'll submit it for Differential review.
3304f3578f

I've already implemented better solution for this problem. When I test it enough I'll submit it for Differential review. https://github.com/Upliner/blender-addons/commit/3304f3578fa621ced532465de13b2876a8e63aac

Omar Emara commented

2022-03-11 17:27:40 +01:00

Added subscriber: @OmarEmaraDev

Omar Emara commented

2022-03-11 17:27:40 +01:00

Changed status from 'Needs Triage' to: 'Archived'

Omar Emara closed this issue

2022-03-11 17:27:40 +01:00

Omar Emara commented

2022-03-11 17:27:40 +01:00

Thanks for the report, since the tracker is only for bugs and error and you are already working on a patch, then we can close this.

Sign in to join this conversation.

No Label

Download

What's New

Blender Studio

Manual

Developers Blog

Documentation

Benchmark

Blender Conference

Development Fund

One-time Donations

Rigify: slow face rig generation #85643