Theme's "Active Modifier Outline" gives error whilst saving theme #85830

New Issue

Sylwia Ptasinska · 2021-02-21T00:02:52+01:00

Sylwia Ptasinska commented

2021-02-21 00:02:52 +01:00

Operating system: Manjaro Linux Kernel 5.10.15-1, KDE Plasma 5.20.5
Graphics card: XFX AMD RX 570

Blender Version: 2.93.0 Alpha, 5dced2a063, master, 2021-02-20

Changing color in "Active Modifier Outline" in Themes/Properties works only for current session. Saving theme cause error (I uploaded blender.crash.txt).

Changing a record in theme directly ("properties" -> "ThemeProperties" -> "active_modifier") doesn't show any errors, but to make it to work it has to be activated manually from Preferences after starting each session.

Operating system: Manjaro Linux Kernel 5.10.15-1, KDE Plasma 5.20.5 Graphics card: XFX AMD RX 570 Blender Version: 2.93.0 Alpha, 5dced2a0636a, master, 2021-02-20 Changing color in "Active Modifier Outline" in Themes/Properties works only for current session. Saving theme cause error (I uploaded blender.crash.txt). Changing a record in theme directly ("properties" -> "ThemeProperties" -> "active_modifier") doesn't show any errors, but to make it to work it has to be activated manually from Preferences after starting each session.

Sylwia Ptasinska commented

2021-02-21 00:02:52 +01:00

Added subscriber: @Eleuth

Hans Goudey commented

2021-02-21 00:56:56 +01:00

Added subscriber: @HooglyBoogly

Hans Goudey commented

2021-02-21 00:56:56 +01:00

Changed status from 'Needs Triage' to: 'Confirmed'

Hans Goudey commented

2021-02-21 00:56:56 +01:00

Thanks for the report. I can reproduce the part about the theme not saving properly, the value is reset when the file loads. I'm not quite sure what's going on though, because I also get an error when creating a new theme, even with this RNA property removed

Error: Python: Traceback (most recent call last):
  File "/home/hans/Documents/Blender-Git/build_linux_debug_lite/bin/2.93/scripts/startup/bl_operators/presets.py", line 134, in execute
    rna_xml.xml_file_write(context,
  File "/home/hans/Documents/Blender-Git/build_linux_debug_lite/bin/2.93/scripts/modules/rna_xml.py", line 400, in xml_file_write
    rna2xml(fw,
  File "/home/hans/Documents/Blender-Git/build_linux_debug_lite/bin/2.93/scripts/modules/rna_xml.py", line 81, in rna2xml
    property_typemap = build_property_typemap(skip_classes, skip_typemap)
  File "/home/hans/Documents/Blender-Git/build_linux_debug_lite/bin/2.93/scripts/modules/rna_xml.py", line 30, in build_property_typemap
    if issubclass(cls, skip_classes):
TypeError: issubclass() arg 1 must be a class

Thanks for the report. I can reproduce the part about the theme not saving properly, the value is reset when the file loads. I'm not quite sure what's going on though, because I also get an error when creating a new theme, even with this RNA property removed ``` Error: Python: Traceback (most recent call last): File "/home/hans/Documents/Blender-Git/build_linux_debug_lite/bin/2.93/scripts/startup/bl_operators/presets.py", line 134, in execute rna_xml.xml_file_write(context, File "/home/hans/Documents/Blender-Git/build_linux_debug_lite/bin/2.93/scripts/modules/rna_xml.py", line 400, in xml_file_write rna2xml(fw, File "/home/hans/Documents/Blender-Git/build_linux_debug_lite/bin/2.93/scripts/modules/rna_xml.py", line 81, in rna2xml property_typemap = build_property_typemap(skip_classes, skip_typemap) File "/home/hans/Documents/Blender-Git/build_linux_debug_lite/bin/2.93/scripts/modules/rna_xml.py", line 30, in build_property_typemap if issubclass(cls, skip_classes): TypeError: issubclass() arg 1 must be a class ```

Pratik Borhade commented

2023-01-04 08:13:20 +01:00

Added subscriber: @PratikPB2123