Bezier Curve handles stopped moving towards/away from Bezier Point with Scale #86046

New Issue

Sergey Kritskiy · 2021-02-27T09:52:09+01:00

Sergey Kritskiy commented

2021-02-27 09:52:09 +01:00

System Information
Operating system: Windows-10-10.0.18362-SP0 64 Bits
Graphics card: GeForce RTX 2070 SUPER/PCIe/SSE2 NVIDIA Corporation 4.5.0 NVIDIA 461.40

Blender Version
Broken: version: 2.93.0 Alpha, branch: master, commit date: 2021-02-25 05:34, hash: 0e1c6a29cb
Worked: 2.92 Release

Short description of error
In 2.92 I'm able to use Scale on a single Curve Handle to move it away or towards bezier Point:

In the latest update of 2.93 I'm not able to do that:

Exact steps for others to reproduce the error

create a Bezier Curve
Go to Edit Mode and select a point Handle
Use Scale (S) to move the Handle

Uploading a scene just for sanity check:
curve.blend

**System Information** Operating system: Windows-10-10.0.18362-SP0 64 Bits Graphics card: GeForce RTX 2070 SUPER/PCIe/SSE2 NVIDIA Corporation 4.5.0 NVIDIA 461.40 **Blender Version** Broken: version: 2.93.0 Alpha, branch: master, commit date: 2021-02-25 05:34, hash: `0e1c6a29cb` Worked: 2.92 Release **Short description of error** In 2.92 I'm able to use `Scale` on a single Curve Handle to move it away or towards bezier Point: ![292.gif](https://archive.blender.org/developer/F9845782/292.gif) In the latest update of 2.93 I'm not able to do that: ![293.gif](https://archive.blender.org/developer/F9845786/293.gif) **Exact steps for others to reproduce the error** 1) create a Bezier Curve 2) Go to Edit Mode and select a point Handle 3) Use `Scale` (`S`) to move the Handle Uploading a scene just for sanity check: [curve.blend](https://archive.blender.org/developer/F9845796/curve.blend)

Sergey Kritskiy commented

2021-02-27 09:52:09 +01:00

Added subscriber: @Sergey-Kritskiy

Falk David commented

2021-02-27 13:14:19 +01:00

Added subscriber: @filedescriptor

Falk David commented

2021-02-27 13:14:19 +01:00

Changed status from 'Needs Triage' to: 'Confirmed'

Falk David commented

2021-02-27 13:14:19 +01:00

I can confirm this on the latest 2.93.0 Alpha, branch: master, commit date: 2021-02-27 12:08, hash: 4b16cb1e9a. This seem like a regression.

I can confirm this on the latest 2.93.0 Alpha, branch: master, commit date: 2021-02-27 12:08, hash: `4b16cb1e9a`. This seem like a regression.

Dilith Jayakody commented

2021-03-19 09:48:13 +01:00

Added subscriber: @dilithjay

Dilith Jayakody commented

2021-03-19 09:48:13 +01:00

Hi. So I was taking a look at this bug and I found the following line (line 231) in source/blender/editors/transform/transform_convert_curve.c:

copy_v3_v3(td->center,  bezt->vec[(hide_handles || (t->around == V3D_AROUND_LOCAL_ORIGINS) ||  (bezt->f2 & SELECT)) ? 1 : 0]);

Turns out, if I replace the entire condition part and replace it with 1, the bug seems to be fixed; meaning that it was previously rotating about its own center instead of that of the control point. Can someone point out the purpose of the condition? The above seems to be reachable only when the handle is selected. So shouldn't its center always be that of the control point? Thanks.

Hi. So I was taking a look at this bug and I found the following line (line 231) in `source/blender/editors/transform/transform_convert_curve.c`: ``` copy_v3_v3(td->center, bezt->vec[(hide_handles || (t->around == V3D_AROUND_LOCAL_ORIGINS) || (bezt->f2 & SELECT)) ? 1 : 0]); ``` Turns out, if I replace the entire condition part and replace it with 1, the bug seems to be fixed; meaning that it was previously rotating about its own center instead of that of the control point. Can someone point out the purpose of the condition? The above seems to be reachable only when the handle is selected. So shouldn't its center always be that of the control point? Thanks.

Falk David commented

2021-03-19 11:08:10 +01:00

Dug into this a bit further. The reason is this commit 201ab7c540. The value t->around is no longer set to V3D_AROUND_LOCAL_ORIGINS when it should be.

So shouldn't its center always be that of the control point?

No, because you can select more than one handle of multiple control points. And in that case, it is important that the center is that of the handle so the real pivot can be calculated.

Dug into this a bit further. The reason is this commit 201ab7c540. The value `t->around` is no longer set to `V3D_AROUND_LOCAL_ORIGINS` when it should be. > So shouldn't its center always be that of the control point? No, because you can select more than one handle of multiple control points. And in that case, it is important that the center is that of the handle so the real pivot can be calculated.

Falk David self-assigned this 2021-03-19 11:08:16 +01:00

Dilith Jayakody commented

2021-03-19 12:54:19 +01:00

No, because you can select more than one handle of multiple control points. And in that case, it is important that the center is that of the handle so the real pivot can be calculated.

Oh, right. My bad. Thanks for the clarification.

> No, because you can select more than one handle of multiple control points. And in that case, it is important that the center is that of the handle so the real pivot can be calculated. Oh, right. My bad. Thanks for the clarification.

Germano Cavalcante commented

2021-03-22 04:47:55 +01:00

Added subscriber: @mano-wii