Import images as Brush set built in Add on not working. #86080

New Issue

Dirk · 2021-02-28T11:08:06+01:00

Dirk commented

2021-02-28 11:08:06 +01:00

System Information
Operating system: Windows-10-10.0.19041-SP0 64 Bits
Graphics card: GeForce RTX 3090/PCIe/SSE2 NVIDIA Corporation 4.5.0 NVIDIA 460.89

Blender Version
Broken: version: 2.93.0 Alpha, branch: master, commit date: 2021-02-13 23:23, hash: blender/blender@f362dad19b ---- and 2.92 + 2.91
Worked: Unknown

Short description of error
File > Import > Brush set is not working .

Exact steps for others to reproduce the error
In blender 2.91 or 2.92 or 2.93

Enable built in add on "Import-Export Import BrushSet"
File > Import > Brush Set
Select several .png images containing mask info (black and white) (zip file included)

See error message
Note the line containing the Brush 3.png . There are too many back slashes in the path.

Python: Traceback (most recent call last):
  File "C:\blender-2.93.0-f362dad19bf4-windows64\2.93\scripts\addons\io_import_BrushSet.py", line 121, in execute
    LoadBrushSet(self.properties.filepath, self.properties.filename)
  File "C:\blender-2.93.0-f362dad19bf4-windows64\2.93\scripts\addons\io_import_BrushSet.py", line 70, in LoadBrushSet
    for file in os.listdir(filepath):
NotADirectoryError: [WinError 267] The directory name is invalid: 'C:\\mask_set\\Brush 3.png'

location: <unknown location>:-1

mask_set.zip

**System Information** Operating system: Windows-10-10.0.19041-SP0 64 Bits Graphics card: GeForce RTX 3090/PCIe/SSE2 NVIDIA Corporation 4.5.0 NVIDIA 460.89 **Blender Version** Broken: version: 2.93.0 Alpha, branch: master, commit date: 2021-02-13 23:23, hash: `blender/blender@f362dad19b` ---- and 2.92 + 2.91 Worked: Unknown **Short description of error** File > Import > Brush set is not working . **Exact steps for others to reproduce the error** In blender 2.91 or 2.92 or 2.93 1) Enable built in add on "Import-Export Import BrushSet" 2) File > Import > Brush Set 3) Select several .png images containing mask info (black and white) (zip file included) See error message **Note the line containing the Brush 3.png . There are too many back slashes in the path.** ``` Python: Traceback (most recent call last): File "C:\blender-2.93.0-f362dad19bf4-windows64\2.93\scripts\addons\io_import_BrushSet.py", line 121, in execute LoadBrushSet(self.properties.filepath, self.properties.filename) File "C:\blender-2.93.0-f362dad19bf4-windows64\2.93\scripts\addons\io_import_BrushSet.py", line 70, in LoadBrushSet for file in os.listdir(filepath): NotADirectoryError: [WinError 267] The directory name is invalid: 'C:\\mask_set\\Brush 3.png' location: <unknown location>:-1 ``` [mask_set.zip](https://archive.blender.org/developer/F9851433/mask_set.zip)

Dirk commented

2021-02-28 11:08:06 +01:00

Added subscriber: @dirk_teucher

blender-admin commented

2021-02-28 11:08:06 +01:00

#100490 was marked as duplicate of this issue

blender-admin commented

2021-02-28 11:08:06 +01:00

blender/blender#100269 was marked as duplicate of this issue

blender-admin commented

2021-02-28 11:08:06 +01:00

#97798 was marked as duplicate of this issue

blender-admin commented

2021-02-28 11:08:06 +01:00

#96024 was marked as duplicate of this issue

blender-admin commented

2021-02-28 11:08:06 +01:00

#93597 was marked as duplicate of this issue

blender-admin commented

2021-02-28 11:08:06 +01:00

#93028 was marked as duplicate of this issue

blender-admin commented

2021-02-28 11:08:06 +01:00

#92337 was marked as duplicate of this issue

blender-admin commented

2021-02-28 11:08:06 +01:00

blender/blender#92013 was marked as duplicate of this issue

blender-admin commented

2021-02-28 11:08:06 +01:00

blender/blender#89819 was marked as duplicate of this issue

blender-admin commented

2021-02-28 11:08:06 +01:00

#88864 was marked as duplicate of this issue

blender-admin commented

2021-02-28 11:08:06 +01:00

#88865 was marked as duplicate of this issue

blender-admin commented

2021-02-28 11:08:06 +01:00

#88821 was marked as duplicate of this issue

blender-admin commented

2021-02-28 11:08:06 +01:00

#87405 was marked as duplicate of this issue

blender-admin commented

2021-02-28 11:08:06 +01:00

#87365 was marked as duplicate of this issue

Robert Guetzkow commented

2021-02-28 12:17:53 +01:00

Added subscriber: @rjg

Robert Guetzkow commented

2021-02-28 12:17:53 +01:00

Changed status from 'Needs Triage' to: 'Confirmed'

Robert Guetzkow commented

2021-02-28 12:17:53 +01:00

This is a bug. The add-on doesn't process the path(s) properly (or uses the file browser incorrectly, if the user is only supposed to select a directory).

Dirk commented

2021-03-01 10:48:16 +01:00

There is a workaround for this bug.
This bug only seems to happen when you select the images individually or as a group of images.
If you select the folder containing the brushes then click "Import BrushSet" twice then the textures do load.(2.92 + 2.93)

Selecting the folder does not work in 2.91

There is a workaround for this bug. This bug only seems to happen when you select the images individually or as a group of images. **If you select the folder containing the brushes then click "Import BrushSet" twice then the textures do load.(2.92 + 2.93)** Selecting the folder does not work in 2.91

Gorgious commented

2021-03-01 15:58:17 +01:00

Added subscriber: @nathan.hild

Gorgious commented

2021-03-01 15:58:17 +01:00

Hello, I fixed the add-on to be able to select indivual images, also added a few parameters : Add fake user, Overwrite existing images, and use verbose console output. How would I go about submitting it for review, if possible ?

The code is available over on https://github.com/Gorgious56/io_import_BrushSet/blob/main/io_import_BrushSet.py

Hello, I fixed the add-on to be able to select indivual images, also added a few parameters : Add fake user, Overwrite existing images, and use verbose console output. How would I go about submitting it for review, if possible ? The code is available over on https://github.com/Gorgious56/io_import_BrushSet/blob/main/io_import_BrushSet.py

Robert Guetzkow commented

2021-03-01 16:02:04 +01:00

@nathan.hild Please submit a patch as explained in the [code review page ]] in our Wiki. You can either use arcanist (section "Use Arcanist") or submit a plain diff (section "Upload a Diff"). I would suggest you split the parts that fix bugs and add new features if that is possible. In general it's a good idea to follow the [ https:*wiki.blender.org/wiki/Process/Contributing_Code | Ingredients of a Patch for new features.

If you have questions about the process, people on the blender-coders channel on blender.chat will help you.

@nathan.hild Please submit a patch as explained in the [code review page ]] in our Wiki. You can either use arcanist (section "Use Arcanist") or submit a plain diff (section "Upload a Diff"). I would suggest you split the parts that fix bugs and add new features if that is possible. In general it's a good idea to follow the [[ https:*wiki.blender.org/wiki/Process/Contributing_Code | Ingredients of a Patch ](https:*wiki.blender.org/wiki/Tools/CodeReview) for new features. If you have questions about the process, people on the [blender-coders ](https://blender.chat/channel/blender-coders) channel on blender.chat will help you.

Gorgious commented

2021-03-01 21:15:41 +01:00

Alright ! That was not without a sweat but I finally managed to commit it :

https://developer.blender.org/D10572

As you suggested this commit only contains the fix to allow users to select individual files.
I plan on updating it further if my addition is accepted by the team.

I guess I have to ping some developper to review it, how do I choose ? The add-ons modules mentions Campbell Barton, Bastien Montagne, Brendon Murphy, Jacques Lucke, Sybren Stüvel.

Thanks for the pointers :)

Alright ! That was not without a sweat but I finally managed to commit it : https://developer.blender.org/D10572 As you suggested this commit only contains the fix to allow users to select individual files. I plan on updating it further if my addition is accepted by the team. I guess I have to ping some developper to review it, how do I choose ? The add-ons modules mentions Campbell Barton, Bastien Montagne, Brendon Murphy, Jacques Lucke, Sybren Stüvel. Thanks for the pointers :)

Robert Guetzkow commented

2021-04-10 16:04:11 +02:00

Added subscriber: @titan2792

Dirk commented

2021-04-10 16:11:00 +02:00

Does this still need to be reviewed? Or has it been merged into master?

Robert Guetzkow commented

2021-04-10 16:27:12 +02:00

@dirk_teucher The patch has not been reviewed yet.

Robert Guetzkow commented

2021-04-12 12:27:46 +02:00

Added subscriber: @waltage

Robert Guetzkow commented

2021-06-05 10:18:48 +02:00

Added subscriber: @markli

Robert Guetzkow commented

2021-06-05 15:19:34 +02:00

Added subscriber: @GavinWyatt

Robert Guetzkow commented

2021-07-12 19:18:02 +02:00

Added subscriber: @CarlForeman

Robert Guetzkow commented

2021-10-07 18:48:22 +02:00

Added subscriber: @Narek-1

Pratik Borhade commented

2021-10-19 12:12:34 +02:00

Added subscribers: @Laci, @PratikPB2123

Gorgious commented

2021-10-19 14:51:57 +02:00

Hello, could we maybe talk about assigning someone to this task ?

It looks like the combined time it took bug triagers and bug reporters up until this point outweighs the time it may take someone to look over the 26 lines I changed in the addon code :p

Cheers

Hello, could we maybe talk about assigning someone to this task ? It looks like the combined time it took bug triagers and bug reporters up until this point outweighs the time it may take someone to look over the 26 lines I changed in the addon code :p Cheers

Pratik Borhade commented

2021-11-12 09:48:35 +01:00

Added subscriber: @DannyBCreative

Pratik Borhade commented

2021-12-03 13:07:47 +01:00

Added subscriber: @plazma

Nico Traber commented

2022-01-23 17:18:47 +01:00

Added subscriber: @Nico-Traber

Robert Guetzkow commented

2022-04-27 12:23:05 +02:00

Added subscribers: @Shady.Hamza, @ThomasDinges

Robert Guetzkow commented

2022-05-03 23:24:11 +02:00

Added subscriber: @MIDIManNI

Robert Guetzkow commented

2022-08-07 21:07:24 +02:00

Added subscriber: @hamiltonjr2

Robert Guetzkow commented

2022-08-19 09:27:46 +02:00

Added subscriber: @gundanlei

Pratik Borhade commented

2023-03-09 14:57:01 +01:00

Alright ! That was not without a sweat but I finally managed to commit it :

https://developer.blender.org/D10572

@nathan.hild hi, can you submit PR for it?
@ideasman42 , can you review it? original author of the add-on doesn't seem active anymore.

> Alright ! That was not without a sweat but I finally managed to commit it : > > https://developer.blender.org/D10572 @nathan.hild hi, can you submit PR for it? @ideasman42 , can you review it? original author of the add-on doesn't seem active anymore.

🎉 1

Pratik Borhade referenced this issue

2023-08-04 11:10:34 +02:00

Python: Traceback NotADirectoryError when importing a PNG brush #104816

Sign in to join this conversation.