Cycles: AttributeNode: Unexpected result when setting a nonexistent attribute #86121

Closed
opened 2021-03-01 11:38:11 +01:00 by Ilja Razinkov · 13 comments

System Information
Operating system: MacOs BigSur 11.2.1
Graphics card: Radeon Pro 570X 4 GB

Blender Version
Broken: 2.92.0 release (2021-02-24 16:25)
Worked: 2.91.2

Short description of error
At least on MacOS, in an Attribute Node, when a non-existent attribute (previous vertex group) is set, last used color in scene is used, even being of a completely unrelated object.

AttributeNode "leaks" data from one object to another. Not only color, but alpha value (exist/not exist) too
Look at video for better understanding, see attached example blend
Screen Recording 2021-03-01 at 13.29.30.mov

Exact steps for others to reproduce the error

  • Open attached file (in the material there are 2 Attribute Nodes with attributes of different objects)
  • Switch between the two attributes
    Look at objects - they will BOTH have colors from the one, not from the object itself
    AttriubuteNodeBug.blend
**System Information** Operating system: MacOs BigSur 11.2.1 Graphics card: Radeon Pro 570X 4 GB **Blender Version** Broken: 2.92.0 release (2021-02-24 16:25) Worked: 2.91.2 **Short description of error** At least on MacOS, in an Attribute Node, when a non-existent attribute (previous vertex group) is set, last used color in scene is used, even being of a completely unrelated object. AttributeNode "leaks" data from one object to another. Not only color, but alpha value (exist/not exist) too Look at video for better understanding, see attached example blend [Screen Recording 2021-03-01 at 13.29.30.mov](https://archive.blender.org/developer/F9856027/Screen_Recording_2021-03-01_at_13.29.30.mov) **Exact steps for others to reproduce the error** - Open attached file (in the material there are 2 Attribute Nodes with attributes of different objects) - Switch between the two attributes Look at objects - they will BOTH have colors from the one, not from the object itself [AttriubuteNodeBug.blend](https://archive.blender.org/developer/F9856036/AttriubuteNodeBug.blend)
Author

Added subscriber: @IPv6

Added subscriber: @IPv6
Author

Problem exist in 2.93 too (current latest alpha) - but leaking happens only from green to red, see screenshots
With this bug half of my nodes simply produce trash for now :(

Screenshot 2021-03-01 at 13.44.34.png

Screenshot 2021-03-01 at 13.44.41.png

Problem exist in 2.93 too (current latest alpha) - but leaking happens only from green to red, see screenshots With this bug half of my nodes simply produce trash for now :( ![Screenshot 2021-03-01 at 13.44.34.png](https://archive.blender.org/developer/F9856049/Screenshot_2021-03-01_at_13.44.34.png) ![Screenshot 2021-03-01 at 13.44.41.png](https://archive.blender.org/developer/F9856051/Screenshot_2021-03-01_at_13.44.41.png)
Ilja Razinkov changed title from AttributeNode completely broken to Cycles+OSL: AttributeNode broken 2021-03-01 12:25:50 +01:00

Added subscriber: @mano-wii

Added subscriber: @mano-wii

In my case, objects without the attribute are black.
GIF.gif

I think this is the expected result (what is the color of a non-existent vertex color).

The strange thing about your image is that it appears green.


(I'm not sure what this report has to do with OSL. The Attribute node is not from OSL).

In my case, objects without the attribute are black. ![GIF.gif](https://archive.blender.org/developer/F9863238/GIF.gif) I think this is the expected result (what is the color of a non-existent vertex color). The strange thing about your image is that it appears green. --- (I'm not sure what this report has to do with OSL. The Attribute node is not from OSL).
Author
  • Regarding black - yes, this is totally expected! This is how it worked in 2.91 (and all the previous versions)

  • In my case non-existent vertex group "produce" (from material nodes view point) last used color in scene on completely unrelated object. When red is attached and green is non-existent -> it became red also, same with green vertex group. Reproducable in 100% of cases on my mac (and many nodes from my materials are not working because of this) :(

  • This happens not only with color - but with "Alpha" socket too! It also leaks 1.0 even when vertex group not exist on current object - this is 100% bug, since non-existent attribute should produce alpha == 0.0 according to the docs of the feature. I can record video demonstrating this if needed

  • i mentioned OSL because i use Cycles+OSL combination and this blend is configured to use this combination.

  • May be this is not important, but i already had some rough cases when OSL caches/optimizes something hardly internaly... and force user (me) to add intermediate nodes to "uncache" this "optimized" stuff. Such "color leak to non-existent attribute" can be produced by similar caching logic (just a guess)

- Regarding black - yes, this is totally expected! This is how it worked in 2.91 (and all the previous versions) - In my case non-existent vertex group "produce" (from material nodes view point) last used color in scene on completely unrelated object. When red is attached and green is non-existent -> it became red also, same with green vertex group. Reproducable in 100% of cases on my mac (and many nodes from my materials are not working because of this) :( - This happens not only with color - but with "Alpha" socket too! It also leaks 1.0 even when vertex group not exist on current object - this is 100% bug, since non-existent attribute should produce alpha == 0.0 according to the docs of the feature. I can record video demonstrating this if needed - i mentioned OSL because i use Cycles+OSL combination and this blend is configured to use this combination. - May be this is not important, but i already had some rough cases when OSL caches/optimizes something hardly internaly... and force user (me) to add intermediate nodes to "uncache" this "optimized" stuff. Such "color leak to non-existent attribute" can be produced by similar caching logic (just a guess)
Germano Cavalcante changed title from Cycles+OSL: AttributeNode broken to Cycles: AttributeNode: Unexpected result when setting a nonexistent attribute 2021-03-04 15:49:24 +01:00
Author

Some notes: seems a bug in MacOs-related. It is not present on Windows (just tested)

Some notes: seems a bug in MacOs-related. It is not present on Windows (just tested)

Changed status from 'Needs Triage' to: 'Confirmed'

Changed status from 'Needs Triage' to: 'Confirmed'

Added subscribers: @kevindietrich, @brecht

Added subscribers: @kevindietrich, @brecht

@kevindietrich on Linux I can confirm some kind of refresh issue, where some tiles in viewport are not using the new attribute immediately when switching between the attributes.

Can you check this? I imagine it's some missing update after the recent optimizations.

@kevindietrich on Linux I can confirm some kind of refresh issue, where some tiles in viewport are not using the new attribute immediately when switching between the attributes. Can you check this? I imagine it's some missing update after the recent optimizations.

I cannot reproduce in master (release or debug build), and I am having trouble compiling 2.92 because of the libraries change (is there a branch in SVN I can access still with the right libraries?).

I cannot reproduce in master (release or debug build), and I am having trouble compiling 2.92 because of the libraries change (is there a branch in SVN I can access still with the right libraries?).

Running make update in the blender-v2.92-release branch should checkout the right libraries.

But I confirmed this in master. I'm seeing some Asan warnings, will quickly check if I see the issue.

Running `make update` in the `blender-v2.92-release` branch should checkout the right libraries. But I confirmed this in master. I'm seeing some Asan warnings, will quickly check if I see the issue.

This issue was referenced by be51d671b5

This issue was referenced by be51d671b500e8b6881295778de7272a70504b71

Changed status from 'Confirmed' to: 'Resolved'

Changed status from 'Confirmed' to: 'Resolved'
Brecht Van Lommel self-assigned this 2021-03-15 20:47:55 +01:00
Sign in to join this conversation.
No Label
Interest
Alembic
Interest
Animation & Rigging
Interest
Asset Browser
Interest
Asset Browser Project Overview
Interest
Audio
Interest
Automated Testing
Interest
Blender Asset Bundle
Interest
BlendFile
Interest
Collada
Interest
Compatibility
Interest
Compositing
Interest
Core
Interest
Cycles
Interest
Dependency Graph
Interest
Development Management
Interest
EEVEE
Interest
EEVEE & Viewport
Interest
Freestyle
Interest
Geometry Nodes
Interest
Grease Pencil
Interest
ID Management
Interest
Images & Movies
Interest
Import Export
Interest
Line Art
Interest
Masking
Interest
Metal
Interest
Modeling
Interest
Modifiers
Interest
Motion Tracking
Interest
Nodes & Physics
Interest
OpenGL
Interest
Overlay
Interest
Overrides
Interest
Performance
Interest
Physics
Interest
Pipeline, Assets & IO
Interest
Platforms, Builds & Tests
Interest
Python API
Interest
Render & Cycles
Interest
Render Pipeline
Interest
Sculpt, Paint & Texture
Interest
Text Editor
Interest
Translations
Interest
Triaging
Interest
Undo
Interest
USD
Interest
User Interface
Interest
UV Editing
Interest
VFX & Video
Interest
Video Sequencer
Interest
Virtual Reality
Interest
Vulkan
Interest
Wayland
Interest
Workbench
Interest: X11
Legacy
Blender 2.8 Project
Legacy
Milestone 1: Basic, Local Asset Browser
Legacy
OpenGL Error
Meta
Good First Issue
Meta
Papercut
Meta
Retrospective
Meta
Security
Module
Animation & Rigging
Module
Core
Module
Development Management
Module
EEVEE & Viewport
Module
Grease Pencil
Module
Modeling
Module
Nodes & Physics
Module
Pipeline, Assets & IO
Module
Platforms, Builds & Tests
Module
Python API
Module
Render & Cycles
Module
Sculpt, Paint & Texture
Module
Triaging
Module
User Interface
Module
VFX & Video
Platform
FreeBSD
Platform
Linux
Platform
macOS
Platform
Windows
Priority
High
Priority
Low
Priority
Normal
Priority
Unbreak Now!
Status
Archived
Status
Confirmed
Status
Duplicate
Status
Needs Info from Developers
Status
Needs Information from User
Status
Needs Triage
Status
Resolved
Type
Bug
Type
Design
Type
Known Issue
Type
Patch
Type
Report
Type
To Do
No Milestone
No project
No Assignees
5 Participants
Notifications
Due Date
The due date is invalid or out of range. Please use the format 'yyyy-mm-dd'.

No due date set.

Dependencies

No dependencies set.

Reference: blender/blender#86121
No description provided.