Debug menu 22 fails with factory settings #86122

New Issue

Jeroen Bakker · 2021-03-01T11:45:57+01:00

Jeroen Bakker commented

2021-03-01 11:45:57 +01:00

Start blender and set debug value to 22 triggers an assert:

BLI_assert failed: source/blender/draw/intern/draw_manager_profiling.c:171, DRW_stats_reset(), at '(DTP.timer_increment - DTP.end_increment) <= 0 && "You forgot a DRW_stats_group/query_end somewhere!"'

Need to check where that somewhere is referring to :-)

DRW_stats_group_start:Workbench
DRW_stats_group_end
DRW_stats_group_start:Overlay
  DRW_stats_group_start:Outlines
  DRW_stats_group_end
DRW_stats_group_end
DRW_stats_reset

DRW_stats_group_start:Workbench
DRW_stats_group_end
DRW_stats_group_start:Overlay
  DRW_stats_group_start:Outlines
  DRW_stats_group_end
DRW_stats_group_end
DRW_stats_reset
DRW_stats_group_start:Workbench
DRW_stats_group_end
DRW_stats_group_start:Overlay
  DRW_stats_group_start:Outlines
  DRW_stats_group_end
DRW_stats_group_end
DRW_stats_reset
DRW_stats_group_start:Workbench
DRW_stats_group_end
DRW_stats_group_start:Overlay
  DRW_stats_group_start:Outlines
  DRW_stats_group_end
DRW_stats_group_end
DRW_stats_reset
DRW_stats_group_start:Workbench
DRW_stats_group_end
DRW_stats_group_start:Overlay
  DRW_stats_group_start:Outlines
  DRW_stats_group_end
DRW_stats_group_end
DRW_stats_reset
DRW_stats_group_start:Workbench
DRW_stats_group_end
DRW_stats_group_start:Overlay
  DRW_stats_group_start:Outlines
  DRW_stats_group_end
DRW_stats_group_end
DRW_stats_reset
DRW_stats_group_start:Workbench
DRW_stats_group_end
DRW_stats_group_start:Overlay
  DRW_stats_group_start:Outlines
  DRW_stats_group_end
DRW_stats_group_end
DRW_stats_reset
DRW_stats_group_start:Workbench
DRW_stats_group_end
DRW_stats_group_start:Overlay
  DRW_stats_group_start:Outlines
  DRW_stats_group_end
DRW_stats_group_end
DRW_stats_reset
DRW_stats_group_start:Workbench
DRW_stats_group_end
DRW_stats_group_start:Overlay
  DRW_stats_group_start:Outlines
  DRW_stats_group_end
DRW_stats_group_end
DRW_stats_reset
DRW_stats_group_start:Workbench
DRW_stats_group_end
DRW_stats_group_start:Overlay
  DRW_stats_group_start:Outlines
  DRW_stats_group_end
DRW_stats_group_end
DRW_stats_reset
DRW_stats_group_start:Workbench
DRW_stats_group_end
DRW_stats_group_start:Overlay
  DRW_stats_group_start:Outlines
  DRW_stats_group_end
DRW_stats_group_end
DRW_stats_reset
DRW_stats_group_start:Workbench
DRW_stats_group_end
DRW_stats_group_start:Overlay
  DRW_stats_group_start:Outlines
  DRW_stats_group_end
DRW_stats_group_end
DRW_stats_reset
DRW_stats_group_start:Workbench
DRW_stats_group_end
DRW_stats_group_start:Overlay
  DRW_stats_group_start:Outlines
  DRW_stats_group_end
DRW_stats_group_end
DRW_stats_reset
DRW_stats_group_start:Workbench
DRW_stats_group_end
DRW_stats_group_start:Overlay
  DRW_stats_group_start:Outlines
  DRW_stats_group_end
DRW_stats_group_end
DRW_stats_reset
DRW_stats_group_start:Workbench
DRW_stats_group_end
DRW_stats_group_start:Overlay
  DRW_stats_group_start:Outlines
  DRW_stats_group_end
DRW_stats_group_end
DRW_stats_reset
DRW_stats_group_start:Workbench
DRW_stats_group_end
DRW_stats_group_start:Overlay
  DRW_stats_group_start:Outlines
  DRW_stats_group_end
DRW_stats_group_end
DRW_stats_reset

Doesn't seem like an issue with the group start/end

Start blender and set debug value to 22 triggers an assert: ``` BLI_assert failed: source/blender/draw/intern/draw_manager_profiling.c:171, DRW_stats_reset(), at '(DTP.timer_increment - DTP.end_increment) <= 0 && "You forgot a DRW_stats_group/query_end somewhere!"' ``` Need to check where that somewhere is referring to :-) ``` DRW_stats_group_start:Workbench DRW_stats_group_end DRW_stats_group_start:Overlay DRW_stats_group_start:Outlines DRW_stats_group_end DRW_stats_group_end DRW_stats_reset DRW_stats_group_start:Workbench DRW_stats_group_end DRW_stats_group_start:Overlay DRW_stats_group_start:Outlines DRW_stats_group_end DRW_stats_group_end DRW_stats_reset DRW_stats_group_start:Workbench DRW_stats_group_end DRW_stats_group_start:Overlay DRW_stats_group_start:Outlines DRW_stats_group_end DRW_stats_group_end DRW_stats_reset DRW_stats_group_start:Workbench DRW_stats_group_end DRW_stats_group_start:Overlay DRW_stats_group_start:Outlines DRW_stats_group_end DRW_stats_group_end DRW_stats_reset DRW_stats_group_start:Workbench DRW_stats_group_end DRW_stats_group_start:Overlay DRW_stats_group_start:Outlines DRW_stats_group_end DRW_stats_group_end DRW_stats_reset DRW_stats_group_start:Workbench DRW_stats_group_end DRW_stats_group_start:Overlay DRW_stats_group_start:Outlines DRW_stats_group_end DRW_stats_group_end DRW_stats_reset DRW_stats_group_start:Workbench DRW_stats_group_end DRW_stats_group_start:Overlay DRW_stats_group_start:Outlines DRW_stats_group_end DRW_stats_group_end DRW_stats_reset DRW_stats_group_start:Workbench DRW_stats_group_end DRW_stats_group_start:Overlay DRW_stats_group_start:Outlines DRW_stats_group_end DRW_stats_group_end DRW_stats_reset DRW_stats_group_start:Workbench DRW_stats_group_end DRW_stats_group_start:Overlay DRW_stats_group_start:Outlines DRW_stats_group_end DRW_stats_group_end DRW_stats_reset DRW_stats_group_start:Workbench DRW_stats_group_end DRW_stats_group_start:Overlay DRW_stats_group_start:Outlines DRW_stats_group_end DRW_stats_group_end DRW_stats_reset DRW_stats_group_start:Workbench DRW_stats_group_end DRW_stats_group_start:Overlay DRW_stats_group_start:Outlines DRW_stats_group_end DRW_stats_group_end DRW_stats_reset DRW_stats_group_start:Workbench DRW_stats_group_end DRW_stats_group_start:Overlay DRW_stats_group_start:Outlines DRW_stats_group_end DRW_stats_group_end DRW_stats_reset DRW_stats_group_start:Workbench DRW_stats_group_end DRW_stats_group_start:Overlay DRW_stats_group_start:Outlines DRW_stats_group_end DRW_stats_group_end DRW_stats_reset DRW_stats_group_start:Workbench DRW_stats_group_end DRW_stats_group_start:Overlay DRW_stats_group_start:Outlines DRW_stats_group_end DRW_stats_group_end DRW_stats_reset DRW_stats_group_start:Workbench DRW_stats_group_end DRW_stats_group_start:Overlay DRW_stats_group_start:Outlines DRW_stats_group_end DRW_stats_group_end DRW_stats_reset DRW_stats_group_start:Workbench DRW_stats_group_end DRW_stats_group_start:Overlay DRW_stats_group_start:Outlines DRW_stats_group_end DRW_stats_group_end DRW_stats_reset ``` Doesn't seem like an issue with the group start/end

Jeroen Bakker self-assigned this 2021-03-01 11:45:57 +01:00

Jeroen Bakker commented

2021-03-01 11:45:57 +01:00

Added subscriber: @Jeroen-Bakker

Jeroen Bakker commented

2021-03-02 14:19:37 +01:00

P2007: (An Untitled Masterwork)

diff --git a/source/blender/draw/intern/draw_manager_profiling.c b/source/blender/draw/intern/draw_manager_profiling.c
index 98a6b2bff00..9bfc8d98fe4 100644
--- a/source/blender/draw/intern/draw_manager_profiling.c
+++ b/source/blender/draw/intern/draw_manager_profiling.c
@@ -151,7 +151,6 @@ void DRW_stats_group_end(void)
 void DRW_stats_query_start(const char *name)
 {
   GPU_debug_group_begin(name);
-  drw_stats_timer_start_ex(name, false);
   drw_stats_timer_start_ex(name, true);
 }

is a proposed fix. Seems like two timers were created

[P2007: (An Untitled Masterwork)](https://archive.blender.org/developer/P2007.txt) ``` diff --git a/source/blender/draw/intern/draw_manager_profiling.c b/source/blender/draw/intern/draw_manager_profiling.c index 98a6b2bff00..9bfc8d98fe4 100644 --- a/source/blender/draw/intern/draw_manager_profiling.c +++ b/source/blender/draw/intern/draw_manager_profiling.c @@ -151,7 +151,6 @@ void DRW_stats_group_end(void) void DRW_stats_query_start(const char *name) { GPU_debug_group_begin(name); - drw_stats_timer_start_ex(name, false); drw_stats_timer_start_ex(name, true); } ``` is a proposed fix. Seems like two timers were created

blender-admin commented

2021-03-02 14:25:52 +01:00

This issue was referenced by ca2044f72b

This issue was referenced by ca2044f72b1023c0df1389af813c36217a67ceca

Jeroen Bakker commented

2021-03-02 14:27:58 +01:00

Changed status from 'Needs Triage' to: 'Resolved'

Jeroen Bakker closed this issue

2021-03-02 14:27:58 +01:00

Sign in to join this conversation.

No Label

Download

What's New

Blender Studio

Manual

Developers Blog

Documentation

Benchmark

Blender Conference

Development Fund

One-time Donations

Debug menu 22 fails with factory settings #86122