Asset Browser: add more info about selected asset to context #86270

New Issue

Sybren A. Stüvel · 2021-03-04T15:01:35+01:00

Sybren A. Stüvel commented

2021-03-04 15:01:35 +01:00

The pose library needs to temporarily load a pose Action. This can be done with the context manager implemented in D10612: PyAPI: add bpy.types.BlendFile.temp_data for temporary library loading:

with bpy.types.BlendData.temp_data() as temp_data:
    with temp_data.libraries.load(asset_library_file) as (data_from, data_to):
        data_to.actions = [pose_asset_name]

    pose.apply_pose_from_action(data_to.actions[0])

(for the pose.apply_pose_from_action() function, see D10578)

This requires three things that currently aren't available in the Asset Browser's context, though:

The library file containing the selected asset,
the name of the selected asset, and
the ID datablock type of the selected asset, so that it can be checked in a poll() function.

The goal of this task is to add this info to the context.

#86270-asset-info-in-context.zip

This ZIP contains three blend files:

asset_library/pose_assets.blend: contains a bunch of pose assets
example_file.blend: the file to open. It auto-registers //asset_library as asset library, and shows the asset browser in the top right corner. It has a panel that prints the contents of the context to the terminal whenever it's redrawn.
character.blend: contains the rigged character "Bob the Bar" used in the other two files.

The pose library needs to temporarily load a pose Action. This can be done with the context manager implemented in [D10612: PyAPI: add bpy.types.BlendFile.temp_data for temporary library loading](https://archive.blender.org/developer/D10612): ``` with bpy.types.BlendData.temp_data() as temp_data: with temp_data.libraries.load(asset_library_file) as (data_from, data_to): data_to.actions = [pose_asset_name] pose.apply_pose_from_action(data_to.actions[0]) ``` (for the `pose.apply_pose_from_action()` function, see [D10578](https://archive.blender.org/developer/D10578)) This requires three things that currently aren't available in the Asset Browser's context, though: - The library file containing the selected asset, - the name of the selected asset, and - the ID datablock type of the selected asset, so that it can be checked in a `poll()` function. The goal of this task is to add this info to the context. ------------------ [#86270-asset-info-in-context.zip](https://archive.blender.org/developer/F9866104/T86270-asset-info-in-context.zip) This ZIP contains three blend files: - `asset_library/pose_assets.blend`: contains a bunch of pose assets - `example_file.blend`: **the file to open**. It auto-registers `//asset_library` as asset library, and shows the asset browser in the top right corner. It has a panel that prints the contents of the context to the terminal whenever it's redrawn. - `character.blend`: contains the rigged character "Bob the Bar" used in the other two files.

Campbell Barton was assigned by Sybren A. Stüvel

2021-03-04 15:01:35 +01:00

Sybren A. Stüvel commented

2021-03-04 15:01:35 +01:00

Changed status from 'Needs Triage' to: 'Confirmed'

Sybren A. Stüvel commented

2021-03-04 15:01:35 +01:00

Added subscriber: @dr.sybren

Julian Eisel commented

2021-03-31 17:08:56 +02:00

Added subscriber: @JulianEisel

Julian Eisel commented

2021-03-31 17:08:56 +02:00

I've done a number of changes in the asset-browser-poselib branch, and I think this is addressed now.
Note that this context doesn't only matter for the Asset Browser, but also for the asset view UI template.

Newly added:

CTX_wm_asset_library(): Gives the asset library (AssetLibraryReference) of the workspace, for the regular UI to use; the Asset Browser overrides it with its own.
CTX_wm_asset_handle(): The active asset handle, the asset view template sets this for operators and menus spawned from it to use; the Asset Browser sets it too.
I'm not happy about the current AssetHandle design, it's just a wrapper around a FileDirEntry, which is how we store the asset information currently. Instead it could be an opaque handle with an API to query info (path relative to the library, name, preview, etc.). I have ideas for this but it needs a number of changes and is part of further work.

The ID type of an asset can be gotten with FileDirEntry.blentype.

I've done a number of changes in the `asset-browser-poselib` branch, and I think this is addressed now. Note that this context doesn't only matter for the Asset Browser, but also for the asset view UI template. Newly added: * `CTX_wm_asset_library()`: Gives the asset library (`AssetLibraryReference`) of the workspace, for the regular UI to use; the Asset Browser overrides it with its own. * `CTX_wm_asset_handle()`: The active asset handle, the asset view template sets this for operators and menus spawned from it to use; the Asset Browser sets it too. I'm not happy about the current `AssetHandle` design, it's just a wrapper around a `FileDirEntry`, which is how we store the asset information currently. Instead it could be an opaque handle with an API to query info (path relative to the library, name, preview, etc.). I have [ideas ](https://hackmd.io/@blender-asset-browser/B19v6heSO) for this but it needs a number of changes and is part of further work. The ID type of an asset can be gotten with `FileDirEntry.blentype`.

Sybren A. Stüvel commented

2021-07-16 10:29:57 +02:00

Changed status from 'Confirmed' to: 'Resolved'

Sybren A. Stüvel closed this issue

2021-07-16 10:29:57 +02:00

Sybren A. Stüvel commented

2021-07-16 10:29:57 +02:00

Marking as Resolved as the work has landed in master.

Brecht Van Lommel added the

Download

What's New

Blender Studio

Manual

Developers Blog

Documentation

Benchmark

Blender Conference

Development Fund

One-time Donations

Asset Browser: add more info about selected asset to context #86270