uv.select operator is hardcoded to cycle #86382

New Issue

Ludvik Koutny · 2021-03-08T10:33:45+01:00

Ludvik Koutny commented

2021-03-08 10:33:45 +01:00

System Information
Operating system: Windows-10-10.0.19041-SP0 64 Bits
Graphics card: GeForce GTX 1080 Ti/PCIe/SSE2 NVIDIA Corporation 4.5.0 NVIDIA 461.40

Blender Version
Broken: version: 2.92.0, branch: master (modified), commit date: 2021-02-24 16:25, hash: 02948a2cab
Worked: (newest version of Blender that worked as expected)

Short description of error
When using uv.select operator in "Extend" mode, the selection cycles between selection and deselection instead of always extending the existing selection, and operator has no option to turn this behavior off. This is inconsistent with rest of selection operators in other Blender editors.

Exact steps for others to reproduce the error

Map the uv.select operator to Shift Left Mouse in the UV Editor (Global) context as shown in the screenshot above.
Enable the "Extend" option
In a Blender file containing any geometry with existing UVs, enter the edit mode and in UV editor, select some UVs
Use Shift+Left Mouse to add another UV mesh element to selection
Use Shift+Left Mouse on already selected UV mesh element
Result: The UV mesh element is deselected despite the uv.select operator being set to "Extend"
Expected: The UV mesh element is not deselected when an operation to Extend current selection is performed

**System Information** Operating system: Windows-10-10.0.19041-SP0 64 Bits Graphics card: GeForce GTX 1080 Ti/PCIe/SSE2 NVIDIA Corporation 4.5.0 NVIDIA 461.40 **Blender Version** Broken: version: 2.92.0, branch: master (modified), commit date: 2021-02-24 16:25, hash: `02948a2cab` Worked: (newest version of Blender that worked as expected) **Short description of error** When using uv.select operator in "Extend" mode, the selection cycles between selection and deselection instead of always extending the existing selection, and operator has no option to turn this behavior off. This is inconsistent with rest of selection operators in other Blender editors. ![image.png](https://archive.blender.org/developer/F9878978/image.png) **Exact steps for others to reproduce the error** 1. Map the uv.select operator to Shift Left Mouse in the UV Editor (Global) context as shown in the screenshot above. 2. Enable the "Extend" option 3. In a Blender file containing any geometry with existing UVs, enter the edit mode and in UV editor, select some UVs 4. Use Shift+Left Mouse to add another UV mesh element to selection 5. Use Shift+Left Mouse on already selected UV mesh element Result: The UV mesh element is deselected despite the uv.select operator being set to "Extend" Expected: The UV mesh element is not deselected when an operation to **Extend** current selection is performed

Ludvik Koutny commented

2021-03-08 10:33:45 +01:00

Added subscriber: @Rawalanche

Philipp Oeser commented

2021-03-08 11:06:16 +01:00

Added subscriber: @lichtwerk

Philipp Oeser commented

2021-03-08 11:06:16 +01:00

Notes:

view3d select has Deselect and Toggle selection options
uv select does not have these

There is already a comment in uv_mouse_select_multi about this:

/* Current behavior of 'extend'
 * is actually toggling, so pass extend flag as 'toggle' here */

This sounds like it is working as intended (but this also sounds like this could see improvements -- e.g. by exposing Toggle selection option and using it)

Notes: - view3d select has `Deselect` and `Toggle selection` options - uv select does not have these There is already a comment in `uv_mouse_select_multi` about this: > /* Current behavior of 'extend' > * is actually toggling, so pass extend flag as 'toggle' here */ This sounds like it is working as intended (but this also sounds like this could see improvements -- e.g. by exposing `Toggle selection` option and using it)

Ludvik Koutny commented

2021-03-08 12:09:53 +01:00

In #86382#1125890, @lichtwerk wrote:
Notes:

view3d select has Deselect and Toggle selection options

uv select does not have these

There is already a comment in uv_mouse_select_multi about this:
/* Current behavior of 'extend'
 * is actually toggling, so pass extend flag as 'toggle' here */

This sounds like it is working as intended (but this also sounds like this could see improvements -- e.g. by exposing Toggle selection option and using it)

I am not sure about this. This may be working as expected for a programmer who is aware of a comment somewhere in the C code, but definitely not for the user. The experienced user sees "Extend" setting in the keymap, with no implication it also means cycling. And beginner/intermediate user is probably not even editing the keymaps themselves, so they will most likely be confused about why are they deselecting elements when holding shift key, which usually means "Add to selection" in all the other parts of Blender. It's really weird if it's allowed to pass behavior which is inconsistent with most other editors for no obvious reason as intended.

> In #86382#1125890, @lichtwerk wrote: > Notes: > > - view3d select has `Deselect` and `Toggle selection` options > - uv select does not have these > > There is already a comment in `uv_mouse_select_multi` about this: > >> /* Current behavior of 'extend' >> * is actually toggling, so pass extend flag as 'toggle' here */ > > This sounds like it is working as intended (but this also sounds like this could see improvements -- e.g. by exposing `Toggle selection` option and using it) I am not sure about this. This may be working as expected for a programmer who is aware of a comment somewhere in the C code, but definitely not for the user. The experienced user sees "Extend" setting in the keymap, with no implication it also means cycling. And beginner/intermediate user is probably not even editing the keymaps themselves, so they will most likely be confused about why are they deselecting elements when holding shift key, which usually means "Add to selection" in all the other parts of Blender. It's really weird if it's allowed to pass behavior which is inconsistent with most other editors for no obvious reason as intended.

Philipp Oeser commented

2021-03-08 14:55:59 +01:00

Changed status from 'Needs Triage' to: 'Needs Developer To Reproduce'

Philipp Oeser commented

2021-03-08 14:55:59 +01:00

OK, will leave that up to the module to classify/decide.

... they will most likely be confused about why are they deselecting elements when holding shift key, which usually means "Add to selection" in all the other parts of Blender. It's really weird if it's allowed to pass behavior which is inconsistent with most other editors for no obvious reason as intended.

Not sure about this though, the behavior of {key Shift Click} to actually toggle seem quite common to me [sure, this then uses its own option which is not called Extend, true ...]?

happens for all mesh elements
also happens in Animations Editors etc

OK, will leave that up to the module to classify/decide. > ... they will most likely be confused about why are they deselecting elements when holding shift key, which usually means "Add to selection" in all the other parts of Blender. It's really weird if it's allowed to pass behavior which is inconsistent with most other editors for no obvious reason as intended. Not sure about this though, the **behavior** of {key Shift Click} to actually toggle seem quite common to me [sure, this then uses its own option which is not called `Extend`, true ...]? - happens for all mesh elements - also happens in Animations Editors etc

Ludvik Koutny commented

2021-03-08 22:22:32 +01:00

In #86382#1126177, @lichtwerk wrote:
OK, will leave that up to the module to classify/decide.

... they will most likely be confused about why are they deselecting elements when holding shift key, which usually means "Add to selection" in all the other parts of Blender. It's really weird if it's allowed to pass behavior which is inconsistent with most other editors for no obvious reason as intended.

Not sure about this though, the behavior of {key Shift Click} to actually toggle seem quite common to me [sure, this then uses its own option which is not called Extend, true ...]?

happens for all mesh elements

also happens in Animations Editors etc

Yes, you are probably right. I have not tested with the default keymap, only with the customized one, so I assume toggle is on in the stock one by default. Anyway, I still think that if the Toggle option is available in other editors, it should be available in the UV one too. Especially given how similar 3D view mesh element and UV editor mesh element selection is, it'd be really odd to have two different workflows per editor, if user doesn't want Extend mode to also toggle.

> In #86382#1126177, @lichtwerk wrote: > OK, will leave that up to the module to classify/decide. > >> ... they will most likely be confused about why are they deselecting elements when holding shift key, which usually means "Add to selection" in all the other parts of Blender. It's really weird if it's allowed to pass behavior which is inconsistent with most other editors for no obvious reason as intended. > > Not sure about this though, the **behavior** of {key Shift Click} to actually toggle seem quite common to me [sure, this then uses its own option which is not called `Extend`, true ...]? > - happens for all mesh elements > - also happens in Animations Editors etc Yes, you are probably right. I have not tested with the default keymap, only with the customized one, so I assume toggle is on in the stock one by default. Anyway, I still think that if the Toggle option is available in other editors, it should be available in the UV one too. Especially given how similar 3D view mesh element and UV editor mesh element selection is, it'd be really odd to have two different workflows per editor, if user doesn't want Extend mode to also toggle.

Campbell Barton commented

2022-05-03 04:54:35 +02:00

Added subscriber: @ideasman42

Campbell Barton commented

2022-05-03 04:54:35 +02:00

Changed status from 'Needs Developer To Reproduce' to: 'Resolved'

Campbell Barton closed this issue

2022-05-03 04:54:35 +02:00

Campbell Barton self-assigned this 2022-05-03 04:54:35 +02:00

Campbell Barton commented

2022-05-03 04:54:35 +02:00

As of d356edf420 this is no longer the case.

As of d356edf420 this is no longer the case.

Sign in to join this conversation.

No Label

Download

What's New

Blender Studio

Manual

Developers Blog

Documentation

Benchmark

Blender Conference

Development Fund

One-time Donations

uv.select operator is hardcoded to cycle #86382