Baking API: remove non-working baking to external image, also cleanup misleading error messages #86608

New Issue

jack conradsen · 2021-03-16T02:00:19+01:00

jack conradsen commented

2021-03-16 02:00:19 +01:00

System Information
Operating system: Windows-10-10.0.18362-SP0 64 Bits
Graphics card: GeForce RTX 3090/PCIe/SSE2 NVIDIA Corporation 4.5.0 NVIDIA 460.89

Blender Version
Broken: version: 2.92.0, branch: master, commit date: 2021-02-24 16:25, hash: 02948a2cab
Worked: (newest version of Blender that worked as expected)

Short description of error
When baking for example an AO map, on a mesh, with no materials. You'll get an error stating you can bake to an external file [which was never implemented fully]
So that means the API would need to be cleaned up [non-working external save_mode removed, warning-/error messages adjusted]

Exact steps for others to reproduce the error
Load new file,
go to bake tab
select ambient occlusion
Hit bake.
Notice error, It suggests to save to an external file. But there is no option to select an external file.

**System Information** Operating system: Windows-10-10.0.18362-SP0 64 Bits Graphics card: GeForce RTX 3090/PCIe/SSE2 NVIDIA Corporation 4.5.0 NVIDIA 460.89 **Blender Version** Broken: version: 2.92.0, branch: master, commit date: 2021-02-24 16:25, hash: `02948a2cab` Worked: (newest version of Blender that worked as expected) **Short description of error** When baking for example an AO map, on a mesh, with no materials. You'll get an error stating you can bake to an external file [which was never implemented fully] So that means the API would need to be cleaned up [non-working external save_mode removed, warning-/error messages adjusted] **Exact steps for others to reproduce the error** Load new file, go to bake tab select ambient occlusion Hit bake. Notice error, It suggests to save to an external file. But there is no option to select an external file.

jack conradsen commented

2021-03-16 02:00:19 +01:00

Added subscriber: @STANN.co

Philipp Oeser commented

2021-03-16 13:29:47 +01:00

Added subscriber: @lichtwerk

Philipp Oeser commented

2021-03-16 13:29:47 +01:00

Changed status from 'Needs Triage' to: 'Needs User Info'

Philipp Oeser commented

2021-03-16 13:29:47 +01:00

Notice error, It suggests to save to an external file. But there is no option to select an external file

Cannot reproduce. I am getting the (expected)

No active image found in material "Material" (0) for object "Cube"

Please try to explain in more detail how your setup is (posting your example .blend file might help here)

Additionally having a model with multiple materials, apparently requires you to add an unconnected image node to all materials before allowing to bake.
This is a pretty confusing setup. And could likely be streamlined

This is indeed not ideal, but I assume this is already covered by {#68925}?

> Notice error, It suggests to save to an external file. But there is no option to select an external file Cannot reproduce. I am getting the (expected) ``` No active image found in material "Material" (0) for object "Cube" ``` Please try to explain in more detail how your setup is (posting your example .blend file might help here) > Additionally having a model with multiple materials, apparently requires you to add an unconnected image node to all materials before allowing to bake. > This is a pretty confusing setup. And could likely be streamlined This is indeed not ideal, but I assume this is already covered by {#68925}?

jack conradsen commented

2021-03-16 15:59:27 +01:00

! In #86608#1130544, @lichtwerk wrote:
Please try to explain in more detail how your setup is (posting your example .blend file might help here)

baking suggests to save to external file.blend
go to bake tab, and hit bake. The error suggesting to save to an external file should appear.

This is indeed not ideal, but I assume this is already covered by {#68925}?

Ah it appears so. Let's focus on the initial issue i spotted

>! In #86608#1130544, @lichtwerk wrote: > Please try to explain in more detail how your setup is (posting your example .blend file might help here) [baking suggests to save to external file.blend](https://archive.blender.org/developer/F9894990/baking_suggests_to_save_to_external_file.blend) go to bake tab, and hit bake. The error suggesting to save to an external file should appear. > This is indeed not ideal, but I assume this is already covered by {#68925}? Ah it appears so. Let's focus on the initial issue i spotted

Philipp Oeser commented

2021-03-16 16:31:26 +01:00

Changed status from 'Needs User Info' to: 'Needs Developer To Reproduce'

Philipp Oeser commented

2021-03-16 16:31:26 +01:00

Added subscriber: @dfelinto

Philipp Oeser commented

2021-03-16 16:31:26 +01:00

Ah, get it now.
That message is indeed a bit misleading (I think), it is intended (originally) to work with baking to external files (for the py-API I suppose), see
https://docs.blender.org/api/master/bpy.ops.object.html#bpy.ops.object.bake

However, this looks like it has never been fully implemented? Doing something like

bpy.ops.object.bake(filepath="/tmp/bake.png", save_mode='EXTERNAL')

will indeed give that warning.

We have a comment here, stating:

  /* XXX hack to force saving to always be internal. Whether (and how) to support
   * external saving will be addressed later */
  if (bkr->save_mode == R_BAKE_SAVE_EXTERNAL) {
    bkr->save_mode = R_BAKE_SAVE_INTERNAL;
  }

Would kindly ask @dfelinto to share the current state of this.

Ah, get it now. That message is indeed a bit misleading (I think), it is intended (originally) to work with baking to external files (for the py-API I suppose), see https://docs.blender.org/api/master/bpy.ops.object.html#bpy.ops.object.bake However, this looks like it has never been fully implemented? Doing something like ``` bpy.ops.object.bake(filepath="/tmp/bake.png", save_mode='EXTERNAL') ``` will indeed give that warning. We have a comment here, stating: ``` /* XXX hack to force saving to always be internal. Whether (and how) to support * external saving will be addressed later */ if (bkr->save_mode == R_BAKE_SAVE_EXTERNAL) { bkr->save_mode = R_BAKE_SAVE_INTERNAL; } ``` Would kindly ask @dfelinto to share the current state of this.

Dalai Felinto commented

2021-03-16 16:34:31 +01:00

It was indeed never supported if I remember well. The fix in this case is to correct the warning only.

Dalai Felinto commented

2021-03-16 16:37:05 +01:00

Changed status from 'Needs Developer To Reproduce' to: 'Needs Triage'

Philipp Oeser commented

2021-03-16 16:40:38 +01:00

Changed status from 'Needs Triage' to: 'Confirmed'

Philipp Oeser commented

2021-03-16 16:40:38 +01:00

OK, so that means the API would need to be cleaned up [non-working external save_mode removed, warning-/error messages adjusted]

Philipp Oeser changed title from ~~baking image, no option to bake to external file, despite warning message suggesting it.~~ to Baking API: remove non-working baking to external image, also cleanup misleading error messages

2021-03-16 16:44:15 +01:00

Philipp Oeser removed the

Download

What's New

Blender Studio

Manual

Developers Blog

Documentation

Benchmark

Blender Conference

Development Fund

One-time Donations

Baking API: remove non-working baking to external image, also cleanup misleading error messages #86608