Spreadsheet text enlarge with too much dots [ . . . ] #86852

Closed
opened 2021-03-23 14:56:03 +01:00 by Kent Davis · 18 comments

Blender Version
Broken: version: 2.93.0 Alpha, branch: master, commit date: 2021-03-20 21:00, hash: 9ca67c47a1
Worked: -

Short description of error
Spreadsheet text when enlarged has too much [ . . . ]

Exact steps for others to reproduce the error

Open Spreadsheet editor.
Blender preferences -> Themes -> Text Style -> Widget -> Increase "Points".

image.png

The numbers should not get ... but be clipped instead (so 1.0000 -> 1.00).

Original report screenshot

Screen Shot 2021-03-23 at 6.51.05 AM.png

**Blender Version** Broken: version: 2.93.0 Alpha, branch: master, commit date: 2021-03-20 21:00, hash: `9ca67c47a1` Worked: - **Short description of error** Spreadsheet text when enlarged has too much [ . . . ] **Exact steps for others to reproduce the error** Open Spreadsheet editor. Blender preferences -> Themes -> Text Style -> Widget -> Increase "Points". ![image.png](https://archive.blender.org/developer/F9909174/image.png) The numbers should not get `...` but be clipped instead (so 1.0000 -> 1.00). **Original report screenshot** ![Screen Shot 2021-03-23 at 6.51.05 AM.png](https://archive.blender.org/developer/F9905577/Screen_Shot_2021-03-23_at_6.51.05_AM.png)
Author

Added subscriber: @Kent-Davis

Added subscriber: @Kent-Davis
Member

Added subscriber: @Harley

Added subscriber: @Harley
Member

@Kent-Davis - It is still very early in the development of the Spreadsheet editor, so many things will change in it over the short term. I imagine the width of the spreadsheet columns will be one of them.

What Kent is pointing out is that the widths of the spreadsheet columns are currently set to a hardcoded width that only changes with user scale:

return 5 * UI_UNIT_X

However many users, especially those with vision issues, need to change the UI font sizes separately from Resolution Scale. Both cases can be accommodated by something like this instead:

  const uiStyle *style = UI_style_get_dpi();
  return style->widget.points * 9 * U.dpi_fac;
@Kent-Davis - It is still very early in the development of the Spreadsheet editor, so many things will change in it over the short term. I imagine the width of the spreadsheet columns will be one of them. What Kent is pointing out is that the widths of the spreadsheet columns are currently set to a hardcoded width that only changes with user scale: ``` return 5 * UI_UNIT_X ``` However many users, especially those with vision issues, need to change the UI font sizes separately from Resolution Scale. Both cases can be accommodated by something like this instead: ``` const uiStyle *style = UI_style_get_dpi(); return style->widget.points * 9 * U.dpi_fac; ```
Author

Oh well they know me as well I have low vision and deaf.
They did fix many different thing to width correctly before until now.
I believe they can do fix everything on Blender.

Oh well they know me as well I have low vision and deaf. They did fix many different thing to width correctly before until now. I believe they can do fix everything on Blender.
Member

Changed status from 'Needs Triage' to: 'Confirmed'

Changed status from 'Needs Triage' to: 'Confirmed'
Member

Added subscriber: @ankitm

Added subscriber: @ankitm

Added subscriber: @dfelinto

Added subscriber: @dfelinto

Changed status from 'Confirmed' to: 'Needs User Info'

Changed status from 'Confirmed' to: 'Needs User Info'

I cannot actually reproduce this. Please specify the steps to reproduce this from "Factory Preferences". The screenshot you shared has way too many unrelated changes.

I cannot actually reproduce this. Please specify the steps to reproduce this from "Factory Preferences". The screenshot you shared has way too many unrelated changes.
Ankit Meel changed title from Spreadsheet text enlarge with too much [ . . . ] to Spreadsheet text enlarge with too much dots [ . . . ] 2021-03-25 12:28:56 +01:00
Member

Changed status from 'Needs User Info' to: 'Confirmed'

Changed status from 'Needs User Info' to: 'Confirmed'

Ok, confirming as a bug but setting as low priority in case the UI team wants to tackle it. Though tempted to move to known issue or even archived if the UI team don't think this is important.

Ok, confirming as a bug but setting as low priority in case the UI team wants to tackle it. Though tempted to move to known issue or even archived if the UI team don't think this is important.

What is not clear to me from @Harley's comment is if the fix is to change the columns to resize based on UI scale, or to just make sure the text doesn't get ....

What is not clear to me from @Harley's comment is if the fix is to change the columns to resize based on UI scale, or to just make sure the text doesn't get `...`.
Member

@dfelinto - is if the fix is to change the columns to resize based on UI scale, or to just make sure the text doesn't get ...

Currently the columns each have a fixed width that does properly change with Preferences/Interface/Resolution Scale, but does not change if similarly altering the font sizes (as Kent needs for accessibility). You can simulate what Kent sees by going into Preferences/Themes/Text Style and changing each of the three "Points" sizes to 24. In that state all the text is much larger without the rest of the UI dimensions changing.

I mostly commented to make the problem understood, and to let Kent know that this area is under construction. I'm assuming that the column sizes will eventually be made to be auto-sizing to content, or differ by data type, and/or allow users to drag to any width. I didn't want to jump in and submit the above simple solution while you seem to be actively in construction.

> @dfelinto - is if the fix is to change the columns to resize based on UI scale, or to just make sure the text doesn't get ... Currently the columns each have a fixed width that *does* properly change with Preferences/Interface/Resolution Scale, but does not change if similarly altering the font sizes (as Kent needs for accessibility). You can simulate what Kent sees by going into Preferences/Themes/Text Style and changing each of the three "Points" sizes to 24. In that state all the text is much larger without the rest of the UI dimensions changing. I mostly commented to make the problem understood, and to let Kent know that this area is under construction. I'm assuming that the column sizes will eventually be made to be auto-sizing to content, or differ by data type, and/or allow users to drag to any width. I didn't want to jump in and submit the above simple solution while you seem to be actively in construction.
Author

@dfelinto You should know.
I have low vision and I unable to view too small text.
Not matter on size need to auto width to be fit itself.
https://youtu.be/raiopIEx3eo

@dfelinto You should know. I have low vision and I unable to view too small text. Not matter on size need to auto width to be fit itself. https://youtu.be/raiopIEx3eo

This issue was referenced by 0f13bded46

This issue was referenced by 0f13bded46feb7f16c21e95321a1a07998930c19
Member

Changed status from 'Confirmed' to: 'Resolved'

Changed status from 'Confirmed' to: 'Resolved'
Harley Acheson self-assigned this 2021-03-25 16:35:59 +01:00
Author

@Harley Good job there is resolve yes but other some more you can see.
Cube and C... (3 dots)
Object Mode/Edit Mode/Sculpting etc still (...)
Scale: Push the 'S' key then drag a little then click appear there still (...)
About auto width and height too.

@Harley Good job there is resolve yes but other some more you can see. Cube and C... (3 dots) Object Mode/Edit Mode/Sculpting etc still (...) Scale: Push the 'S' key then drag a little then click appear there still (...) About auto width and height too.
Author

There have many (...) I show you other one
https://youtu.be/OtMDvBanU-E


There (Scene) and (View Layer) have auto width so awesome.
BUT
Object Mode, Edit Mode, and etc still (...)
Scale still (...)
other place still (...)
https://youtu.be/ZGe5y2xPsmU

There have many (...) I show you other one https://youtu.be/OtMDvBanU-E - - - - - - - - - - - - - - - - - - - - - - - - There (Scene) and (View Layer) have auto width so awesome. BUT Object Mode, Edit Mode, and etc still (...) Scale still (...) other place still (...) https://youtu.be/ZGe5y2xPsmU
Sign in to join this conversation.
No Label
Interest
Alembic
Interest
Animation & Rigging
Interest
Asset Browser
Interest
Asset Browser Project Overview
Interest
Audio
Interest
Automated Testing
Interest
Blender Asset Bundle
Interest
BlendFile
Interest
Collada
Interest
Compatibility
Interest
Compositing
Interest
Core
Interest
Cycles
Interest
Dependency Graph
Interest
Development Management
Interest
EEVEE
Interest
EEVEE & Viewport
Interest
Freestyle
Interest
Geometry Nodes
Interest
Grease Pencil
Interest
ID Management
Interest
Images & Movies
Interest
Import Export
Interest
Line Art
Interest
Masking
Interest
Metal
Interest
Modeling
Interest
Modifiers
Interest
Motion Tracking
Interest
Nodes & Physics
Interest
OpenGL
Interest
Overlay
Interest
Overrides
Interest
Performance
Interest
Physics
Interest
Pipeline, Assets & IO
Interest
Platforms, Builds & Tests
Interest
Python API
Interest
Render & Cycles
Interest
Render Pipeline
Interest
Sculpt, Paint & Texture
Interest
Text Editor
Interest
Translations
Interest
Triaging
Interest
Undo
Interest
USD
Interest
User Interface
Interest
UV Editing
Interest
VFX & Video
Interest
Video Sequencer
Interest
Virtual Reality
Interest
Vulkan
Interest
Wayland
Interest
Workbench
Interest: X11
Legacy
Blender 2.8 Project
Legacy
Milestone 1: Basic, Local Asset Browser
Legacy
OpenGL Error
Meta
Good First Issue
Meta
Papercut
Meta
Retrospective
Meta
Security
Module
Animation & Rigging
Module
Core
Module
Development Management
Module
EEVEE & Viewport
Module
Grease Pencil
Module
Modeling
Module
Nodes & Physics
Module
Pipeline, Assets & IO
Module
Platforms, Builds & Tests
Module
Python API
Module
Render & Cycles
Module
Sculpt, Paint & Texture
Module
Triaging
Module
User Interface
Module
VFX & Video
Platform
FreeBSD
Platform
Linux
Platform
macOS
Platform
Windows
Priority
High
Priority
Low
Priority
Normal
Priority
Unbreak Now!
Status
Archived
Status
Confirmed
Status
Duplicate
Status
Needs Info from Developers
Status
Needs Information from User
Status
Needs Triage
Status
Resolved
Type
Bug
Type
Design
Type
Known Issue
Type
Patch
Type
Report
Type
To Do
No Milestone
No project
No Assignees
5 Participants
Notifications
Due Date
The due date is invalid or out of range. Please use the format 'yyyy-mm-dd'.

No due date set.

Dependencies

No dependencies set.

Reference: blender/blender#86852
No description provided.