Boolean union causing crash when combined with a dependency loop (2.93 regression) #86879

New Issue

Alaska · 2021-03-24T09:51:10+01:00

Alaska commented

2021-03-24 09:51:10 +01:00

System Information:
Operating system: Linux-5.10.0-4-amd64-x86_64-with-debian-bullseye-sid 64 Bits
Graphics card: GeForce RTX 3070/PCIe/SSE2 NVIDIA Corporation 4.5.0 NVIDIA 460.67

Blender Version:
Broken: 2.93.0 Alpha, branch: master, commit date: 2021-03-24 01:38, hash: 3f47df577d
Worked: 2.92 release (Technically it doesn't work in 2.92, but Blender doesn't crash when doing this which is why I've listed it as "worked")

Short description of error:
I've found that when the boolean union modifier is used on an object with the target object also having a boolean modifier that has this object as it's target, Blender will crash (in some situations). Here's my crash log:
blender.crash.txt
Technically this is a dependency loop and as such a user shouldn't be doing this, but I've found that from time to time I can accidentally select the wrong object with the eye dropper and as such this crash can occur.

Exact steps for others to reproduce the error:
Watch the video or read the steps below.

With the "General" startup file, select the cube and duplicate it and move it.
Now select the original cube and add a boolean modifier to it set to Difference mode and with the duplicate cube as the target.
Now select the duplicate cube and give it a boolean modifier set to Union mode with the original cube as the target. Blender will crash.

Note: In step 2 I tell you to select the original cube then add the Difference boolean modifier to it. If you instead give the difference modifier to the duplicated cube, Blender will not crash unless you change a setting on the duplicate cubes modifier after setting up the union modifier. Not sure why.

Boolean union crash.mp4

EDIT:
Added a test file.
boolean_crash.blend

**System Information:** Operating system: Linux-5.10.0-4-amd64-x86_64-with-debian-bullseye-sid 64 Bits Graphics card: GeForce RTX 3070/PCIe/SSE2 NVIDIA Corporation 4.5.0 NVIDIA 460.67 **Blender Version:** Broken: 2.93.0 Alpha, branch: master, commit date: 2021-03-24 01:38, hash: `3f47df577d` Worked: 2.92 release (Technically it doesn't work in 2.92, but Blender doesn't crash when doing this which is why I've listed it as "worked") **Short description of error:** I've found that when the boolean union modifier is used on an object with the target object also having a boolean modifier that has this object as it's target, Blender will crash (in some situations). Here's my crash log: [blender.crash.txt](https://archive.blender.org/developer/F9906748/blender.crash.txt) Technically this is a dependency loop and as such a user shouldn't be doing this, but I've found that from time to time I can accidentally select the wrong object with the eye dropper and as such this crash can occur. **Exact steps for others to reproduce the error:** Watch the video or read the steps below. 1. With the "General" startup file, select the cube and duplicate it and move it. 2. Now select the original cube and add a boolean modifier to it set to `Difference` mode and with the duplicate cube as the target. 3. Now select the duplicate cube and give it a boolean modifier set to `Union` mode with the original cube as the target. Blender will crash. Note: In step 2 I tell you to select the original cube then add the `Difference` boolean modifier to it. If you instead give the difference modifier to the duplicated cube, Blender will not crash unless you change a setting on the duplicate cubes modifier after setting up the union modifier. Not sure why. [Boolean union crash.mp4](https://archive.blender.org/developer/F9906749/Boolean_union_crash.mp4) EDIT: Added a test file. [boolean_crash.blend](https://archive.blender.org/developer/F9906800/boolean_crash.blend)

Alaska commented

2021-03-24 09:51:10 +01:00

Added subscriber: @Alaska

Falk David commented

2021-03-24 10:23:51 +01:00

Added subscriber: @filedescriptor

Falk David commented

2021-03-24 10:23:51 +01:00

Changed status from 'Needs Triage' to: 'Confirmed'

Falk David commented

2021-03-24 10:23:51 +01:00

I can reproduce this crash on the latest 2.93.0 Alpha, branch: master, commit date: 2021-03-24 08:34, hash: 865025c343.

I can reproduce this crash on the latest 2.93.0 Alpha, branch: master, commit date: 2021-03-24 08:34, hash: `865025c343`.

Falk David commented

2021-03-24 10:49:44 +01:00

Added subscriber: @HooglyBoogly

Falk David commented

2021-03-24 10:49:44 +01:00

Ran this through a debug build. The crash happens in blender/source/blender/modifiers/intern/MOD_boolean.c:663 because mesh_operand is NULL.

mesh_operand = BKE_modifier_get_evaluated_mesh_from_evaluated_object(bmd->object, false);
BKE_mesh_wrapper_ensure_mdata(mesh_operand);

@HooglyBoogly Does this just need a NULL check?

The dependency graph detects the cycle correctly:

Dependency cycle detected:
  OBCube/Geometry Component/GEOMETRY_EVAL() depends on
  OBCube.001/Geometry Component/GEOMETRY_EVAL() via 'Boolean Modifier'
  OBCube/Geometry Component/GEOMETRY_EVAL() via 'Boolean Modifier'
Detected 1 dependency cycles

Ran this through a debug build. The crash happens in `blender/source/blender/modifiers/intern/MOD_boolean.c:663` because `mesh_operand` is `NULL`. ``` mesh_operand = BKE_modifier_get_evaluated_mesh_from_evaluated_object(bmd->object, false); BKE_mesh_wrapper_ensure_mdata(mesh_operand); ``` @HooglyBoogly Does this just need a `NULL` check? The dependency graph detects the cycle correctly: ``` Dependency cycle detected: OBCube/Geometry Component/GEOMETRY_EVAL() depends on OBCube.001/Geometry Component/GEOMETRY_EVAL() via 'Boolean Modifier' OBCube/Geometry Component/GEOMETRY_EVAL() via 'Boolean Modifier' Detected 1 dependency cycles ```

Hans Goudey commented

2021-03-29 20:26:59 +02:00

Honestly I'm not sure, I didn't work on this code really. If a NULL check fixes this problem it looks like it would be reasonable to add.