Proportional transform scale does not show small values #88346

New Issue

george b · 2021-05-17T11:46:35+02:00

george b commented

2021-05-17 11:46:35 +02:00

System Information
Operating system: Windows-10-10.0.19041-SP0 64 Bits
Graphics card: GeForce RTX 2060/PCIe/SSE2 NVIDIA Corporation 4.5.0 NVIDIA 462.31

Blender Version
Broken: version: 2.92.0, branch: master, commit date: 2021-02-24 16:25, hash: 02948a2cab
Worked: ?

The problem
When activating Proportional Editing with objects sized in centimeter range, the influence circle is way to big, out of the screen and you need to scale it a lot with scroll .
This is very slow with high poly meshes (500k to 1M triangles).
Adjusting the proportional size for small areas just shows 0.00.
Users expect that default influence should be initialized relative to screen size or to object size.

Exact steps for others to reproduce the error

Enable Proportional Editing
After adjusting the Proportional size value for 1 cm or less of influence the onscreen value for proportional shows just 0.00.

**System Information** Operating system: Windows-10-10.0.19041-SP0 64 Bits Graphics card: GeForce RTX 2060/PCIe/SSE2 NVIDIA Corporation 4.5.0 NVIDIA 462.31 **Blender Version** Broken: version: 2.92.0, branch: master, commit date: 2021-02-24 16:25, hash: `02948a2cab` Worked: ? **The problem** When activating Proportional Editing with objects sized in centimeter range, the influence circle is way to big, out of the screen and you need to scale it a lot with scroll . This is very slow with high poly meshes (500k to 1M triangles). Adjusting the proportional size for small areas just shows 0.00. Users expect that default influence should be initialized relative to screen size or to object size. **Exact steps for others to reproduce the error** - Enable Proportional Editing - After adjusting the Proportional size value for 1 cm or less of influence the onscreen value for proportional shows just 0.00.

george b commented

2021-05-17 11:46:35 +02:00

Added subscriber: @GeRo

Germano Cavalcante commented

2021-06-22 20:34:33 +02:00

Added subscribers: @mont29, @mano-wii

Germano Cavalcante commented

2021-06-22 20:34:33 +02:00

This is not really a bug, but a design issue.
We could solve this by supporting units in the proportional editing value:

diff --git a/source/blender/editors/transform/transform_mode_translate.c b/source/blender/editors/transform/transform_mode_translate.c
index 3088f6a7776..8f7ef4ae4c2 100644
--- a/source/blender/editors/transform/transform_mode_translate.c
+++ b/source/blender/editors/transform/transform_mode_translate.c
@@ -201,8 +201,19 @@ static void headerTranslation(TransInfo *t, const float vec[3], char str[UI_MAX_
   }
 
   if (t->flag & T_PROP_EDIT_ALL) {
-    ofs += BLI_snprintf_rlen(
-        str + ofs, UI_MAX_DRAW_STR - ofs, TIP_(" Proportional size: %.2f"), t->prop_size);
+    ofs += BLI_strncpy_rlen(str + ofs, TIP_(" Proportional size: "), UI_MAX_DRAW_STR - ofs);
+    if (unit) {
+      ofs += BKE_unit_value_as_string(str + ofs,
+                                      UI_MAX_DRAW_STR - ofs,
+                                      t->prop_size * unit->scale_length,
+                                      4,
+                                      B_UNIT_LENGTH,
+                                      unit,
+                                      false);
+    }
+    else {
+      ofs += BLI_snprintf_rlen(str + ofs, UI_MAX_DRAW_STR - ofs, "%.2f", t->prop_size);
+    }
   }
 
   if (t->spacetype == SPACE_NODE) {

But with this change, we would lose translations of " Proportional size: %.2f".
I don't know to what extent such a change justifies losing some translations.

@mont29, (you know the translations area better), is there any way to get around the problem of losing translations? And is this really a problem?

This is not really a bug, but a design issue. We could solve this by supporting units in the proportional editing value: ``` diff --git a/source/blender/editors/transform/transform_mode_translate.c b/source/blender/editors/transform/transform_mode_translate.c index 3088f6a7776..8f7ef4ae4c2 100644 --- a/source/blender/editors/transform/transform_mode_translate.c +++ b/source/blender/editors/transform/transform_mode_translate.c @@ -201,8 +201,19 @@ static void headerTranslation(TransInfo *t, const float vec[3], char str[UI_MAX_ } if (t->flag & T_PROP_EDIT_ALL) { - ofs += BLI_snprintf_rlen( - str + ofs, UI_MAX_DRAW_STR - ofs, TIP_(" Proportional size: %.2f"), t->prop_size); + ofs += BLI_strncpy_rlen(str + ofs, TIP_(" Proportional size: "), UI_MAX_DRAW_STR - ofs); + if (unit) { + ofs += BKE_unit_value_as_string(str + ofs, + UI_MAX_DRAW_STR - ofs, + t->prop_size * unit->scale_length, + 4, + B_UNIT_LENGTH, + unit, + false); + } + else { + ofs += BLI_snprintf_rlen(str + ofs, UI_MAX_DRAW_STR - ofs, "%.2f", t->prop_size); + } } if (t->spacetype == SPACE_NODE) { ``` But with this change, we would lose translations of `" Proportional size: %.2f"`. I don't know to what extent such a change justifies losing some translations. --- @mont29, (you know the translations area better), is there any way to get around the problem of losing translations? And is this really a problem?

blender-admin commented

2021-06-22 22:17:44 +02:00

This issue was referenced by fa1868ae97

This issue was referenced by fa1868ae971c2dc50efb2f5dbf8ed2b2b6f08d08

Germano Cavalcante commented

2021-06-22 22:18:05 +02:00

Changed status from 'Needs Triage' to: 'Resolved'

Germano Cavalcante closed this issue

2021-06-22 22:18:05 +02:00

Germano Cavalcante self-assigned this 2021-06-22 22:18:05 +02:00

Sign in to join this conversation.

No Label

Download

What's New

Blender Studio

Manual

Developers Blog

Documentation

Benchmark

Blender Conference

Development Fund

One-time Donations

Proportional transform scale does not show small values #88346