DrawManager: Task counters atomics. #88369

New Issue

Closed

opened 2021-05-18 15:34:41 +02:00 by Jeroen Bakker · 4 comments

Jeroen Bakker commented

2021-05-18 15:34:41 +02:00

Member

task counters in draw_cache_mesh_extract.c are allocated in serial.
Atomics are released when the cpu cache line is flushed. this could lead to additional wait. as other threads needs to wait untile the cpu cacheline is flushed before they can do an atomic operation.

When placing the atomics in different cache lines would be more efficient lock, but uses more cache lines.

We should test if this is measurable. test what is faster:

current implementation
place atomics in different cache lines.
use mutex. (they are cases that they are faster)

Current allocation in mesh_buffer_cache_create_requested

size_t counters_size = (sizeof(mbc) / sizeof(void *)) * sizeof(int32_t);
int32_t *task_counters = MEM_callocN(counters_size, __func__);

task counters in draw_cache_mesh_extract.c are allocated in serial. Atomics are released when the cpu cache line is flushed. this could lead to additional wait. as other threads needs to wait untile the cpu cacheline is flushed before they can do an atomic operation. When placing the atomics in different cache lines would be more efficient lock, but uses more cache lines. We should test if this is measurable. test what is faster: * current implementation * place atomics in different cache lines. * use mutex. (they are cases that they are faster) Current allocation in `mesh_buffer_cache_create_requested` ``` size_t counters_size = (sizeof(mbc) / sizeof(void *)) * sizeof(int32_t); int32_t *task_counters = MEM_callocN(counters_size, __func__); ```

Jeroen Bakker self-assigned this 2021-05-18 15:34:41 +02:00

Jeroen Bakker commented

2021-05-18 15:34:41 +02:00

Author

Member

Changed status from 'Needs Triage' to: 'Confirmed'

Changed status from 'Needs Triage' to: 'Confirmed'

Jeroen Bakker commented

2021-05-18 15:34:41 +02:00

Author

Member

Added subscribers: @Jeroen-Bakker, @machieb, @warcanin, @fclem, @GeorgiaPacific, @kioku, @JorgeBernalMartinez, @elias.andersson92, @TheRedWaxPolice, @JacobMerrill-1, @ideasman42

Added subscribers: @Jeroen-Bakker, @machieb, @warcanin, @fclem, @GeorgiaPacific, @kioku, @JorgeBernalMartinez, @elias.andersson92, @TheRedWaxPolice, @JacobMerrill-1, @ideasman42

Jeroen Bakker removed their assignment 2021-05-18 16:01:31 +02:00

Jeroen Bakker self-assigned this 2021-05-21 14:22:44 +02:00

Jeroen Bakker commented

2021-06-16 09:46:47 +02:00

Author

Member

Changed status from 'Confirmed' to: 'Archived'

Changed status from 'Confirmed' to: 'Archived'

Jeroen Bakker closed this issue

2021-06-16 09:46:47 +02:00

Jeroen Bakker commented

2021-06-16 09:46:47 +02:00

Author

Member

Recent refactorings removed all the atomics but one in this case.

Recent refactorings removed all the atomics but one in this case.

Sign in to join this conversation.

No Label

Animation & Rigging

Asset Browser Project Overview

Automated Testing

Blender Asset Bundle

Dependency Graph

Development Management

EEVEE & Viewport

Images & Movies

Motion Tracking

Nodes & Physics

Pipeline, Assets & IO

Platforms, Builds & Tests

Render & Cycles

Render Pipeline

Sculpt, Paint & Texture

Video Sequencer

Virtual Reality

Blender 2.8 Project

Milestone 1: Basic, Local Asset Browser

Good First Issue

Animation & Rigging

Development Management

EEVEE & Viewport

Nodes & Physics

Pipeline, Assets & IO

Platforms, Builds & Tests

Render & Cycles

Sculpt, Paint & Texture

Needs Info from Developers

Needs Information from User

No Milestone

No project

No Assignees

1 Participants

Notifications

Due Date

The due date is invalid or out of range. Please use the format 'yyyy-mm-dd'.

No due date set.

Dependencies

No dependencies set.

Reference: blender/blender#88369

No description provided.