Move vertex group names from object to geometry #88951

New Issue

Jacques Lucke · 2021-06-08T12:24:47+02:00

Jacques Lucke commented

2021-06-08 12:24:47 +02:00

For (unknown) historical reasons vertex group names are stored on the object instead of on the geometry.
This is causing technical problems when we want to access attributes of a mesh in a generic way and don't have the object. Also see #88460 (Technical design for attribute ui list).

The solution is to move the names of vertex groups to the geometry (mesh, lattice, grease pencil).
This can cause data loss when the geometry and object are in different .blend files, but this case is expected to be quite rare.

For (unknown) historical reasons vertex group names are stored on the object instead of on the geometry. This is causing technical problems when we want to access attributes of a mesh in a generic way and don't have the object. Also see #88460 (Technical design for attribute ui list). The solution is to move the names of vertex groups to the geometry (mesh, lattice, grease pencil). This can cause data loss when the geometry and object are in different .blend files, but this case is expected to be quite rare.

Jacques Lucke commented

2021-06-08 12:24:47 +02:00

Changed status from 'Needs Triage' to: 'Confirmed'

Jacques Lucke commented

2021-06-08 12:24:47 +02:00

Added subscriber: @JacquesLucke

Hans Goudey commented

2021-06-14 20:22:15 +02:00

Added subscriber: @HooglyBoogly

Hans Goudey self-assigned this 2021-06-23 18:03:18 +02:00

Hans Goudey commented

2021-06-24 00:27:04 +02:00

Should the Python API for vertex groups be moved to object data as well? Other than consistency and clarity, another reason to do it is so the "Vertex Group" panel can display when you have a mesh pinned in the property editor, but no object.

Also, maybe moving the active vertex group index would be a good opportunity to get rid of the "index starts at one" thing for actdef

Should the Python API for vertex groups be moved to object data as well? Other than consistency and clarity, another reason to do it is so the "Vertex Group" panel can display when you have a mesh pinned in the property editor, but no object. Also, maybe moving the active vertex group index would be a good opportunity to get rid of the "index starts at one" thing for `actdef`

Hadrien Brissaud commented

2021-06-28 22:25:51 +02:00

Added subscriber: @hadrien

Hadrien Brissaud commented

2021-06-28 22:25:51 +02:00

In #88951#1181740, @HooglyBoogly wrote:
Should the Python API for vertex groups be moved to object data as well? Other than consistency and clarity, another reason to do it is so the "Vertex Group" panel can display when you have a mesh pinned in the property editor, but no object.

Also, maybe moving the active vertex group index would be a good opportunity to get rid of the "index starts at one" thing for actdef

Always found it odd that pinning a mesh in properties would hide its vertex groups, which I thought were object data. So, the reason is lost to history ? in any case, changing this would be an improvement from my point of view.

> In #88951#1181740, @HooglyBoogly wrote: > Should the Python API for vertex groups be moved to object data as well? Other than consistency and clarity, another reason to do it is so the "Vertex Group" panel can display when you have a mesh pinned in the property editor, but no object. > > Also, maybe moving the active vertex group index would be a good opportunity to get rid of the "index starts at one" thing for `actdef` Always found it odd that pinning a mesh in properties would hide its vertex groups, which I thought were object data. So, the reason is lost to history ? in any case, changing this would be an improvement from my point of view.

Hans Goudey changed title from ~~Move vertex group names from object to geometry.~~ to Move vertex group names from object to geometry

2021-06-29 05:48:04 +02:00

blender-admin commented

2021-07-13 18:10:34 +02:00

This issue was referenced by 3b6ee8cee7

This issue was referenced by 3b6ee8cee7080af200e25e944fe30d310240e138

Dalai Felinto commented

2021-07-15 11:58:23 +02:00

Added subscriber: @dfelinto

Dalai Felinto commented

2021-07-15 11:58:23 +02:00

This introduced a big issue. This should have bumped the minimum blender version:

diff --git a/source/blender/blenkernel/BKE_blender_version.h b/source/blender/blenkernel/BKE_blender_version.h
index dffd70c077f..926938b7419 100644
--- a/source/blender/blenkernel/BKE_blender_version.h
+++ b/source/blender/blenkernel/BKE_blender_version.h
@@ -44,8 +44,8 @@ extern "C" {
 /* Minimum Blender version that supports reading file written with the current
  * version. Older Blender versions will test this and show a warning if the file
  * was written with too new a version. */
-#define BLENDER_FILE_MIN_VERSION 290
-#define BLENDER_FILE_MIN_SUBVERSION 0
+#define BLENDER_FILE_MIN_VERSION 300
+#define BLENDER_FILE_MIN_SUBVERSION 11
 
 /** User readable version string. */
 const char *BKE_blender_version_string(void);

I'm going to report it as a UnbreakNow! bug soon.

This introduced a big issue. This should have bumped the minimum blender version: ``` diff --git a/source/blender/blenkernel/BKE_blender_version.h b/source/blender/blenkernel/BKE_blender_version.h index dffd70c077f..926938b7419 100644 --- a/source/blender/blenkernel/BKE_blender_version.h +++ b/source/blender/blenkernel/BKE_blender_version.h @@ -44,8 +44,8 @@ extern "C" { /* Minimum Blender version that supports reading file written with the current * version. Older Blender versions will test this and show a warning if the file * was written with too new a version. */ -#define BLENDER_FILE_MIN_VERSION 290 -#define BLENDER_FILE_MIN_SUBVERSION 0 +#define BLENDER_FILE_MIN_VERSION 300 +#define BLENDER_FILE_MIN_SUBVERSION 11 /** User readable version string. */ const char *BKE_blender_version_string(void); ``` I'm going to report it as a UnbreakNow! bug soon.

Dalai Felinto commented

2021-07-15 12:05:38 +02:00

Report: #89870

Dalai Felinto commented

2021-07-16 14:43:47 +02:00

Changed status from 'Confirmed' to: 'Resolved'

Dalai Felinto closed this issue

2021-07-16 14:43:47 +02:00

Sign in to join this conversation.

No Label

Download

What's New

Blender Studio

Manual

Developers Blog

Documentation

Benchmark

Blender Conference

Development Fund

One-time Donations

Move vertex group names from object to geometry #88951