GPU: Push Constants #89553
Labels
No Label
Interest
Alembic
Interest
Animation & Rigging
Interest
Asset Browser
Interest
Asset Browser Project Overview
Interest
Audio
Interest
Automated Testing
Interest
Blender Asset Bundle
Interest
BlendFile
Interest
Collada
Interest
Compatibility
Interest
Compositing
Interest
Core
Interest
Cycles
Interest
Dependency Graph
Interest
Development Management
Interest
EEVEE
Interest
EEVEE & Viewport
Interest
Freestyle
Interest
Geometry Nodes
Interest
Grease Pencil
Interest
ID Management
Interest
Images & Movies
Interest
Import Export
Interest
Line Art
Interest
Masking
Interest
Metal
Interest
Modeling
Interest
Modifiers
Interest
Motion Tracking
Interest
Nodes & Physics
Interest
OpenGL
Interest
Overlay
Interest
Overrides
Interest
Performance
Interest
Physics
Interest
Pipeline, Assets & IO
Interest
Platforms, Builds & Tests
Interest
Python API
Interest
Render & Cycles
Interest
Render Pipeline
Interest
Sculpt, Paint & Texture
Interest
Text Editor
Interest
Translations
Interest
Triaging
Interest
Undo
Interest
USD
Interest
User Interface
Interest
UV Editing
Interest
VFX & Video
Interest
Video Sequencer
Interest
Virtual Reality
Interest
Vulkan
Interest
Wayland
Interest
Workbench
Interest: X11
Legacy
Blender 2.8 Project
Legacy
Milestone 1: Basic, Local Asset Browser
Legacy
OpenGL Error
Meta
Good First Issue
Meta
Papercut
Meta
Retrospective
Meta
Security
Module
Animation & Rigging
Module
Core
Module
Development Management
Module
EEVEE & Viewport
Module
Grease Pencil
Module
Modeling
Module
Nodes & Physics
Module
Pipeline, Assets & IO
Module
Platforms, Builds & Tests
Module
Python API
Module
Render & Cycles
Module
Sculpt, Paint & Texture
Module
Triaging
Module
User Interface
Module
VFX & Video
Platform
FreeBSD
Platform
Linux
Platform
macOS
Platform
Windows
Priority
High
Priority
Low
Priority
Normal
Priority
Unbreak Now!
Status
Archived
Status
Confirmed
Status
Duplicate
Status
Needs Info from Developers
Status
Needs Information from User
Status
Needs Triage
Status
Resolved
Type
Bug
Type
Design
Type
Known Issue
Type
Patch
Type
Report
Type
To Do
No Milestone
No project
No Assignees
3 Participants
Notifications
Due Date
No due date set.
Dependencies
No dependencies set.
Reference: blender/blender#89553
Loading…
Reference in New Issue
No description provided.
Delete Branch "%!s(<nil>)"
Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?
Add the concept of push constants to GPUShader(Interface)
Branch:
temp-gpu-push-constants
.What are push constants?
Push constants have been introduced with vulkan and the main difference with uniform buffers are that they are transported inside the command buffer and not bound. A shader can only have a single push constant (struct). Per shader stage the offset can be changed.
There is a minimum (specification) and maximum (physical device property) that should be respected.
GLSL example
In openGL this could be written as a UBO
Alternatives
Alternative1: Cross compilation using macros
Cross compilation can be done with a simple macro
challenge is that we still need to indetify the push constant in the shader interface for the API. if it is handled as a regular uniform there would be differences when using OpenGL vs Vulkan.
Alternative2: Source parsing.
Using a preprocessor we could detect the push constant and retrieve the needed information. For OpenGL we need the name for locating the binding. This could be written as a string parser.
Alternative3: Source parsing using GLSLANG.
For this case the source parsing could be done by the glslang. this library is already included in the shaderc lib that we want to use for SpirV compilation.
The biggest challenge is that we still need to rewrite the Vulkan GLSL to OpenGL GLSL. This could be done by walking the AST like (https://github.com/KhronosGroup/glslang/blob/master/glslang/MachineIndependent/intermOut.cpp) but that leads to different source code and reduces traceability.
TODO
Both doesn't seem active, but do what we want using AST.
Conclusion
I prefer to use Alternative2 as is a solution that works. Both 1 and 3 are limited and would need alternative 2 to fix their short comings.
The result of the parser would be passed to the ShaderInterface the shader interface can check if a uniform is actually a push constant and register it as a push constant.
Usages:
NOTE: On Linux/Mesa the maxPushConstatsSize = 128 bytes.
Changed status from 'Needs Triage' to: 'Confirmed'
Added subscriber: @Jeroen-Bakker
Added subscriber: @2046411367
Added subscriber: @dodo-2
Changed status from 'Confirmed' to: 'Archived'
Replaced by GPUShaderCreateInfo