Crash choosing interface socket type of custom tree #90233

New Issue

Sergey · 2021-07-27T12:37:10+02:00

Sergey commented

2021-07-27 12:37:10 +02:00

System Information
Operating system: Windows-10-10.0.19041-SP0 64 Bits
Graphics card: Intel(R) HD Graphics 630 Intel 4.5.0 - Build 25.20.100.6471

Blender Version
Broken: version: 3.0.0 Alpha, branch: master, commit date: 2021-07-25 22:03, hash: a77d203932

Short description of error
I was tried to adopt this changes https://developer.blender.org/D10912 for Sverchok when faces with the crash. Luckily it's reproducible on a simple example below.
The crash is happening only if a tree had this class method - https://docs.blender.org/api/master/bpy.types.NodeTree.html#bpy.types.NodeTree.valid_socket_type

Another problem is that the console is polluted with the message -

WARN (bpy.rna): C:\Users\blender\git\blender-vdev\blender.git\source\blender\python\intern\bpy_rna.c:1504 pyrna_enum_to_py: current value '-1' matches no enum in 'CustomTreeType', 'NodeTree', 'type

Probably @LukasTonne has a solution

Exact steps for others to reproduce the error
untitled (2).blend

Open the file
Run the script
Add one socket
Try to choose its type

**System Information** Operating system: Windows-10-10.0.19041-SP0 64 Bits Graphics card: Intel(R) HD Graphics 630 Intel 4.5.0 - Build 25.20.100.6471 **Blender Version** Broken: version: 3.0.0 Alpha, branch: master, commit date: 2021-07-25 22:03, hash: `a77d203932` **Short description of error** I was tried to adopt this changes https://developer.blender.org/D10912 for Sverchok when faces with the crash. Luckily it's reproducible on a simple example below. The crash is happening only if a tree had this class method - https://docs.blender.org/api/master/bpy.types.NodeTree.html#bpy.types.NodeTree.valid_socket_type Another problem is that the console is polluted with the message - ``` WARN (bpy.rna): C:\Users\blender\git\blender-vdev\blender.git\source\blender\python\intern\bpy_rna.c:1504 pyrna_enum_to_py: current value '-1' matches no enum in 'CustomTreeType', 'NodeTree', 'type ``` Probably @LukasTonne has a solution **Exact steps for others to reproduce the error** [untitled (2).blend](https://archive.blender.org/developer/F10240492/untitled__2_.blend) ![2021-07-27_14-24-23.png](https://archive.blender.org/developer/F10240493/2021-07-27_14-24-23.png) 1. Open the file 2. Run the script 3. Add one socket 4. Try to choose its type

Sergey commented

2021-07-27 12:37:10 +02:00

Added subscribers: @LukasTonne, @randum

Philipp Oeser commented

2021-07-28 16:05:50 +02:00

Added subscriber: @lichtwerk

Philipp Oeser commented

2021-07-28 16:05:50 +02:00

Changed status from 'Needs Triage' to: 'Confirmed'

Philipp Oeser commented

2021-07-28 16:05:50 +02:00

Can confirm the crash, in a Debug build, an Assert is hit when adding the input socket already.

BLI_assert failed: source/blender/blenkernel/intern/node.cc:450, write_node_socket_default_value(), at '0'

Can confirm the crash, in a Debug build, an Assert is hit when adding the input socket already. ``` BLI_assert failed: source/blender/blenkernel/intern/node.cc:450, write_node_socket_default_value(), at '0' ```

Lukas Tönne self-assigned this 2021-08-10 09:17:35 +02:00

Lukas Tönne commented

2021-08-10 09:17:35 +02:00

Confirmed, will take a look. At first glance looks like the custom socket has a default_value pointer, which should not be happening (is only used for C socket types, custom sockets use only IDProperties).

Confirmed, will take a look. At first glance looks like the custom socket has a `default_value` pointer, which should not be happening (is only used for C socket types, custom sockets use only IDProperties).

Lukas Tönne commented

2021-08-10 10:35:46 +02:00

Fixes in D12179.

The warning current value '-1' matches no enum is because when loading the file the script for defining the custom tree hasn't run yet, but the node editor still has the tree loaded. Nothing to worry about.

Another issue is that socket add operator for trees always adds a float socket by default, regardless of whether it's supported by the tree type. That should be fixed separately though, it needs some more thought:
https://developer.blender.org/diffusion/B/browse/master/source/blender/editors/space_node/node_edit.cc$2357

Fixes in [D12179](https://archive.blender.org/developer/D12179). The warning `current value '-1' matches no enum` is because when loading the file the script for defining the custom tree hasn't run yet, but the node editor still has the tree loaded. Nothing to worry about. Another issue is that socket add operator for trees always adds a `float` socket by default, regardless of whether it's supported by the tree type. That should be fixed separately though, it needs some more thought: https://developer.blender.org/diffusion/B/browse/master/source/blender/editors/space_node/node_edit.cc$2357

blender-admin commented

2022-05-01 10:27:22 +02:00

This issue was referenced by df0616bcd0

This issue was referenced by df0616bcd0c3d2a020a36c573b4df49c9947c949

Lukas Tönne commented

2022-05-01 10:28:27 +02:00

Changed status from 'Confirmed' to: 'Resolved'

Lukas Tönne closed this issue

2022-05-01 10:28:27 +02:00

Sergey commented

2022-05-05 09:38:09 +02:00

The problem with the warning was not solved, should I open another ticket?

The problem with the warning was not solved, should I open another ticket? ![image.png](https://archive.blender.org/developer/F13052804/image.png)

Philipp Oeser commented

2022-05-05 10:07:58 +02:00

In #90233#1352370, @randum wrote:
The problem with the warning was not solved, should I open another ticket?

Yes, you can reference this report here (might end up being a Known Issue, but still worth a report)

> In #90233#1352370, @randum wrote: > The problem with the warning was not solved, should I open another ticket? Yes, you can reference this report here (might end up being a Known Issue, but still worth a report)

Sign in to join this conversation.

4 Participants

Notifications

Due Date

No due date set.

Dependencies

No dependencies set.

Reference: blender/blender#90233

Download

What's New

Blender Studio

Manual

Developers Blog

Documentation

Benchmark

Blender Conference

Development Fund

One-time Donations

Crash choosing interface socket type of custom tree #90233