Inconsistent name separator used for duplicate node sockets names. #91826

New Issue

Brecht Van Lommel · 2021-09-29T20:03:15+02:00

Brecht Van Lommel commented

2021-09-29 20:03:15 +02:00

System Information
Operating system: Linux-5.4.0-84-generic-x86_64-with-glibc2.31 64 Bits
Graphics card: NVIDIA RTX A6000/PCIe/SSE2 NVIDIA Corporation 4.5.0 NVIDIA 470.42.01

Blender Version
Broken: version: 3.0.0 Alpha, branch: master, hash: 1d47885

Short description of error

Introduced by 756c22b, it's not properly connecting the second image socket in mix RGB nodes on load.

I suspect it's because the duplicate socket naming convention changed between .001 and _001 at some point.

Exact steps for others to reproduce the error

Download https://download.blender.org/demo/test/pabellon_barcelona_v1.scene_.zip
Open Compositor editor
Notice missing socket connections as compared to for example Blender 2.93.

**System Information** Operating system: Linux-5.4.0-84-generic-x86_64-with-glibc2.31 64 Bits Graphics card: NVIDIA RTX A6000/PCIe/SSE2 NVIDIA Corporation 4.5.0 NVIDIA 470.42.01 **Blender Version** Broken: version: 3.0.0 Alpha, branch: master, hash: `1d47885` **Short description of error** Introduced by 756c22b, it's not properly connecting the second image socket in mix RGB nodes on load. I suspect it's because the duplicate socket naming convention changed between .001 and _001 at some point. **Exact steps for others to reproduce the error** * Download https://download.blender.org/demo/test/pabellon_barcelona_v1.scene_.zip * Open Compositor editor * Notice missing socket connections as compared to for example Blender 2.93.

Brecht Van Lommel commented

2021-09-29 20:03:15 +02:00

Added subscriber: @brecht

blender-admin commented

2021-09-29 20:03:15 +02:00

#92636 was marked as duplicate of this issue

Brecht Van Lommel commented

2021-09-29 20:05:16 +02:00

Added subscriber: @Blendify

Brecht Van Lommel commented

2021-09-29 20:06:25 +02:00

If no quick solution can be found for this, I suggest to revert the changes for such nodes with multiple sockets that have the same name, since this leads to data loss when resaving .blend files that you may not notice until later.

Aaron Carlisle commented

2021-09-29 21:37:26 +02:00

I can reproduce but not with a file saved in recent versions of Blender, I wonder if the same can happen with some shader nodes that were also converted?

Ankit Meel commented

2021-09-29 21:47:36 +02:00

Changed status from 'Needs Triage' to: 'Confirmed'

Aaron Carlisle commented

2021-09-29 22:05:36 +02:00

The problem might stem from https://developer.blender.org/diffusion/B/browse/master/source/blender/blenkernel/intern/node.cc$1515

The proposed solution would be to make this an underscore, there also seems to need some versioning code to check existing nodes for the . seperator.

The problem might stem from https://developer.blender.org/diffusion/B/browse/master/source/blender/blenkernel/intern/node.cc$1515 The proposed solution would be to make this an underscore, there also seems to need some versioning code to check existing nodes for the `.` seperator.

Brecht Van Lommel commented

2021-09-29 22:16:41 +02:00

Added subscribers: @JacquesLucke, @HooglyBoogly

Brecht Van Lommel commented

2021-09-29 22:16:41 +02:00

Cycles handles both _001 and .001, Eevee does not use these identifiers so works regardless. So shader nodes are not an issue for Blender's own renderers, but for external engines this is still messy.

I'm confused about what the current convention is. And it's not clear to me if geometry nodes have a similar issues or if they avoid it, and if so why?

Cycles handles both `_001` and `.001`, Eevee does not use these identifiers so works regardless. So shader nodes are not an issue for Blender's own renderers, but for external engines this is still messy. I'm confused about what the current convention is. And it's not clear to me if geometry nodes have a similar issues or if they avoid it, and if so why?

Jacques Lucke commented

2021-10-01 22:55:23 +02:00

Looks like for some reason different conventions are used throughout node.cc. BLI_uniquename_cb is used three times, sometimes with . and sometimes with _.
Some versioning code just use one convention would be great. We really don't want that the same socket has different identifiers in different cases. That's also why I'm moving towards explicit socket identifiers with the socket declarations instead of some automatically generated identifiers.

I think we should revert the breaking commit for now, then add versioning to make sure that built-in nodes are consistent (i.e. the same socket does not have different identifiers in different nodes). Then we can commit the socket declarations again. I don't really care if the convention is to use _ or . or both, it should just should be consistent for different nodes of the same type.

Looks like for some reason different conventions are used throughout `node.cc`. `BLI_uniquename_cb` is used three times, sometimes with `.` and sometimes with `_`. Some versioning code just use one convention would be great. We really don't want that the same socket has different identifiers in different cases. That's also why I'm moving towards explicit socket identifiers with the socket declarations instead of some automatically generated identifiers. I think we should revert the breaking commit for now, then add versioning to make sure that built-in nodes are consistent (i.e. the same socket does not have different identifiers in different nodes). Then we can commit the socket declarations again. I don't really care if the convention is to use `_` or `.` or both, it should just should be consistent for different nodes of the same type.

Raimund Klink commented

2021-10-02 09:33:40 +02:00

Added subscriber: @Raimund58

Aaron Carlisle commented

2021-10-04 16:37:44 +02:00

The affecting nodes have been reverted in 0bc4056455 I'm leaving this task open until we figure out how to deal with the root cause.

The affecting nodes have been reverted in 0bc4056455 I'm leaving this task open until we figure out how to deal with the root cause.

Aaron Carlisle changed title from ~~Compositor Mix RGB node has broken links opening old .blend files~~ to Inconsistent name separator used for duplicate node sockets names.

2021-10-04 16:39:04 +02:00

Hans Goudey commented

2021-11-11 00:24:01 +01:00

Added subscribers: @Ed-H, @PratikPB2123

Hans Goudey self-assigned this 2021-11-11 00:36:11 +01:00

blender-admin commented

2021-11-12 19:22:43 +01:00

This issue was referenced by d845ba481c

This issue was referenced by d845ba481c6d2ef50bf87bec834555d5e1faf64c

Hans Goudey commented

2021-11-12 19:22:58 +01:00

Changed status from 'Confirmed' to: 'Resolved'

Hans Goudey closed this issue

2021-11-12 19:22:58 +01:00

Thomas Dinges added this to the 3.0 milestone 2023-02-08 15:59:02 +01:00

Sign in to join this conversation.

No Label

Download

What's New

Blender Studio

Manual

Developers Blog

Documentation

Benchmark

Blender Conference

Development Fund

One-time Donations

Inconsistent name separator used for duplicate node sockets names. #91826