Relocate Library Override loses local Materials (but not for automatically overridden data) #92780

New Issue

Konstantins Visnevskis · 2021-11-03T11:13:01+01:00

2021-11-03 11:13:01 +01:00

System Information
Operating system: Windows-10-10.0.19041-SP0 64 Bits
Graphics card: NVIDIA GeForce RTX 2080 Ti/PCIe/SSE2 NVIDIA Corporation 4.5.0 NVIDIA 472.39

Blender Version
Broken: version: 2.93.5, branch: master, commit date: 2021-10-05 12:04, hash: a791bdabd0

Short description of error
After Make Lybbrary Override Hierarchy on a Linked Collection, some object's data becomes linked and some a Lybrary Override.
Apparently that depends on whether the object has a valid shape key driver or not.
Not all of object datas becoming overrides might be a bug, given there's no way to enforce either condition by design, while it does has some implications, as described below.

When recovering from auto-save a scene with Lybrary overrides, one has to do "Relocate" on each of Link paths to make them relative again.
This action resets all the material links, that were made local, to the source ones.
However for objects that had their data made a Lybrary override automatically, this does not occur.

In other words - objects, that don't have a valid working shape key with a driver lose their local materials upon Lybrary Relocate.
So either losing local materials, or not all object datas becoming overrides could be a bug.

In case none are, this may be a useful workaround for many -
to create driven shapekeys for every object that shouldn't lose it's local materials upion Lybrary Relocate.

Exact steps for others to reproduce the error
linkable.blend

Link -> attached file -> Collections -> Collection_for_Linking
Outliner -> expand Collection_for_Linking -> Right click -> ID Data -> Lybrary Override Hierarchy
Overridden object data is linked, not overridden
Make object's material local. Wait for autosave. (Or save and move the saved file to break link path)
Open the autosave.
Relocate Lybrary to real path.
Local material is lost.

That doesn't happen if object data Library Override is generated instead of link automatically upon Make Library Override Hierarchy, as is the case with objects that have valid shapekey drivers.

**System Information** Operating system: Windows-10-10.0.19041-SP0 64 Bits Graphics card: NVIDIA GeForce RTX 2080 Ti/PCIe/SSE2 NVIDIA Corporation 4.5.0 NVIDIA 472.39 **Blender Version** Broken: version: 2.93.5, branch: master, commit date: 2021-10-05 12:04, hash: `a791bdabd0` **Short description of error** After Make Lybbrary Override Hierarchy on a Linked Collection, some object's data becomes linked and some a Lybrary Override. Apparently that depends on whether the object has a valid shape key driver or not. Not all of object datas becoming overrides might be a bug, given there's no way to enforce either condition by design, while it does has some implications, as described below. When recovering from auto-save a scene with Lybrary overrides, one has to do "Relocate" on each of Link paths to make them relative again. This action resets all the material links, that were made local, to the source ones. However for objects that had their data made a Lybrary override automatically, this does not occur. In other words - objects, that don't have a valid working shape key with a driver lose their local materials upon Lybrary Relocate. So either losing local materials, or not all object datas becoming overrides could be a bug. In case none are, this may be a useful workaround for many - to create driven shapekeys for every object that shouldn't lose it's local materials upion Lybrary Relocate. **Exact steps for others to reproduce the error** [linkable.blend](https://archive.blender.org/developer/F11694051/linkable.blend) - Link -> attached file -> Collections -> Collection_for_Linking - Outliner -> expand Collection_for_Linking -> Right click -> ID Data -> Lybrary Override Hierarchy - Overridden object data is linked, not overridden - Make object's material local. Wait for autosave. (Or save and move the saved file to break link path) - Open the autosave. - Relocate Lybrary to real path. - Local material is lost. That doesn't happen if object data Library Override is generated instead of link automatically upon Make Library Override Hierarchy, as is the case with objects that have valid shapekey drivers.

Konstantins Visnevskis commented

2021-11-03 11:13:01 +01:00

Added subscriber: @KonstantinsVisnevskis

Konstantins Visnevskis changed title from ~~Relocate Lybrary override loses local Materials (but not for overridden data, which can't be controlled directly)~~ to Relocate Library Override loses local Materials (but not for overridden data, which can't be controlled directly)

2021-11-03 11:13:19 +01:00

Konstantins Visnevskis changed title from ~~Relocate Library Override loses local Materials (but not for overridden data, which can't be controlled directly)~~ to Relocate Library Override loses local Materials (but not for automatically overridden data)

2021-11-03 11:14:05 +01:00

Philipp Oeser commented

2021-11-03 14:48:40 +01:00

Added subscribers: @mont29, @lichtwerk

Philipp Oeser commented

2021-11-03 14:48:40 +01:00

Changed status from 'Needs Triage' to: 'Needs Developer To Reproduce'

Philipp Oeser commented

2021-11-03 14:48:40 +01:00

I can confirm the behavior.

Not sure if the fact that "Not all of object datas becoming overrides might be a bug" is the culprit here either (if no override on mesh is there I can imagine the material issue is expected).
Also not sure why an override on mesh actually gets generated in the shapekey driver scenario.
In the end there might be an explanation to all this, best if @mont29 has a look.

I can confirm the behavior. Not sure if the fact that "Not all of object datas becoming overrides might be a bug" is the culprit here either (if no override on mesh is there I can imagine the material issue is expected). Also not sure why an override on mesh actually gets generated in the shapekey driver scenario. In the end there might be an explanation to all this, best if @mont29 has a look.

Bastien Montagne commented

2021-11-03 17:50:32 +01:00

Meshes being made overrides are expected, since they depend on shapekeys which depend on drivers which depend on an (override) object...

Material issue is an internal limitation caused by the infamous intertwining of Object and ObData when it comes to material management.
To be specific here, the (override) object is local, so fully read when reading the working file. However, since the lib file is missing, there is no mesh, and therefore an empty placeholder mesh is generated, which has no materials. Currently, we always sync objects' materials count from it obdata's materials count. In that specific case however, we should do the other way around.

Meshes being made overrides are expected, since they depend on shapekeys which depend on drivers which depend on an (override) object... Material issue is an internal limitation caused by the infamous intertwining of Object and ObData when it comes to material management. To be specific here, the (override) object is local, so fully read when reading the working file. However, since the lib file is missing, there is no mesh, and therefore an empty placeholder mesh is generated, which has no materials. Currently, we always sync objects' materials count from it obdata's materials count. In that specific case however, we should do the other way around.

blender-admin commented

2021-11-03 17:57:45 +01:00

This issue was referenced by c29f9e14e4

This issue was referenced by c29f9e14e4180af0fbba83d66e08c9852da7fa9c

Gints Zilbalodis commented

2021-11-03 18:14:12 +01:00

Added subscriber: @gintszilbalodis

Bastien Montagne commented

2021-11-03 18:16:08 +01:00

Changed status from 'Needs Developer To Reproduce' to: 'Resolved'

Bastien Montagne closed this issue

2021-11-03 18:16:08 +01:00

Bastien Montagne self-assigned this 2021-11-03 18:16:08 +01:00

Konstantins Visnevskis commented

2021-11-04 12:43:12 +01:00

Hi, tested a few times with 3.0 3e6907eb8a and at first it seemed not to be working, but after re-saving the library with the same build (was saved with 2.93.5 release previously), it strangely does work! This will save lots of dummy shape-keys for the movie :) Thanks!

Hi, tested a few times with 3.0 3e6907eb8a3d and at first it seemed not to be working, but after re-saving the library with the same build (was saved with 2.93.5 release previously), it strangely does work! This will save lots of dummy shape-keys for the movie :) Thanks!

Sign in to join this conversation.

5 Participants

Notifications

Due Date

No due date set.

Dependencies

No dependencies set.

Reference: blender/blender#92780

Download

What's New

Blender Studio

Manual

Developers Blog

Documentation

Benchmark

Blender Conference

Development Fund

One-time Donations

Relocate Library Override loses local Materials (but not for automatically overridden data) #92780