Vertex Paint Viewport Overlays stencil mask not working #93129

New Issue

Royster · 2021-11-16T15:58:48+01:00

Royster commented

2021-11-16 15:58:48 +01:00

platform: Windows-10-10.0.19042-SP0
Graphics card: 1080

Broken: 3.1.0 Alpha

          commit date: 2021-11-14 00:26 hash: 7e82c840b7a4
          build date: 2021-11-15, 00:51:48

Worked: Has'nt worked for ages

Go to vertex paint mode, select some polys on a model.
Go to overlay options/vertexpaint/stencil mask opacity the slider does nothing to unselected polys overlay.

platform: Windows-10-10.0.19042-SP0 Graphics card: 1080 Broken: 3.1.0 Alpha ``` commit date: 2021-11-14 00:26 hash: 7e82c840b7a4 build date: 2021-11-15, 00:51:48 ``` Worked: Has'nt worked for ages Go to vertex paint mode, select some polys on a model. Go to overlay options/vertexpaint/stencil mask opacity the slider does nothing to unselected polys overlay. ![Overlays_Notworking.jpg](https://archive.blender.org/developer/F11815370/Overlays_Notworking.jpg)

Royster commented

2021-11-16 15:58:48 +01:00

Added subscriber: @Royston

Philipp Oeser commented

2021-11-17 11:39:38 +01:00

Added subscribers: @Jeroen-Bakker, @lichtwerk

Philipp Oeser commented

2021-11-17 11:39:38 +01:00

Changed status from 'Needs Triage' to: 'Confirmed'

Philipp Oeser commented

2021-11-17 11:39:38 +01:00

Stencil Mask does not exist for Vertex Paint (it is only there for Texture Paint).
So that description is totally misleading.
And even if it was meant for something else: it has no effect.

I have already raised my concerns in 409d3f4880.

I think the conclusion at that point was to remove that slider all together, but it is still there.
If the intention was to affect the opacity of the painted vertex color [seems more like this was the case], then I am unsure why this fails:

pd->painting.alpha_blending (determined by paint_object_is_rendered_transparent) might never be true? (even forcing it to true has no effect

looking at this piece of code btw:

    case CTX_MODE_PAINT_VERTEX: {
      opacity = pd->overlay.vertex_paint_mode_opacity;
      if (opacity > 0.0f) {
        state = DRW_STATE_WRITE_COLOR | DRW_STATE_DEPTH_EQUAL;
        state |= pd->painting.alpha_blending ? DRW_STATE_BLEND_ALPHA : DRW_STATE_BLEND_MUL;
        DRW_PASS_CREATE(psl->paint_color_ps, state | pd->clipping_state);

        sh = OVERLAY_shader_paint_vertcol();
        pd->paint_surf_grp = grp = DRW_shgroup_create(sh, psl->paint_color_ps);
        DRW_shgroup_uniform_block(grp, "globalsBlock", G_draw.block_ubo);
        DRW_shgroup_uniform_bool_copy(grp, "useAlphaBlend", true); //pd->painting.alpha_blending
        DRW_shgroup_uniform_float_copy(grp, "opacity", opacity);
      }
      break;
    }

I think this is something for @Jeroen-Bakker to rectify?

`Stencil Mask` does not exist for Vertex Paint (it is only there for Texture Paint). So that description is totally misleading. And even if it was meant for something else: it has no effect. I have already raised my concerns in 409d3f4880. I think the conclusion at that point was to remove that slider all together, but it is still there. If the intention was to affect the opacity of the painted vertex color [seems more like this was the case], then I am unsure why this fails: - `pd->painting.alpha_blending` (determined by `paint_object_is_rendered_transparent`) might never be true? (even forcing it to true has no effect looking at this piece of code btw: ``` case CTX_MODE_PAINT_VERTEX: { opacity = pd->overlay.vertex_paint_mode_opacity; if (opacity > 0.0f) { state = DRW_STATE_WRITE_COLOR | DRW_STATE_DEPTH_EQUAL; state |= pd->painting.alpha_blending ? DRW_STATE_BLEND_ALPHA : DRW_STATE_BLEND_MUL; DRW_PASS_CREATE(psl->paint_color_ps, state | pd->clipping_state); sh = OVERLAY_shader_paint_vertcol(); pd->paint_surf_grp = grp = DRW_shgroup_create(sh, psl->paint_color_ps); DRW_shgroup_uniform_block(grp, "globalsBlock", G_draw.block_ubo); DRW_shgroup_uniform_bool_copy(grp, "useAlphaBlend", true); //pd->painting.alpha_blending DRW_shgroup_uniform_float_copy(grp, "opacity", opacity); } break; } ``` I think this is something for @Jeroen-Bakker to rectify?

Philipp Oeser changed title from ~~Viewport Overlays stencil mask not working~~ to Vertex Paint Viewport Overlays stencil mask not working

2021-11-17 11:40:03 +01:00

Royster commented

2021-11-17 15:16:00 +01:00

Would be nice if you could change the opacity of the masked polys.
At the moment I keep having to turn off overlays to see what the color changes look like on the model as a whole.

Would be nice if you could change the opacity of the masked polys. At the moment I keep having to turn off overlays to see what the color changes look like on the model as a whole.

Royster commented

2021-11-17 15:33:34 +01:00

Would be better if just the selected faces where highlighted around the edge.

Royster commented

2021-11-22 11:10:50 +01:00

It has the effect of being in the way of being able to see what the rest of the model looks like.
It also effects color sampling (s key) as you cannot sample colors without hiding it.

It has the effect of being in the way of being able to see what the rest of the model looks like. It also effects color sampling (s key) as you cannot sample colors without hiding it.

Matthew Hinson commented

2022-07-25 22:36:00 +02:00

Added subscriber: @Matthew-Hinson

Philipp Oeser removed the

Download

What's New

Blender Studio

Manual

Developers Blog

Documentation

Benchmark

Blender Conference

Development Fund

One-time Donations

Vertex Paint Viewport Overlays stencil mask not working #93129