Fix Hotkeys malfunction after leaving text field with no input using IME(Chinese/Japanese/Korean) Ref T93421 #93986

New Issue

Takahiro Shizuki · 2021-12-12T08:59:44+01:00

Takahiro Shizuki commented

2021-12-12 08:59:44 +01:00

This is a fail creating a differental D13551.

This patch fixes about the bug affected by D11929.

Summary:
In Blender v3.0 for Windows, Hot keys are not functional when a user click 3D viewport after inputting no text on text edit with IME enabled.

Reason:

If a user inputed no text on text edit and click 3D viewport, IME is not closed. (If a user inputed some text, IME is closed.)
By D11929, When IME is opened, a key event is forwarded to IME.

This bug is happen by aboves.

Approach:

modifying to become same to v2.92's behavior.

Note: The Behavior per blender version:

    click a text edit, switch to IME On (manually or automatically), inputting some letters, click 3D viewport:
            2.92: After above, IME Off automatically and hotkey is functional.
                After using hotkey, click a text edit and IME switch should be On.
            3.0 (Released): After above, IME Off automatically and hotkey is functional.
                After using hotkey, click a text edit and IME switch should be On.
        click a text edit, switch to IME On (manually or automatically), click 3D viewport:
            2.92: After above, IME is not changed and hotkey is functional (IME word conversion list will be popup, inputting is continue on IME).
                After using hotkey, click a text edit and IME switch should be not changed (IME On).
            3.0 (Released): After above, IME is not change and some hotkey is NOT functional (IME word conversion list will be popup, inputting is continue on IME).
                And, click a text edit and IME switch should be not changed (IME On).

The Behavior of a fixing:

    click a text edit, switch to IME On (manually or automatically), inputting some letters, click 3D viewport:
        After above, IME Off automatically and hotkey is functional.
            After using hotkey, click a text edit and IME switch should be On.

    click a text edit, switch to IME On (manually or automatically), click 3D viewport:
        After above, IME Off automatically and hotkey is functional.
            After using hotkey, click a text edit and IME switch should be On.

#93421-patch-20211212.diff

# This is a fail creating a differental [D13551](https://archive.blender.org/developer/D13551). Ref #93421 This patch fixes about the bug affected by [D11929](https://archive.blender.org/developer/D11929). Summary: In Blender v3.0 for Windows, Hot keys are not functional when a user click 3D viewport after inputting no text on text edit with IME enabled. Reason: - If a user inputed no text on text edit and click 3D viewport, IME is not closed. (If a user inputed some text, IME is closed.) - By [D11929](https://archive.blender.org/developer/D11929), When IME is opened, a key event is forwarded to IME. This bug is happen by aboves. Approach: - modifying to become same to v2.92's behavior. ``` Note: The Behavior per blender version: click a text edit, switch to IME On (manually or automatically), inputting some letters, click 3D viewport: 2.92: After above, IME Off automatically and hotkey is functional. After using hotkey, click a text edit and IME switch should be On. 3.0 (Released): After above, IME Off automatically and hotkey is functional. After using hotkey, click a text edit and IME switch should be On. click a text edit, switch to IME On (manually or automatically), click 3D viewport: 2.92: After above, IME is not changed and hotkey is functional (IME word conversion list will be popup, inputting is continue on IME). After using hotkey, click a text edit and IME switch should be not changed (IME On). 3.0 (Released): After above, IME is not change and some hotkey is NOT functional (IME word conversion list will be popup, inputting is continue on IME). And, click a text edit and IME switch should be not changed (IME On). The Behavior of a fixing: click a text edit, switch to IME On (manually or automatically), inputting some letters, click 3D viewport: After above, IME Off automatically and hotkey is functional. After using hotkey, click a text edit and IME switch should be On. click a text edit, switch to IME On (manually or automatically), click 3D viewport: After above, IME Off automatically and hotkey is functional. After using hotkey, click a text edit and IME switch should be On. ``` [#93421-patch-20211212.diff](https://archive.blender.org/developer/F12733133/T93421-patch-20211212.diff)

Takahiro Shizuki commented

2021-12-12 08:59:44 +01:00

Added subscriber: @sntulix