Loading a new file gives crash while rendering in viewport #94041

New Issue

sungreen sungreen · 2021-12-14T02:33:03+01:00

sungreen sungreen commented

2021-12-14 02:33:03 +01:00

Operating system: Win10, Linux
Graphics card: NVIDIA

Blender Version: 3.10, master)

Short description
Crash appears on loading a new file when viewport render is enabled

Steps to Reproduce

Blender Preferences -> Save & Load -> uncheck Load UI
Render Cycles
Viewport Shading: Rendered
File -> New -> General ==> GPUTexture: Texture allocation failed

When data is being accessed gc->texture = 0x0
static GPUTexture *blf_batch_cache_texture_load(void)
{

GlyphCacheBLF *gc = g_batch.glyph_cache;
BLI_assert(gc);
BLI_assert(gc->bitmap_len > 0);

if (gc->bitmap_len > gc->bitmap_len_landed) {
  const int tex_width = GPU_texture_width(gc->texture);

gc->texture = 0x0
gc->bitmap_len = 2022
gc->bitmap_len_landed = 0

Operating system: Win10, Linux Graphics card: NVIDIA Blender Version: 3.10, master) **Short description** Crash appears on loading a new file when viewport render is enabled **Steps to Reproduce** - Blender Preferences -> Save & Load -> uncheck Load UI - Render Cycles - Viewport Shading: Rendered - File -> New -> General ==> GPUTexture: Texture allocation failed When data is being accessed gc->texture = 0x0 static GPUTexture *blf_batch_cache_texture_load(void) { ``` GlyphCacheBLF *gc = g_batch.glyph_cache; BLI_assert(gc); BLI_assert(gc->bitmap_len > 0); ``` ``` if (gc->bitmap_len > gc->bitmap_len_landed) { const int tex_width = GPU_texture_width(gc->texture); ``` gc->texture = 0x0 gc->bitmap_len = 2022 gc->bitmap_len_landed = 0

sungreen sungreen commented

2021-12-14 02:33:03 +01:00

Added subscriber: @Nikolaysungreen

Pratik Borhade commented

2021-12-14 08:07:26 +01:00

Added subscriber: @PratikPB2123

Pratik Borhade commented

2021-12-14 08:19:19 +01:00

Thanks for the report. Can confirm crash on master (c1f5d8d023c6fdef67efbc6ce2af49e384c9bd98)

Appears to be regression because 2.93.0LTS works fine here

blender.exe         :0x00007FF63CA6EE90  region_draw_emboss
blender.exe         :0x00007FF63CA6A3A0  ED_region_do_draw
blender.exe         :0x00007FF63C4E3310  wm_draw_window_offscreen
blender.exe         :0x00007FF63C4E3160  wm_draw_window
blender.exe         :0x00007FF63C4E2C60  wm_draw_update
blender.exe         :0x00007FF63C4BD330  WM_main
blender.exe         :0x00007FF63C13F190  main
blender.exe         :0x00007FF641657208  __scrt_common_main_seh
KERNEL32.DLL        :0x00007FFBD7637020  BaseThreadInitThunk
ntdll.dll           :0x00007FFBD9622630  RtlUserThreadStart```

Thanks for the report. Can confirm crash on master (`c1f5d8d023c6fdef67efbc6ce2af49e384c9bd98`) Appears to be regression because 2.93.0LTS works fine here ```blender.exe :0x00007FF6414700A0 immVertex2f blender.exe :0x00007FF63CA6EE90 region_draw_emboss blender.exe :0x00007FF63CA6A3A0 ED_region_do_draw blender.exe :0x00007FF63C4E3310 wm_draw_window_offscreen blender.exe :0x00007FF63C4E3160 wm_draw_window blender.exe :0x00007FF63C4E2C60 wm_draw_update blender.exe :0x00007FF63C4BD330 WM_main blender.exe :0x00007FF63C13F190 main blender.exe :0x00007FF641657208 __scrt_common_main_seh KERNEL32.DLL :0x00007FFBD7637020 BaseThreadInitThunk ntdll.dll :0x00007FFBD9622630 RtlUserThreadStart```

Pratik Borhade commented

2021-12-14 10:11:24 +01:00

Changed status from 'Needs Triage' to: 'Confirmed'

Pratik Borhade changed title from ~~GPUTexture: Texture allocation failed~~ to Loading a new file gives crash while rendering in viewport

2021-12-14 10:28:00 +01:00

Brecht Van Lommel commented

2021-12-15 21:11:44 +01:00

Added subscriber: @brecht

Brecht Van Lommel commented

2021-12-15 21:11:44 +01:00

I suspect something goes wrong with the OpenGL context in BlenderDisplayDriver::gl_context_dispose, causing OpenGL calls to fail aftwards.

I suspect something goes wrong with the OpenGL context in `BlenderDisplayDriver::gl_context_dispose`, causing OpenGL calls to fail aftwards.

Michael commented

2021-12-17 08:24:44 +01:00

Added subscriber: @michael64

Michael commented

2021-12-17 09:12:52 +01:00

Thank you @Nikolaysungreen for the nicely reproducable crash report.
This crash was introduced in 0803119725 so all 2.93 versions still work and 3.0.0 is the first that crashes.
Normally when you switch to cycles-x render view GHOST_CreateOpenGLContext is called as shown in P2669.
When you switch back to solid view GHOST_DisposeOpenGLContext is called.

I pasted a stracktrace of the last GHOST_DisposeOpenGLContext call P2668 and maybe the disposing worked
but I do not see a call of GHOST_CreateOpenGLContext so when the crash happens we might not have a context.

Even without a context the OpenGL functions do not produce something noticable with glGetError().
The first difference after creating a new scene without 'Load UI' is that GLTexture::proxy_check(0)
fails. glTexImage2D(gl_proxy, mip, internal_format, UNPACK2(size), 0, gl_format, gl_type, nullptr)
followed by glGetTexLevelParameteriv(gl_proxy, 0, GL_TEXTURE_WIDTH, &width)
gives a width of 0 for the 16384x1 proxy texture of the glyph cache.
The same sequence before context deletion with the exact same parameters to glTexImage2D worked.

This failed texture proxy check makes GLTexture::init_internal return false and instead of a texture we have NULL
which is dereferenced in blf_batch_cache_texture_load with GPU_texture_width(gc->texture) resulting in a crash.
So far the diagnosis.
Maybe this can be fixed by somehow calling GHOST_CreateOpenGLContext or some ancestor function
in the stacktrace of P2669 when the new scene is generated but I'll leave this to you guys.

Thank you @Nikolaysungreen for the nicely reproducable crash report. This crash was introduced in 0803119725 so all 2.93 versions still work and 3.0.0 is the first that crashes. Normally when you switch to cycles-x render view GHOST_CreateOpenGLContext is called as shown in [P2669](https://archive.blender.org/developer/P2669.txt). When you switch back to solid view GHOST_DisposeOpenGLContext is called. I pasted a stracktrace of the last GHOST_DisposeOpenGLContext call [P2668](https://archive.blender.org/developer/P2668.txt) and maybe the disposing worked but I do not see a call of GHOST_CreateOpenGLContext so when the crash happens we might not have a context. Even without a context the OpenGL functions do not produce something noticable with glGetError(). The first difference after creating a new scene without 'Load UI' is that GLTexture::proxy_check(0) fails. glTexImage2D(gl_proxy, mip, internal_format, UNPACK2(size), 0, gl_format, gl_type, nullptr) followed by glGetTexLevelParameteriv(gl_proxy, 0, GL_TEXTURE_WIDTH, &width) gives a width of 0 for the 16384x1 proxy texture of the glyph cache. The same sequence before context deletion with the exact same parameters to glTexImage2D worked. This failed texture proxy check makes GLTexture::init_internal return false and instead of a texture we have NULL which is dereferenced in blf_batch_cache_texture_load with GPU_texture_width(gc->texture) resulting in a crash. So far the diagnosis. Maybe this can be fixed by somehow calling GHOST_CreateOpenGLContext or some ancestor function in the stacktrace of [P2669](https://archive.blender.org/developer/P2669.txt) when the new scene is generated but I'll leave this to you guys.

Ron Walker commented

2021-12-30 02:19:49 +01:00

Added subscriber: @o6a2

Sergey Sharybin self-assigned this 2022-01-11 11:25:07 +01:00

blender-admin commented

2022-01-11 11:27:35 +01:00

This issue was referenced by 7a2b181591

This issue was referenced by 7a2b18159170b91694fd7c64825a699314fae3ca

Sergey Sharybin commented

2022-01-12 10:12:52 +01:00

Changed status from 'Confirmed' to: 'Resolved'

Sergey Sharybin closed this issue

2022-01-12 10:12:52 +01:00

Sign in to join this conversation.

No Label

Download

What's New

Blender Studio

Manual

Developers Blog

Documentation

Benchmark

Blender Conference

Development Fund

One-time Donations

Loading a new file gives crash while rendering in viewport #94041