Box Select (Axis Range) taking selection box proportions into account #94104

New Issue

Garek · 2021-12-15T10:09:35+01:00

Garek commented

2021-12-15 10:09:35 +01:00

Blender Version
Broken: version: 3.0.0, branch: master (modified), commit date: 2021-12-02 18:35, hash: f1cca30557
Broken: version: 2.50-alpha0 (first introduced)
Worked: never

Short description of error
Box Select (Axis Range) (as it seems) intended to work like this: if an element (NLA strip, keyframe etc.) exists on the same axis range (horizontal or vertical) as selection box, it's selected. But since it's introduction in 2.50 it's been broken and worked like this:

If an element on the same horizontal axis range as selection box and vertical length of a selection box is smaller than it's horizontal length then it's selected.
If an element on the same vertical axis range as selection box and horizontal length of a selection box is smaller than it's vertical length then it's selected.
See attached video for clarification

Exact steps for others to reproduce the error

Open attached .blend file.
In NLA editor make sure you use Box Select (Axis Range).
Draw wide box under NLA strip - it is selected, which is expected.
Click on emptry spase to deselect.
Draw narrow box under NLA strip - it is not selected.
Draw narrow box to the right or left side of NLA strip - it is selected, which is expected.
Draw wide box to the right or left side of NLA strip - it is not selected

Box Selection Axis Range bug 2021-12-15 13-57-50-890.mp4
Box Selection Axis Range bug.blend

**Blender Version** Broken: version: 3.0.0, branch: master (modified), commit date: 2021-12-02 18:35, hash: `f1cca30557` Broken: version: 2.50-alpha0 (first introduced) Worked: never **Short description of error** `Box Select (Axis Range)` (as it seems) intended to work like this: if an element (NLA strip, keyframe etc.) exists on the same axis range (horizontal or vertical) as selection box, it's selected. But since it's introduction in 2.50 it's been broken and worked like this: - If an element on the same horizontal axis range as selection box **and vertical length of a selection box is smaller than it's horizontal length** then it's selected. - If an element on the same vertical axis range as selection box **and horizontal length of a selection box is smaller than it's vertical length** then it's selected. See attached video for clarification **Exact steps for others to reproduce the error** 1. Open attached .blend file. 2. In NLA editor make sure you use `Box Select (Axis Range)`. 3. Draw wide box under NLA strip - it is selected, which is expected. 4. Click on emptry spase to deselect. 5. Draw narrow box under NLA strip - it is not selected. 6. Draw narrow box to the right or left side of NLA strip - it is selected, which is expected. 7. Draw wide box to the right or left side of NLA strip - it is not selected [Box Selection Axis Range bug 2021-12-15 13-57-50-890.mp4](https://archive.blender.org/developer/F12745127/Box_Selection_Axis_Range_bug_2021-12-15_13-57-50-890.mp4) [Box Selection Axis Range bug.blend](https://archive.blender.org/developer/F12745128/Box_Selection_Axis_Range_bug.blend)

Garek commented

2021-12-15 10:09:35 +01:00

Added subscriber: @Garek

Brad Clark commented

2021-12-15 21:18:07 +01:00

Added subscriber: @BClark

Garek commented

2021-12-17 19:21:32 +01:00

So I investigated it a bit... It was added in 34baf51dcb. And it seems that it is not a bug. On commit message::

ALT-BKEY will select either all the keyframes in the frame-range specified or the channel range specified, depending on which axis of the select region was larger. This method is prejudiced towards frame-range selection.

In code comments:

mode depends on which axis of the range is larger to determine which axis to use

So reading this there is really some logic to it. It depends if you want to select all keyframes of certain channels or all keyframes in certain frame range. Main problem is that it's unclear to user a purpose of this tool and how it is working.

So I investigated it a bit... It was added in 34baf51dcb. And it seems that it is not a bug. On commit message:: > ALT-BKEY will select either all the keyframes in the frame-range specified or the channel range specified, depending on which axis of the select region was larger. This method is prejudiced towards frame-range selection. In code comments: > mode depends on which axis of the range is larger to determine which axis to use So reading this there is really some logic to it. It depends if you want to select all keyframes of certain channels or all keyframes in certain frame range. Main problem is that it's unclear to user a purpose of this tool and how it is working.

Germano Cavalcante commented

2021-12-24 19:50:38 +01:00

Added subscriber: @mano-wii

Germano Cavalcante commented

2021-12-24 19:50:38 +01:00

Changed status from 'Needs Triage' to: 'Archived'

Germano Cavalcante closed this issue

2021-12-24 19:50:38 +01:00

Germano Cavalcante commented

2021-12-24 19:50:38 +01:00

Seeing the code, this is intentional.
See https://developer.blender.org/diffusion/B/browse/master/source/blender/editors/space_nla/nla_select.c$382-387
So can't be considered a bug.

Thanks for the report anyway.

For user requests and feedback, please use other channels: https://wiki.blender.org/wiki/Communication/Contact#User_Feedback_and_Requests

For more information on why this isn't considered a bug, visit: https://wiki.blender.org/wiki/Reference/Not_a_bug

Seeing the code, this is intentional. See https://developer.blender.org/diffusion/B/browse/master/source/blender/editors/space_nla/nla_select.c$382-387 So can't be considered a bug. Thanks for the report anyway. For user requests and feedback, please use other channels: https://wiki.blender.org/wiki/Communication/Contact#User_Feedback_and_Requests For more information on why this isn't considered a bug, visit: https://wiki.blender.org/wiki/Reference/Not_a_bug

Sign in to join this conversation.

No Label

Download

What's New

Blender Studio

Manual

Developers Blog

Documentation

Benchmark

Blender Conference

Development Fund

One-time Donations

Box Select (Axis Range) taking selection box proportions into account #94104