Grease pencil always uses the viewport display color of a world for its ambient light (even if the world uses nodes) #94318

New Issue

richard schweiger · 2021-12-22T08:38:41+01:00

richard schweiger commented

2021-12-22 08:38:41 +01:00

System Information
Operating system: Windows-10-10.0.19042-SP0 64 Bits
Graphics card: NVIDIA GeForce RTX 3070/PCIe/SSE2 NVIDIA Corporation 4.5.0 NVIDIA 496.13

Blender Version
Broken: version: 3.0.0, branch: master, commit date: 2021-12-02 18:35, hash: f1cca30557
Worked: (newest version of Blender that worked as expected)

Short description of error
when changing the viewport display color in the world properties all grease pencil strokes get ambient lit by the color (even if the world uses nodes).
it used to only change the background color in viewport shading, when its background is set to world. at least thats whats documented about "viewport-display" right now.
theres no mention about this influence on grease pencil in the documentation. And the Menu Label "Viewport dispaly" does not conclude to any influence on Grease Pencil either.
this can lead to very confusing and frustrating situations.

Exact steps for others to reproduce the error
start 2D Animation scene, make GreasePencil strokes change the material color of the strokes to any bright color. Goto World settings, and change the ViewportDisplay color. Change the ViewportShading mode to Material or Render to see the influence of Viewport Dispaly color on GreasePencil elements.

greasepencil_viewportdisplay.blend

**System Information** Operating system: Windows-10-10.0.19042-SP0 64 Bits Graphics card: NVIDIA GeForce RTX 3070/PCIe/SSE2 NVIDIA Corporation 4.5.0 NVIDIA 496.13 **Blender Version** Broken: version: 3.0.0, branch: master, commit date: 2021-12-02 18:35, hash: `f1cca30557` Worked: (newest version of Blender that worked as expected) **Short description of error** when changing the viewport display color in the world properties all grease pencil strokes get ambient lit by the color (even if the world uses nodes). it used to only change the background color in viewport shading, when its background is set to world. at least thats whats documented about "viewport-display" right now. theres no mention about this influence on grease pencil in the documentation. And the Menu Label "Viewport dispaly" does not conclude to any influence on Grease Pencil either. this can lead to very confusing and frustrating situations. **Exact steps for others to reproduce the error** start 2D Animation scene, make GreasePencil strokes change the material color of the strokes to any bright color. Goto World settings, and change the ViewportDisplay color. Change the ViewportShading mode to Material or Render to see the influence of Viewport Dispaly color on GreasePencil elements. [greasepencil_viewportdisplay.blend](https://archive.blender.org/developer/F12771588/greasepencil_viewportdisplay.blend)

richard schweiger commented

2021-12-22 08:38:41 +01:00

Added subscriber: @office

Philipp Oeser commented

2021-12-22 09:43:20 +01:00

Added subscriber: @lichtwerk

Philipp Oeser commented

2021-12-22 09:43:20 +01:00

Changed status from 'Needs Triage' to: 'Needs User Info'

Philipp Oeser commented

2021-12-22 09:43:20 +01:00

Cannot reproduce.

What is your strokes Blend mode set to?
Mind sharing an example file?

Cannot reproduce. What is your strokes `Blend` mode set to? Mind sharing an example file?

richard schweiger commented

2021-12-22 09:50:15 +01:00

sorry i forgot to mention you need to go to materialView or renderView to see the influence.greasepencil_viewportdisplay.blend

sorry i forgot to mention you need to go to materialView or renderView to see the influence.[greasepencil_viewportdisplay.blend](https://archive.blender.org/developer/F12771588/greasepencil_viewportdisplay.blend)

richard schweiger commented

2021-12-22 09:53:41 +01:00

the strokes i used are all set to "regular". i uploaded a file from version 2.93.5 its the same behaviour in 3.0.

richard schweiger commented

2021-12-22 09:56:09 +01:00

here you see a blue stroke material and the world Viewport Display color set to yellow. The Stroke is rendered green.

here you see a blue stroke material and the world Viewport Display color set to yellow. The Stroke is rendered green. ![image.png](https://archive.blender.org/developer/F12771595/image.png)

Philipp Oeser commented

2021-12-22 10:27:59 +01:00

Yeah, seems like the viewport color is always used as ambient color here (even if the world uses nodes).

gpencil_light_ambient_add(stl->pd->global_light_pool, &world->horr);

horr is the Viewport Display Color.

This might be by design, checking...

Yeah, seems like the viewport color is always used as ambient color here (even if the world uses nodes). ``` gpencil_light_ambient_add(stl->pd->global_light_pool, &world->horr); ``` `horr` is the Viewport Display Color. This might be by design, checking...

Philipp Oeser changed title from ~~viewport-display color multiplies grease pencil~~ to Grease pencil always uses the viewport display color of a world for its ambient light (even if the world uses nodes)

2021-12-22 12:12:20 +01:00

Philipp Oeser commented

2021-12-22 12:14:22 +01:00

Changed status from 'Needs User Info' to: 'Needs Developer To Reproduce'

Philipp Oeser commented

2021-12-22 12:14:22 +01:00

I have a patch that uses the backgound nodes' color as ambient light.
But since I am not sure if this is really the way to go, will set status accordingly.

I have a patch that uses the backgound nodes' color as ambient light. But since I am not sure if this is really the way to go, will set status accordingly.

Antonio Vazquez commented

2021-12-22 13:26:29 +01:00

Added subscribers: @fclem, @antoniov

Antonio Vazquez commented

2021-12-22 13:26:29 +01:00

We need @fclem opinion.

Clément Foucault commented

2022-01-03 15:05:47 +01:00

Changed status from 'Needs Developer To Reproduce' to: 'Archived'

Clément Foucault closed this issue

2022-01-03 15:05:47 +01:00

Clément Foucault commented

2022-01-03 15:05:47 +01:00

The issue is that using the nodetree as ambient color is hard to get right. It is simple if the nodetree is really simple but it gets complex really quickly.

Eevee is used to render the background this is why the background color uses the nodetree.

The user level workaround is to disable Use Nodes in the world tab and let EEVEE and Gpencil engines use the same color.

EEVEE rewrite will bring full GPencil lighting so I am not in favor of adding complexity to Gpencil engine lighting.

The issue is that using the nodetree as ambient color is hard to get right. It is simple if the nodetree is really simple but it gets complex really quickly. Eevee is used to render the background this is why the background color uses the nodetree. The user level workaround is to disable `Use Nodes` in the world tab and let EEVEE and Gpencil engines use the same color. EEVEE rewrite will bring full GPencil lighting so I am not in favor of adding complexity to Gpencil engine lighting.

Aleš Jelovčan commented

2022-01-03 15:20:38 +01:00

Added subscriber: @frogstomp-4

Aleš Jelovčan commented

2022-01-03 15:20:38 +01:00

For the time being, I think viewport background color is good solution to set up base lightning setting. Would not change anything before eevee-rewrite lands.

Sign in to join this conversation.

No Label

Download

What's New

Blender Studio

Manual

Developers Blog

Documentation

Benchmark

Blender Conference

Development Fund

One-time Donations

Grease pencil always uses the viewport display color of a world for its ambient light (even if the world uses nodes) #94318