Compositor: Alternate sharpen kernel for filter node. #95275

New Issue

Jeroen Bakker · 2022-01-28T08:14:17+01:00

Jeroen Bakker commented

2022-01-28 08:14:17 +01:00

Add a new kernel to the filter node.

Api name of the kernel is: "SHARPEN_DIAMOND"
Display name: "Diamond". The description could mention that this is a softer version of sharpen.

Kernel should look like

0  -1  0
-1  5 -1
0  -1  0

See COM_FilterNode and def_cmp_filter

Original request: https://blender.community/c/rightclickselect/57Kq

Add a new kernel to the filter node. Api name of the kernel is: "SHARPEN_DIAMOND" Display name: "Diamond". The description could mention that this is a softer version of sharpen. Kernel should look like ``` 0 -1 0 -1 5 -1 0 -1 0 ``` See `COM_FilterNode` and `def_cmp_filter` Original request: https://blender.community/c/rightclickselect/57Kq

Jeroen Bakker commented

2022-01-28 08:14:17 +01:00

Added subscriber: @Jeroen-Bakker

Jeroen Bakker commented

2022-01-28 08:14:25 +01:00

Changed status from 'Needs Triage' to: 'Confirmed'

Colin Basnett commented

2022-01-29 03:39:17 +01:00

Added subscriber: @cmbasnett

Jeroen Bakker commented

2022-01-29 11:30:35 +01:00

Hi colin saw you were working on this task. If so please assign yourself to it.

Btw I would just add the new kernel to the kernel list. Adding a new option would add some complexity and confusion.

There are ways to display the items in the list as subitems.

Hi colin saw you were working on this task. If so please assign yourself to it. Btw I would just add the new kernel to the kernel list. Adding a new option would add some complexity and confusion. There are ways to display the items in the list as subitems.

Colin Basnett self-assigned this 2022-01-29 23:49:59 +01:00

Colin Basnett commented

2022-01-29 23:55:05 +01:00

Sounds good. The question then becomes what to name these things. Photoshop has two filters "Sharpen" and "Sharpen More". Perhaps the existing sharpen kernel could be renamed to "Sharpen More" and the new one be named "Sharpen"? Inversely, we could leave the existing Sharpen as-is and call the new one "Sharpen Less".

Colin Basnett commented

2022-02-04 10:47:43 +01:00

I've implemented this in the simpler way described, simply as another option in the kernel list.

I've named it "Sharpen Less" in the interface, since "Diamond" seemed needlessly opaque. In my opinion, calling it "Sharpen Less" gets the functionality across to the user more directly without needing a mouse-over description.

I will post up a PR over the weekend!

I've implemented this in the simpler way described, simply as another option in the kernel list. I've named it "Sharpen Less" in the interface, since "Diamond" seemed needlessly opaque. In my opinion, calling it "Sharpen Less" gets the functionality across to the user more directly without needing a mouse-over description. I will post up a PR over the weekend! ![image.png](https://archive.blender.org/developer/F12845385/image.png)

Ludvik Koutny commented

2022-02-09 10:38:54 +01:00

Added subscriber: @Rawalanche

Ludvik Koutny commented

2022-02-09 10:38:54 +01:00

I'd suggest perhaps adding also Sharpen Even Less, Sharpen Slightly More and Sharpen More filters.

No, seriously. Shouldn't this go through some UX sanity check filter before being committed? It's quite obvious that if there's a need for "Sharpen Less" mode, what's really needed is a Sharpen filter with some sort of amount slider/multiplier, like in pretty much any other common sense software out there. The idea of user having a choice between two "Sharpen" and "Sharpen Less" modes, expecting that one or the other will be the exact amount of sharpening they desire is just wrong.

In other words, the sharpening matrix should be parametric, instead of having two hardcoded options.

I'd suggest perhaps adding also Sharpen Even Less, Sharpen Slightly More and Sharpen More filters. No, seriously. Shouldn't this go through some UX sanity check filter before being committed? It's quite obvious that if there's a need for "Sharpen Less" mode, what's really needed is a Sharpen filter with some sort of amount slider/multiplier, like in pretty much any other common sense software out there. The idea of user having a choice between two "Sharpen" and "Sharpen Less" modes, expecting that one or the other will be the exact amount of sharpening they desire is just wrong. In other words, the sharpening matrix should be parametric, instead of having two hardcoded options.

Hallam Roberts commented

2022-02-09 11:16:59 +01:00

Added subscriber: @MysteryPancake

Hallam Roberts commented

2022-02-09 11:16:59 +01:00

In #95275#1304556, @Rawalanche wrote:
I'd suggest perhaps adding also Sharpen Even Less, Sharpen Slightly More and Sharpen More filters.

No, seriously. Shouldn't this go through some UX sanity check filter before being committed? It's quite obvious that if there's a need for "Sharpen Less" mode, what's really needed is a Sharpen filter with some sort of amount slider/multiplier, like in pretty much any other common sense software out there. The idea of user having a choice between two "Sharpen" and "Sharpen Less" modes, expecting that one or the other will be the exact amount of sharpening they desire is just wrong.

In other words, the sharpening matrix should be parametric, instead of having two hardcoded options.

The Filter node has a "factor" slider for this purpose (it can go above 1 when the text is edited). I believe the idea with this kernel was to provide a different shaped kernel, a diamond shape rather than a box shape.

It is currently named "Box Sharpen" and "Diamond Sharpen" in the UI for this reason.

> In #95275#1304556, @Rawalanche wrote: > I'd suggest perhaps adding also Sharpen Even Less, Sharpen Slightly More and Sharpen More filters. > > No, seriously. Shouldn't this go through some UX sanity check filter before being committed? It's quite obvious that if there's a need for "Sharpen Less" mode, what's really needed is a Sharpen filter with some sort of amount slider/multiplier, like in pretty much any other common sense software out there. The idea of user having a choice between two "Sharpen" and "Sharpen Less" modes, expecting that one or the other will be the exact amount of sharpening they desire is just wrong. > > In other words, the sharpening matrix should be parametric, instead of having two hardcoded options. The Filter node has a "factor" slider for this purpose (it can go above 1 when the text is edited). I believe the idea with this kernel was to provide a different shaped kernel, a diamond shape rather than a box shape. It is currently named "Box Sharpen" and "Diamond Sharpen" in the UI for this reason. ![image.png](https://archive.blender.org/developer/F12857199/image.png)

Ludvik Koutny commented

2022-02-09 11:54:00 +01:00

In #95275#1304613, @MysteryPancake wrote:

In #95275#1304556, @Rawalanche wrote:
I'd suggest perhaps adding also Sharpen Even Less, Sharpen Slightly More and Sharpen More filters.

No, seriously. Shouldn't this go through some UX sanity check filter before being committed? It's quite obvious that if there's a need for "Sharpen Less" mode, what's really needed is a Sharpen filter with some sort of amount slider/multiplier, like in pretty much any other common sense software out there. The idea of user having a choice between two "Sharpen" and "Sharpen Less" modes, expecting that one or the other will be the exact amount of sharpening they desire is just wrong.

In other words, the sharpening matrix should be parametric, instead of having two hardcoded options.

The Filter node has a "factor" slider for this purpose (it can go above 1 when the text is edited). I believe the idea with this kernel was to provide a different shaped kernel, a diamond shape rather than a box shape.

It is currently named "Box Sharpen" and "Diamond Sharpen" in the UI for this reason.

Ah, nevermind then. From the original picture as well as the request it was not obvious it has factor, and the "Sharpen Less" name did not really help.

> In #95275#1304613, @MysteryPancake wrote: >> In #95275#1304556, @Rawalanche wrote: >> I'd suggest perhaps adding also Sharpen Even Less, Sharpen Slightly More and Sharpen More filters. >> >> No, seriously. Shouldn't this go through some UX sanity check filter before being committed? It's quite obvious that if there's a need for "Sharpen Less" mode, what's really needed is a Sharpen filter with some sort of amount slider/multiplier, like in pretty much any other common sense software out there. The idea of user having a choice between two "Sharpen" and "Sharpen Less" modes, expecting that one or the other will be the exact amount of sharpening they desire is just wrong. >> >> In other words, the sharpening matrix should be parametric, instead of having two hardcoded options. > > The Filter node has a "factor" slider for this purpose (it can go above 1 when the text is edited). I believe the idea with this kernel was to provide a different shaped kernel, a diamond shape rather than a box shape. > > It is currently named "Box Sharpen" and "Diamond Sharpen" in the UI for this reason. > > ![image.png](https://archive.blender.org/developer/F12857199/image.png) Ah, nevermind then. From the original picture as well as the request it was not obvious it has factor, and the "Sharpen Less" name did not really help.

Evan Wilson commented

2022-02-09 12:09:27 +01:00

Added subscriber: @EAW

Evan Wilson commented

2022-02-09 12:09:27 +01:00

Changed status from 'Confirmed' to: 'Resolved'

Evan Wilson closed this issue

2022-02-09 12:09:27 +01:00

Evan Wilson commented

2022-02-09 12:09:27 +01:00

As this has been implemented, I’ll close this task.

Fabian-Meyer commented

2024-01-06 20:20:29 +01:00

Sorry to ressurect this but shouldn't the filter node have a size (in px) UI element? Or the possibility to submit your own filter kernel...
Something like in photoshop with size, amount (and threshold)?

Sorry to ressurect this but shouldn't the filter node have a size (in px) UI element? Or the possibility to submit your own filter kernel... Something like in photoshop with size, amount (and threshold)?

Sign in to join this conversation.

No Label

Download

What's New

Blender Studio

Manual

Developers Blog

Documentation

Benchmark

Blender Conference

Development Fund

One-time Donations

Compositor: Alternate sharpen kernel for filter node. #95275