Display asset node groups in the add menu #95446

New Issue

Hans Goudey · 2022-02-02T17:55:39+01:00

Hans Goudey commented

2022-02-02 17:55:39 +01:00

Based on the discussion in #92811, node groups from available asset data-blocks should be displayed in the node editor add menu.

Menu items should be created dynamically based on which catalogs the node groups are part of.
An "Asset" icon should distinguish them from other groups and built-in nodes.

This may require refactoring of the node editor add menu, which is currently generated automatically based on the code in nodeitems_builtins.py (#92825)

Further Questions

What do do when a node group is in multiple catalogs? Possibly add two entries in the add menu.

Based on the discussion in #92811, node groups from available asset data-blocks should be displayed in the node editor add menu. Menu items should be created dynamically based on which catalogs the node groups are part of. An "Asset" icon should distinguish them from other groups and built-in nodes. This may require refactoring of the node editor add menu, which is currently generated automatically based on the code in `nodeitems_builtins.py` (#92825) **Further Questions** - What do do when a node group is in multiple catalogs? Possibly add two entries in the add menu.

Hans Goudey commented

2022-02-02 17:55:39 +01:00

Changed status from 'Needs Triage' to: 'Confirmed'

Hans Goudey commented

2022-02-02 17:55:39 +01:00

Added subscriber: @HooglyBoogly

Julian Eisel commented

2022-02-24 16:26:42 +01:00

Added subscriber: @JulianEisel

Julian Eisel commented

2022-02-24 16:26:42 +01:00

Some notes:

Asset libraries are currently loaded on activation in the asset browser or asset view templates. This process may take a while (esp if the library isn't indexed yet). So the add menu should support asynchronous loading and indicate the status (loading or done?).
The asset system isn't done yet, and the asset browser uses the file browser's per space storage for the list of assets. However, for the asset view templates I've already worked on a global storage system, so this is what you'd use here. The API is simple - I hope :) Should be as simple as calling ED_assetlist_storage_fetch() and adding menu items via ED_assetlist_iterate().
For a regular menu users may not expect expensive (async) loading, so maybe it should use a different UI. It could be made more consistent with the normal asset browser/view UIs like suggested in #54642: (A catalog selector should be displayed there too, somehow.)

What do do when a node group is in multiple catalogs? Possibly add two entries in the add menu.

An asset can only be in one catalog currently. In future dynamic catalogs may be added which are just filtering presets. These would then allow displaying assets in multiple dynamic catalogs.

Some notes: - Asset libraries are currently loaded on activation in the asset browser or asset view templates. This process may take a while (esp if the library isn't indexed yet). So the add menu should support asynchronous loading and indicate the status (loading or done?). - The asset system isn't done yet, and the asset browser uses the file browser's per space storage for the list of assets. However, for the asset view templates I've already worked on a global storage system, so this is what you'd use here. The API is simple - I hope :) Should be as simple as calling `ED_assetlist_storage_fetch()` and adding menu items via `ED_assetlist_iterate()`. - For a regular menu users may not expect expensive (async) loading, so maybe it should use a different UI. It could be made more consistent with the normal asset browser/view UIs like suggested in #54642: ![Assets_Material_Selector.png](https://archive.blender.org/developer/F2725404/Assets_Material_Selector.png) (A catalog selector should be displayed there too, somehow.) > - What do do when a node group is in multiple catalogs? Possibly add two entries in the add menu. An asset can only be in one catalog currently. In future dynamic catalogs may be added which are just filtering presets. These would then allow displaying assets in multiple dynamic catalogs.

Angus Stanton commented

2022-04-16 00:42:55 +02:00

Added subscriber: @ab_stanton

Angus Stanton commented

2022-04-18 13:57:21 +02:00

Is there a design task being worked on for this? I thought I'd start implementing it but it seems a bit confused. Will the nodes appear in the add menu as: asset_libary -> catalog -> node group, or will it be as @JulianEisel said with the more asset library-esque UI? I got it working to a basic level in the add menu, but without the add menu refactorings mentioned in #92825 .

Hans Goudey commented

2022-07-11 04:42:16 +02:00

@ab_stanton Sorry for the delayed response. It's not totally clear honestly. The benefit to adding it in the existing add menu is that node groups could fit right in with builtin nodes, which we've wanted in the past. Julian mentions the benefits to the other approach above. If we use the normal add menu I think we'd have to make sure to support asynchronous loading and showing the status, which sounds like it could be annoying to combine with the UI menu code, not sure.

Angus Stanton commented

2022-07-14 19:57:23 +02:00

@HooglyBoogly yeah, also yeah if #92825 does need to be done first then I'm not sure I have the energy for it, refactoring isn't the top of my list of things to do in my spare time. I would be interested to see how the async loading could be incorporated into the menu, can't think of where else in blender implements that, bar maybe the asset library previews, but not any buttons afaik

blender-admin commented

2022-09-19 18:57:10 +02:00

This issue was referenced by bdb5754147

This issue was referenced by bdb57541475f20ccc4f6e5f8fc075ac424becc19

Hans Goudey commented

2023-01-02 16:06:00 +01:00

Changed status from 'Confirmed' to: 'Resolved'

Hans Goudey closed this issue

2023-01-02 16:06:00 +01:00

Hans Goudey self-assigned this 2023-01-02 16:06:00 +01:00

Sign in to join this conversation.

No Label

Download

What's New

Blender Studio

Manual

Developers Blog

Documentation

Benchmark

Blender Conference

Development Fund

One-time Donations

Display asset node groups in the add menu #95446