Regression: Missing update in custom Nodetree #96394

New Issue

Gregory · 2022-03-13T11:17:06+01:00

Gregory commented

2022-03-13 11:17:06 +01:00

System Information
Operating system: Windows-10-10.0.19042-SP0 64 Bits
Graphics card: GeForce GTX 1070/PCIe/SSE2 NVIDIA Corporation 4.5.0 NVIDIA 461.40

Blender Version
Broken: version: 3.1.0, current master
Affected by 7e712b2d6a

Short description of error
If create custom node tree with name "CustomNodeTree" and try update node tree by script: bpy.data.node_groups["CustomNodeTree"].interface_update(bpy.context) - tree not updated. In version Blender 3.0 function works good

Exact steps for others to reproduce the error

Download archive batch_render_nodes.zip
Install zip-archive add-on in Blender 3.0 and Blender 3.1
Download test file Batch_Render_Nodes_UPDATE_TREE_TEST.blend
Open test file in Blender 3.0
Try change sockets values
Sockets output values updated
Open same test file in Blender 3.1
Try change sockets values
Sockets output values not updated

For update sockets and all node tree i used function https://docs.blender.org/api/current/bpy.types.NodeTree.html#bpy.types.NodeTree.interface_update
batch_render_nodes.zip
Batch_Render_Nodes_UPDATE_TREE_TEST.blend

3.0.0	3.1.0
Video_Blender_3_0.mp4	Video_Blender_3_1.mp4

**System Information** Operating system: Windows-10-10.0.19042-SP0 64 Bits Graphics card: GeForce GTX 1070/PCIe/SSE2 NVIDIA Corporation 4.5.0 NVIDIA 461.40 **Blender Version** Broken: version: 3.1.0, current master Affected by 7e712b2d6a **Short description of error** If create custom node tree with name "CustomNodeTree" and try update node tree by script: `bpy.data.node_groups["CustomNodeTree"].interface_update(bpy.context)` - tree not updated. In version Blender 3.0 function works good **Exact steps for others to reproduce the error** 1. Download archive `batch_render_nodes.zip` 2. Install zip-archive add-on in Blender 3.0 and Blender 3.1 3. Download test file `Batch_Render_Nodes_UPDATE_TREE_TEST.blend` 4. Open test file in Blender 3.0 5. Try change sockets values 6. Sockets output values updated 7. Open same test file in Blender 3.1 8. Try change sockets values 9. Sockets output values not updated For update sockets and all node tree i used function https://docs.blender.org/api/current/bpy.types.NodeTree.html#bpy.types.NodeTree.interface_update [batch_render_nodes.zip](https://archive.blender.org/developer/F12941658/batch_render_nodes.zip) [Batch_Render_Nodes_UPDATE_TREE_TEST.blend](https://archive.blender.org/developer/F12941677/Batch_Render_Nodes_UPDATE_TREE_TEST.blend) | 3.0.0 | 3.1.0 | | -- | -- | | [Video_Blender_3_0.mp4](https://archive.blender.org/developer/F12941688/Video_Blender_3_0.mp4) | [Video_Blender_3_1.mp4](https://archive.blender.org/developer/F12941690/Video_Blender_3_1.mp4) |

Gregory commented

2022-03-13 11:17:06 +01:00

Added subscriber: @GregoryS

Pratik Borhade commented

2022-03-21 07:12:30 +01:00

Added subscriber: @PratikPB2123

Pratik Borhade commented

2022-03-21 07:40:44 +01:00

Changed status from 'Needs Triage' to: 'Needs User Info'

Pratik Borhade commented

2022-03-21 07:40:44 +01:00

Create custom node tree by python

Hi, thanks for the report. You mean using default python template?

I don't think I understand steps for reproducing the problem. Are you using custom script? Can you attach that?
Also, please test again on latest 3.2 build: https://builder.blender.org/download/daily/
Similar reports I have seen where responsible commit was 7e712b2d6a

> Create custom node tree by python Hi, thanks for the report. You mean using default python template? I don't think I understand steps for reproducing the problem. Are you using custom script? Can you attach that? Also, please test again on latest 3.2 build: https://builder.blender.org/download/daily/ Similar reports I have seen where responsible commit was 7e712b2d6a

Gregory commented

2022-03-23 20:12:49 +01:00

In #96394#1326520, @PratikPB2123 wrote:

Create custom node tree by python

Hi, thanks for the report. You mean using default python template?

I don't think I understand steps for reproducing the problem. Are you using custom script? Can you attach that?
Also, please test again on latest 3.2 build: https://builder.blender.org/download/daily/
Similar reports I have seen where responsible commit was 7e712b2d6a

Thanks!

I codding add-on for batch rendering using node trees.
Steps:

Download archive batch_render_nodes.zip batch_render_nodes.zip
Install zip-archive add-on in Blender 3.0 and Blender 3.1
3.Download test file Batch_Render_Nodes_UPDATE_TREE_TEST.blend Batch_Render_Nodes_UPDATE_TREE_TEST.blend
Open test file Batch_Render_Nodes_UPDATE_TREE_TEST.blend in Blender 3.0
Try change sockets values
Sockets output values updated
Open test file Batch_Render_Nodes_UPDATE_TREE_TEST.blend in Blender 3.1
Try change sockets values
Sockets output values not updated

I try Blender 3.2. Sockets output information also not updated

For update sockets and all node tree i used function https://docs.blender.org/api/current/bpy.types.NodeTree.html#bpy.types.NodeTree.interface_update

Also i upload screen videocapture
Video_Blender_3_0.mp4
Video_Blender_3_1.mp4

> In #96394#1326520, @PratikPB2123 wrote: >> Create custom node tree by python > Hi, thanks for the report. You mean using default python template? > > I don't think I understand steps for reproducing the problem. Are you using custom script? Can you attach that? > Also, please test again on latest 3.2 build: https://builder.blender.org/download/daily/ > Similar reports I have seen where responsible commit was 7e712b2d6a Thanks! I codding add-on for batch rendering using node trees. Steps: 1. Download archive batch_render_nodes.zip [batch_render_nodes.zip](https://archive.blender.org/developer/F12941658/batch_render_nodes.zip) 2. Install zip-archive add-on in Blender 3.0 and Blender 3.1 3.Download test file Batch_Render_Nodes_UPDATE_TREE_TEST.blend [Batch_Render_Nodes_UPDATE_TREE_TEST.blend](https://archive.blender.org/developer/F12941677/Batch_Render_Nodes_UPDATE_TREE_TEST.blend) 4. Open test file Batch_Render_Nodes_UPDATE_TREE_TEST.blend in Blender 3.0 5. Try change sockets values 6. Sockets output values updated 7. Open test file Batch_Render_Nodes_UPDATE_TREE_TEST.blend in Blender 3.1 8. Try change sockets values 9. Sockets output values not updated I try Blender 3.2. Sockets output information also not updated For update sockets and all node tree i used function https://docs.blender.org/api/current/bpy.types.NodeTree.html#bpy.types.NodeTree.interface_update Also i upload screen videocapture [Video_Blender_3_0.mp4](https://archive.blender.org/developer/F12941688/Video_Blender_3_0.mp4) [Video_Blender_3_1.mp4](https://archive.blender.org/developer/F12941690/Video_Blender_3_1.mp4)

Pratik Borhade commented

2022-03-24 03:39:15 +01:00

Changed status from 'Needs User Info' to: 'Confirmed'

Pratik Borhade commented

2022-03-24 03:39:15 +01:00

Added subscriber: @JacquesLucke

Pratik Borhade commented

2022-03-24 03:39:15 +01:00

Thank you for the information :)
I can confirm now. This is got affected after the same commit. This one- 7e712b2d6a
@JacquesLucke ^

Thank you for the information :) I can confirm now. This is got affected after the same commit. This one- 7e712b2d6a @JacquesLucke ^

Pratik Borhade changed title from ~~Function - interface_update(context) - from class NodeTree not work in Blender 3.1~~ to Regression: Missing update in custom Nodetree

2022-03-24 03:44:49 +01:00

Jacques Lucke commented

2022-03-24 11:50:38 +01:00

I'm not 100%, but right now this does not feel like a bug in Blender to me.

It seems like you expect Blender to call the update method on every node when you call interface_update. However, there is no reason why it should do that. interface_update is a method that was supposed to be called to force an update when the inputs or outputs of a node group changed. However, Blender never calls this function itself anymore, so maybe it should even be removed.

From what I can tell, the current update-logic in the addon is very brittle. This is also shown by the fact that you always call interface_update three times, so that data can propagate for three nodes. This might give the illusion that it works, but is still unreliable when there are longer chains of nodes.

A short term fix would be to just call node.update() for all the nodes manually.

@persistent
def updateNodeTreeTimerThread():

        for tree in bpy.data.node_groups:
            if tree.bl_idname == 'BatchNodesTree':
                for _ in range(3):
                    for node in tree.nodes:
                        node.update()

In addition you might have to loop over the different area/regions in the Blender UI and call tag_redraw on them.
For a more complete example see P2851.

I highly recommend you to implement a system that gives you control over when and in what order nodes are executed.

I'm not 100%, but right now this does not feel like a bug in Blender to me. It seems like you expect Blender to call the `update` method on every node when you call `interface_update`. However, there is no reason why it should do that. `interface_update` is a method that was supposed to be called to force an update when the inputs or outputs of a node group changed. However, Blender never calls this function itself anymore, so maybe it should even be removed. From what I can tell, the current update-logic in the addon is very brittle. This is also shown by the fact that you always call `interface_update` three times, so that data can propagate for three nodes. This might give the illusion that it works, but is still unreliable when there are longer chains of nodes. A short term fix would be to just call `node.update()` for all the nodes manually. ``` @persistent def updateNodeTreeTimerThread(): for tree in bpy.data.node_groups: if tree.bl_idname == 'BatchNodesTree': for _ in range(3): for node in tree.nodes: node.update() ``` In addition you might have to loop over the different area/regions in the Blender UI and call `tag_redraw` on them. For a more complete example see [P2851](https://archive.blender.org/developer/P2851.txt). I highly recommend you to implement a system that gives you control over when and in what order nodes are executed.

Gregory commented

2022-04-06 13:32:13 +02:00

In #96394#1329178, @JacquesLucke wrote:
I'm not 100%, but right now this does not feel like a bug in Blender to me.

It seems like you expect Blender to call the update method on every node when you call interface_update. However, there is no reason why it should do that. interface_update is a method that was supposed to be called to force an update when the inputs or outputs of a node group changed. However, Blender never calls this function itself anymore, so maybe it should even be removed.

From what I can tell, the current update-logic in the addon is very brittle. This is also shown by the fact that you always call interface_update three times, so that data can propagate for three nodes. This might give the illusion that it works, but is still unreliable when there are longer chains of nodes.

A short term fix would be to just call node.update() for all the nodes manually.
@persistent
def updateNodeTreeTimerThread():

        for tree in bpy.data.node_groups:
            if tree.bl_idname == 'BatchNodesTree':
                for _ in range(3):
                    for node in tree.nodes:
                        node.update()
In addition you might have to loop over the different area/regions in the Blender UI and call tag_redraw on them.
For a more complete example see P2851.

I highly recommend you to implement a system that gives you control over when and in what order nodes are executed.

Thanks !I have updated the code, thanks to your advice. Update nodes works

> In #96394#1329178, @JacquesLucke wrote: > I'm not 100%, but right now this does not feel like a bug in Blender to me. > > It seems like you expect Blender to call the `update` method on every node when you call `interface_update`. However, there is no reason why it should do that. `interface_update` is a method that was supposed to be called to force an update when the inputs or outputs of a node group changed. However, Blender never calls this function itself anymore, so maybe it should even be removed. > > From what I can tell, the current update-logic in the addon is very brittle. This is also shown by the fact that you always call `interface_update` three times, so that data can propagate for three nodes. This might give the illusion that it works, but is still unreliable when there are longer chains of nodes. > > A short term fix would be to just call `node.update()` for all the nodes manually. > ``` > @persistent > def updateNodeTreeTimerThread(): > > for tree in bpy.data.node_groups: > if tree.bl_idname == 'BatchNodesTree': > for _ in range(3): > for node in tree.nodes: > node.update() > ``` > > In addition you might have to loop over the different area/regions in the Blender UI and call `tag_redraw` on them. > For a more complete example see [P2851](https://archive.blender.org/developer/P2851.txt). > > I highly recommend you to implement a system that gives you control over when and in what order nodes are executed. Thanks !I have updated the code, thanks to your advice. Update nodes works

Jacques Lucke commented

2022-04-07 14:14:21 +02:00

Changed status from 'Confirmed' to: 'Archived'

Jacques Lucke closed this issue

2022-04-07 14:14:21 +02:00

Sign in to join this conversation.

No Label

Download

What's New

Blender Studio

Manual

Developers Blog

Documentation

Benchmark

Blender Conference

Development Fund

One-time Donations

Regression: Missing update in custom Nodetree #96394