Armature corrupted after undo #96452

New Issue

Kirill · 2022-03-14T14:45:04+01:00

Kirill commented

2022-03-14 14:45:04 +01:00

System Information
Operating system: Windows-10-10.0.19044-SP0 64 Bits
Graphics card: NVIDIA GeForce RTX 3070 Ti/PCIe/SSE2 NVIDIA Corporation 4.5.0 NVIDIA 511.79

Blender Version
Broken: version: 3.1.0, branch: master, commit date: 2022-03-08 18:16, hash: c77597cd0e
Worked: 2.93

Short description of error
Joining armatures and undoing causes armature to be corrupted

Exact steps for others to reproduce the error
#96452.blend

Open file
Join 2 armatures

Undo

Check bone constraints or bone properties, they will be obviously corrupted(bad name, missing properties, can't enter edit mode). With no constraints present, bones can dissapear completely

**System Information** Operating system: Windows-10-10.0.19044-SP0 64 Bits Graphics card: NVIDIA GeForce RTX 3070 Ti/PCIe/SSE2 NVIDIA Corporation 4.5.0 NVIDIA 511.79 **Blender Version** Broken: version: 3.1.0, branch: master, commit date: 2022-03-08 18:16, hash: `c77597cd0e` Worked: 2.93 **Short description of error** Joining armatures and undoing causes armature to be corrupted **Exact steps for others to reproduce the error** [#96452.blend](https://archive.blender.org/developer/F12928120/T96452.blend) - Open file - Join 2 armatures # Undo Check bone constraints or bone properties, they will be obviously corrupted(bad name, missing properties, can't enter edit mode). With no constraints present, bones can dissapear completely

Kirill commented

2022-03-14 14:45:04 +01:00

Added subscriber: @AngryBearr-2

Richard Antalik changed title from ~~Bone constraint properties disappear~~ to Armature corrupted after undo

2022-03-15 01:30:31 +01:00

Richard Antalik commented

2022-03-15 01:30:31 +01:00

Changed status from 'Needs Triage' to: 'Confirmed'

Bastien Montagne commented

2022-03-15 14:59:34 +01:00

Added subscriber: @mont29

Bastien Montagne commented

2022-03-15 14:59:34 +01:00

OK, issue is caused by e648e38887, specifically the clearing of the ID user count on write introduced by this commit.

However, this is merely revealing a bug in the join operator for armatures, and a bad behavior:

Bug: Armature data ID of the source is left empty (all of its bones being moved to destination one), but the ID is not properly tagged as changed.
** Before e648e38887, the change in ID.us (since object using the source armature is deleted) was enough for undo to detect ID as changed.
Bad behavior: Editing the source Armature ID is very bad - other unaffected objects might be using it. It is also different behavior from e.g. Mesh objects joining. Code should either:
- Leave the source armature ID unchanged, and work with a temp copy of it.
- Delete the source armature ID together with its object.
  Think bad behavior should be fixed by option 1.

Will commit missing DEG tag, which fixes the crash and is safe enough to be backported to 3.1 should we do a corrective release. Will leave proper fix of the behavior of this operator itself to the #animation_rigging team.

OK, issue is caused by e648e38887, specifically the clearing of the ID user count on write introduced by this commit. However, this is merely revealing a bug in the join operator for armatures, and a bad behavior: * Bug: Armature data ID of the source is left empty (all of its bones being moved to destination one), but the ID is not properly tagged as changed. ** *Before e648e38887, the change in `ID.us` (since object using the source armature is deleted) was enough for undo to detect ID as changed.* * Bad behavior: Editing the source Armature ID is very bad - other unaffected objects might be using it. It is also different behavior from e.g. Mesh objects joining. Code should either: - Leave the source armature ID unchanged, and work with a temp copy of it. - Delete the source armature ID together with its object. Think bad behavior should be fixed by option 1. ----------------------- Will commit missing DEG tag, which fixes the crash and is safe enough to be backported to 3.1 should we do a corrective release. Will leave proper fix of the behavior of this operator itself to the #animation_rigging team.

blender-admin commented

2022-03-15 15:00:19 +01:00

This issue was referenced by 2fc52fb742

This issue was referenced by 2fc52fb742396bf790395a0327cf77c1c97fd229

blender-admin commented

2022-03-15 15:00:19 +01:00

This issue was referenced by 2156841c8c

This issue was referenced by 2156841c8ca8e754e073ceb14912c7529af891bf

Bastien Montagne commented

2022-03-15 15:03:47 +01:00

Changed status from 'Confirmed' to: 'Resolved'

Bastien Montagne closed this issue

2022-03-15 15:03:47 +01:00

Bastien Montagne self-assigned this 2022-03-15 15:03:47 +01:00

Thomas Dinges added this to the 3.1 milestone 2023-02-08 15:52:44 +01:00

Sign in to join this conversation.

No Label

Download

What's New

Blender Studio

Manual

Developers Blog

Documentation

Benchmark

Blender Conference

Development Fund

One-time Donations

Armature corrupted after undo #96452

Undo