Default attribute input and output names for modifier fields #96707

New Issue

Hans Goudey · 2022-03-22T14:42:16+01:00

Hans Goudey commented

2022-03-22 14:42:16 +01:00

When a field is exposed to the modifier as an input or output, it would be useful to be able to choose a default name for an attribute read or created with that field.

Hans Goudey commented

2022-03-22 14:42:16 +01:00

Changed status from 'Needs Triage' to: 'Confirmed'

Hans Goudey commented

2022-03-22 14:42:16 +01:00

Added subscriber: @HooglyBoogly

Simon Thommes commented

2022-03-22 19:30:19 +01:00

Added subscriber: @SimonThommes

Simon Thommes commented

2022-03-22 19:31:53 +01:00

Small addition: In the case of modifier inputs that would also require to set the default input to be an attribute in the first place.
For outputs that is given, for nodes the input should be passed via node link.

Small addition: In the case of modifier inputs that would also require to set the default input to be an attribute in the first place. For outputs that is given, for nodes the input should be passed via node link.

Hans Goudey commented

2022-03-22 20:31:28 +01:00

For outputs that is given, for nodes the input should be passed via node link.

I'm not sure what you mean with the second part of this sentence, could you elaborate?

> For outputs that is given, for nodes the input should be passed via node link. I'm not sure what you mean with the second part of this sentence, could you elaborate?

Simon Thommes commented

2022-03-23 12:11:04 +01:00

I'm talking about the default of inputs of the node group for when it's used in another node tree.
I phrased it badly, what I meant was that there the default value should be used regardless. So the default attribute behavior would only affect the modifier version of that node group.
maybe there has to be a bit of discussion on this topic, but I think this makes the most sense.

I'm talking about the default of inputs of the node group for when it's used in another node tree. I phrased it badly, what I meant was that there the default value should be used regardless. So the default attribute behavior would only affect the modifier version of that node group. maybe there has to be a bit of discussion on this topic, but I think this makes the most sense.

Hans Goudey self-assigned this 2022-04-25 15:31:25 +02:00

blender-admin commented

2022-04-28 15:39:30 +02:00

This issue was referenced by 0ad73bb965

This issue was referenced by 0ad73bb9655f04afb5ad56174d8fb416cded3e4c

Jacques Lucke commented

2022-10-20 15:18:17 +02:00

Changed status from 'Confirmed' to: 'Resolved'

Jacques Lucke closed this issue

2022-10-20 15:18:17 +02:00

Doltramir Sires commented

2022-11-30 03:24:40 +01:00

Added subscriber: @Doltramir

Doltramir Sires commented

2022-11-30 03:24:40 +01:00

So, I don't think it works the way it is intended to work.

What I believe it should do (the right behaviour):

Input has 'default' that specifies the default value for input, and 'default attribute' which does the same, but specifies default attribute name, if you are using input as an attribute.
Output does not have the 'default', but it does have 'default attribute', and there you should put what to use, as the default attribute's name to store values (When you assign modifier, 'default attribute' says what should be put into corresponding output field by default).

Input's 'default' does what it is intended to do. But both of 'default attribute' don't.
What they actually do right now (the wrong behaviour):

Input's 'default attribute' just fills the field once. It is not treated as a default. So if you'll try to reset it's value, you'll get empty string, instead of actual default. Which is not what we want (if we wanted that, we could've just cleared that field).
And output's 'default attribute' just gets what is put into 'default attribute' from your geometry, and outputs it. That's the opposite of what it should do.

By default output should do the:

StoreNamedAttribute(name={default attribute}, value=from_socket)

Instead it does this:

StoreNamedAttribute(name="", value=GetNamedAttribute(name={default attribute}))

So, we need to make input's 'default attribute' indeed be the default value for attribute selection, and output's default attribute more of a 'default' of String input, so it would be proper default, and would actually do what it is intended to do.

So, I don't think it works the way it is intended to work. What I believe it should do (the right behaviour): - Input has 'default' that specifies the default value for input, and 'default attribute' which does the same, but specifies default attribute name, if you are using input as an attribute. - Output does not have the 'default', but it does have 'default attribute', and there you should put what to use, as the default attribute's name to store values (When you assign modifier, 'default attribute' says what should be put into corresponding output field by default). Input's 'default' does what it is intended to do. But both of 'default attribute' don't. What they actually do right now (the wrong behaviour): - Input's 'default attribute' just fills the field once. It is not treated as a default. So if you'll try to reset it's value, you'll get empty string, instead of actual default. Which is not what we want (if we wanted that, we could've just cleared that field). - And output's 'default attribute' just gets what is put into 'default attribute' from your geometry, and outputs it. That's the opposite of what it should do. By default output should do the: ``` StoreNamedAttribute(name={default attribute}, value=from_socket) ``` Instead it does this: ``` StoreNamedAttribute(name="", value=GetNamedAttribute(name={default attribute})) ``` So, we need to make input's 'default attribute' indeed be the default value for attribute selection, and output's default attribute more of a 'default' of String input, so it would be proper default, and would actually do what it is intended to do.

Sign in to join this conversation.

No Label

Download

What's New

Blender Studio

Manual

Developers Blog

Documentation

Benchmark

Blender Conference

Development Fund

One-time Donations

Default attribute input and output names for modifier fields #96707