Regression: GPencil primitives handlers not working #96828

New Issue

Antonio Vazquez · 2022-03-28T12:56:23+02:00

Antonio Vazquez commented

2022-03-28 12:56:23 +02:00

Tested using last master code on Windows

To reproduce:

Open 2D Template
Draw a Primitive curve
Try to use the handler points.

The problem was produced by commit 52af3b20d4

Cleanup: cursor motion events now have value set to KM_NOTHING

The problem is the event->val is set to KM_NOTHING, but the primitive need to check that the mouse is moving and also that mouse button is pressed.

The line with the problem is 1484 in gpencil_primitive.c

if ((event->val == KM_PRESS) && tgpi->sel_cp != SELECT_NONE) {

Tested using last `master` code on Windows To reproduce: 1) Open 2D Template 2) Draw a Primitive curve 3) Try to use the handler points. The problem was produced by commit 52af3b20d45ea525a0ce66b2613ac132c9032a3f **Cleanup: cursor motion events now have value set to KM_NOTHING** The problem is the `event->val` is set to `KM_NOTHING`, but the primitive need to check that the mouse is moving and also that mouse button is pressed. The line with the problem is `1484` in `gpencil_primitive.c` ` if ((event->val == KM_PRESS) && tgpi->sel_cp != SELECT_NONE) {`

Antonio Vazquez commented

2022-03-28 12:56:23 +02:00

Added subscriber: @antoniov

Antonio Vazquez commented

2022-03-28 12:57:24 +02:00

Changed status from 'Needs Triage' to: 'Confirmed'

Antonio Vazquez commented

2022-03-28 12:57:24 +02:00

Added subscriber: @ideasman42

Antonio Vazquez commented

2022-03-28 12:57:24 +02:00

@ideasman42 could you look at this regresion? I don't know how check now if the mouse is moving and the mouse button is pressed.

Antonio Vazquez commented

2022-03-28 12:57:44 +02:00

Added subscriber: @mendio

Antonio Vazquez self-assigned this 2022-03-28 13:09:47 +02:00

blender-admin commented

2022-03-28 13:11:00 +02:00

This issue was referenced by bac78e9bbe

This issue was referenced by bac78e9bbe1fa4ab13c0fc07b35e431dfb551610

blender-admin commented

2022-03-28 13:11:00 +02:00

This issue was referenced by e6dfe570cc

This issue was referenced by e6dfe570cc00fbacf41d66e55fcf2e1b195eb780

Antonio Vazquez commented

2022-03-28 13:12:08 +02:00

Changed status from 'Confirmed' to: 'Resolved'

Antonio Vazquez closed this issue

2022-03-28 13:12:08 +02:00

Antonio Vazquez changed title from ~~Regresion: GPencil primitives handlers not working~~ to Regression: GPencil primitives handlers not working

2022-03-28 13:15:14 +02:00

Sign in to join this conversation.

No Label

Download

What's New

Blender Studio

Manual

Developers Blog

Documentation

Benchmark

Blender Conference

Development Fund

One-time Donations

Regression: GPencil primitives handlers not working #96828