Drawing of pose markers does not take NLA time mapping into account #97323

New Issue

Sybren A. Stüvel · 2022-04-14T11:19:47+02:00

Sybren A. Stüvel commented

2022-04-14 11:19:47 +02:00

System Information
Operating system: Linux-5.11.0-49-generic-x86_64-with-glibc2.33 64 Bits
Graphics card: GeForce RTX 2080/PCIe/SSE2 NVIDIA Corporation 4.5.0 NVIDIA 460.91.03

Blender Version
Broken: version: 3.2.0 Alpha, branch: master, hash: d6e7241237
Worked: don't think it ever workerd

Short description of error
Shifting an Action on the NLA, then going into tweak mode to edit it, shows the keyframes shifted in the animation editors. The action's pose markers are still in their absolute position.

The pose markers should align with the 2nd, 3rd, and 4th keyframe.

Exact steps for others to reproduce the error

Open the attached file, look at the pose markers.
Drag the action in the NLA editor, and see the keys moving while the pose markers stay put.

[D14176-select-markers.blend](https://archive.blender.org/developer/F13001132/D14176-select-markers.blend)

Context & Relevance

These "pose" markers originated from the old, now obsolete, pose library. However, regardless of the status of that library, I've heard the desire to have Action-scoped markers (so independent of scene time), and the pose markers would fit that need quite well. The only thing that has to be done to make this a reality is a rename (from "pose marker" to "action marker") and some UI cleanup. Fixing this bug is a good start.

Marked as low-prio because the new purpose for pose markers isn't that official yet.

Note: Be sure to test the marker.select_leftright operator as well (f1ae6952a8) after addressing this issue.

**System Information** Operating system: Linux-5.11.0-49-generic-x86_64-with-glibc2.33 64 Bits Graphics card: GeForce RTX 2080/PCIe/SSE2 NVIDIA Corporation 4.5.0 NVIDIA 460.91.03 **Blender Version** Broken: version: 3.2.0 Alpha, branch: `master`, hash: `d6e7241237` Worked: don't think it ever workerd **Short description of error** Shifting an Action on the NLA, then going into tweak mode to edit it, shows the keyframes shifted in the animation editors. The action's pose markers are still in their absolute position. ![image.png](https://archive.blender.org/developer/F13001129/image.png) The pose markers should align with the 2nd, 3rd, and 4th keyframe. **Exact steps for others to reproduce the error** - Open the attached file, look at the pose markers. - Drag the action in the NLA editor, and see the keys moving while the pose markers stay put. [[D14176](https://archive.blender.org/developer/D14176)-select-markers.blend](https://archive.blender.org/developer/F13001132/D14176-select-markers.blend) **Context & Relevance** These "pose" markers originated from the old, now obsolete, pose library. However, regardless of the status of that library, I've heard the desire to have Action-scoped markers (so independent of scene time), and the pose markers would fit that need quite well. The only thing that has to be done to make this a reality is a rename (from "pose marker" to "action marker") and some UI cleanup. Fixing this bug is a good start. Marked as low-prio because the new purpose for pose markers isn't that official yet. **Note:** Be sure to test the `marker.select_leftright` operator as well (f1ae6952a8) after addressing this issue.

Sybren A. Stüvel commented

2022-04-14 11:19:47 +02:00

Added subscriber: @dr.sybren

Nate Rupsis commented

2022-04-14 19:30:03 +02:00

Added subscriber: @nrupsis

Nate Rupsis self-assigned this 2022-04-14 19:30:03 +02:00

Nate Rupsis commented

2022-04-14 19:30:03 +02:00

Been wanting to get into Blender development. Looks like a good first issue 😄

Brad Clark commented

2022-04-14 19:42:02 +02:00

Added subscriber: @BClark

Brad Clark commented

2022-04-14 19:42:02 +02:00

Thank you Nate.

Richard Antalik commented

2022-04-14 21:06:05 +02:00

Changed status from 'Needs Triage' to: 'Confirmed'

Colin Basnett commented

2022-04-15 00:35:28 +02:00

Added subscriber: @cmbasnett

Nate Rupsis commented

2022-04-19 01:56:19 +02:00

Alright, I've spent some significant time trying to make heads and tails of this, certainly learned a lot 😃

However, I do need some domain context clarification. For the keyframes inside of the Action strip (NLA Track), those are dependent on the Strips contexts, however, the pose marks (as far as I understand) are not.

Do we just want the pose markers to line up with the key frames on draw? (i.e, entering tweak mode), or do we actually want to add them the the dependency graph for this context?

Alright, I've spent some significant time trying to make heads and tails of this, certainly learned a lot 😃 However, I do need some domain context clarification. For the keyframes inside of the Action strip (NLA Track), those are dependent on the Strips contexts, however, the pose marks (as far as I understand) are not. Do we just want the pose markers to line up with the key frames on draw? (i.e, entering tweak mode), or do we actually want to add them the the dependency graph for this context?

Ezra Goss commented

2022-04-21 00:39:57 +02:00

Added subscriber: @ezragoss

Nate Rupsis commented

2022-04-26 03:53:29 +02:00

Changed status from 'Confirmed' to: 'Needs User Info'

Pratik Borhade commented

2022-06-08 12:20:07 +02:00

Added subscriber: @PratikPB2123

Pratik Borhade commented

2022-06-08 12:20:07 +02:00

Changed status from 'Needs User Info' to: 'Needs Developer To Reproduce'

Pratik Borhade commented

2022-06-08 12:20:07 +02:00

Do we just want the pose markers to line up with the key frames on draw? (i.e, entering tweak mode), or do we actually want to add them the the dependency graph for this context?

@dr.sybren ^

> Do we just want the pose markers to line up with the key frames on draw? (i.e, entering tweak mode), or do we actually want to add them the the dependency graph for this context? @dr.sybren ^

Philipp Oeser removed the

Download

What's New

Blender Studio

Manual

Developers Blog

Documentation

Benchmark

Blender Conference

Development Fund

One-time Donations

Drawing of pose markers does not take NLA time mapping into account #97323