Regression: Massive drops in Animation playback (fps) in the viewport (Depsgraph) #98157

New Issue

Jeroen Bakker · 2022-05-16T08:29:16+02:00

Jeroen Bakker commented

2022-05-16 08:29:16 +02:00

**System Information**
Operating system: Linux-5.13.0-0.rc6.45.fc35.x86_64-x86_64-with-fedora-36-Rawhide 64 Bits
Graphics card: NVIDIA GeForce GTX 970M/PCIe/SSE2 NVIDIA Corporation 4.5.0 NVIDIA 495.44

version	VSYNC	fps solid	fps material	fps rendered
3.0.1	off	200	57	41
3.1.2 (regression caused by `d09b1d2759`)	off	110	57	41

Short description of error
Massive drops in Animation playback dependency graph evaluation.

See note in the commit.

Right now the check is not optimal, because it results in more depsgraph
nodes than are necessary. This can be improved when it becomes cheaper
to check if a node tree contains any references to a video texture.
The node tree update refactor mentioned before makes it much easier
to construct this kind of run-time data from the bottom up, instead of
scanning the entire node tree recursively every time some information
is needed.

``` **System Information** Operating system: Linux-5.13.0-0.rc6.45.fc35.x86_64-x86_64-with-fedora-36-Rawhide 64 Bits Graphics card: NVIDIA GeForce GTX 970M/PCIe/SSE2 NVIDIA Corporation 4.5.0 NVIDIA 495.44 ``` | version | VSYNC | fps solid | fps material | fps rendered | | -- | -- | -- | -- | -- | | 3.0.1 | off | 200 | 57 | 41 | | 3.1.2 (regression caused by d09b1d2759) | off | 110 | 57 | 41 | **Short description of error** Massive drops in Animation playback dependency graph evaluation. See note in the commit. ``` Right now the check is not optimal, because it results in more depsgraph nodes than are necessary. This can be improved when it becomes cheaper to check if a node tree contains any references to a video texture. The node tree update refactor mentioned before makes it much easier to construct this kind of run-time data from the bottom up, instead of scanning the entire node tree recursively every time some information is needed. ```

Jeroen Bakker commented

2022-05-16 08:29:16 +02:00

Added subscribers: @Jeroen-Bakker, @JacquesLucke, @geocentric_wage, @PratikPB2123, @Raimund58, @LukasTonne, @deadpin, @fclem, @lichtwerk, @ditos

Jeroen Bakker commented

2022-05-16 08:32:24 +02:00

As this has been written as a limitation of the implementation we should discuss how important is it and if there are some quick wins to add in order to lower the priority.

Jeroen Bakker changed title from ~~Regression: Massive drops in Animation playback (fps) in the viewport (Workbench)~~ to Regression: Massive drops in Animation playback (fps) in the viewport (Depsgraph)

2022-05-16 08:32:39 +02:00

Jeroen Bakker commented

2022-05-16 08:38:00 +02:00

Changed status from 'Needs Triage' to: 'Confirmed'