Regression: Calling save on image fails due to file path options not being correctly applied #98305

New Issue

Bill Ortis · 2022-05-21T19:40:42+02:00

Bill Ortis commented

2022-05-21 19:40:42 +02:00

System Information
Operating system: Windows-10-10.0.19044-SP0 64 Bits
Graphics card: NVIDIA GeForce GTX 1660 SUPER/PCIe/SSE2 NVIDIA Corporation 4.5.0 NVIDIA 512.59

Blender Version
Broken:

version: 3.3.0 Alpha, branch: master, commit date: 2022-05-20 22:53, hash: dfb8c90324
Broken since 29a3f43da5
Worked:
Before 29a3f43da5

Short description of error
Setting filepath_raw on an bpy.types.Image object and then calling save() results in the error:

imb_savepng: Cannot open file for writing: ''
Invalid argument
Error: Python: Traceback (most recent call last):
  File "\Text", line 9, in <module>
RuntimeError: Error: Could not write image: Invalid argument
Error: Image 'temp' could not be saved to 'C:\Users\user\AppData\Local\Temp\tmpb7if1xli/img'

This issue affects the glTF exporter and third-party add-ons such as Blender2MSFS2.

Exact steps for others to reproduce the error

Execute the following script from the text editor

import tempfile
import bpy

tmp_image = bpy.data.images.new("temp", 4, 4)

with tempfile.TemporaryDirectory() as tmpdirname:
    tmpfilename = tmpdirname + '/img'
    tmp_image.filepath_raw = tmpfilename
    tmp_image.save()

**System Information** Operating system: Windows-10-10.0.19044-SP0 64 Bits Graphics card: NVIDIA GeForce GTX 1660 SUPER/PCIe/SSE2 NVIDIA Corporation 4.5.0 NVIDIA 512.59 **Blender Version** Broken: - version: 3.3.0 Alpha, branch: master, commit date: 2022-05-20 22:53, hash: `dfb8c90324` - Broken since 29a3f43da5 Worked: - Before 29a3f43da5 **Short description of error** Setting `filepath_raw` on an `bpy.types.Image` object and then calling `save()` results in the error: ``` imb_savepng: Cannot open file for writing: '' Invalid argument Error: Python: Traceback (most recent call last): File "\Text", line 9, in <module> RuntimeError: Error: Could not write image: Invalid argument Error: Image 'temp' could not be saved to 'C:\Users\user\AppData\Local\Temp\tmpb7if1xli/img' ``` This issue affects the glTF exporter and third-party add-ons such as Blender2MSFS2. **Exact steps for others to reproduce the error** - Execute the following script from the text editor ``` import tempfile import bpy tmp_image = bpy.data.images.new("temp", 4, 4) with tempfile.TemporaryDirectory() as tmpdirname: tmpfilename = tmpdirname + '/img' tmp_image.filepath_raw = tmpfilename tmp_image.save() ```

Bill Ortis commented

2022-05-21 19:40:42 +02:00

Added subscriber: @lionheart001

Robert Guetzkow commented

2022-05-21 19:56:48 +02:00

Added subscriber: @rjg

Robert Guetzkow commented

2022-05-21 19:56:48 +02:00

Is it correct that you are using the Blender2MSFS2
third-party add-on from this repository https://github.com/tml1024/Blender2MSFS2 ?

Is it correct that you are using the Blender2MSFS2 third-party add-on from this repository https://github.com/tml1024/Blender2MSFS2 ?

Scurest commented

2022-05-21 20:01:57 +02:00

Added subscriber: @scurest

Scurest commented

2022-05-21 20:01:57 +02:00

Note that the same thing happened in CI for the glTF addon repo. https://github.com/KhronosGroup/glTF-Blender-IO/pull/1646#issuecomment-1132006357

Robert Guetzkow commented

2022-05-21 20:53:16 +02:00

Added subscriber: @JulienDuroure

Robert Guetzkow commented

2022-05-21 20:56:09 +02:00

@scurest Thank you for noticing. Seems like this could be an issue in Blender and needs further investigations, if this occasionally fails with the official glTF add-on as well.

Julien Duroure commented

2022-05-21 21:14:03 +02:00

@rjg I can confirm that exporting this file as glTF separated is ko since a few days (last ok CI was 5 days ago)
bea4c6d2c9/tests/scenes/01_principled_material.blend

@rjg I can confirm that exporting this file as glTF separated is ko since a few days (last ok CI was 5 days ago) https://github.com/KhronosGroup/glTF-Blender-IO/blob/bea4c6d2c9fb5c371518dc33c14c06e2ae4b3185/tests/scenes/01_principled_material.blend

Bill Ortis commented

2022-05-21 21:49:57 +02:00

In #98305#1362260, @rjg wrote:
Is it correct that you are using the Blender2MSFS2
third-party add-on from this repository https://github.com/tml1024/Blender2MSFS2 ?

Yes, that is the one. A stable compiler. There are two out there, this one runs best. Version 42.10 by RonH

In #98305#1362276, @JulienDuroure wrote:
@rjg I can confirm that exporting this file as glTF separated is ko since a few days (last ok CI was 5 days ago)
bea4c6d2c9/tests/scenes/01_principled_material.blend

We export these 'seperated' also.

Bill

> In #98305#1362260, @rjg wrote: > Is it correct that you are using the Blender2MSFS2 > third-party add-on from this repository https://github.com/tml1024/Blender2MSFS2 ? Yes, that is the one. A stable compiler. There are two out there, this one runs best. Version 42.10 by RonH > In #98305#1362276, @JulienDuroure wrote: > @rjg I can confirm that exporting this file as glTF separated is ko since a few days (last ok CI was 5 days ago) > https://github.com/KhronosGroup/glTF-Blender-IO/blob/bea4c6d2c9fb5c371518dc33c14c06e2ae4b3185/tests/scenes/01_principled_material.blend We export these 'seperated' also. Bill

Robert Guetzkow commented

2022-05-21 22:26:50 +02:00

@JulienDuroure Are there any particular steps necessary, or does just an export of the project as-is to .glb fail? Does this fail consistently or occasionally?

Current master (dfb8c90324c018068f12ca41543c3c311dff6d21) seems to be working fine on my system with the provided file.

Edit: I have just noticed that the textures are not packed. I will test this again tomorrow with the textures, just in case that makes any difference.

@JulienDuroure Are there any particular steps necessary, or does just an export of the project as-is to `.glb` fail? Does this fail consistently or occasionally? Current master (`dfb8c90324c018068f12ca41543c3c311dff6d21`) seems to be working fine on my system with the provided file. Edit: I have just noticed that the textures are not packed. I will test this again tomorrow with the textures, just in case that makes any difference.

Julien Duroure commented

2022-05-21 22:32:34 +02:00

Seems to break without any condition on github CI.

Don't have a computer to check right now, but did you change export format to glTF separated, instead of glb ?

Seems to break without any condition on github CI. Don't have a computer to check right now, but did you change export format to glTF separated, instead of glb ?

Robert Guetzkow commented

2022-05-21 22:41:15 +02:00

First test with glTF Separate seems to be working fine, but I will check again tomorrow with the images. Just so that we are not looking at different commits, could you please post one of the affected commit hashes that fails in your CI?

Scurest commented

2022-05-22 00:38:36 +02:00

I can repro with current alpha (blender-3.3.0-alpha+master.dfb8c90324c0-linux.x86_64-release). Binary/Separate etc. doesn't make a difference.

Reduced test case:

import tempfile
import bpy

tmp_image = bpy.data.images.new("temp", 4, 4)

with tempfile.TemporaryDirectory() as tmpdirname:
    tmpfilename = tmpdirname + '/img'
    tmp_image.filepath_raw = tmpfilename
    tmp_image.save()

Stick it in a text editor and run it. Fails with current alpha. Works on 3.1 & blender-3.3.0-alpha+master.08a39d32a988.

I can repro with current alpha (blender-3.3.0-alpha+master.dfb8c90324c0-linux.x86_64-release). Binary/Separate etc. doesn't make a difference. Reduced test case: ``` import tempfile import bpy tmp_image = bpy.data.images.new("temp", 4, 4) with tempfile.TemporaryDirectory() as tmpdirname: tmpfilename = tmpdirname + '/img' tmp_image.filepath_raw = tmpfilename tmp_image.save() ``` Stick it in a text editor and run it. Fails with current alpha. Works on 3.1 & blender-3.3.0-alpha+master.08a39d32a988.

Robert Guetzkow commented

2022-05-22 00:47:13 +02:00

@scurest I can reproduce the issue with your script (presumably the issue was not triggered with the exporter due to the missing images). I will update the ticket description tomorrow so that it is fully triaged and confirmed.

Scurest commented

2022-05-22 01:56:30 +02:00

Possibly related to 29a3f43da5.

Possibly related to 29a3f43da5d3.

Robert Guetzkow changed title from ~~Cannot Export glTF-2 files, getting error~~ to Regression: Calling save on image fails due to file path options not being correctly applied

2022-05-22 10:54:20 +02:00

Robert Guetzkow commented

2022-05-22 10:54:20 +02:00

Changed status from 'Needs Triage' to: 'Confirmed'

Robert Guetzkow commented

2022-05-22 11:18:41 +02:00

Added subscriber: @brecht

Robert Guetzkow commented

2022-05-22 11:18:41 +02:00

@brecht This is likely a ticket for you.
@scurest Thank you for looking into this.

@brecht This is likely a ticket for you. @scurest Thank you for looking into this.

blender-admin commented

2022-05-23 12:06:07 +02:00

This issue was referenced by eba6900b08

This issue was referenced by eba6900b083e78b70c328783382f99bb18da6099

Brecht Van Lommel commented

2022-05-23 12:44:50 +02:00

Changed status from 'Confirmed' to: 'Resolved'

Brecht Van Lommel closed this issue

2022-05-23 12:44:50 +02:00

Brecht Van Lommel self-assigned this 2022-05-23 12:44:50 +02:00

Bill Ortis commented

2022-05-25 07:07:34 +02:00

Just to let you know, I did test Build 3.3 May 23rd and May 24th (today) with exporting glTF-2 (MSFS format) separated. Build May 24th got quite a ways along before it crashed. Much better then the instant black crash screen. Must be close.

Bill
LHC

Just to let you know, I did test Build 3.3 May 23rd and May 24th (today) with exporting glTF-2 (MSFS format) separated. Build May 24th got quite a ways along before it crashed. Much better then the instant black crash screen. Must be close. Bill LHC

Julien Duroure commented

2022-05-25 07:29:12 +02:00

Hello,
I confirm that there is no more issue on glTF exporter!
Thanks

Hello, I confirm that there is no more issue on glTF exporter! Thanks

Bill Ortis commented

2022-05-25 17:28:00 +02:00

Just ran Blender 3.3 May 25th Build. I was able to export first half of the scene I am working on, but the interior section of the scene still fails. But... It is attempting to build it instead of just throwing out the error notice. It runs for several long seconds until the error pops up. So close...

Again, the file exports fine in Blender 3.1 and 3.2.

Error notice attached..

Just ran Blender 3.3 May 25th Build. I was able to export first half of the scene I am working on, but the interior section of the scene still fails. But... It is attempting to build it instead of just throwing out the error notice. It runs for several long seconds until the error pops up. So close... Again, the file exports fine in Blender 3.1 and 3.2. Error notice attached.. ![Screenshot 2022-05-25 081700.jpg](https://archive.blender.org/developer/F13104661/Screenshot_2022-05-25_081700.jpg)

Brecht Van Lommel commented

2022-05-25 17:54:20 +02:00

The actual error is scrolled out of view, it would be at the very bottom. It should be easier to copy the text from the console window (Window > Toggle System Console in Blender).

Scurest commented

2022-05-25 20:30:10 +02:00

Removed subscriber: @scurest

Bill Ortis commented

2022-05-25 23:51:36 +02:00

Roger that, Brecht.

Got it.

Roger that, Brecht. Got it. ![Screenshot 2022-05-25 145017.jpg](https://archive.blender.org/developer/F13105873/Screenshot_2022-05-25_145017.jpg)

Bill Ortis commented

2022-05-26 19:42:12 +02:00

Hello Team Blender,

I just wanted to report that I just tested Blender 3.3 Alpha May 26th Build with exporting glTF-2 in MSFS exporter by RonH, and..... IT WORKED!!!!!!!!!!!!!!!!!!!!!!!!!

Thank you Team Blender. I can once again begin testing Alpha daily. Very grateful for your help on this. God bless you.

Bill
LHC

Hello Team Blender, I just wanted to report that I just tested Blender 3.3 Alpha May 26th Build with exporting glTF-2 in MSFS exporter by RonH, and..... IT WORKED!!!!!!!!!!!!!!!!!!!!!!!!! Thank you Team Blender. I can once again begin testing Alpha daily. Very grateful for your help on this. God bless you. Bill LHC ![Screenshot 2022-05-26 103720.jpg](https://archive.blender.org/developer/F13110143/Screenshot_2022-05-26_103720.jpg)

Thomas Dinges added this to the 3.2 milestone 2023-02-08 15:51:07 +01:00

Sign in to join this conversation.

No Label

Download

What's New

Blender Studio

Manual

Developers Blog

Documentation

Benchmark

Blender Conference

Development Fund

One-time Donations

Regression: Calling save on image fails due to file path options not being correctly applied #98305