Regression: Blender crashes when moving grease pencil object has any invisible layers #98853

New Issue

Hazuki Aoi · 2022-06-13T17:38:51+02:00

Hazuki Aoi commented

2022-06-13 17:38:51 +02:00

System Information
Operating system: Windows-10-10.0.22000-SP0 64 Bits
Graphics card: NVIDIA GeForce RTX 3070 Laptop GPU/PCIe/SSE2 NVIDIA Corporation 4.5.0 NVIDIA 511.79

Blender Version
Broken: version: 3.2.0, branch: master, commit date: 2022-06-08 10:22, hash: e05e1e3691
Worked: 3.1.2

This first started to crash with 7ca13eef7c, crash got fixed with 21d633f83b (but then slowness/leak appeared).

Short description of error
when a grease pencil object has any invisible layers and press g key or use handle yo move object, blender will become very slow and crash.

And I upload video and blender file here to show how it.
BlenderGPCrash.mp4
GP_Crash.blend

**System Information** Operating system: Windows-10-10.0.22000-SP0 64 Bits Graphics card: NVIDIA GeForce RTX 3070 Laptop GPU/PCIe/SSE2 NVIDIA Corporation 4.5.0 NVIDIA 511.79 **Blender Version** Broken: version: 3.2.0, branch: master, commit date: 2022-06-08 10:22, hash: `e05e1e3691` Worked: 3.1.2 This first started to crash with 7ca13eef7c, crash got fixed with 21d633f83b (but then slowness/leak appeared). **Short description of error** when a grease pencil object has any invisible layers and press g key or use handle yo move object, blender will become very slow and crash. And I upload video and blender file here to show how it. [BlenderGPCrash.mp4](https://archive.blender.org/developer/F13156765/BlenderGPCrash.mp4) [GP_Crash.blend](https://archive.blender.org/developer/F13156771/GP_Crash.blend)

Hazuki Aoi commented

2022-06-13 17:38:51 +02:00

Added subscriber: @hazukiaoi

blender-admin commented

2022-06-13 17:38:51 +02:00

#99020 was marked as duplicate of this issue

Aleš Jelovčan commented

2022-06-14 08:45:17 +02:00

Added subscriber: @frogstomp-4

Aleš Jelovčan commented

2022-06-14 08:45:17 +02:00

Changed status from 'Needs Triage' to: 'Confirmed'

Aleš Jelovčan commented

2022-06-14 08:45:17 +02:00

Can confirm in 3.2.0 and 3.3a.

Memory leak, gets more noticeable when more layers are hidden. Got to 16k memory consumption in seconds.

Can confirm in 3.2.0 and 3.3a. Memory leak, gets more noticeable when more layers are hidden. Got to 16k memory consumption in seconds.

Aleš Jelovčan commented

2022-06-14 08:48:55 +02:00

@hazukiaoi problem appears to be mirror modifier, you have 3 of them enabled. If you disable mirror modifier it performs normally.

Philipp Oeser commented

2022-06-14 08:51:18 +02:00

Added subscriber: @lichtwerk

Philipp Oeser commented

2022-06-14 08:51:18 +02:00

Looks like a regression, will bisect.

Aleš Jelovčan commented

2022-06-14 08:52:21 +02:00

Adding array or multiple strokes modifier also produces memory leak. Looks like modifier that add new geometry are affected.

Philipp Oeser commented

2022-06-14 10:11:45 +02:00

Added subscriber: @filedescriptor

Philipp Oeser commented

2022-06-14 10:11:45 +02:00

This first started to crash with 7ca13eef7c, crash got fixed with 21d633f83b (but then slowness/leak appeared).

CC @filedescriptor

This first started to crash with 7ca13eef7c, crash got fixed with 21d633f83b (but then slowness/leak appeared). CC @filedescriptor

Philipp Oeser changed title from ~~Blender crashes when moving grease pencil object has any invisible layers~~ to Regression: Blender crashes when moving grease pencil object has any invisible layers

2022-06-14 10:12:10 +02:00

Falk David self-assigned this 2022-06-14 14:57:00 +02:00

Falk David commented

2022-06-14 14:57:00 +02:00

Looking into it!

Falk David commented

2022-06-14 16:57:51 +02:00

Added subscriber: @antoniov

Falk David commented

2022-06-14 16:57:51 +02:00

Ok so whats happening is that the modifier keeps adding new frames to the evaluated object resulting in an exponential increase. This is because when preparing the data for the modifiers we only copy visible strokes to the eval object. But the modifiers do not consider visibility and will generate the mirrored strokes even for layers that are hidden. Because those layers have not been copied (only their structure) we run into this issue.

There are a couple of options to fix this:

always copy the active frame of all layers (even if the layer is hidden)
prevent modifiers from generating strokes of hidden layers

@antoniov Any thoughts on this?

Ok so whats happening is that the modifier keeps adding new frames to the evaluated object resulting in an exponential increase. This is because when preparing the data for the modifiers we only copy visible strokes to the eval object. But the modifiers do not consider visibility and will generate the mirrored strokes even for layers that are hidden. Because those layers have not been copied (only their structure) we run into this issue. There are a couple of options to fix this: 1) always copy the active frame of all layers (even if the layer is hidden) 2) prevent modifiers from generating strokes of hidden layers @antoniov Any thoughts on this?

Falk David commented

2022-06-14 17:24:07 +02:00

Here is a fix using the first method: P3004

Here is a fix using the first method: [P3004](https://archive.blender.org/developer/P3004.txt)

Antonio Vazquez commented

2022-06-14 20:57:02 +02:00

The option 1) is slower but I will go for this one. The active frame would be always available, so better copy always the data.