Node selection doesn't go through reroute nodes #98992

Closed
opened 2022-06-19 18:31:39 +02:00 by tempdevnova · 9 comments

System Information
Operating system: Windows-10-10.0.19043-SP0 64 Bits
Graphics card: GeForce GTX 1080/PCIe/SSE2 NVIDIA Corporation 4.5.0 NVIDIA 431.07

Blender Version
Broken: version: 3.2.0, branch: master, commit date: 2022-06-08 10:22, hash: e05e1e3691
Worked: (newest version of Blender that worked as expected)

Short description of error
Thanks to https:*developer.blender.org/rB75bb99fa40dd (also mentioned in https:*wiki.blender.org/wiki/Reference/Release_Notes/3.2/Nodes_Physics)
Node links of selected nodes are now highlighted the entirely, which is awesome.

What is not so awesome is that this selection doesn't pass through reroute nodes, meaning that in large node setups you usually have to go through several reroute nodes until you see where a node is connecting to.

To fix this just highight all branches and reroutes of an output link(right side of a node) and highlight only the upstream branches for input links(left side of a node).
This way a user can directly see where the inputs are coming from and where the outputs are leading to.

Not sure whether this is a bug or developer oversight. But anyways I really don't think we need a https://devtalk.blender.org/ discussion over this, as there is not much to discuss about since nobody cares which reroutes a node takes and only where the inputs come from and where the outputs go to.

So yeah probably a developer oversight.

Thank you and have a great day!

**System Information** Operating system: Windows-10-10.0.19043-SP0 64 Bits Graphics card: GeForce GTX 1080/PCIe/SSE2 NVIDIA Corporation 4.5.0 NVIDIA 431.07 **Blender Version** Broken: version: 3.2.0, branch: master, commit date: 2022-06-08 10:22, hash: `e05e1e3691` Worked: (newest version of Blender that worked as expected) **Short description of error** Thanks to https:*developer.blender.org/rB75bb99fa40dd (also mentioned in https:*wiki.blender.org/wiki/Reference/Release_Notes/3.2/Nodes_Physics) Node links of selected nodes are now highlighted the entirely, which is awesome. What is not so awesome is that this selection doesn't pass through reroute nodes, meaning that in large node setups you usually have to go through several reroute nodes until you see where a node is connecting to. To fix this just highight all branches and reroutes of an output link(right side of a node) and highlight only the **upstream** branches for input links(left side of a node). This way a user can directly see where the inputs are coming from and where the outputs are leading to. Not sure whether this is a bug or developer oversight. But anyways I really don't think we need a https://devtalk.blender.org/ discussion over this, as there is not much to discuss about since nobody cares which reroutes a node takes and only where the inputs come from and where the outputs go to. So yeah probably a developer oversight. Thank you and have a great day!
Author

Added subscriber: @tempdevnova

Added subscriber: @tempdevnova
Member

Added subscribers: @lone_noel, @PratikPB2123

Added subscribers: @lone_noel, @PratikPB2123
Member

Changed status from 'Needs Triage' to: 'Confirmed'

Changed status from 'Needs Triage' to: 'Confirmed'
Member

highlight through reroutes would be useful. Currently having your links
organized with a lot of reroutes does diminish the improvements from
this patch a bit

Hi, thanks for the report. This is improvement was also mentioned in the original patch D11930: Nodes: Improve readability of selected node links
@lone_noel hi, can you check this report?

> highlight through reroutes would be useful. Currently having your links > organized with a lot of reroutes does diminish the improvements from > this patch a bit Hi, thanks for the report. This is improvement was also mentioned in the original patch [D11930: Nodes: Improve readability of selected node links](https://archive.blender.org/developer/D11930) @lone_noel hi, can you check this report?
Member

Added subscriber: @HooglyBoogly

Added subscriber: @HooglyBoogly
Member

Changed status from 'Confirmed' to: 'Archived'

Changed status from 'Confirmed' to: 'Archived'
Member

Thanks for the report, but the issue reported here is a request for modified/improved behavior and not a bug in current behavior. Closing as this bug tracker is only for bugs and errors.

For user requests and feedback, please use other channels: https://wiki.blender.org/wiki/Communication/Contact#User_Feedback_and_Requests

For more information on why this isn't considered a bug, visit: https://wiki.blender.org/wiki/Reference/Not_a_bug

Thanks for the report, but the issue reported here is a request for modified/improved behavior and not a bug in current behavior. Closing as this bug tracker is only for bugs and errors. For user requests and feedback, please use other channels: https://wiki.blender.org/wiki/Communication/Contact#User_Feedback_and_Requests For more information on why this isn't considered a bug, visit: https://wiki.blender.org/wiki/Reference/Not_a_bug
Leon Schittek self-assigned this 2022-06-20 22:43:03 +02:00
Member

Thanks for the ping, @PratikPB2123! I had this on my list, but didn't have too much time recently to work on Blender things.
I have a first version working now (see video below) and I'll try to find the time to prepare a patch over the next weeks.


T98992_v1.mp4

Thanks for the ping, @PratikPB2123! I had this on my list, but didn't have too much time recently to work on Blender things. I have a first version working now (see video below) and I'll try to find the time to prepare a patch over the next weeks. --- [T98992_v1.mp4](https://archive.blender.org/developer/F13209113/T98992_v1.mp4)
Leon Schittek removed their assignment 2022-06-20 22:44:54 +02:00
Member

Removing myself as assignee, since the task is closed, but will still try to tackle it once I have the time.

Removing myself as assignee, since the task is closed, but will still try to tackle it once I have the time.
Sign in to join this conversation.
No Label
Interest
Alembic
Interest
Animation & Rigging
Interest
Asset Browser
Interest
Asset Browser Project Overview
Interest
Audio
Interest
Automated Testing
Interest
Blender Asset Bundle
Interest
BlendFile
Interest
Collada
Interest
Compatibility
Interest
Compositing
Interest
Core
Interest
Cycles
Interest
Dependency Graph
Interest
Development Management
Interest
EEVEE
Interest
EEVEE & Viewport
Interest
Freestyle
Interest
Geometry Nodes
Interest
Grease Pencil
Interest
ID Management
Interest
Images & Movies
Interest
Import Export
Interest
Line Art
Interest
Masking
Interest
Metal
Interest
Modeling
Interest
Modifiers
Interest
Motion Tracking
Interest
Nodes & Physics
Interest
OpenGL
Interest
Overlay
Interest
Overrides
Interest
Performance
Interest
Physics
Interest
Pipeline, Assets & IO
Interest
Platforms, Builds & Tests
Interest
Python API
Interest
Render & Cycles
Interest
Render Pipeline
Interest
Sculpt, Paint & Texture
Interest
Text Editor
Interest
Translations
Interest
Triaging
Interest
Undo
Interest
USD
Interest
User Interface
Interest
UV Editing
Interest
VFX & Video
Interest
Video Sequencer
Interest
Virtual Reality
Interest
Vulkan
Interest
Wayland
Interest
Workbench
Interest: X11
Legacy
Blender 2.8 Project
Legacy
Milestone 1: Basic, Local Asset Browser
Legacy
OpenGL Error
Meta
Good First Issue
Meta
Papercut
Meta
Retrospective
Meta
Security
Module
Animation & Rigging
Module
Core
Module
Development Management
Module
EEVEE & Viewport
Module
Grease Pencil
Module
Modeling
Module
Nodes & Physics
Module
Pipeline, Assets & IO
Module
Platforms, Builds & Tests
Module
Python API
Module
Render & Cycles
Module
Sculpt, Paint & Texture
Module
Triaging
Module
User Interface
Module
VFX & Video
Platform
FreeBSD
Platform
Linux
Platform
macOS
Platform
Windows
Priority
High
Priority
Low
Priority
Normal
Priority
Unbreak Now!
Status
Archived
Status
Confirmed
Status
Duplicate
Status
Needs Info from Developers
Status
Needs Information from User
Status
Needs Triage
Status
Resolved
Type
Bug
Type
Design
Type
Known Issue
Type
Patch
Type
Report
Type
To Do
No Milestone
No project
No Assignees
4 Participants
Notifications
Due Date
The due date is invalid or out of range. Please use the format 'yyyy-mm-dd'.

No due date set.

Dependencies

No dependencies set.

Reference: blender/blender#98992
No description provided.