Circle Select on a Curve in Edit Mode = _BLI_assert_abort for Pydebug of Blender 3.2 #99073

Open
opened 2022-06-22 00:48:53 +02:00 by Lukas Sneyd · 5 comments

System Information
Operating system: Windows 11
Graphics card: Nvidia 3070ti

Blender Version
Broken: 3.2 pydebug
Worked: unknown

Short description of error
If you use circle select to click in viewport in edit mode of a curve object in Blender 3.2 Pydebug in VS 2019 (python/native debugging) it will crash and give you _BLI_assert_abort.

ucrtbased.dll!issue_debug_notification(const wchar_t * const message) Line 28
	at minkernel\crts\ucrt\src\appcrt\internal\report_runtime_error.cpp(28)
ucrtbased.dll!__acrt_report_runtime_error(const wchar_t * message) Line 154
	at minkernel\crts\ucrt\src\appcrt\internal\report_runtime_error.cpp(154)
ucrtbased.dll!abort() Line 61
	at minkernel\crts\ucrt\src\appcrt\startup\abort.cpp(61)
blender.exe!_BLI_assert_abort() Line 47
	at E:\blender-git\blender\source\blender\blenlib\intern\BLI_assert.c(47)
blender.exe!BKE_editmesh_from_object(Object * ob) Line 59
	at E:\blender-git\blender\source\blender\blenkernel\intern\editmesh.c(59)
blender.exe!em_setup_viewcontext(bContext * C, ViewContext * vc) Line 4359
	at E:\blender-git\blender\source\blender\editors\mesh\editmesh_select.c(4359)
blender.exe!view3d_circle_select_recalc(void * user_data) Line 4614
	at E:\blender-git\blender\source\blender\editors\space_view3d\view3d_select.c(4614)
blender.exe!view3d_circle_select_modal(bContext * C, wmOperator * op, const wmEvent * event) Line 4639
	at E:\blender-git\blender\source\blender\editors\space_view3d\view3d_select.c(4639)
blender.exe!wm_handler_operator_call(bContext * C, ListBase * handlers, wmEventHandler * handler_base, wmEvent * event, PointerRNA * properties, const unsigned char * kmi_idname) Line 2327
	at E:\blender-git\blender\source\blender\windowmanager\intern\wm_event_system.c(2327)
blender.exe!wm_handlers_do_intern(bContext * C, wmWindow * win, wmEvent * event, ListBase * handlers) Line 3227
	at E:\blender-git\blender\source\blender\windowmanager\intern\wm_event_system.c(3227)
blender.exe!wm_handlers_do(bContext * C, wmEvent * event, ListBase * handlers) Line 3279
	at E:\blender-git\blender\source\blender\windowmanager\intern\wm_event_system.c(3279)
blender.exe!wm_event_do_handlers(bContext * C) Line 3869
	at E:\blender-git\blender\source\blender\windowmanager\intern\wm_event_system.c(3869)
blender.exe!WM_main(bContext * C) Line 626
	at E:\blender-git\blender\source\blender\windowmanager\intern\wm.c(626)
blender.exe!main(int argc, const unsigned char * * UNUSED_argv_c) Line 551
	at E:\blender-git\blender\source\creator\creator.c(551)
[External Code]

Exact steps for others to reproduce the error
Default startup, object mode, add bezier curve, go into edit mode, switch to circle select, click viewport. Also happens with circle, nurbs curve, nurbs circle, and path.

**System Information** Operating system: Windows 11 Graphics card: Nvidia 3070ti **Blender Version** Broken: 3.2 pydebug Worked: unknown **Short description of error** If you use circle select to click in viewport in edit mode of a curve object in Blender 3.2 Pydebug in VS 2019 (python/native debugging) it will crash and give you _BLI_assert_abort. ``` ucrtbased.dll!issue_debug_notification(const wchar_t * const message) Line 28 at minkernel\crts\ucrt\src\appcrt\internal\report_runtime_error.cpp(28) ucrtbased.dll!__acrt_report_runtime_error(const wchar_t * message) Line 154 at minkernel\crts\ucrt\src\appcrt\internal\report_runtime_error.cpp(154) ucrtbased.dll!abort() Line 61 at minkernel\crts\ucrt\src\appcrt\startup\abort.cpp(61) blender.exe!_BLI_assert_abort() Line 47 at E:\blender-git\blender\source\blender\blenlib\intern\BLI_assert.c(47) blender.exe!BKE_editmesh_from_object(Object * ob) Line 59 at E:\blender-git\blender\source\blender\blenkernel\intern\editmesh.c(59) blender.exe!em_setup_viewcontext(bContext * C, ViewContext * vc) Line 4359 at E:\blender-git\blender\source\blender\editors\mesh\editmesh_select.c(4359) blender.exe!view3d_circle_select_recalc(void * user_data) Line 4614 at E:\blender-git\blender\source\blender\editors\space_view3d\view3d_select.c(4614) blender.exe!view3d_circle_select_modal(bContext * C, wmOperator * op, const wmEvent * event) Line 4639 at E:\blender-git\blender\source\blender\editors\space_view3d\view3d_select.c(4639) blender.exe!wm_handler_operator_call(bContext * C, ListBase * handlers, wmEventHandler * handler_base, wmEvent * event, PointerRNA * properties, const unsigned char * kmi_idname) Line 2327 at E:\blender-git\blender\source\blender\windowmanager\intern\wm_event_system.c(2327) blender.exe!wm_handlers_do_intern(bContext * C, wmWindow * win, wmEvent * event, ListBase * handlers) Line 3227 at E:\blender-git\blender\source\blender\windowmanager\intern\wm_event_system.c(3227) blender.exe!wm_handlers_do(bContext * C, wmEvent * event, ListBase * handlers) Line 3279 at E:\blender-git\blender\source\blender\windowmanager\intern\wm_event_system.c(3279) blender.exe!wm_event_do_handlers(bContext * C) Line 3869 at E:\blender-git\blender\source\blender\windowmanager\intern\wm_event_system.c(3869) blender.exe!WM_main(bContext * C) Line 626 at E:\blender-git\blender\source\blender\windowmanager\intern\wm.c(626) blender.exe!main(int argc, const unsigned char * * UNUSED_argv_c) Line 551 at E:\blender-git\blender\source\creator\creator.c(551) [External Code] ``` **Exact steps for others to reproduce the error** Default startup, object mode, add bezier curve, go into edit mode, switch to circle select, click viewport. Also happens with circle, nurbs curve, nurbs circle, and path.
Author

Added subscriber: @lcas

Added subscriber: @lcas

Added subscriber: @rjg

Added subscriber: @rjg

Changed status from 'Needs Triage' to: 'Confirmed'

Changed status from 'Needs Triage' to: 'Confirmed'

The assert is triggered because the Bezier curve is not a mesh, yet view3d_circle_select_recalc() calls em_setup_viewcontext(), which calls BKE_editmesh_from_object when in edit mode. The latter contains the BLI_assert(ob->type == OB_MESH);.

It appears this issue was introduced in 0375720e28

The assert is triggered because the Bezier curve is not a mesh, yet `view3d_circle_select_recalc()` calls `em_setup_viewcontext()`, which calls `BKE_editmesh_from_object` when in edit mode. The latter contains the `BLI_assert(ob->type == OB_MESH);`. It appears this issue was introduced in 0375720e28
Author

Would it be ok to do this? If I add a more specific check for OB_MESH in em_setup_viewcontext()

original

void em_setup_viewcontext(bContext *C, ViewContext *vc)
{
  Depsgraph *depsgraph = CTX_data_ensure_evaluated_depsgraph(C);
  ED_view3d_viewcontext_init(C, vc, depsgraph);

  if (vc->obedit) {
    vc->em = BKE_editmesh_from_object(vc->obedit);
  }
}

new

void em_setup_viewcontext(bContext *C, ViewContext *vc)
{
  Depsgraph *depsgraph = CTX_data_ensure_evaluated_depsgraph(C);
  ED_view3d_viewcontext_init(C, vc, depsgraph);

  if (vc->obedit->type == OB_MESH) {
    vc->em = BKE_editmesh_from_object(vc->obedit);
  }
}
Would it be ok to do this? If I add a more specific check for `OB_MESH` in `em_setup_viewcontext()` original ``` void em_setup_viewcontext(bContext *C, ViewContext *vc) { Depsgraph *depsgraph = CTX_data_ensure_evaluated_depsgraph(C); ED_view3d_viewcontext_init(C, vc, depsgraph); if (vc->obedit) { vc->em = BKE_editmesh_from_object(vc->obedit); } } ``` new ``` void em_setup_viewcontext(bContext *C, ViewContext *vc) { Depsgraph *depsgraph = CTX_data_ensure_evaluated_depsgraph(C); ED_view3d_viewcontext_init(C, vc, depsgraph); if (vc->obedit->type == OB_MESH) { vc->em = BKE_editmesh_from_object(vc->obedit); } } ```
Philipp Oeser removed the
Interest
Modeling
label 2023-02-09 15:27:39 +01:00
Sign in to join this conversation.
No Label
Interest
Alembic
Interest
Animation & Rigging
Interest
Asset Browser
Interest
Asset Browser Project Overview
Interest
Audio
Interest
Automated Testing
Interest
Blender Asset Bundle
Interest
BlendFile
Interest
Collada
Interest
Compatibility
Interest
Compositing
Interest
Core
Interest
Cycles
Interest
Dependency Graph
Interest
Development Management
Interest
EEVEE
Interest
EEVEE & Viewport
Interest
Freestyle
Interest
Geometry Nodes
Interest
Grease Pencil
Interest
ID Management
Interest
Images & Movies
Interest
Import Export
Interest
Line Art
Interest
Masking
Interest
Metal
Interest
Modeling
Interest
Modifiers
Interest
Motion Tracking
Interest
Nodes & Physics
Interest
OpenGL
Interest
Overlay
Interest
Overrides
Interest
Performance
Interest
Physics
Interest
Pipeline, Assets & IO
Interest
Platforms, Builds & Tests
Interest
Python API
Interest
Render & Cycles
Interest
Render Pipeline
Interest
Sculpt, Paint & Texture
Interest
Text Editor
Interest
Translations
Interest
Triaging
Interest
Undo
Interest
USD
Interest
User Interface
Interest
UV Editing
Interest
VFX & Video
Interest
Video Sequencer
Interest
Virtual Reality
Interest
Vulkan
Interest
Wayland
Interest
Workbench
Interest: X11
Legacy
Blender 2.8 Project
Legacy
Milestone 1: Basic, Local Asset Browser
Legacy
OpenGL Error
Meta
Good First Issue
Meta
Papercut
Meta
Retrospective
Meta
Security
Module
Animation & Rigging
Module
Core
Module
Development Management
Module
EEVEE & Viewport
Module
Grease Pencil
Module
Modeling
Module
Nodes & Physics
Module
Pipeline, Assets & IO
Module
Platforms, Builds & Tests
Module
Python API
Module
Render & Cycles
Module
Sculpt, Paint & Texture
Module
Triaging
Module
User Interface
Module
VFX & Video
Platform
FreeBSD
Platform
Linux
Platform
macOS
Platform
Windows
Priority
High
Priority
Low
Priority
Normal
Priority
Unbreak Now!
Status
Archived
Status
Confirmed
Status
Duplicate
Status
Needs Info from Developers
Status
Needs Information from User
Status
Needs Triage
Status
Resolved
Type
Bug
Type
Design
Type
Known Issue
Type
Patch
Type
Report
Type
To Do
No Milestone
No project
No Assignees
2 Participants
Notifications
Due Date
The due date is invalid or out of range. Please use the format 'yyyy-mm-dd'.

No due date set.

Dependencies

No dependencies set.

Reference: blender/blender#99073
No description provided.