Regression: Rendering in the viewport is constantly restarted by some sculpting brushes and the position of mouse cursor #99196

Closed
opened 2022-06-27 07:58:52 +02:00 by Stay_Here · 20 comments

System Information
Operating system: Windows-10-10.0.19043-SP0 64 Bits
Graphics card: Quadro RTX 3000 with Max-Q Design/PCIe/SSE2 NVIDIA Corporation 4.5.0 NVIDIA 516.25

Blender Version
Broken: version: 3.2.0, branch: master, commit date: 2022-06-08 10:22, hash: e05e1e3691
Worked: 3.2.1

So the original issue came with 8b7cd1ed2a
This apparently got "fixed" by 285a68b7bb

Short description of error
Cycles affected by the brushes.mp4
Rendering in the viewport is constantly restarted by some sculpting brushes and the position of mouse cursor.
1, Moving the mouse cursor out of the viewport can stop causing the problem.
2, Not all brushes are causing the problem. For example, Grab brush, Elastic brush, Draw brush, Mask brush are not causing the problem.
3, This problem does not happen in Blender 3.1 or Blender 3.0.

note: after 285a68b7bb, it seems only the Pose & Boundary brushes are still affected (and only if you hover the mesh)

Exact steps for others to reproduce the error
A sample file is included.
Bug on Cycles rendering in Sculpt.blend

**System Information** Operating system: Windows-10-10.0.19043-SP0 64 Bits Graphics card: Quadro RTX 3000 with Max-Q Design/PCIe/SSE2 NVIDIA Corporation 4.5.0 NVIDIA 516.25 **Blender Version** Broken: version: 3.2.0, branch: master, commit date: 2022-06-08 10:22, hash: `e05e1e3691` Worked: 3.2.1 So the original issue came with 8b7cd1ed2a This apparently got "fixed" by 285a68b7bb **Short description of error** [Cycles affected by the brushes.mp4](https://archive.blender.org/developer/F13231965/Cycles_affected_by_the_brushes.mp4) Rendering in the viewport is constantly restarted by some sculpting brushes and the position of mouse cursor. 1, Moving the mouse cursor out of the viewport can stop causing the problem. 2, Not all brushes are causing the problem. For example, Grab brush, Elastic brush, Draw brush, Mask brush are not causing the problem. 3, This problem does not happen in Blender 3.1 or Blender 3.0. note: after 285a68b7bb, it seems only the Pose & Boundary brushes are still affected (and only if you hover the mesh) **Exact steps for others to reproduce the error** A sample file is included. [Bug on Cycles rendering in Sculpt.blend](https://archive.blender.org/developer/F13231970/Bug_on_Cycles_rendering_in_Sculpt.blend)
Author

Added subscriber: @Stay_Here

Added subscriber: @Stay_Here

#99510 was marked as duplicate of this issue

#99510 was marked as duplicate of this issue
Member

Added subscriber: @PratikPB2123

Added subscriber: @PratikPB2123
Member

Changed status from 'Needs Triage' to: 'Confirmed'

Changed status from 'Needs Triage' to: 'Confirmed'
Member

Thanks for the report.
I can confirm in 3.2.1 but not in 3.1 and 3.3

Thanks for the report. I can confirm in 3.2.1 but not in 3.1 and 3.3
Member

Added subscriber: @lichtwerk

Added subscriber: @lichtwerk
Member

Fixed between 173a15bcda - add1da52ad
Exact commit is not known to me. @lichtwerk , can you check please?

Fixed between 173a15bcda8f - add1da52ad78 Exact commit is not known to me. @lichtwerk , can you check please?
Member

Will bisect when this changed (for the better).
Note though that the Pose and Boundary brushes are still affected if you hover over the mesh (also in master)

Will bisect when this changed (for the better). Note though that the Pose and Boundary brushes are still affected if you hover over the mesh (also in master)
Member

Added subscriber: @JosephEagar

Added subscriber: @JosephEagar
Member

This apparently got "fixed" by 285a68b7bb

So nothing to backport to 3.2.1 I guess

CC @JosephEagar

Note though this was entirely fine in 3.2.1 (even with the Pose & Boundary brushes, which are now still broken in that regard in master), will check what was the original cause in the first place (maybe that will help fix said two brushes as well...)

This apparently got "fixed" by 285a68b7bb So nothing to backport to 3.2.1 I guess CC @JosephEagar Note though this was entirely fine in 3.2.1 (even with the `Pose` & `Boundary` brushes, which are now still broken in that regard in master), will check what was the original cause in the first place (maybe that will help fix said two brushes as well...)
Member

Added subscriber: @Jeroen-Bakker

Added subscriber: @Jeroen-Bakker
Member

So the original issue came with 8b7cd1ed2a

CC @Jeroen-Bakker

So the original issue came with 8b7cd1ed2a CC @Jeroen-Bakker
Philipp Oeser changed title from Rendering in the viewport is constantly restarted by some sculpting brushes and the position of mouse cursor to Regression: Rendering in the viewport is constantly restarted by some sculpting brushes and the position of mouse cursor 2022-06-29 13:06:33 +02:00

This issue was referenced by f7c6d3705d

This issue was referenced by f7c6d3705df8c182d70ca8ca12bb8ac160cdba8f

This issue was referenced by 2185943235

This issue was referenced by 21859432357a80d50eab71552350f6dd242abfb2

This issue was referenced by ee57ac8abf

This issue was referenced by ee57ac8abfe4c7b88e510d31aab965bbea082f1e

This issue was referenced by c39e932631

This issue was referenced by c39e9326317442f6751fb0b2929c49b3512309d5
Member

Changed status from 'Confirmed' to: 'Resolved'

Changed status from 'Confirmed' to: 'Resolved'
Joseph Eagar self-assigned this 2022-06-30 08:36:11 +02:00
Member

Ok. I had to do a small amount of cleanup, but I think I've gotten this fixed. The root cause was paint-related code in sculpt_update_object (called by its external API, BKE_sculpt_update_object_for_edit). I went through and renamed the two functions' needs_color (which was actually unused) parameter to is_paint_tool. I also fixed a bunch of places where I had named API parameters or functions "color" instead of "paint", and a few bugs caused by it.

Ok. I had to do a small amount of cleanup, but I think I've gotten this fixed. The root cause was paint-related code in `sculpt_update_object` (called by its external API, `BKE_sculpt_update_object_for_edit`). I went through and renamed the two functions' `needs_color` (which was actually unused) parameter to `is_paint_tool`. I also fixed a bunch of places where I had named API parameters or functions "color" instead of "paint", and a few bugs caused by it.

Added subscriber: @Alex_Rom

Added subscriber: @Alex_Rom

Removed subscriber: @Alex_Rom

Removed subscriber: @Alex_Rom
Thomas Dinges added this to the 3.2 milestone 2023-02-08 15:51:06 +01:00
Sign in to join this conversation.
No Label
Interest
Alembic
Interest
Animation & Rigging
Interest
Asset Browser
Interest
Asset Browser Project Overview
Interest
Audio
Interest
Automated Testing
Interest
Blender Asset Bundle
Interest
BlendFile
Interest
Collada
Interest
Compatibility
Interest
Compositing
Interest
Core
Interest
Cycles
Interest
Dependency Graph
Interest
Development Management
Interest
EEVEE
Interest
EEVEE & Viewport
Interest
Freestyle
Interest
Geometry Nodes
Interest
Grease Pencil
Interest
ID Management
Interest
Images & Movies
Interest
Import Export
Interest
Line Art
Interest
Masking
Interest
Metal
Interest
Modeling
Interest
Modifiers
Interest
Motion Tracking
Interest
Nodes & Physics
Interest
OpenGL
Interest
Overlay
Interest
Overrides
Interest
Performance
Interest
Physics
Interest
Pipeline, Assets & IO
Interest
Platforms, Builds & Tests
Interest
Python API
Interest
Render & Cycles
Interest
Render Pipeline
Interest
Sculpt, Paint & Texture
Interest
Text Editor
Interest
Translations
Interest
Triaging
Interest
Undo
Interest
USD
Interest
User Interface
Interest
UV Editing
Interest
VFX & Video
Interest
Video Sequencer
Interest
Virtual Reality
Interest
Vulkan
Interest
Wayland
Interest
Workbench
Interest: X11
Legacy
Blender 2.8 Project
Legacy
Milestone 1: Basic, Local Asset Browser
Legacy
OpenGL Error
Meta
Good First Issue
Meta
Papercut
Meta
Retrospective
Meta
Security
Module
Animation & Rigging
Module
Core
Module
Development Management
Module
EEVEE & Viewport
Module
Grease Pencil
Module
Modeling
Module
Nodes & Physics
Module
Pipeline, Assets & IO
Module
Platforms, Builds & Tests
Module
Python API
Module
Render & Cycles
Module
Sculpt, Paint & Texture
Module
Triaging
Module
User Interface
Module
VFX & Video
Platform
FreeBSD
Platform
Linux
Platform
macOS
Platform
Windows
Priority
High
Priority
Low
Priority
Normal
Priority
Unbreak Now!
Status
Archived
Status
Confirmed
Status
Duplicate
Status
Needs Info from Developers
Status
Needs Information from User
Status
Needs Triage
Status
Resolved
Type
Bug
Type
Design
Type
Known Issue
Type
Patch
Type
Report
Type
To Do
No Milestone
No project
No Assignees
6 Participants
Notifications
Due Date
The due date is invalid or out of range. Please use the format 'yyyy-mm-dd'.

No due date set.

Dependencies

No dependencies set.

Reference: blender/blender#99196
No description provided.