Drag and drop does not work with the wayland backend #99737

New Issue

Sebastian Parborg · 2022-07-15T15:11:26+02:00

Sebastian Parborg commented

2022-07-15 15:11:26 +02:00

System Information
Operating system: Gentoo Linux
Graphics card: AMD Vega

Blender Version
Broken: master
Worked: -

Short description of error
When dragging and dropping files from outside of Blender, it almost always fails (nothing happens).
See video below. (Drag and dropping into GIMP and other wayland applications seem to work flawlessly)
rec_30.mp4

It seems like Blender does sometimes detect that something is dropped into it as this is printed into the terminal:

I haven't tried any other window manager but Sway. However I think that Blender might be violating the specs here somehow and that is why things are weird.
Here is a blog post from one of the wlroots developers on how the clipboard and drag and drop works in wayland: https://emersion.fr/blog/2020/wayland-clipboard-drag-and-drop/

drop file /home/zed/elkfinal.png
drop file /home/zed/elkfinal.png
drop file /home/zed/elkfinal.png
drop file /home/zed/elkfinal.png
drop file /home/zed/elkfinal.png

In the rare case that the drag and drop works, the image in this case is not dropped where the mouse cursor is, but in an other location.
IE the mouse could be in the left corner of the 3D view, but the image is inserted on the right corner instead.

Exact steps for others to reproduce the error

Open Blender running the wayland backend
Try to drag an image into the 3D view from an other program.
Notice how it is flaky and doesn't work most of the time.

**System Information** Operating system: Gentoo Linux Graphics card: AMD Vega **Blender Version** Broken: master Worked: - **Short description of error** When dragging and dropping files from outside of Blender, it almost always fails (nothing happens). See video below. (Drag and dropping into GIMP and other wayland applications seem to work flawlessly) [rec_30.mp4](https://archive.blender.org/developer/F13294800/rec_30.mp4) It seems like Blender does sometimes detect that something is dropped into it as this is printed into the terminal: I haven't tried any other window manager but Sway. However I think that Blender might be violating the specs here somehow and that is why things are weird. Here is a blog post from one of the wlroots developers on how the clipboard and drag and drop works in wayland: https://emersion.fr/blog/2020/wayland-clipboard-drag-and-drop/ ``` drop file /home/zed/elkfinal.png drop file /home/zed/elkfinal.png drop file /home/zed/elkfinal.png drop file /home/zed/elkfinal.png drop file /home/zed/elkfinal.png ``` In the rare case that the drag and drop works, the image in this case is not dropped where the mouse cursor is, but in an other location. IE the mouse could be in the left corner of the 3D view, but the image is inserted on the right corner instead. **Exact steps for others to reproduce the error** 1. Open Blender running the wayland backend 2. Try to drag an image into the 3D view from an other program. 3. Notice how it is flaky and doesn't work most of the time.

Sebastian Parborg commented

2022-07-15 15:11:26 +02:00

Added subscriber: @ZedDB

Sebastian Parborg commented

2022-07-15 15:12:00 +02:00

Changed status from 'Needs Triage' to: 'Confirmed'

Campbell Barton was assigned by Sebastian Parborg

2022-07-15 15:12:00 +02:00

blender-admin commented

2022-07-19 05:33:02 +02:00

This issue was referenced by bbf87c4f75

This issue was referenced by bbf87c4f750992f47f514733e3a7d33573f5c860

Campbell Barton commented

2022-07-19 05:33:06 +02:00

Changed status from 'Confirmed' to: 'Resolved'

Campbell Barton closed this issue

2022-07-19 05:33:06 +02:00

Sebastian Parborg commented

2022-07-19 16:25:37 +02:00

Changed status from 'Resolved' to: 'Confirmed'

Sebastian Parborg reopened this issue

2022-07-19 16:25:37 +02:00

Sebastian Parborg commented

2022-07-19 16:25:37 +02:00

This seems to still not be fixed.

I've tried it with latest sway master and there seems to work with GTK3 clients, sometimes.
With QT5 clients (pcmanfm-qt) it is still is not working.

I'm guessing that there are some race condition going on as ASAN also regularly shuts down Blender when I try to drag and drop with:

==24348==ERROR: AddressSanitizer: heap-use-after-free on address 0x608000d27460 at pc 0x000010bbe835 bp 0x7ffb7895aa40 sp 0x7ffb7895aa30
READ of size 8 at 0x608000d27460 thread T23
    - 0 0x10bbe834 in operator() /home/zed/prog/blender/intern/ghost/intern/GHOST_SystemWayland.cpp:1217
    - 1 0x10bf3b30 in __invoke_impl<void, data_device_handle_drop(void*, wl_data_device*)::<lambda(input_t*, data_offer_t*, wl_surface*, std::string)>, input_t*, data_offer_t*, wl_surface*, std::__cxx11::basic_string<char, std::char_traits<char>, std::allocator<char> > > /usr/lib/gcc/x86_64-pc-linux-gnu/11.3.0/include/g++-v11/bits/invoke.h:61
    - 2 0x10bf370e in __invoke<data_device_handle_drop(void*, wl_data_device*)::<lambda(input_t*, data_offer_t*, wl_surface*, std::string)>, input_t*, data_offer_t*, wl_surface*, std::__cxx11::basic_string<char, std::char_traits<char>, std::allocator<char> > > /usr/lib/gcc/x86_64-pc-linux-gnu/11.3.0/include/g++-v11/bits/invoke.h:96
    - 3 0x10bf3110 in _M_invoke<0, 1, 2, 3, 4> /usr/lib/gcc/x86_64-pc-linux-gnu/11.3.0/include/g++-v11/bits/std_thread.h:253
    - 4 0x10bf2d40 in operator() /usr/lib/gcc/x86_64-pc-linux-gnu/11.3.0/include/g++-v11/bits/std_thread.h:260
    - 5 0x10bf2cd0 in _M_run /usr/lib/gcc/x86_64-pc-linux-gnu/11.3.0/include/g++-v11/bits/std_thread.h:211
    - 6 0x7ffbb3625f3f  (/usr/lib/gcc/x86_64-pc-linux-gnu/11.3.0/libstdc++.so.6+0xd4f3f)
    - 7 0x7ffbb330a496 in start_thread /var/tmp/portage/sys-libs/glibc-2.34-r13/work/glibc-2.34/nptl/pthread_create.c:435
    #8 0x7ffbb338c37b  (/lib64/libc.so.6+0x10937b)

0x608000d27460 is located 64 bytes inside of 88-byte region [0x608000d27420,0x608000d27478)
freed by thread T0 here:
    - 0 0x7ffbc86210e7 in operator delete(void*, unsigned long) (/usr/lib/gcc/x86_64-pc-linux-gnu/11.3.0/libasan.so.6+0xb50e7)
    - 1 0x10bbde9c in data_device_handle_leave /home/zed/prog/blender/intern/ghost/intern/GHOST_SystemWayland.cpp:1173
    #2 0x7ffbaf166e29  (/usr/lib64/libffi.so.8+0x6e29)

previously allocated by thread T0 here:
    - 0 0x7ffbc8620087 in operator new(unsigned long) (/usr/lib/gcc/x86_64-pc-linux-gnu/11.3.0/libasan.so.6+0xb4087)
    - 1 0x10bbcd33 in data_device_handle_data_offer /home/zed/prog/blender/intern/ghost/intern/GHOST_SystemWayland.cpp:1119
    #2 0x7ffbaf166e29  (/usr/lib64/libffi.so.8+0x6e29)

Thread T23 created by T0 here:
    - 0 0x7ffbc85c3571 in pthread_create (/usr/lib/gcc/x86_64-pc-linux-gnu/11.3.0/libasan.so.6+0x57571)
    - 1 0x7ffbb3626004 in std::thread::_M_start_thread(std::unique_ptr<std::thread::_State, std::default_delete<std::thread::_State> >, void (*)()) (/usr/lib/gcc/x86_64-pc-linux-gnu/11.3.0/libstdc++.so.6+0xd5004)
    - 2 0x10bbfdc5 in data_device_handle_drop /home/zed/prog/blender/intern/ghost/intern/GHOST_SystemWayland.cpp:1272
    - 3 0x7ffbaf166e29  (/usr/lib64/libffi.so.8+0x6e29)

So I'm guessing that there is some non thread safe stuff happening in Blender that makes it sometimes not work and sometimes we get this "use after free" error.

I'm getting a similar "use after free" error when exiting Blender as well.

This seems to still not be fixed. I've tried it with latest sway master and there seems to work with GTK3 clients, sometimes. With QT5 clients (pcmanfm-qt) it is still is not working. I'm guessing that there are some race condition going on as ASAN also regularly shuts down Blender when I try to drag and drop with: ``` ==24348==ERROR: AddressSanitizer: heap-use-after-free on address 0x608000d27460 at pc 0x000010bbe835 bp 0x7ffb7895aa40 sp 0x7ffb7895aa30 READ of size 8 at 0x608000d27460 thread T23 - 0 0x10bbe834 in operator() /home/zed/prog/blender/intern/ghost/intern/GHOST_SystemWayland.cpp:1217 - 1 0x10bf3b30 in __invoke_impl<void, data_device_handle_drop(void*, wl_data_device*)::<lambda(input_t*, data_offer_t*, wl_surface*, std::string)>, input_t*, data_offer_t*, wl_surface*, std::__cxx11::basic_string<char, std::char_traits<char>, std::allocator<char> > > /usr/lib/gcc/x86_64-pc-linux-gnu/11.3.0/include/g++-v11/bits/invoke.h:61 - 2 0x10bf370e in __invoke<data_device_handle_drop(void*, wl_data_device*)::<lambda(input_t*, data_offer_t*, wl_surface*, std::string)>, input_t*, data_offer_t*, wl_surface*, std::__cxx11::basic_string<char, std::char_traits<char>, std::allocator<char> > > /usr/lib/gcc/x86_64-pc-linux-gnu/11.3.0/include/g++-v11/bits/invoke.h:96 - 3 0x10bf3110 in _M_invoke<0, 1, 2, 3, 4> /usr/lib/gcc/x86_64-pc-linux-gnu/11.3.0/include/g++-v11/bits/std_thread.h:253 - 4 0x10bf2d40 in operator() /usr/lib/gcc/x86_64-pc-linux-gnu/11.3.0/include/g++-v11/bits/std_thread.h:260 - 5 0x10bf2cd0 in _M_run /usr/lib/gcc/x86_64-pc-linux-gnu/11.3.0/include/g++-v11/bits/std_thread.h:211 - 6 0x7ffbb3625f3f (/usr/lib/gcc/x86_64-pc-linux-gnu/11.3.0/libstdc++.so.6+0xd4f3f) - 7 0x7ffbb330a496 in start_thread /var/tmp/portage/sys-libs/glibc-2.34-r13/work/glibc-2.34/nptl/pthread_create.c:435 #8 0x7ffbb338c37b (/lib64/libc.so.6+0x10937b) 0x608000d27460 is located 64 bytes inside of 88-byte region [0x608000d27420,0x608000d27478) freed by thread T0 here: - 0 0x7ffbc86210e7 in operator delete(void*, unsigned long) (/usr/lib/gcc/x86_64-pc-linux-gnu/11.3.0/libasan.so.6+0xb50e7) - 1 0x10bbde9c in data_device_handle_leave /home/zed/prog/blender/intern/ghost/intern/GHOST_SystemWayland.cpp:1173 #2 0x7ffbaf166e29 (/usr/lib64/libffi.so.8+0x6e29) previously allocated by thread T0 here: - 0 0x7ffbc8620087 in operator new(unsigned long) (/usr/lib/gcc/x86_64-pc-linux-gnu/11.3.0/libasan.so.6+0xb4087) - 1 0x10bbcd33 in data_device_handle_data_offer /home/zed/prog/blender/intern/ghost/intern/GHOST_SystemWayland.cpp:1119 #2 0x7ffbaf166e29 (/usr/lib64/libffi.so.8+0x6e29) Thread T23 created by T0 here: - 0 0x7ffbc85c3571 in pthread_create (/usr/lib/gcc/x86_64-pc-linux-gnu/11.3.0/libasan.so.6+0x57571) - 1 0x7ffbb3626004 in std::thread::_M_start_thread(std::unique_ptr<std::thread::_State, std::default_delete<std::thread::_State> >, void (*)()) (/usr/lib/gcc/x86_64-pc-linux-gnu/11.3.0/libstdc++.so.6+0xd5004) - 2 0x10bbfdc5 in data_device_handle_drop /home/zed/prog/blender/intern/ghost/intern/GHOST_SystemWayland.cpp:1272 - 3 0x7ffbaf166e29 (/usr/lib64/libffi.so.8+0x6e29) ``` So I'm guessing that there is some non thread safe stuff happening in Blender that makes it sometimes not work and sometimes we get this "use after free" error. I'm getting a similar "use after free" error when exiting Blender as well.

Campbell Barton commented

2022-08-04 14:35:26 +02:00

Fixed 727cc426bc & a95103f6f4.

Fixed 727cc426bc & a95103f6f4.

Campbell Barton commented

2022-08-04 14:35:37 +02:00

Changed status from 'Confirmed' to: 'Resolved'

Campbell Barton closed this issue

2022-08-04 14:35:37 +02:00

Sign in to join this conversation.