Regression: Texture slots thumbnails in Texture painting mode are missing #99868

New Issue

Juan Romero · 2022-07-20T11:59:00+02:00

Juan Romero commented

2022-07-20 11:59:00 +02:00

System Information
Operating system: Windows-10-10.0.22000-SP0 64 Bits
Graphics card: NVIDIA GeForce RTX 3090/PCIe/SSE2 NVIDIA Corporation 4.5.0 NVIDIA 516.59

Blender Version
Broken: version: 3.3.0 Alpha, branch: master, commit date: 2022-07-19 23:16, hash: 40ffb94ab4
Caused by 8b7cd1ed2a

Short description of error
Texture slots thumbnails in Texture painting mode are missing

Exact steps for others to reproduce the error
In Texture Paint mode, create texture, begin to paint, save texture and blender file. In the active tools panel>Texture Slots, the texture appears as a generic icon and its name, in 2.90 there was a thumbnail of the created texture instead of a generic icon.

images for reference:

**System Information** Operating system: Windows-10-10.0.22000-SP0 64 Bits Graphics card: NVIDIA GeForce RTX 3090/PCIe/SSE2 NVIDIA Corporation 4.5.0 NVIDIA 516.59 **Blender Version** Broken: version: 3.3.0 Alpha, branch: master, commit date: 2022-07-19 23:16, hash: `40ffb94ab4` Caused by 8b7cd1ed2a **Short description of error** Texture slots thumbnails in Texture painting mode are missing **Exact steps for others to reproduce the error** In Texture Paint mode, create texture, begin to paint, save texture and blender file. In the active tools panel>Texture Slots, the texture appears as a generic icon and its name, in 2.90 there was a thumbnail of the created texture instead of a generic icon. images for reference: ![Bug.jpg](https://archive.blender.org/developer/F13308091/Bug.jpg)

Juan Romero commented

2022-07-20 11:59:00 +02:00

Added subscriber: @JuanRomero

Omar Emara commented

2022-07-20 13:10:56 +02:00

Added subscriber: @OmarEmaraDev

Omar Emara commented

2022-07-20 13:10:56 +02:00

Changed status from 'Needs Triage' to: 'Archived'

Omar Emara closed this issue

2022-07-20 13:10:56 +02:00

Omar Emara commented

2022-07-20 13:10:56 +02:00

It seems this was internationally changed in D14455. So this is not a bug, but an expected behavior.

It seems this was internationally changed in [D14455](https://archive.blender.org/developer/D14455). So this is not a bug, but an expected behavior.

Evan Wilson commented

2022-07-20 14:49:04 +02:00

Added subscriber: @EAW

Evan Wilson commented

2022-07-20 14:49:04 +02:00

In #99868#1393182, @OmarEmaraDev wrote:
It seems this was internationally changed in D14455. So this is not a bug, but an expected behavior.

I am not seeing where it was intentionally changed.
I would think the new rna_TexPaintSlot_icon_get code was added to support this case, but I could be wrong.

> In #99868#1393182, @OmarEmaraDev wrote: > It seems this was internationally changed in [D14455](https://archive.blender.org/developer/D14455). So this is not a bug, but an expected behavior. I am not seeing where it was intentionally changed. I would think the new `rna_TexPaintSlot_icon_get` code was added to support this case, but I could be wrong.

Omar Emara commented

2022-07-20 14:54:24 +02:00

@EAW rna_TexPaintSlot_icon_get is the RNA icon_value property, which is used in TEXTURE_UL_texpaintslots getting its items from texture_paint_slots. icon_value is a static icon, hence the change in behavior.

@EAW `rna_TexPaintSlot_icon_get` is the RNA `icon_value` property, which is used in `TEXTURE_UL_texpaintslots` getting its items from `texture_paint_slots`. `icon_value` is a static icon, hence the change in behavior.

Evan Wilson commented

2022-07-20 16:14:20 +02:00

@OmarEmaraDev Thank you for the reply.
I was confused as I was testing the 'Single Image' texture slot, which still has an image specific thumbnail in the dropdown. I now see that this report was referring to the material texture slots.

@OmarEmaraDev Thank you for the reply. I was confused as I was testing the 'Single Image' texture slot, which still has an image specific thumbnail in the dropdown. I now see that this report was referring to the material texture slots.

Andy Cuccaro commented

2022-07-21 13:59:30 +02:00

Added subscriber: @AndyCuccaro

Andy Cuccaro commented

2022-07-21 13:59:30 +02:00

What's the purpose of the icon then? And what was the purpose of removing it? Seems like it was removed either unintentionally or "just because".

Omar Emara commented

2022-07-22 13:39:16 +02:00

Changed status from 'Archived' to: 'Needs Developer To Reproduce'

Omar Emara reopened this issue

2022-07-22 13:39:16 +02:00

Jeroen Bakker commented

2022-09-16 14:38:29 +02:00

Added subscriber: @Jeroen-Bakker

Jeroen Bakker commented

2022-09-16 14:38:29 +02:00

Changed status from 'Needs Developer To Reproduce' to: 'Confirmed'

Jeroen Bakker commented

2022-09-16 14:38:29 +02:00

This is something we should get back. It was removed as color attributes and textures share the same panel.
We should add a new rna property to get the correct icon:

Thumbnail of the texture when the paint slot refers to an image.
Color attribute icon when the paint slot refers to a color attribute.

That said it is fairly straight forward, but is not high on my priority list. I would believe that anyone with some experience in development should be able to fix this.

Texture thumbnail rendering is not removed and still available.
adding a branch base on the type of paint slot

If anyone wants to pick this up, please assign the task to you. I would be happy to guide you to the process.

This is something we should get back. It was removed as color attributes and textures share the same panel. We should add a new rna property to get the correct icon: * Thumbnail of the texture when the paint slot refers to an image. * Color attribute icon when the paint slot refers to a color attribute. That said it is fairly straight forward, but is not high on my priority list. I would believe that anyone with some experience in development should be able to fix this. * Texture thumbnail rendering is not removed and still available. * adding a branch base on the type of paint slot If anyone wants to pick this up, please assign the task to you. I would be happy to guide you to the process.

Philipp Oeser changed title from ~~Texture slots thumbnails in Texture painting mode are missing~~ to Regression: Texture slots thumbnails in Texture painting mode are missing

2022-09-16 15:24:20 +02:00

Philipp Oeser removed the

Download

What's New

Blender Studio

Manual

Developers Blog

Documentation

Benchmark

Blender Conference

Development Fund

One-time Donations

Regression: Texture slots thumbnails in Texture painting mode are missing #99868