Sun, Apr 22
Also, RegionEmbossSide is unused now and should be removed.
This is removing region emboss, but in the commit message you speak about area emboss. So either you removed the wrong emboss or used the wrong term :) What was your intention?
Hey and happy lekker Sunday! ;)
Sat, Apr 21
I think this depends a bit on how we want to handle scrolling in the top-bar. If we don't want any scrolling and instead do things like moving tabs into a '...' menu if there are to many to display, the second solution sounds better. If we want to make sections scrollable option one should be the way to go.
Fri, Apr 20
Thu, Apr 19
Wed, Apr 18
Forgot to add, debugged this with @Campbell Barton (campbellbarton). I wouldn't just commit such a change in makesdna without clearance ;)
Tue, Apr 17
Managing the workspaces of the workspaces.blend is actually something I hoped to allow through the new Blender settings design, see T54115.
For the records, I agree Ctrl + Q → Enter should still work, I can have a look at it after the code quest.
Mon, Apr 16
Sun, Apr 15
Fri, Apr 13
Thu, Apr 12
Mon, Apr 9
Aaand pushed. Thanks @Diego Gangl (januz)!
Sun, Apr 8
Agree, better to use a checkbox here to be clear. Don't think the drawing is clear enough really.
Am generally a bit wary of such changes in such vital functions, but think this is fine and worth trying. Only briefly tested though ;)
Don't think there's a nice way to support displaying the keymap item string in the tooltip. Only if we added support for dynamically generated operator descriptions/tooltips (which in fact might be useful to have). So for me this is good to go, even if I'd really like to have the tooltip thing working (this is a general issue in Blender though).
Fri, Apr 6
Although it doesn't completely resolve what's reported here, rB72e5082b6757e does relating changes. Would still be nice to have proper "focus" support.
Wed, Apr 4
Almost there! Functionality wise this seems to work just fine now. Just have a little more nit picking ;)
Thu, Mar 29
Was checking if we can do this more generically, e.g. in ui_block_bounds_calc_text. Doesn't seem to be possible in a nice way though, so think this approach is fine.
Mar 23 2018
Fixed by commit rB357b72e0a7d4a.
Committed rB60712d12eb89f. Thanks!
This finally landed in master! Committed rB60712d12eb89f.
Mar 22 2018
Agree that "workspaces" isn't the best term by now, but "Editors" sounds ambiguous too. Everything in this list is an editor, most even have the term in their name. Maybe something like "Main" or "General"? Or "Interaction"/"Interactive" since these are the main editors to interact with data visually. Or something like "Graphics"?
Mar 20 2018
Doubt they are related, this issue happens within the draw-manager.
Mar 19 2018
All points should be addressed now. I kept the system "General" section (contains all system settings), think that's fine, even for an initial commit to blender2.8.
- Address most minor points from review
- Revert some rather experimental changes
Mar 9 2018
Committed rB41b38c5f75b3 to avoid misleading users like it happened here.