- User Since
- Mar 12 2021, 11:34 AM (63 w, 1 d)
Mon, May 23
Apr 3 2022
Jan 5 2022
I am unable to reproduce this on current master. Would you be able to attempt to reproduce it again and share detailed steps? @Pratik Borhade (PratikPB2123) @Marco Hoo (MarcoHoo)
I also tried switching to the commit before e3748d7fa557 to see if it had been inadvertently fixed by my recent patches, but still could not get it to work.
Lastly, it's worth noting I believe the duplicate vertex issue shown in the videos above is unrelated to T86926, however the blend file @Pratik Borhade (PratikPB2123) attached seems to be reproducing the issue in T86926.
Apologies, this ticket somehow got lost in my email. Will take a look at it today.
Jan 4 2022
Thanks for the report, I can confirm that this is indeed the same root cause as T94145. I will commit a patch shortly and will merge the tasks for now.
Dec 17 2021
Dec 13 2021
Thanks for the report, I will take a look at fixing this over the Christmas period.
Nov 18 2021
Nov 9 2021
Thanks for pointing this out. I am quite busy at the moment but would like to try taking a look at this over the weekend. Before then, if anybody is interested to look into this themselves let me know/claim this task.
Nov 8 2021
Nov 1 2021
Oct 26 2021
Oct 14 2021
@Howard Trickey (howardt) If you click into the image here on phabricator and then right click save as it will give you the correct 620x620 resolution ones.
Oct 11 2021
My bad, here they are.
Thank you, all works great now.
Oct 3 2021
This works all well. The only thing is that when you input a number like 20 using the number keys, if you press any other number the input is ignored because it would be > 180. This feels slightly off to me as for example when you input 20 and then want to input 30 there is an extra number key press required which seemingly does nothing. Therefore I recommend fixing this first.
Sep 29 2021
@Hans Goudey (HooglyBoogly) Thanks for letting me know, I will follow that from now on.
Sep 28 2021
This was intended functionality. I limited the angle constraint to the range (0, 90) so that it is always acute. You can achieve all possible angles using multiples of that range.
I realise now this may be annoying as it stops you from inputting further angle constraint values and so I can fix that part of it.
Sep 27 2021
Sep 26 2021
Sep 24 2021
Sep 23 2021
Sep 22 2021
Sep 21 2021
Sep 14 2021
@Tomáš Matýs (Asterix) I have actually been working on various improvements to the knife tool over the summer as part of GSOC. Details about each can be found here: https://devtalk.blender.org/t/gsoc-2021-knife-tool-improvements-weekly-reports/.
This improvement is included amongst those and so it is probably better to abandon this revision and wait until my branch soc-2021-knife-tools is merged into master. Currently, I am working to get it merged ahead of bcon2 on 22nd of September!
Aug 2 2021
I have been working on multi-object edit mode support for the knife tool and knife project as part of my GSOC project.
Jul 10 2021
Jun 25 2021
We successfully solved the issue on blender.chat
Jun 22 2021
Jun 21 2021
Jun 14 2021
I notice a small typo in hierarchical
Jun 7 2021
@Henrik Dick (weasel) I asked @Hans Goudey (HooglyBoogly) about it but it seems they decided against adding the feature related to modifiers, meaning this still breaks clicking on a modifier panel background not setting the modifier. If I find time I will look into finding a solution that works for both.
Jun 2 2021
Apr 13 2021
Apr 12 2021
@Daniel Bystedt (dbystedt) No problem, I've added the two decimal points for the status bar display and replaced the RNA definition for the angle increment with one designed for rotation/angles which means the knife tool settings and top bar now look like so:
Apr 10 2021
@Pratik Borhade (PratikPB2123) I did indeed commit locally it would seem, this diff should have all of the correct changes.
Thanks @PatrikPB2123 I considered that however I feel it makes more sense to reset to default if the angle is set out of the bounds 0 to 90 degrees. However, if many feel this should work as you suggest I can indeed add it.
(I'm also noticing now I may have messed up this diff revision? Does it still contain my changes from my old diff? If not I have them saved locally so I can attempt to fix it)
Apr 9 2021
Mar 30 2021
For me it only works using the actual number keys along the top of the keyboard, not the numpad keys. This is intentional as such functionality is the same for tools like scale and rotate.
Sorry I realise I was unclear about that.
Mar 29 2021
Mar 24 2021
Mar 18 2021
Mar 17 2021
Mar 16 2021
From looking into it it seems to be caused by the function wm_operator_finished in wm_event_system.c being ran even if the user clicked on the hud window. I would imagine the fix for this would be to block this function from running if a hud window is being clicked? Perhaps by considering clicking anywhere within a hud window to not be a VIEW3D_OT_select operation. I'm not totally sure how to implement this but so perhaps someone more experienced can help out, however I will give it a go.
Mar 14 2021
This appears to be caused by the LISTBASE_FOREACH loop in ed_undo.c at line 930 not considering the fact that two seperate objects can have the same object data. Because of this it only increases len on the first iteration, as it then updates the id->tag of the object data. Once this tag is updated, len does not change on the second iteration. However the object in the second iteration is obact, causing r_active_index to be set incorrectly.