Page MenuHome

Cian Jinks (Hobbes)
User

Projects (10)

User Details

User Since
Mar 12 2021, 11:34 AM (63 w, 1 d)

Recent Activity

Mon, May 23

Cian Jinks (Hobbes) awarded rB690ecaae208d: Fix T97153: Knife project crashes a Love token.
Mon, May 23, 11:14 AM

Apr 3 2022

Cian Jinks (Hobbes) awarded D14518: Knife tool: Fix UI alignment in extra settings popover a Love token.
Apr 3 2022, 5:54 PM · User Interface

Jan 5 2022

Cian Jinks (Hobbes) claimed T92952: Knife tool angle constraint printout is unsynchronized with viewport drawing.
Jan 5 2022, 9:17 PM · Modeling, BF Blender
Cian Jinks (Hobbes) added a comment to T93979: Knife tool issue : create duplicate vertex unexpectedly..

I am unable to reproduce this on current master. Would you be able to attempt to reproduce it again and share detailed steps? @Pratik Borhade (PratikPB2123) @Marco Hoo (MarcoHoo)
I also tried switching to the commit before e3748d7fa557 to see if it had been inadvertently fixed by my recent patches, but still could not get it to work.
Lastly, it's worth noting I believe the duplicate vertex issue shown in the videos above is unrelated to T86926, however the blend file @Pratik Borhade (PratikPB2123) attached seems to be reproducing the issue in T86926.

Jan 5 2022, 9:12 PM · Modeling, BF Blender
Pratik Borhade (PratikPB2123) awarded rB1dc0bf86bb50: Fix T93695: Discontinuous cutting with the knife tool a Like token.
Jan 5 2022, 8:08 PM
Cian Jinks (Hobbes) updated subscribers of rB1dc0bf86bb50: Fix T93695: Discontinuous cutting with the knife tool.

@Pratik Borhade (PratikPB2123) This is also probably worth adding to a bugfix release for 3.0.0 as you mentioned in rBe3748d7fa557d3d538ab54d94b037f56fabd263e.

Jan 5 2022, 7:51 PM
Cian Jinks (Hobbes) closed T93695: Discontinuous cutting with the knife tool as Resolved by committing rB1dc0bf86bb50: Fix T93695: Discontinuous cutting with the knife tool.
Jan 5 2022, 7:46 PM · Modeling, BF Blender
Cian Jinks (Hobbes) committed rB1dc0bf86bb50: Fix T93695: Discontinuous cutting with the knife tool (authored by Cian Jinks (Hobbes)).
Fix T93695: Discontinuous cutting with the knife tool
Jan 5 2022, 7:46 PM
Cian Jinks (Hobbes) claimed T93695: Discontinuous cutting with the knife tool.

Apologies, this ticket somehow got lost in my email. Will take a look at it today.

Jan 5 2022, 1:42 PM · Modeling, BF Blender
Pratik Borhade (PratikPB2123) awarded rBe3748d7fa557: Fix T94145: Knife tool fails in orthographic mode a Like token.
Jan 5 2022, 2:26 AM

Jan 4 2022

Cian Jinks (Hobbes) claimed T93979: Knife tool issue : create duplicate vertex unexpectedly..
Jan 4 2022, 9:32 PM · Modeling, BF Blender
Cian Jinks (Hobbes) closed T94145: Knife project fails in orthographic mode as Resolved by committing rBe3748d7fa557: Fix T94145: Knife tool fails in orthographic mode.
Jan 4 2022, 9:31 PM · Modeling, BF Blender
Cian Jinks (Hobbes) committed rBe3748d7fa557: Fix T94145: Knife tool fails in orthographic mode (authored by Cian Jinks (Hobbes)).
Fix T94145: Knife tool fails in orthographic mode
Jan 4 2022, 9:31 PM
Cian Jinks (Hobbes) merged task T94313: Knife tool fails to draw cuts in orthographic mode into T94145: Knife project fails in orthographic mode.
Jan 4 2022, 9:10 PM · BF Blender, Modeling
Cian Jinks (Hobbes) merged T94313: Knife tool fails to draw cuts in orthographic mode into T94145: Knife project fails in orthographic mode.
Jan 4 2022, 9:10 PM · Modeling, BF Blender
Cian Jinks (Hobbes) added a comment to T94313: Knife tool fails to draw cuts in orthographic mode.

Thanks for the report, I can confirm that this is indeed the same root cause as T94145. I will commit a patch shortly and will merge the tasks for now.

Jan 4 2022, 9:10 PM · BF Blender, Modeling
Cian Jinks (Hobbes) claimed T94313: Knife tool fails to draw cuts in orthographic mode.
Jan 4 2022, 6:18 PM · BF Blender, Modeling
Cian Jinks (Hobbes) claimed T94145: Knife project fails in orthographic mode.
Jan 4 2022, 4:52 PM · Modeling, BF Blender

Dec 17 2021

Pratik Borhade (PratikPB2123) awarded rB6e77afe6ec7b: Applying patch D12600, GSOC Knife Tools branch a Like token.
Dec 17 2021, 12:02 PM

Dec 13 2021

Cian Jinks (Hobbes) added a comment to T93979: Knife tool issue : create duplicate vertex unexpectedly..

Thanks for the report, I will take a look at fixing this over the Christmas period.

Dec 13 2021, 1:13 PM · Modeling, BF Blender

Nov 18 2021

Mahesh Deshpande (mahesh0806) awarded rB6e77afe6ec7b: Applying patch D12600, GSOC Knife Tools branch a Love token.
Nov 18 2021, 1:07 PM

Nov 9 2021

Cian Jinks (Hobbes) added a comment to T92952: Knife tool angle constraint printout is unsynchronized with viewport drawing.

Thanks for pointing this out. I am quite busy at the moment but would like to try taking a look at this over the weekend. Before then, if anybody is interested to look into this themselves let me know/claim this task.

Nov 9 2021, 4:38 PM · Modeling, BF Blender

Nov 8 2021

Konstantins Visnevskis (kivig) awarded rB2c2d4bc3a331: Knife: Preserve right click cancel functionality a Like token.
Nov 8 2021, 11:43 PM

Nov 1 2021

Pratik Borhade (PratikPB2123) awarded rB2c2d4bc3a331: Knife: Preserve right click cancel functionality a Like token.
Nov 1 2021, 6:49 PM

Oct 26 2021

Cian Jinks (Hobbes) committed rB2c2d4bc3a331: Knife: Preserve right click cancel functionality (authored by Cian Jinks (Hobbes)).
Knife: Preserve right click cancel functionality
Oct 26 2021, 11:30 PM
Cian Jinks (Hobbes) committed rB485c634c4cda: Cleanup: Confusion with knife xray functionality (authored by Cian Jinks (Hobbes)).
Cleanup: Confusion with knife xray functionality
Oct 26 2021, 10:53 PM
Cian Jinks (Hobbes) committed rBb37caa3f0644: Fix: Knife unused function warning (authored by Cian Jinks (Hobbes)).
Fix: Knife unused function warning
Oct 26 2021, 10:24 PM
Cian Jinks (Hobbes) committed rB71fd0f7b7b0a: Fix: Knife measurements broken when a cut point is in space (authored by Cian Jinks (Hobbes)).
Fix: Knife measurements broken when a cut point is in space
Oct 26 2021, 10:14 PM

Oct 14 2021

Cian Jinks (Hobbes) added a comment to D12812: Add Knife Tool visible measurement images to documentation.

@Howard Trickey (howardt) If you click into the image here on phabricator and then right click save as it will give you the correct 620x620 resolution ones.

Oct 14 2021, 10:54 PM
Cian Jinks (Hobbes) awarded T92212: Cycles Metal device a Love token.
Oct 14 2021, 5:56 PM · Cycles, Render & Cycles

Oct 11 2021

Cian Jinks (Hobbes) closed T91785: new Knife tool. Angle constraint stucks at «9» input as Resolved by committing rBf9755add6544: Fix T91785: Change max input limit for knife tool angle snapping.
Oct 11 2021, 12:12 PM · Modeling, BF Blender
Cian Jinks (Hobbes) committed rBf9755add6544: Fix T91785: Change max input limit for knife tool angle snapping (authored by Pratik Borhade (PratikPB2123)).
Fix T91785: Change max input limit for knife tool angle snapping
Oct 11 2021, 12:12 PM
Cian Jinks (Hobbes) closed D12728: Fix T91785: Change max input limit for the angle snapping.
Oct 11 2021, 12:12 PM · Modeling
Cian Jinks (Hobbes) added a comment to D12812: Add Knife Tool visible measurement images to documentation.

My bad, here they are.

Oct 11 2021, 11:55 AM
Cian Jinks (Hobbes) accepted D12728: Fix T91785: Change max input limit for the angle snapping.

Thank you, all works great now.

Oct 11 2021, 1:13 AM · Modeling
Cian Jinks (Hobbes) requested review of D12812: Add Knife Tool visible measurement images to documentation.
Oct 11 2021, 1:03 AM

Oct 3 2021

Cian Jinks (Hobbes) requested changes to D12728: Fix T91785: Change max input limit for the angle snapping.

This works all well. The only thing is that when you input a number like 20 using the number keys, if you press any other number the input is ignored because it would be > 180. This feels slightly off to me as for example when you input 20 and then want to input 30 there is an extra number key press required which seemingly does nothing. Therefore I recommend fixing this first.

Oct 3 2021, 11:32 PM · Modeling

Sep 29 2021

Cian Jinks (Hobbes) added a comment to rBf0f70729b10e: Fix: Knife undo with no cut segments left.

@Hans Goudey (HooglyBoogly) Thanks for letting me know, I will follow that from now on.

Sep 29 2021, 11:32 AM
Ilja Razinkov (IPv6) awarded D12600: GSOC 2021 Knife Tool Improvements Project a Like token.
Sep 29 2021, 10:36 AM · Restricted Project, Modeling
Vyacheslav (hitrpr) awarded D12600: GSOC 2021 Knife Tool Improvements Project a Love token.
Sep 29 2021, 8:01 AM · Restricted Project, Modeling
Cian Jinks (Hobbes) committed rBf0f70729b10e: Fix: Knife undo with no cut segments left (authored by Cian Jinks (Hobbes)).
Fix: Knife undo with no cut segments left
Sep 29 2021, 12:10 AM

Sep 28 2021

Cian Jinks (Hobbes) committed rBefe3a13b55c0: Cleanup: Removed redundant if macro (authored by Cian Jinks (Hobbes)).
Cleanup: Removed redundant if macro
Sep 28 2021, 10:59 PM
Cian Jinks (Hobbes) added a comment to T91785: new Knife tool. Angle constraint stucks at «9» input.

This was intended functionality. I limited the angle constraint to the range (0, 90) so that it is always acute. You can achieve all possible angles using multiples of that range.
I realise now this may be annoying as it stops you from inputting further angle constraint values and so I can fix that part of it.

Sep 28 2021, 6:58 PM · Modeling, BF Blender

Sep 27 2021

Konstantins Visnevskis (kivig) awarded rB93b36fad684f: Knife: Expose XYZ axis locking in modal keymap a Like token.
Sep 27 2021, 9:31 PM
Konstantins Visnevskis (kivig) awarded D12600: GSOC 2021 Knife Tool Improvements Project a Love token.
Sep 27 2021, 9:31 PM · Restricted Project, Modeling
Pablo Vazquez (pablovazquez) awarded D12600: GSOC 2021 Knife Tool Improvements Project a Love token.
Sep 27 2021, 3:45 PM · Restricted Project, Modeling
Raimund Klink (Raimund58) awarded rB6e77afe6ec7b: Applying patch D12600, GSOC Knife Tools branch a Love token.
Sep 27 2021, 9:57 AM

Sep 26 2021

Cian Jinks (Hobbes) committed rB93b36fad684f: Knife: Expose XYZ axis locking in modal keymap (authored by Cian Jinks (Hobbes)).
Knife: Expose XYZ axis locking in modal keymap
Sep 26 2021, 11:21 PM

Sep 24 2021

Fran Marz (franMarz) awarded D12600: GSOC 2021 Knife Tool Improvements Project a Love token.
Sep 24 2021, 1:00 PM · Restricted Project, Modeling

Sep 23 2021

Cian Jinks (Hobbes) added a watcher for Modeling: Cian Jinks (Hobbes).
Sep 23 2021, 9:01 PM
Hardnax (HARDNAX) awarded D12600: GSOC 2021 Knife Tool Improvements Project a Love token.
Sep 23 2021, 2:53 PM · Restricted Project, Modeling
Vitalii Vlasov (Fracture128) awarded D12600: GSOC 2021 Knife Tool Improvements Project a Like token.
Sep 23 2021, 1:44 PM · Restricted Project, Modeling
Damian (damian) awarded D12600: GSOC 2021 Knife Tool Improvements Project a Burninate token.
Sep 23 2021, 12:42 PM · Restricted Project, Modeling
Erick Tukuniata (erickblender) awarded D12600: GSOC 2021 Knife Tool Improvements Project a Like token.
Sep 23 2021, 8:39 AM · Restricted Project, Modeling
Deen (Bit) awarded D12600: GSOC 2021 Knife Tool Improvements Project a Love token.
Sep 23 2021, 4:55 AM · Restricted Project, Modeling
Pratik Borhade (PratikPB2123) awarded D12600: GSOC 2021 Knife Tool Improvements Project a Party Time token.
Sep 23 2021, 3:28 AM · Restricted Project, Modeling
Daniel Ulrich (dulrich) awarded D12600: GSOC 2021 Knife Tool Improvements Project a Love token.
Sep 23 2021, 2:56 AM · Restricted Project, Modeling
YAFU (YAFU) awarded D12600: GSOC 2021 Knife Tool Improvements Project a Love token.
Sep 23 2021, 12:45 AM · Restricted Project, Modeling
Gavriel Lavi (Gavriel5578) awarded D12600: GSOC 2021 Knife Tool Improvements Project a Pterodactyl token.
Sep 23 2021, 12:23 AM · Restricted Project, Modeling

Sep 22 2021

Cian Jinks (Hobbes) updated the summary of D12600: GSOC 2021 Knife Tool Improvements Project.
Sep 22 2021, 4:30 PM · Restricted Project, Modeling
Cian Jinks (Hobbes) requested review of D12600: GSOC 2021 Knife Tool Improvements Project.
Sep 22 2021, 4:28 PM · Restricted Project, Modeling

Sep 21 2021

Cian Jinks (Hobbes) awarded rB08031197250a: Cycles: merge of cycles-x branch, a major update to the renderer a Love token.
Sep 21 2021, 3:41 PM

Sep 14 2021

Cian Jinks (Hobbes) added a comment to D10853: Knife Tool Constrained Angle Mode Improvement.

@Tomáš Matýs (Asterix) I have actually been working on various improvements to the knife tool over the summer as part of GSOC. Details about each can be found here: https://devtalk.blender.org/t/gsoc-2021-knife-tool-improvements-weekly-reports/.
This improvement is included amongst those and so it is probably better to abandon this revision and wait until my branch soc-2021-knife-tools is merged into master. Currently, I am working to get it merged ahead of bcon2 on 22nd of September!

Sep 14 2021, 12:20 PM · Modeling

Aug 2 2021

Cian Jinks (Hobbes) added a comment to T56948: Multi-Object-Mode: Operators that need refactor on their logic.

I have been working on multi-object edit mode support for the knife tool and knife project as part of my GSOC project.

Aug 2 2021, 4:34 PM · Modeling, BF Blender

Jul 10 2021

Cian Jinks (Hobbes) abandoned D11704: Testing local angle snapping.
Jul 10 2021, 1:46 PM

Jun 25 2021

Cian Jinks (Hobbes) requested review of D11704: Testing local angle snapping.
Jun 25 2021, 4:01 PM
Cian Jinks (Hobbes) abandoned D11669: Knife tool arc drawing test.

We successfully solved the issue on blender.chat

Jun 25 2021, 4:00 PM

Jun 22 2021

Cian Jinks (Hobbes) updated the summary of D11669: Knife tool arc drawing test.
Jun 22 2021, 12:25 PM
Cian Jinks (Hobbes) requested review of D11669: Knife tool arc drawing test.
Jun 22 2021, 12:24 PM

Jun 21 2021

Cian Jinks (Hobbes) edited P2190 Arc drawing code.
Jun 21 2021, 3:30 PM
Cian Jinks (Hobbes) created P2190 Arc drawing code.
Jun 21 2021, 3:30 PM

Jun 14 2021

Cian Jinks (Hobbes) added a comment to D11598: To fill the incomplteness of the file.

I notice a small typo in hierarchical

Jun 14 2021, 12:50 PM · Documentation

Jun 7 2021

Cian Jinks (Hobbes) added a comment to D10755: Fix T86602: Redo Last Panel in the bottom left disappears on left click (regression).

@Henrik Dick (weasel) I asked @Hans Goudey (HooglyBoogly) about it but it seems they decided against adding the feature related to modifiers, meaning this still breaks clicking on a modifier panel background not setting the modifier. If I find time I will look into finding a solution that works for both.

Jun 7 2021, 5:03 PM · User Interface

Jun 2 2021

Cian Jinks (Hobbes) awarded D11462: Workaround for gcc 11 compiler bug. a Like token.
Jun 2 2021, 5:07 PM

Apr 13 2021

Cian Jinks (Hobbes) added a project to D10853: Knife Tool Constrained Angle Mode Improvement: Modeling.
Apr 13 2021, 12:25 PM · Modeling

Apr 12 2021

Cian Jinks (Hobbes) updated the diff for D10853: Knife Tool Constrained Angle Mode Improvement.

@Daniel Bystedt (dbystedt) No problem, I've added the two decimal points for the status bar display and replaced the RNA definition for the angle increment with one designed for rotation/angles which means the knife tool settings and top bar now look like so:

Apr 12 2021, 5:46 PM · Modeling

Apr 10 2021

Cian Jinks (Hobbes) updated the diff for D10853: Knife Tool Constrained Angle Mode Improvement.

@Pratik Borhade (PratikPB2123) I did indeed commit locally it would seem, this diff should have all of the correct changes.

Apr 10 2021, 5:56 PM · Modeling
Cian Jinks (Hobbes) added a comment to D10853: Knife Tool Constrained Angle Mode Improvement.

Thanks @PatrikPB2123 I considered that however I feel it makes more sense to reset to default if the angle is set out of the bounds 0 to 90 degrees. However, if many feel this should work as you suggest I can indeed add it.
(I'm also noticing now I may have messed up this diff revision? Does it still contain my changes from my old diff? If not I have them saved locally so I can attempt to fix it)

Apr 10 2021, 2:09 PM · Modeling
Pratik Borhade (PratikPB2123) awarded D10853: Knife Tool Constrained Angle Mode Improvement a Like token.
Apr 10 2021, 7:32 AM · Modeling

Apr 9 2021

Cian Jinks (Hobbes) updated the diff for D10853: Knife Tool Constrained Angle Mode Improvement.

Thank you so much for the feedback @Campbell Barton (campbellbarton) @Daniel Bystedt (dbystedt) ! I've implemented the following list of changes (copied from your comments):

Apr 9 2021, 11:32 PM · Modeling

Mar 30 2021

Cian Jinks (Hobbes) added a comment to D10853: Knife Tool Constrained Angle Mode Improvement.

For me it only works using the actual number keys along the top of the keyboard, not the numpad keys. This is intentional as such functionality is the same for tools like scale and rotate.
Sorry I realise I was unclear about that.

Mar 30 2021, 1:18 PM · Modeling

Mar 29 2021

Cian Jinks (Hobbes) requested review of D10853: Knife Tool Constrained Angle Mode Improvement.
Mar 29 2021, 2:03 PM · Modeling

Mar 24 2021

Cian Jinks (Hobbes) updated the task description for T86893: Measure tool undo repitition.
Mar 24 2021, 1:13 PM · Restricted Project, Core, BF Blender
Cian Jinks (Hobbes) created T86893: Measure tool undo repitition.
Mar 24 2021, 1:06 PM · Restricted Project, Core, BF Blender

Mar 18 2021

Cian Jinks (Hobbes) added a comment to D10755: Fix T86602: Redo Last Panel in the bottom left disappears on left click (regression).

Sounds great!

Mar 18 2021, 11:31 PM · User Interface
Henrik Dick (weasel) awarded D10755: Fix T86602: Redo Last Panel in the bottom left disappears on left click (regression) a Love token.
Mar 18 2021, 12:21 AM · User Interface

Mar 17 2021

Cian Jinks (Hobbes) added a revision to T86022: 3D View: mouse clicks pass through interface: D10755: Fix T86602: Redo Last Panel in the bottom left disappears on left click (regression).
Mar 17 2021, 10:33 PM · User Interface, BF Blender
Cian Jinks (Hobbes) added a revision to T86602: Redo Last Panel in the bottom left disappears on left click (regression): D10755: Fix T86602: Redo Last Panel in the bottom left disappears on left click (regression).
Mar 17 2021, 10:33 PM · User Interface, BF Blender
Cian Jinks (Hobbes) added tasks to D10755: Fix T86602: Redo Last Panel in the bottom left disappears on left click (regression): T86602: Redo Last Panel in the bottom left disappears on left click (regression), T86022: 3D View: mouse clicks pass through interface.
Mar 17 2021, 10:33 PM · User Interface
Cian Jinks (Hobbes) requested review of D10755: Fix T86602: Redo Last Panel in the bottom left disappears on left click (regression).
Mar 17 2021, 10:28 PM · User Interface
Cian Jinks (Hobbes) claimed T86602: Redo Last Panel in the bottom left disappears on left click (regression).
Mar 17 2021, 5:07 PM · User Interface, BF Blender

Mar 16 2021

Cian Jinks (Hobbes) added a comment to T86602: Redo Last Panel in the bottom left disappears on left click (regression).

From looking into it it seems to be caused by the function wm_operator_finished in wm_event_system.c being ran even if the user clicked on the hud window. I would imagine the fix for this would be to block this function from running if a hud window is being clicked? Perhaps by considering clicking anywhere within a hud window to not be a VIEW3D_OT_select operation. I'm not totally sure how to implement this but so perhaps someone more experienced can help out, however I will give it a go.

Mar 16 2021, 10:25 PM · User Interface, BF Blender

Mar 14 2021

Cian Jinks (Hobbes) added a revision to T86561: Crash when entering edit mode with multiple objects sharing the same mesh: D10720: Fix T86561: Crash when entering edit mode with multiple objects sharing the same mesh.
Mar 14 2021, 4:48 PM · Core, BF Blender
Cian Jinks (Hobbes) added a task to D10720: Fix T86561: Crash when entering edit mode with multiple objects sharing the same mesh: T86561: Crash when entering edit mode with multiple objects sharing the same mesh.
Mar 14 2021, 4:48 PM
Cian Jinks (Hobbes) requested review of D10720: Fix T86561: Crash when entering edit mode with multiple objects sharing the same mesh.
Mar 14 2021, 4:43 PM
Cian Jinks (Hobbes) added a comment to T86561: Crash when entering edit mode with multiple objects sharing the same mesh.

This appears to be caused by the LISTBASE_FOREACH loop in ed_undo.c at line 930 not considering the fact that two seperate objects can have the same object data. Because of this it only increases len on the first iteration, as it then updates the id->tag of the object data. Once this tag is updated, len does not change on the second iteration. However the object in the second iteration is obact, causing r_active_index to be set incorrectly.

Mar 14 2021, 1:46 PM · Core, BF Blender