Page MenuHome

Cian Jinks (Hobbes)
User

Projects

User does not belong to any projects.

User Details

User Since
Mar 12 2021, 11:34 AM (4 w, 3 d)

Recent Activity

Yesterday

Cian Jinks (Hobbes) updated the diff for D10853: Knife Tool Constrained Angle Mode Improvement.

@Daniel Bystedt (dbystedt) No problem, I've added the two decimal points for the status bar display and replaced the RNA definition for the angle increment with one designed for rotation/angles which means the knife tool settings and top bar now look like so:

Mon, Apr 12, 5:46 PM

Sat, Apr 10

Cian Jinks (Hobbes) updated the diff for D10853: Knife Tool Constrained Angle Mode Improvement.

@Pratik Borhade (PratikPB2123) I did indeed commit locally it would seem, this diff should have all of the correct changes.

Sat, Apr 10, 5:56 PM
Cian Jinks (Hobbes) added a comment to D10853: Knife Tool Constrained Angle Mode Improvement.

Thanks @PatrikPB2123 I considered that however I feel it makes more sense to reset to default if the angle is set out of the bounds 0 to 90 degrees. However, if many feel this should work as you suggest I can indeed add it.
(I'm also noticing now I may have messed up this diff revision? Does it still contain my changes from my old diff? If not I have them saved locally so I can attempt to fix it)

Sat, Apr 10, 2:09 PM
Pratik Borhade (PratikPB2123) awarded D10853: Knife Tool Constrained Angle Mode Improvement a Like token.
Sat, Apr 10, 7:32 AM

Fri, Apr 9

Cian Jinks (Hobbes) updated the diff for D10853: Knife Tool Constrained Angle Mode Improvement.

Thank you so much for the feedback @Campbell Barton (campbellbarton) @Daniel Bystedt (dbystedt) ! I've implemented the following list of changes (copied from your comments):

Fri, Apr 9, 11:32 PM

Tue, Mar 30

Cian Jinks (Hobbes) added a comment to D10853: Knife Tool Constrained Angle Mode Improvement.

For me it only works using the actual number keys along the top of the keyboard, not the numpad keys. This is intentional as such functionality is the same for tools like scale and rotate.
Sorry I realise I was unclear about that.

Tue, Mar 30, 1:18 PM

Mon, Mar 29

Cian Jinks (Hobbes) requested review of D10853: Knife Tool Constrained Angle Mode Improvement.
Mon, Mar 29, 2:03 PM

Wed, Mar 24

Cian Jinks (Hobbes) updated the task description for T86893: Measure tool undo repitition.
Wed, Mar 24, 1:13 PM · Core, BF Blender
Cian Jinks (Hobbes) created T86893: Measure tool undo repitition.
Wed, Mar 24, 1:06 PM · Core, BF Blender

Thu, Mar 18

Cian Jinks (Hobbes) added a comment to D10755: Fix T86602: Redo Last Panel in the bottom left disappears on left click (regression).

Sounds great!

Thu, Mar 18, 11:31 PM · User Interface
Henrik Dick (weasel) awarded D10755: Fix T86602: Redo Last Panel in the bottom left disappears on left click (regression) a Love token.
Thu, Mar 18, 12:21 AM · User Interface

Wed, Mar 17

Cian Jinks (Hobbes) added a revision to T86022: 3D View: mouse clicks pass through interface: D10755: Fix T86602: Redo Last Panel in the bottom left disappears on left click (regression).
Wed, Mar 17, 10:33 PM · User Interface, BF Blender
Cian Jinks (Hobbes) added a revision to T86602: Redo Last Panel in the bottom left disappears on left click (regression): D10755: Fix T86602: Redo Last Panel in the bottom left disappears on left click (regression).
Wed, Mar 17, 10:33 PM · User Interface, BF Blender
Cian Jinks (Hobbes) added tasks to D10755: Fix T86602: Redo Last Panel in the bottom left disappears on left click (regression): T86602: Redo Last Panel in the bottom left disappears on left click (regression), T86022: 3D View: mouse clicks pass through interface.
Wed, Mar 17, 10:33 PM · User Interface
Cian Jinks (Hobbes) requested review of D10755: Fix T86602: Redo Last Panel in the bottom left disappears on left click (regression).
Wed, Mar 17, 10:28 PM · User Interface
Cian Jinks (Hobbes) claimed T86602: Redo Last Panel in the bottom left disappears on left click (regression).
Wed, Mar 17, 5:07 PM · User Interface, BF Blender

Tue, Mar 16

Cian Jinks (Hobbes) added a comment to T86602: Redo Last Panel in the bottom left disappears on left click (regression).

From looking into it it seems to be caused by the function wm_operator_finished in wm_event_system.c being ran even if the user clicked on the hud window. I would imagine the fix for this would be to block this function from running if a hud window is being clicked? Perhaps by considering clicking anywhere within a hud window to not be a VIEW3D_OT_select operation. I'm not totally sure how to implement this but so perhaps someone more experienced can help out, however I will give it a go.

Tue, Mar 16, 10:25 PM · User Interface, BF Blender

Sun, Mar 14

Cian Jinks (Hobbes) added a revision to T86561: Crash when entering edit mode with multiple objects sharing the same mesh: D10720: Fix T86561: Crash when entering edit mode with multiple objects sharing the same mesh.
Sun, Mar 14, 4:48 PM · Core, BF Blender
Cian Jinks (Hobbes) added a task to D10720: Fix T86561: Crash when entering edit mode with multiple objects sharing the same mesh: T86561: Crash when entering edit mode with multiple objects sharing the same mesh.
Sun, Mar 14, 4:48 PM
Cian Jinks (Hobbes) requested review of D10720: Fix T86561: Crash when entering edit mode with multiple objects sharing the same mesh.
Sun, Mar 14, 4:43 PM
Cian Jinks (Hobbes) added a comment to T86561: Crash when entering edit mode with multiple objects sharing the same mesh.

This appears to be caused by the LISTBASE_FOREACH loop in ed_undo.c at line 930 not considering the fact that two seperate objects can have the same object data. Because of this it only increases len on the first iteration, as it then updates the id->tag of the object data. Once this tag is updated, len does not change on the second iteration. However the object in the second iteration is obact, causing r_active_index to be set incorrectly.

Sun, Mar 14, 1:46 PM · Core, BF Blender