- User Since
- Jan 28 2019, 8:02 PM (95 w, 1 h)
Thanks for the report and for testing! : ) I'm going to close this though, since I know about this, and the active modifier idea is still a work in progress.
Sat, Nov 21
In order to look into this we need a more detailed description of your exact steps, the outcome, and how it compared to your expectations.
Aha, this is a trick file!
Thanks for the report. I can reproduce the crash with your file, but not if I reproduce the same set of node myself.
Fri, Nov 20
I agree this looks a lot better!
You put the link to Julian's commit in the description, but could you explain how this patch relates to that commit more clearly? Just the link isn't very helpful.
The bigger notes are about the poll functions and the particle system copying.
Code looks good, and it works for the use case of showing unselectable objects.
This change was committed with the category changes, so I'm closing this. Thanks for looking at these details though.
Oops, this is actually resolved with rB256e77c987d2: Fix T82833: GreasePencil crash when changing to Vertex Color mode
The worked and broken range is quite helpful, thanks. I bisected and found this is caused by caused by rB0688309988e5: Fix undo UI text containing shortcuts & newlines. but->tip is NULL in ui_but_tip_len_only_first_line.
Thu, Nov 19
I can reproduce the crash in your test file. I'll look into fixing this in a few minutes.
Thanks for the report. Without any indication of what causes this it's not possible for us to investigate it though. If you do get more information please update this report.
Wed, Nov 18
I haven't looked into this at all, but my hunch is that there should be a way to pass around a pointer the enum property or its items when exposing to a group. Since this is already done for RNA sub-types maybe it won't be so bad.
Tue, Nov 17
In that case I'll close this report. Thanks for reporting anyway. And like you say, just make another report if the problem comes up again.
Mon, Nov 16
Sun, Nov 15
This works for me. Thanks.
Sat, Nov 14
This looks works great, and the highlight with the border to replace the arrow looks so good!
Fri, Nov 13
Hey, sorry to bug again, but I don't think this was the correct solution to this warning, because this function is passed as a pointer to another below in this file:
/home/hans/Documents/Blender-Git/blender/source/blender/draw/intern/draw_cache_impl_gpencil.c:889:27: warning: passing argument 4 of ‘BKE_gpencil_visible_stroke_iter’ from incompatible pointer type [-Wincompatible-pointer-types] 889 | NULL, ob, NULL, gpencil_edit_curve_stroke_iter_cb, &iter, false, cfra); | ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~ | | | void (*)(bGPDlayer *, bGPDstroke *, void *)
After this commit I get a crash when starting curve edit mode.
I think some sort of viewer option for a node might be more effective at doing this.
This has been resolved!
I don't mean removing the whole enum, just the old flag if it was never actually used. But either way it doesn't really matter.
I think this is an improvement too. It's nice to make it clear that there is more word to see when the text that actually gets displayed looks like it could be some word.
I do think the layout looks a bit better, nice design here.
Why not remove split_angle from DNA too?
Getting there! Some of these comments apply to both types of modifiers (I wish gpencil modifiers were just modifiers, oh well..), I trust you'll apply the changes in both places if they apply : )
Thu, Nov 12
I like this idea! Just a few comments, but this looks pretty good. I didn't test it though.