- User Since
- Jan 28 2019, 8:02 PM (45 w, 1 d)
Thu, Dec 5
Thanks for the bug report! At this point though that is a known limitation of the current boolean algorithm. There's a new one being worked on right now (in the "newboolean" branch) that will handle these cases.
Wed, Dec 4
How about "Rounds corners by adding geometry to the mesh's edges and vertices"
I think bevel might be better described by "Cuts or removes volume from the mesh's edges and corners" or "Cuts or add geometry to the mesh's edges and corners"
Tue, Dec 3
Is the wording of these tooltips flexible? I'm noticing some inconsistencies with the way most other tooltips read. Maybe it would make sense to do a pass on them for that.
Mon, Nov 25
Sat, Nov 23
I really am not sure why the text editor cursor is red anyway. The cursor everywhere else in Blender is colored by the theme to be a blue that goes well with everything else in the interface.
Thu, Nov 21
Wed, Nov 20
Addressed final comments
That right side looks quite a bit better, I agree.
Mon, Nov 18
Hi, we can't do anything with this report as it doesn't have all the requested information. Instead of "green thing" and "blue thing" could you use more precise words?
@Jeroen Bakker (jbakker) Interesting. I was under the impression that AMD was working ROCm as an open source answer to CUDA and a replacement to their proprietary OpenCL driver stack. I also don't have a great understanding of this landscape and I haven't found much material out there about it.
Fri, Nov 15
Here's that. Yeah I guess the whole situation isn't ideal, but I'm curious to see how it works out.
Thu, Nov 14
Can I ask if you're using ROCm to test this?
They are small things, but the code formatting is one thing you will probably need to think about. I would run make format with the files you've changed as arguments, that should standardize the formatting.
Wed, Nov 13
This is the simpler test case I've been using. I've found that the error is in the offset_meet function, where I think it's not set up to properly handle this sequence of edge directions and face normals.
The difference between the sides is that when placing the "boundary vertices" bevel goes around each vertex counterclockwise.
At the error, build_boundary travels starting at the highlighted middle edge until it reaches the other highlighted edge in the X direction.
This specific sequence of directions means that offset_meet ends up trying to intersect the two thicker lines to try to find where to put the boundary vertex.
Normally that would be great but the thicker blue line isn't in the right location, so it ends up averaging the closest points on each of the lines.
Tue, Nov 12
Mon, Nov 11
Nov 9 2019
I've run into problems with this card too. Even with the the proprietary drivers installed on Ubuntu 18.04 like is suggested the performance is quite poor when editing in the viewport while rendering. Things that never create issues in either macOS or Windows with the same card. This is really disappointing. I'm hoping that with AMD's support of Blender on the development fund that these issues will begin to improve in the future. Ideally rocm would get better performance with Blender openCL, because that seems to be the future for compute on AMD GPUs.
Nov 8 2019
Addressed comments from review
Nov 6 2019
Pardon the inverted colors, here's a quick demo.
Commented out repface to avoid warning. (Issue should be solved, but low priority and needs input)
Updated against latest master
Nov 5 2019
I can confirm this too, definitely a bug. I'll look into it and see what I can find.
Nov 2 2019
Oct 20 2019
Oct 15 2019
For the ToolSettings comment, I also agree it would preferable to store the ProfileCurve specifically for the operator. I haven't changed that yet but I'll look into it.
- Renamed ProfileWidget -> ProfileCurve. I used ProfileCurve instead of CurveProfile to give emphasis to the word "Profile" rather than "Curve." Although this doesn't mirror CurveMapping quite as well, I think it's a better name. It keeps the data separate from the UI, and it's clear that it's not a profiling tool.
- ProfilePoint: Store handle type for left and right handle separately from the flag.
- Other renamed functions
Oct 14 2019
Oct 8 2019
@Julian Eisel (Severin) With rounded corners those boxes could look great! It also emphasizes how you can drag them around which isn't totally apparent otherwise.
Oct 7 2019
Oct 3 2019
Sep 28 2019
Sep 25 2019
After looking through many of the bevel test results manually, I haven't been able to visually confirm many of the failed operations. The test reports that there is a "Vertex Coordinate Mismatch," but all the vertices I've checked are in the correct locations, and their indexing has been the same as well.
Sep 24 2019
It also looks like the automated bevel test is failing: https://builder.blender.org/admin/#/builders/16/builds/250/steps/4/logs/stdio
Adding the Profile Widget instead of expanding the CurveMapping Widget
I wanted to write down the justification for having a new profile widget, because I think that's one thing reviewers could wonder about. One thing I considered at the beginning if the project was adding this functionality to the CurveMapping widget, but I decided not to for these reasons:
- Better tooltips The use cases of the two widgets are quite different. Different RNA for the two widgets means the tooltips can be specific to the function.
- Each widget is simpler with fewer cases It will be much easier in the future to add features and fix problems with the two widgets if the code for each is simpler. It will be easier to make the profile widget mirror a curve object in the future because of this.
- Completely different evaluation paradigm For the profile widget, the evaluation / sampling code matters much more, because it directly controls the final mesh, whereas the evaluation of a CurveMapping widgey is a behind the scenes operation. But more importantly, evaluating the profile widget returns a pair of coordinates, not just a Y value.
- Overhangs Because the profile isn't a mapping from X to Y, it has to be drawn and evaluated differently. Adding this complication to the CurveMapping widget would unecessarily increase its complexity.
- New potential use cases for the Profile Widet The profile widget could be used to bring more power to any generated mesh (possibly curves, wireframes..) And it's accessible from Python so any addon can use it.
(Using the right diff this time)
- Responded / fixed comments from review
Sep 22 2019
Sep 19 2019
Oops. Next time I'll add the revision to the commit message,.
Yeah, there's always the battle between convenience (having properties everywhere they might be useful) and organization (keeping only a type of property in a single place.
Hmm, I see "Construct" in the tooltip for every built in add-mesh operator.
I'd be happy to change the others to "Add," I think it's a better word anyway, but it seemed simplest just to fix this inconsistency.
Well the bevel active tool doesn't use the bevel weights, so I'm not sure why it would make sense to have them in the same location. Plus they're very different things-- one is the options for the operation you're about to do with the tool, and one is used to control data attached to edges.
Sep 18 2019
If I understand you correctly, that's separate from the Bevel active tool. The bevel weight is in the "Item" tab of the viewport side panel.
You propose using the average normal for the direction of some of the gizmos. I'm curious what you'd propose doing about situations where the average normal doesn't make sense. For example, the average normal of a cube or a sphere would be zero, and anything close to that would have a nonsensical gizmo direction. Maybe more individual handles would work?
Sep 17 2019
Sep 14 2019
- Merged lastest master
Sep 12 2019
Sep 11 2019
- Merge with latest master
- Removed changes unrelated to patch incorrectly included in last merge
Sep 10 2019
- Updated to current master
Sep 8 2019
Aug 26 2019
Aug 19 2019
Aug 18 2019
- Comment format updates to align with style guide.
- Removed extra profile orientation regularization code.
- Revert change to default bevel width.
Aug 17 2019
Aug 15 2019
Those reasons make sense IMO, even though I will always leave it enabled.