Page MenuHome

Jacques Lucke (JacquesLucke)
User

Projects (16)

User Details

User Since
Nov 18 2013, 5:57 PM (444 w, 8 h)

Recent Activity

Yesterday

Jacques Lucke (JacquesLucke) updated the summary of D14934: Curves: Add float selection in sculpt mode.
Mon, May 23, 3:34 PM · Geometry Nodes
Jacques Lucke (JacquesLucke) added a comment to T95776: How to attach hair to a surface.

Based on the different arguments mentioned in https://hackmd.io/@II9-Bkl4TJifCqGL2jgbUw/BkZ-b7Bv9, I come to the conclusion that we should use a rest_position attribute on the surface.
Working with surface_rest_position and surface_rest_orientation attributes on curves has some benefits in some use-cases and could be added later if there is need for it.

Mon, May 23, 3:16 PM · Geometry Nodes
Jacques Lucke (JacquesLucke) committed rB2f2d13b8c664: Fix T97237: dragging custom node group asset adds broken node (authored by Jacques Lucke (JacquesLucke)).
Fix T97237: dragging custom node group asset adds broken node
Mon, May 23, 2:44 PM
Jacques Lucke (JacquesLucke) closed T97237: Asset Browser: dragging custom node group asset adds broken node as Resolved by committing rB2f2d13b8c664: Fix T97237: dragging custom node group asset adds broken node.
Mon, May 23, 2:44 PM · BF Blender (3.2), Pipeline, Assets & I/O, Nodes & Physics, Asset Browser
Jacques Lucke (JacquesLucke) closed D15013: Fix T97237: Disable add node group operator for custom node trees..
Mon, May 23, 2:44 PM
Jacques Lucke (JacquesLucke) updated the diff for D15013: Fix T97237: Disable add node group operator for custom node trees..
  • fix typo
Mon, May 23, 2:23 PM
Jacques Lucke (JacquesLucke) accepted D14916: EEVEE/Workbench: support Curves attributes rendering.

I have a few more small comments, but overall looks good to me. I'm also accepting in the name of Hans, since he is on holidays and his concern has been addressed.

Mon, May 23, 2:18 PM · EEVEE & Viewport
Jacques Lucke (JacquesLucke) updated the diff for D15013: Fix T97237: Disable add node group operator for custom node trees..
  • Merge branch 'blender-v3.2-release' into custom-node-group-asset
  • improve operator poll
Mon, May 23, 12:54 PM
Jacques Lucke (JacquesLucke) accepted D15011: Cleanup: Simplify custom data file writing process.
Mon, May 23, 12:44 PM
Jacques Lucke (JacquesLucke) requested changes to D14760: Mesh: Add an explicit "positions changed" function.
Mon, May 23, 11:59 AM · Geometry Nodes, Modeling
Jacques Lucke (JacquesLucke) added a comment to T97408: Converting the color attribute causes undo to fail.

It should be noted that this is a problem specifically with sculpt-undo. When I convert the layer and undo while I'm in object mode, it works fine.
There is a comment /* Memfile undo killed the layer; re-create it. */ which begs the question why undo killed the layer in the first place.

Mon, May 23, 11:49 AM · Restricted Project, Sculpt, Paint & Texture, BF Blender
Jacques Lucke (JacquesLucke) committed rBa5409d2b5941: Fix T98316: geometry nodes stop updating after duplication (authored by Jacques Lucke (JacquesLucke)).
Fix T98316: geometry nodes stop updating after duplication
Mon, May 23, 11:30 AM
Jacques Lucke (JacquesLucke) closed T98316: Regression: Geometry Node Tree Stop Update Upon Duplication as Resolved by committing rBa5409d2b5941: Fix T98316: geometry nodes stop updating after duplication.
Mon, May 23, 11:30 AM · Animation & Rigging, Nodes & Physics, Geometry Nodes, BF Blender
Jacques Lucke (JacquesLucke) claimed T97237: Asset Browser: dragging custom node group asset adds broken node.
Mon, May 23, 11:15 AM · BF Blender (3.2), Pipeline, Assets & I/O, Nodes & Physics, Asset Browser
Jacques Lucke (JacquesLucke) added a revision to T97237: Asset Browser: dragging custom node group asset adds broken node: D15013: Fix T97237: Disable add node group operator for custom node trees..
Mon, May 23, 11:14 AM · BF Blender (3.2), Pipeline, Assets & I/O, Nodes & Physics, Asset Browser
Jacques Lucke (JacquesLucke) added a task to D15013: Fix T97237: Disable add node group operator for custom node trees.: T97237: Asset Browser: dragging custom node group asset adds broken node.
Mon, May 23, 11:14 AM
Jacques Lucke (JacquesLucke) added a reviewer for D15013: Fix T97237: Disable add node group operator for custom node trees.: Julian Eisel (Severin).
Mon, May 23, 11:14 AM
Jacques Lucke (JacquesLucke) updated the summary of D15013: Fix T97237: Disable add node group operator for custom node trees..
Mon, May 23, 11:14 AM
Jacques Lucke (JacquesLucke) requested review of D15013: Fix T97237: Disable add node group operator for custom node trees..
Mon, May 23, 11:11 AM
Jacques Lucke (JacquesLucke) closed T98298: Regression: Attribute capture yields broken results as Archived.

From what I can tell, the Attribute Capture node works perfectly fine here (check with the Viewer node in the spreadsheet).
The problem is that the Mesh to Curve node expects an edge selection, however you provide a point attribute. That's generally not an issue, because the node would just interpolate the point to an edge attribute, but in this specific case the interpolation does not do what you want.

Mon, May 23, 10:40 AM · Geometry Nodes, Nodes & Physics, BF Blender
Jacques Lucke (JacquesLucke) added a comment to T98076: Regression: Particle mirror broken for particular mirrored mesh..

Hmm, difficult. The change is caused storing correctly normalized coordinates in CD_ORCO instead of unnormalized coordinates (in MOD_deform_mesh_eval_get). Still not sure at which level this can be fixed unfortunately..

Mon, May 23, 10:08 AM · Nodes & Physics, BF Blender
Jacques Lucke (JacquesLucke) accepted D14944: Fix T98101: Handle single point curves in delete brush.
Mon, May 23, 9:40 AM · Geometry Nodes
Jacques Lucke (JacquesLucke) accepted D15002: Fix: Sample pressure properly for 3D curves sculpt brushes.
Mon, May 23, 9:38 AM · Geometry Nodes
Jacques Lucke (JacquesLucke) added a comment to T97237: Asset Browser: dragging custom node group asset adds broken node.

The issue is that node_add_group_exec does not know what type of node to add. It usually determines the node type by calling node_group_idname, but that only works for built-in tree types.
Note, the fix for the very specific example case is to just return "CustomNodeType" from node_group_idname in the default case, but that's not a generic fix obviously.

Mon, May 23, 9:32 AM · BF Blender (3.2), Pipeline, Assets & I/O, Nodes & Physics, Asset Browser
Jacques Lucke (JacquesLucke) closed T98231: Regression: Material Output inside node group not working if there is a Group Output Node as Resolved by committing rBb81f1b8cf171: Fix T98231: missing update when material output is in group.
Mon, May 23, 9:12 AM · Nodes & Physics, BF Blender
Jacques Lucke (JacquesLucke) committed rBb81f1b8cf171: Fix T98231: missing update when material output is in group (authored by Jacques Lucke (JacquesLucke)).
Fix T98231: missing update when material output is in group
Mon, May 23, 9:12 AM
Jacques Lucke (JacquesLucke) closed D14998: Fix T98231: missing updates when material output is in group.
Mon, May 23, 9:12 AM

Sun, May 22

Jacques Lucke (JacquesLucke) added a comment to D15009: Functions: Speedup preparing multi-function parameters..

Why is the latter necessary when the named constructor already exists?

Sun, May 22, 5:05 PM
Jacques Lucke (JacquesLucke) added a reviewer for D15009: Functions: Speedup preparing multi-function parameters.: Hans Goudey (HooglyBoogly).
Sun, May 22, 3:32 PM
Jacques Lucke (JacquesLucke) updated the summary of D15009: Functions: Speedup preparing multi-function parameters..
Sun, May 22, 3:31 PM
Jacques Lucke (JacquesLucke) updated the diff for D15009: Functions: Speedup preparing multi-function parameters..
  • cleanup
Sun, May 22, 3:30 PM
Jacques Lucke (JacquesLucke) updated the summary of D15009: Functions: Speedup preparing multi-function parameters..
Sun, May 22, 3:30 PM
Jacques Lucke (JacquesLucke) requested review of D15009: Functions: Speedup preparing multi-function parameters..
Sun, May 22, 3:26 PM
Jacques Lucke (JacquesLucke) created P2967 (An Untitled Masterwork).
Sun, May 22, 2:11 PM
Jacques Lucke (JacquesLucke) committed rBfdb1f7046870: Cleanup: fix wrong type (authored by Jacques Lucke (JacquesLucke)).
Cleanup: fix wrong type
Sun, May 22, 12:01 PM

Sat, May 21

Jacques Lucke (JacquesLucke) added a comment to T98231: Regression: Material Output inside node group not working if there is a Group Output Node.

I don't like it either, but it's not something we can break now. It's used quite a lot in practice.

Sat, May 21, 4:41 PM · Nodes & Physics, BF Blender
Jacques Lucke (JacquesLucke) added a comment to D14993: BLI: Use no_unique_address attribute..

Ok, check other compilers we support. Found that clang 8 compiles, but generates warnings: https://godbolt.org/z/MGcd5eMMe
Since we still support clang 8 (https://wiki.blender.org/wiki/Building_Blender#Compiler_Versions), it would be good to check for that somehow. Not sure where the right place for that check would be. I couldn't find similar checks for clang right now.

Sat, May 21, 9:21 AM

Fri, May 20

Jacques Lucke (JacquesLucke) added a comment to T95776: How to attach hair to a surface.

Started writing some notes about the different arguments for using rest_position on the surface vs. using surface_rest_position and surface_rest_orientation on curves: https://hackmd.io/@II9-Bkl4TJifCqGL2jgbUw/BkZ-b7Bv9

Fri, May 20, 9:33 PM · Geometry Nodes
Jacques Lucke (JacquesLucke) added a comment to D14993: BLI: Use no_unique_address attribute..

I'm not sure a guard is necessary.

Fri, May 20, 5:12 PM
Jacques Lucke (JacquesLucke) updated the diff for D14993: BLI: Use no_unique_address attribute..
  • Merge branch 'master' into no-unique-address
Fri, May 20, 4:32 PM
Jacques Lucke (JacquesLucke) committed rBde561280fc0b: Cleanup: don't use variable name that matches type alias (authored by Jacques Lucke (JacquesLucke)).
Cleanup: don't use variable name that matches type alias
Fri, May 20, 4:32 PM
Jacques Lucke (JacquesLucke) updated the diff for D14993: BLI: Use no_unique_address attribute..
  • more cases
  • use macro for msvc support
Fri, May 20, 4:30 PM
Jacques Lucke (JacquesLucke) claimed T98231: Regression: Material Output inside node group not working if there is a Group Output Node.
Fri, May 20, 2:38 PM · Nodes & Physics, BF Blender
Jacques Lucke (JacquesLucke) added a reviewer for D14998: Fix T98231: missing updates when material output is in group: Hans Goudey (HooglyBoogly).
Fri, May 20, 2:37 PM
Jacques Lucke (JacquesLucke) updated the summary of D14998: Fix T98231: missing updates when material output is in group.
Fri, May 20, 2:37 PM
Jacques Lucke (JacquesLucke) added a revision to T98231: Regression: Material Output inside node group not working if there is a Group Output Node: D14998: Fix T98231: missing updates when material output is in group.
Fri, May 20, 2:34 PM · Nodes & Physics, BF Blender
Jacques Lucke (JacquesLucke) added a task to D14998: Fix T98231: missing updates when material output is in group: T98231: Regression: Material Output inside node group not working if there is a Group Output Node.
Fri, May 20, 2:34 PM
Jacques Lucke (JacquesLucke) requested review of D14998: Fix T98231: missing updates when material output is in group.
Fri, May 20, 2:34 PM
Jacques Lucke (JacquesLucke) updated the summary of D14993: BLI: Use no_unique_address attribute..
Fri, May 20, 1:43 PM
Jacques Lucke (JacquesLucke) added a comment to T98231: Regression: Material Output inside node group not working if there is a Group Output Node.

The current behavior is described in the is_output_node method. Will try to implement the todo comment there, with some luck that will solve the issue.

Fri, May 20, 1:20 PM · Nodes & Physics, BF Blender
Jacques Lucke (JacquesLucke) accepted D14996: Curves: Support pressure in sculpt brushes.
Fri, May 20, 1:12 PM · Geometry Nodes
Jacques Lucke (JacquesLucke) accepted D14992: Curves: Use only current brush location for delete brush.
Fri, May 20, 1:10 PM · Geometry Nodes
Jacques Lucke (JacquesLucke) added a comment to T98272: Regression: Physics force field strength affect varies inversely proportion to physics substeps per frame.

It seems like the issue is that the beginning of btDiscreteDynamicsWorld::stepSimulation computes that there should only be one subset. clampedSimulationSteps always ends up being 1 for me. I don't really know why that is yet. The meaning of the timeStep and fixedTimeStep input to the function is not clear to me.

Fri, May 20, 1:07 PM · Nodes & Physics, BF Blender
Jacques Lucke (JacquesLucke) added inline comments to D14992: Curves: Use only current brush location for delete brush.
Fri, May 20, 12:55 PM · Geometry Nodes
Jacques Lucke (JacquesLucke) requested changes to D14992: Curves: Use only current brush location for delete brush.
Fri, May 20, 12:37 PM · Geometry Nodes
Jacques Lucke (JacquesLucke) added a comment to D14993: BLI: Use no_unique_address attribute..

https://builder.blender.org/admin/#/builders/18/builds/421

Fri, May 20, 12:25 PM
Jacques Lucke (JacquesLucke) updated the diff for D14993: BLI: Use no_unique_address attribute..
  • disable warning
Fri, May 20, 12:24 PM
Jacques Lucke (JacquesLucke) added a comment to D14760: Mesh: Add an explicit "positions changed" function.

How much do we want to let BKE_mesh_tag_positions_changed know what changed? For example, if all vertices are translated, we might not want to re-calculate tessellation or normals.

Fri, May 20, 12:16 PM · Geometry Nodes, Modeling
Jacques Lucke (JacquesLucke) updated the diff for D14993: BLI: Use no_unique_address attribute..
  • cleanup
Fri, May 20, 11:57 AM
Jacques Lucke (JacquesLucke) added a comment to D14993: BLI: Use no_unique_address attribute..

https://builder.blender.org/admin/#/builders/18/builds/420

Fri, May 20, 11:56 AM
Jacques Lucke (JacquesLucke) updated the summary of D14993: BLI: Use no_unique_address attribute..
Fri, May 20, 11:55 AM
Jacques Lucke (JacquesLucke) requested review of D14993: BLI: Use no_unique_address attribute..
Fri, May 20, 11:45 AM
Jacques Lucke (JacquesLucke) committed rB8e02b0d5d4f9: Cleanup: make functions for setting clone/stencil layer more consistent (authored by Martijn Versteegh (Baardaap)).
Cleanup: make functions for setting clone/stencil layer more consistent
Fri, May 20, 9:37 AM
Jacques Lucke (JacquesLucke) closed D14991: Make CustomData_set_layer_clone_index() and ..._stencil_index() behave consistent with the other .._index() functions.
Fri, May 20, 9:37 AM
Jacques Lucke (JacquesLucke) accepted D14991: Make CustomData_set_layer_clone_index() and ..._stencil_index() behave consistent with the other .._index() functions.
Fri, May 20, 9:35 AM

Thu, May 19

Jacques Lucke (JacquesLucke) updated the summary of D14972: Curves: New Pinch brush (WIP)..
Thu, May 19, 3:04 PM
Jacques Lucke (JacquesLucke) updated the diff for D14972: Curves: New Pinch brush (WIP)..
  • Merge branch 'master' into pinch-brush
  • add clump radius property
  • take brush direction into account
  • support clump radius
Thu, May 19, 3:03 PM

Wed, May 18

Jacques Lucke (JacquesLucke) closed T97761: Truncation Error for Integers Capture on Points after Resampling as Resolved by committing rB2e70af5cd527: Fix T97761: incorrect mixing of integers.
Wed, May 18, 5:03 PM · Good First Issue, Nodes & Physics, Geometry Nodes, BF Blender
Jacques Lucke (JacquesLucke) committed rB2e70af5cd527: Fix T97761: incorrect mixing of integers (authored by Jacques Lucke (JacquesLucke)).
Fix T97761: incorrect mixing of integers
Wed, May 18, 5:03 PM
Jacques Lucke (JacquesLucke) closed D14892: Fix T97761: Incorrect mixing of integers..
Wed, May 18, 5:03 PM
Jacques Lucke (JacquesLucke) committed rBf517b3a29568: Fix T98157: improve animation fps with better check in depsgraph (authored by Jacques Lucke (JacquesLucke)).
Fix T98157: improve animation fps with better check in depsgraph
Wed, May 18, 4:43 PM
Jacques Lucke (JacquesLucke) closed T98157: Regression: Massive drops in Animation playback (fps) in the viewport (Depsgraph) as Resolved by committing rBf517b3a29568: Fix T98157: improve animation fps with better check in depsgraph.
Wed, May 18, 4:43 PM · Nodes & Physics, Core, Images & Movies, BF Blender
Jacques Lucke (JacquesLucke) closed T98157: Regression: Massive drops in Animation playback (fps) in the viewport (Depsgraph), a subtask of T88219: Regression: Massive drops in Animation playback (fps) in the viewport, as Resolved.
Wed, May 18, 4:43 PM · Nodes & Physics, Core, Images & Movies, EEVEE & Viewport, BF Blender
Jacques Lucke (JacquesLucke) closed D14957: Improve check for whether a node tree references an animated Image..
Wed, May 18, 4:43 PM
Jacques Lucke (JacquesLucke) added inline comments to D14957: Improve check for whether a node tree references an animated Image..
Wed, May 18, 4:39 PM
Jacques Lucke (JacquesLucke) updated the diff for D14972: Curves: New Pinch brush (WIP)..
  • increase strength
Wed, May 18, 4:29 PM
Jacques Lucke (JacquesLucke) updated the summary of D14972: Curves: New Pinch brush (WIP)..
Wed, May 18, 4:28 PM
Jacques Lucke (JacquesLucke) updated the summary of D14972: Curves: New Pinch brush (WIP)..
Wed, May 18, 4:01 PM
Jacques Lucke (JacquesLucke) updated the diff for D14972: Curves: New Pinch brush (WIP)..
  • Merge branch 'master' into pinch-brush
  • fix
  • pinch improvements
Wed, May 18, 3:56 PM
Jacques Lucke (JacquesLucke) updated the summary of D14957: Improve check for whether a node tree references an animated Image..
Wed, May 18, 1:22 PM
Jacques Lucke (JacquesLucke) retitled D14957: Improve check for whether a node tree references an animated Image. from Improve check for whether a node tree references an animated Image. (WIP) to Improve check for whether a node tree references an animated Image..
Wed, May 18, 1:20 PM
Jacques Lucke (JacquesLucke) abandoned D14897: Move particle system modifier to C++..
Wed, May 18, 12:06 PM

Tue, May 17

Jacques Lucke (JacquesLucke) updated subscribers of D14972: Curves: New Pinch brush (WIP)..
Tue, May 17, 6:47 PM
Jacques Lucke (JacquesLucke) requested review of D14972: Curves: New Pinch brush (WIP)..
Tue, May 17, 6:43 PM
Jacques Lucke (JacquesLucke) added a comment to D14942: Curves: Draw legacy hair particle system as curves object. (WIP).

This is a general design issue when switching from dedicated UV map attributes to generic float2 attributes, not sure if a solution was considered for that.

Tue, May 17, 4:14 PM
Jacques Lucke (JacquesLucke) retitled D14942: Curves: Draw legacy hair particle system as curves object. (WIP) from Curves: Draw legacy hair particle system as curves object. to Curves: Draw legacy hair particle system as curves object. (WIP).
Tue, May 17, 4:02 PM
Jacques Lucke (JacquesLucke) added a comment to D14942: Curves: Draw legacy hair particle system as curves object. (WIP).

Yeah fair enough, will add that to the description.

Tue, May 17, 3:59 PM
Jacques Lucke (JacquesLucke) accepted D14967: Cleanup: Use const in curves sculpt code.
Tue, May 17, 12:11 PM
Jacques Lucke (JacquesLucke) added a comment to D14957: Improve check for whether a node tree references an animated Image..

https://builder.blender.org/admin/#/builders/18/builds/408

Tue, May 17, 10:25 AM
Jacques Lucke (JacquesLucke) updated the diff for D14957: Improve check for whether a node tree references an animated Image..
  • missing null check
  • Merge branch 'blender-v3.2-release' into has-image-animation-check
Tue, May 17, 10:25 AM
Jacques Lucke (JacquesLucke) updated the summary of D14942: Curves: Draw legacy hair particle system as curves object. (WIP).
Tue, May 17, 10:11 AM
Jacques Lucke (JacquesLucke) retitled D14942: Curves: Draw legacy hair particle system as curves object. (WIP) from Curves: Draw legacy hair particle system as curves object. (WIP) to Curves: Draw legacy hair particle system as curves object..
Tue, May 17, 9:07 AM
Jacques Lucke (JacquesLucke) updated the diff for D14942: Curves: Draw legacy hair particle system as curves object. (WIP).
  • cleanup
Tue, May 17, 9:06 AM
Jacques Lucke (JacquesLucke) added a comment to D14942: Curves: Draw legacy hair particle system as curves object. (WIP).

https://builder.blender.org/admin/#/builders/18/builds/407

Tue, May 17, 9:03 AM
Jacques Lucke (JacquesLucke) updated the summary of D14942: Curves: Draw legacy hair particle system as curves object. (WIP).
Tue, May 17, 9:02 AM
Jacques Lucke (JacquesLucke) updated the summary of D14942: Curves: Draw legacy hair particle system as curves object. (WIP).
Tue, May 17, 9:00 AM
Jacques Lucke (JacquesLucke) updated the diff for D14942: Curves: Draw legacy hair particle system as curves object. (WIP).
  • move some functions to bke
  • remove more dead drawing code
Tue, May 17, 8:57 AM
Jacques Lucke (JacquesLucke) updated the summary of D14942: Curves: Draw legacy hair particle system as curves object. (WIP).
Tue, May 17, 8:18 AM
Jacques Lucke (JacquesLucke) updated the diff for D14942: Curves: Draw legacy hair particle system as curves object. (WIP).

Thanks Brecht, that helps a lot!

Tue, May 17, 8:18 AM

Mon, May 16

Vyacheslav (hitrpr) awarded rB94a54ab5549b: Curves: add operator to convert hair particle system to new curves a Like token.
Mon, May 16, 9:20 PM