UI Module Coordinator, Asset Browser & VR Development Lead
User Details
- User Since
- Dec 12 2013, 11:11 PM (446 w, 4 h)
Today
Yesterday
Wed, Jun 29
A very nice improvement indeed. There are some other pending patches touching the icon file. So I want to check on possible conflicts and the best order to merge things first.
Tue, Jun 28
Although it would be nice to have this fixed there, I'm not confident enough in that this won't cause other issues. Such selection keymaps are fiddly/fragile.
Mon, Jun 27
Checked with Pablo in person, we agreed on using the "Widget" font style for the File Browser text.
Awesome!
Can be fixed with this:
diff --git a/source/blender/editors/space_file/filesel.c b/source/blender/editors/space_file/filesel.c index e42e1e98660..4fdde7a63fe 100644 --- a/source/blender/editors/space_file/filesel.c +++ b/source/blender/editors/space_file/filesel.c @@ -890,8 +890,8 @@ FileAttributeColumnType file_attribute_column_type_find_isect(const View2D *v2d, float file_string_width(const char *str) { const uiStyle *style = UI_style_get(); - UI_fontstyle_set(&style->widget); - return BLF_width(style->widget.uifont_id, str, BLF_DRAW_STR_DUMMY_MAX); + UI_fontstyle_set(&style->widgetlabel); + return BLF_width(style->widgetlabel.uifont_id, str, BLF_DRAW_STR_DUMMY_MAX); }
There is code to explicitly move headers to the top for File/Asset Browsers and some other editors if the Header Position is not set to Keep Existing.
Thanks a lot for the patch, this is really helpful!
Thanks a ton for the fix!
Fri, Jun 24
- Merge branch 'master' into arcpatch-D9140
Fri, Jun 17
The escape key shouldn’t be used this way, escape and right click mean cancel in Blender. I think using the enter keys is fine here. I’m not sure if that is as simple as this patch though, it’s important that this is mentioned in the statusbar/header (wherever the other shortcuts are shown for the eyedropper). Not at my computer right now so I can’t check the details unfortunately.
Thu, Jun 16
Nice, thank you!
Wed, Jun 15
This should be just fine. I will commit this and add a comment explaining why this is done.
Tue, Jun 14
Mon, Jun 13
Thu, Jun 2
Wed, Jun 1
May 31 2022
Fixed the crash (rB75ef51cc80c6) and a further issue (rB765c16bbd08b: Fix wrong asset dropped when dragging from loc. of just cleared asset), should be fine now.