Committed rB95373e2749, rBf5bbaf55ac, rBcac756a92a.

Works fine here. Even with AddressSanitizer and --debug-memory (which would almost certainly cause a crash or error print if there was a bad memory access). You seem to be using a rather customized version of Blender, could you try if this happens with factory settings? Since this involves a custom startup file, maybe just rename your config directory for this.
First, I'd try with latest builds though, https://builder.blender.org/download/.

Guess this is fine then.
Re point size - right, didn't mean to say that this patch should fix it, just something to check on.

So just for the records, seems this isn't a new issue introduced with our changes, but we exposed it by opening the Volumes panel by default.
Then things actually make sense ;)

@Alberto Velázquez (dcvertice) could you try opening the file browser in a 2.80 build and opening all panels in the left sidebar? We now have the Volumes panel open by default, that may be the thing accessing the network drive.

The theme changes should be fine. Noticed one drawing issue though.

Works fine for me, tested on Linux and Windows 10. Not sure what could cause this, maybe try with factory settings? (File → Defaults → Load Factory Settings)

@Kalyan (coder.kalyan) I wouldn't recommend this for someone just getting into Blender development, this is a harder task than it appears to be. Issue is a) getting the updated transform data out (previously you had to force an update of the object matrices, potentially duplicating work - the new depsgraph might make this simple to solve), and b) efficiently recalculating the gizmo position (calculating its position with 1000's of vertices selected can be expensive).

In D5754#133422, @Campbell Barton (campbellbarton) wrote:

Overall approach seems fine, although only having one temp screen seems a bit strange.
For example
[...]
Wouldn't it be best to allow a single temp window per type?

Definitely, yes. We were planning to address that separately, see T69652.

We want to do things a bit different, so that secondary/temporary Blender windows are not on top of non-Blender windows - like this patch does it.

There we go, had to manually run arc install-certificate to bind arc to my account.
Sorry about the noise.

Checking updated arc credentials

Why the hell... I've gotten Bastien's former machine in the Institute, changed the git config - the commits have me set as author - created new SSH keys, created a fresh checkout, ... but Arc still pushed this with Bastien's account...
Sorry about this, checking what's going on.

My suggestion was to start by making all temporary windows to be always-on-top, see D5765. That literally means always on top, even on top of non-Blender windows. Then try to get to this task as soon as possible, hence why it's set to high priority.
Multi-window support in Blender is far from great in regards to usability, but that's nothing new and we won't be able to fix it for 2.81. But again - I see it as a high priority issue.

Okay, this is quite a corner case. Found a way to reproduce it from factory settings:

• Open an older Blender version (from before the new file browser)
• F12 to get the temporary render window opened
• Change the Image Editor to a File Browser and back
• Save the file
• Open it in new Blender with the new file browser
• Open a file browser

-> Crash.

Testing this with GNOME, I can't get it to work, even with the windows key being freed from window actions.

• Correct Cocoa implementation
• Cleanup: Add comments, clang-format

Phrased this badly, I mean I'm not actually proposing to apply this to all temp windows by default, although we might want to do just that. What matters for this review is checking if it works on all platforms and if this way of doing it is fine.
We'd probably need to figure out where precisely we want to use it then, and if we want to make it optional in some cases.

Please, do not set task priority yourself, that is for developers.
Also, DirectX isn't a graphics card. It's probably best if you do Help → Save System Info and upload the resulting system_info.txt here (e.g. by dragging it into the comment box).

Any design feedback not strictly about the points mentioned here should go to the design task, T62971. Here we only list the TODOs for 2.81, and maybe try to find solutions to the mentioned open topics.

That is actually the intended behavior, although it's of arguable use. See rBd71db08f6d31.
Closing the report as this works by design.

In T69652#772193, @Piotr (radi0n) wrote:

Maybe feature to double click an empty area to parent directory?

I'd find that a bit obscure and more importantly confusing. Double clicking at the wrong place would then jump directories, without being obvious why and where it jumped to (users might have to remember and check the file path to find out).

This is a driver bug in this specific version of Mesa, it's fixed in newer ones. See T69461.
We'll probably have to find a workaround.

This patch now also contains the file browser icons.

• Rename types to address review points
• Change handling to work for all button types

Heh, I knew you'd point exactly these things out :) Just wanted to have feedback before spending time on coming up with better names.
Thanks for the quick feedback.

Note that this patch doesn't actually add the file browser icons, it's just refactoring the extra icons to enable it.

The first one isn't a bug, Blender handled temporary windows that way before, we just kept using that convention. It's something we want to change now though, see T69652.

In T69456#771632, @Alberto Velázquez (dcvertice) wrote:

Of course no the origin of the problems with file browser that I talk in this thread.

Can't tell what you mean by that sentence :)

Okay so we haven't gotten any new reports on this and the issue is fixed with updated drivers. So it's probably not worth doing workarounds from our side. I'll close this now, but surely look out for similar reports.

Tested with the redesigned file browser in 2.81, seems to work without issues. Closing the report then :)

For the records, the file browser redesign didn't change anything but the file browser file size strings. If master uses base 10 sizes, that was the case before the redesign.