@Sybren A. Stüvel (sybren) good points, I like your idea.
AFAIK the main reason the operator poll() doesn't take context as const is to be able to set the disabled hint. Eventually I'd like to see this addressed, and not having the Python code rely on this is a good idea I think, might save us some trouble later on.

Added IES lights to the list (thanks Dalai for the suggestion).

In T55239#1146628, @Luciano Muñoz Sessarego (looch) wrote:

I would love that all these assets were hosted in the blender cloud and be part of it on the one hand encouraging more subscribers on the other hand keeping blender light weight but ready to connect to a massive online library of high quality assets.

Fixed in e945ca346642.

I do not understand why it's an issue to make the rationale (which I've explained carefully) in the commit. You could have just quoted my comment or put it in your own words. I'd personally even be fine with just linking to it as long as everybody can find the rationale without own digging.
Clear rationales in commit messages (including reverts) is something I've reminded the UI module members multiple times of. I even remember explicitly tagging you on that at least once, and IIRC that was about rationales in revert commits too.

I tried to give a thorough rationale in D10968: Revert D10835: Removal of Lock Camera Gizmo Button. Indeed this should have been included in the commit message (reminder: *always* have clear rationales in commit messages).

rB4baf3964aee2, thanks @Harley Acheson (harley) for doing the revert.

Also please note that this isn't just a decision by me, to a degree I'm the messenger here. But I do agree with the remarks.

The decision was made to revert the addition for the 2.93 release, so accepting this. I know that many people like this addition and it would be great if we could look into this together again for the 3.0 release.

Problem is that this function doesn't cover this case: https://developer.blender.org/diffusion/B/browse/master/source/blender/editors/interface/interface_handlers.c$622-640.
Ideally this could just walk up the RNA path of the property to see if any parent is of a preferences RNA type. But we can't get that path there unfortunately, not sure if there's a way to get it.
Alternatively, when registering custom properties, BPY could flag them as "inside a preferences struct". But this would break when nesting a property group inside a property group inside the add-on preferences...

To me it seems important to have this rather harmless confirmation prompt look drastically different from ones like the quit confirmation prompt, where you might not be able to undo (e.g. auto save turned off or not working because of sculpt mode, or using Linux where the quit.blend is stored in /tmp/- which is another stupid thing...). This is a popup that may often appear during normal work and should be small and unobtrusive (if there is one at all), confirmation prompts to avoid data-loss -- or even just the moment where the user thinks there was some data-loss -- can well be intrusive. They interrupt the user intentionally and want to make them think.

Closing all tasks in the "Done" column of the Asset Browser (Milestone 1: Basic, Local Asset Browser).

Closing all tasks in the "Done" column of the Asset Browser (Milestone 1: Basic, Local Asset Browser).

Closing all tasks in the "Done" column of the Asset Browser (Milestone 1: Basic, Local Asset Browser).

Closing all tasks in the "Done" column of the Asset Browser (Milestone 1: Basic, Local Asset Browser).

Closing all tasks in the "Done" column of the Asset Browser (Milestone 1: Basic, Local Asset Browser).

Closing all tasks in the "Done" column of the Asset Browser (Milestone 1: Basic, Local Asset Browser).

Closing all tasks in the "Done" column of the Asset Browser (Milestone 1: Basic, Local Asset Browser).

Closing all tasks in the "Done" column of the Asset Browser (Milestone 1: Basic, Local Asset Browser).

Closing all tasks in the "Done" column of the Asset Browser (Milestone 1: Basic, Local Asset Browser).

Closing all tasks in the "Done" column of the Asset Browser (Milestone 1: Basic, Local Asset Browser).

Closing all tasks in the "Done" column of the Asset Browser (Milestone 1: Basic, Local Asset Browser).

Closing all tasks in the "Done" column of the Asset Browser (Milestone 1: Basic, Local Asset Browser).

Closing all tasks in the "Done" column of the Asset Browser (Milestone 1: Basic, Local Asset Browser).

Closing all tasks in the "Done" column of the Asset Browser (Milestone 1: Basic, Local Asset Browser).

Closing all tasks in the "Done" column of the Asset Browser (Milestone 1: Basic, Local Asset Browser).

Closing all tasks in the "Done" column of the Asset Browser (Milestone 1: Basic, Local Asset Browser).

Closing all tasks in the "Done" column of the Asset Browser (Milestone 1: Basic, Local Asset Browser).

Closing all tasks in the "Done" column of the Asset Browser (Milestone 1: Basic, Local Asset Browser).

In D10887#278579, @Harley Acheson (harley) wrote:

As for “app menu”, 14% of devtalk users don’t know that exists and the majority hate it by a 2:1 margin:
https://devtalk.blender.org/t/feedback-wanted-on-the-app-menu-poll/16868

I know about the issues with the app menu, and I'd be happy to see a better design. But that doesn't change the fact that it's logically one of the more appropriate places for this, if not the most appropriate.

This is a task were I hope to get some help from contributors. Much of this work is simple and you can follow other cases.

Closing since this is an intentional change in the upcoming 2.93 release. It's mentioned in the WIP release notes, but it's a bit hidden. Think it deserves a more prominent mention (e.g. an own section for the window management changes).

I find placing this in the Preferences a weird choice, especially since it's an operator, not a Blender setting. It could be placed in the hamburger on the lower left, or in the app menu in the top-bar (with the Blender icon).

• Merge branch 'master' into temp-idtype-preview-getter

• Update to latest master

This popped up on my radar...

Thanks for working on this!

Seems just fine, think we do the same in some similar cases (or used to).

Done with rB83c53d1bee25 & rBA4422b945d5ad.

Good, closing as archived then :)