Alexander Romanov (a.romanov)
blend4web.com

Projects

User Details

User Since
Oct 23 2014, 12:36 PM (152 w, 2 d)

Recent Activity

Aug 10 2017

Alexander Romanov (a.romanov) added a comment to T52316: Principled BSDF not available in Node Menu: Shift+A then Shader. Not in menu.

This bug was fixed in Blend4Web 17.02.1.

Aug 10 2017, 10:37 AM · BF Blender

Jul 28 2017

Alexander Romanov (a.romanov) retitled D2757: Draw Engine Python API from init to Draw Engine Python API.
Jul 28 2017, 6:10 PM
Alexander Romanov (a.romanov) created D2757: Draw Engine Python API.
Jul 28 2017, 6:02 PM

Jul 17 2017

Alexander Romanov (a.romanov) created T52092: Crash when unlinking group with directly connected sockets.
Jul 17 2017, 3:48 PM · BF Blender

Jul 4 2017

Alexander Romanov (a.romanov) committed rB3898236b81b9: Third fix for my merge: crash after switch to edit mode reported by @dfelinto (authored by Alexander Romanov (a.romanov)).
Third fix for my merge: crash after switch to edit mode reported by @dfelinto
Jul 4 2017, 4:54 PM
Alexander Romanov (a.romanov) committed rB0ef48ad50435: One more fix for merged 'normal map tangents not working correctly when there… (authored by Alexander Romanov (a.romanov)).
One more fix for merged 'normal map tangents not working correctly when there…
Jul 4 2017, 3:25 PM

Jul 3 2017

Alexander Romanov (a.romanov) committed rBde2faa395f2d: Fix for merged 'normal map tangents not working correctly when there are no UV… (authored by Alexander Romanov (a.romanov)).
Fix for merged 'normal map tangents not working correctly when there are no UV…
Jul 3 2017, 7:17 PM
Alexander Romanov (a.romanov) committed rBe1482841dd5d: Merge branch 'master' into blender2.8 (authored by Alexander Romanov (a.romanov)).
Merge branch 'master' into blender2.8
Jul 3 2017, 7:16 PM

Jun 22 2017

Alexander Romanov (a.romanov) added a comment to T51868: Crash when using reference to deleted object in python (ASAN enabled).

OK, this is just breaking Python data consistency without taking of such references into account. I just wanted to understand whether we going to do something with such cases. E.g. we could free blender data and mark the python object as invalid if reference exist.

Jun 22 2017, 4:40 PM · BF Blender
Alexander Romanov (a.romanov) edited the description of T51868: Crash when using reference to deleted object in python (ASAN enabled).
Jun 22 2017, 11:52 AM · BF Blender
Alexander Romanov (a.romanov) created T51868: Crash when using reference to deleted object in python (ASAN enabled).
Jun 22 2017, 11:38 AM · BF Blender

Jun 13 2017

Alexander Romanov (a.romanov) created D2709: Fix for T51746.
Jun 13 2017, 2:55 PM

Jun 7 2017

Alexander Romanov (a.romanov) added a comment to T48773: bpy.ops.action.clean() resets fcurve Bezier handlers' types.

The task is still actual. The patch is still working for me. Could anyone take a look?

Jun 7 2017, 11:45 AM · Animation, BF Blender

May 30 2017

Alexander Romanov (a.romanov) updated the summary of D2694: Exposing Draw Engine methods for external render engine..
May 30 2017, 11:31 AM

May 29 2017

Alexander Romanov (a.romanov) updated the diff for D2694: Exposing Draw Engine methods for external render engine..
  • fix memleak
  • minor changes
May 29 2017, 3:47 PM
Alexander Romanov (a.romanov) created D2694: Exposing Draw Engine methods for external render engine..
May 29 2017, 1:53 PM
Alexander Romanov (a.romanov) added a comment to T51520: Broken vertex weights after two mesh joining..

He used "Data Transfer" and "Dynamic Paint" and then has applied them.

May 29 2017, 9:39 AM · BF Blender

May 22 2017

Alexander Romanov (a.romanov) added a comment to T51520: Broken vertex weights after two mesh joining..

Our artist, who found the issue is currently on vacation. I'll ask him as soon as he returns.

May 22 2017, 5:03 PM · BF Blender

May 16 2017

Alexander Romanov (a.romanov) created T51520: Broken vertex weights after two mesh joining..
May 16 2017, 1:52 PM · BF Blender
Alexander Romanov (a.romanov) added a comment to D2577: Shader PyNodes for Blender 2.8.

Here are some concerns/open questions from my side here:

  • The API seems quite low level: simply exposed bf_gpu to python. It should be possible to make it more streamlined and decoupled from internal specifics.

I agree with you here. But afaik, booth C and Python implementations should be available. Both implementations should be able to live together. Most important thing here is that python GPULink function allocates C-structure which is unmanaged with Python and freeing is performed in C-core. And another thing is uniform passing. Now shader recompiles every time when some property in node has changed (this is legacy drawback).

May 16 2017, 12:06 PM · BF Blender: 2.8
Alexander Romanov (a.romanov) updated the diff for D2577: Shader PyNodes for Blender 2.8.
  • merge from blender2.8
  • updated for eevee
  • fix campbell suggestions
May 16 2017, 12:06 PM · BF Blender: 2.8

May 12 2017

Alexander Romanov (a.romanov) added a comment to rB3fbafaffa116: Eevee: Add tonemapping using ocio..

This commit introduces crash for me if ASAN is enabled.
Steps to reproduce:

  1. Open default scene
  2. Switch to Eevee
  3. Save the file
  4. Crash!
May 12 2017, 1:48 PM

Apr 28 2017

Alexander Romanov (a.romanov) added a comment to T51336: Crash on file open.

I can't reproduce. but actually, the function can return NULL but this is not checked.

Apr 28 2017, 12:48 PM · BF Blender

Apr 27 2017

Alexander Romanov (a.romanov) updated subscribers of rBf5bc8ad4ce87: Add red alert in UI controls for datablock pointer properties.

I'm don't really like the way this is done. Added inline comments on some specifics, but I really think this should have been approached differently.
Also, I'd like to see an example of where this would be needed. I'd say it should never be possible to set an invalid value there in the first place. UI code should probably check that when selecting and renaming search items, and fail properly instead of allowing to set invalid values.

Apr 27 2017, 5:34 PM
Alexander Romanov (a.romanov) created T51336: Crash on file open.
Apr 27 2017, 5:09 PM · BF Blender

Apr 26 2017

Alexander Romanov (a.romanov) updated the summary of D2577: Shader PyNodes for Blender 2.8.
Apr 26 2017, 4:29 PM · BF Blender: 2.8
Alexander Romanov (a.romanov) added inline comments to D2577: Shader PyNodes for Blender 2.8.
Apr 26 2017, 4:06 PM · BF Blender: 2.8
Alexander Romanov (a.romanov) updated the diff for D2577: Shader PyNodes for Blender 2.8.
  • fix memleaks
  • rename shader_node_compat_desc structure
  • use dynstr
  • using _PyUnicode_AsString
  • use ((BaseMathObject *)obj)->data to for passing pointer to uniform
  • use PyBool_Check
  • correct Py_INCREF in pygpu_get_shader_node_classes
  • moving shader API to submodule
Apr 26 2017, 4:04 PM · BF Blender: 2.8

Apr 24 2017

Alexander Romanov (a.romanov) added a comment to D2577: Shader PyNodes for Blender 2.8.

General Questions
====

  • Who would use this functionality?

    Artists? ... or is this intended only for engine-authors so they can match Blender's viewport to their engine?

    Of course there would be some technical artists who like to write GLSL, I just try get a sense of it's intended use.
Apr 24 2017, 10:21 AM · BF Blender: 2.8

Apr 20 2017

Alexander Romanov (a.romanov) updated the summary of D2577: Shader PyNodes for Blender 2.8.
Apr 20 2017, 7:05 PM · BF Blender: 2.8
Alexander Romanov (a.romanov) updated the diff for D2577: Shader PyNodes for Blender 2.8.
  • Update for the current blender2.8 branch
  • Started replacing of Cycles nodes
Apr 20 2017, 3:05 PM · BF Blender: 2.8
Alexander Romanov (a.romanov) created T51263: "Direction" UI control draw bug.
Apr 20 2017, 1:05 PM · BF Blender: 2.8
Alexander Romanov (a.romanov) created T51260: Forward compatibility after D113.
Apr 20 2017, 10:49 AM · BF Blender
Alexander Romanov (a.romanov) committed rB31c644b657d3: Fix T51198: Crash with new Datablock ID Properties (authored by Alexander Romanov (a.romanov)).
Fix T51198: Crash with new Datablock ID Properties
Apr 20 2017, 10:40 AM
Alexander Romanov (a.romanov) closed T51198: Crash with new Datablock ID Properties as "Resolved" by committing rB31c644b657d3: Fix T51198: Crash with new Datablock ID Properties.
Apr 20 2017, 10:40 AM · BF Blender

Apr 18 2017

Alexander Romanov (a.romanov) added a comment to T51198: Crash with new Datablock ID Properties.

@Bastien Montagne (mont29) for first part of P464 I've recorded the video: https://youtu.be/jF0CtWQPsC4

Apr 18 2017, 6:06 PM · BF Blender
Alexander Romanov (a.romanov) updated subscribers of T51243: Delete Globally won't work with Datablock ID Properties.

@Bastien Montagne (mont29), If I understand correctly, "X" do removing for the current scene and "Shift+X" - for all scenes? So in case of single scene "X" should also work? If this operator has "scene" context, I suppose that lookup in scene idproperties should be sufficient?

Apr 18 2017, 5:55 PM · BF Blender
Alexander Romanov (a.romanov) added a comment to P464 fix_d113_crash.diff.

@Bastien Montagne (mont29) I've recorded a video to show the bug: https://youtu.be/jF0CtWQPsC4

Apr 18 2017, 5:24 PM
Alexander Romanov (a.romanov) updated the summary of D2467: Automatic scripts reload after path editing.
Apr 18 2017, 10:45 AM · User Interface
Alexander Romanov (a.romanov) retitled D2467: Automatic scripts reload after path editing from Add "script.reload" button to User Preference Panel to Automatic scripts reload after path editing.
Apr 18 2017, 10:41 AM · User Interface

Apr 17 2017

Alexander Romanov (a.romanov) committed rB11f4b407d4b5: Fix build error on Windows introduced in D2425 (authored by Alexander Romanov (a.romanov)).
Fix build error on Windows introduced in D2425
Apr 17 2017, 12:40 PM
Alexander Romanov (a.romanov) added a comment to T48238: Viewport Project: Wireframes for Blender 2.8.

@Mike Erwin (merwin): I have nothing to add. I think that new wireframes are awesome ))

Apr 17 2017, 11:19 AM · User Interface, BF Blender: 2.8
Alexander Romanov (a.romanov) added a comment to rB78b5d66af8e2: Object Info node support for GLSL mode and the internal render.

I fail in build, but is this correction right?

F:\Blender_Git\blender\source\blender\blenlib\BLI_hash.h(28): error C4431: missing type specifier - int assumed. Note:C no longer supports default-int (F:\Blender_Git\blender\source\blender\blenkernel\intern\object_dupli.c) [F:\Blender_Git\build_windows_Release_x64_vc12_Release\source\blender\blenkernel\bf_blenkernel.vcxproj]
F:\Blender_Git\blender\source\blender\blenlib\BLI_hash.h(28): error C2054: expected '(' to follow 'inline' (F:\Blender_Git\blender\source\blender\blenkernel\intern\object_dupli.c) [F:\Blender_Git\build_windows_Release_x64_vc12_Release\source\blender\blenkernel\bf_blenkernel.vcxproj]
Apr 17 2017, 9:24 AM

Apr 15 2017

Duarte Farrajota Ramos (duarteframos) awarded F499530: Screenshot from 2017-03-01 18-44-03.png a Love token.
Apr 15 2017, 5:01 AM

Apr 14 2017

mic lack30 (miclack) awarded D113: Datablock ID Properties a Love token.
Apr 14 2017, 8:39 PM
Alexander Romanov (a.romanov) added a comment to T51198: Crash with new Datablock ID Properties.

Possible solution for forward compatibility issue: P465

Apr 14 2017, 7:55 PM · BF Blender
Alexander Romanov (a.romanov) created P465 Forward compatibility after D113.
Apr 14 2017, 7:54 PM
Alexander Romanov (a.romanov) committed rB78b5d66af8e2: Object Info node support for GLSL mode and the internal render (authored by Alexander Romanov (a.romanov)).
Object Info node support for GLSL mode and the internal render
Apr 14 2017, 5:15 PM
Alexander Romanov (a.romanov) closed D2425: Object Info node support for GLSL mode and the internal render by committing rB78b5d66af8e2: Object Info node support for GLSL mode and the internal render.
Apr 14 2017, 5:15 PM
Alexander Romanov (a.romanov) added a comment to T51198: Crash with new Datablock ID Properties.

The reason of crash is infinite recursion, which happens in RNA_pointer_as_string.
I've also found python crash if you will try to remove the custom property pressing "-" button.
This is my solution for these two issues: P464

Apr 14 2017, 3:10 PM · BF Blender
Alexander Romanov (a.romanov) created P464 fix_d113_crash.diff.
Apr 14 2017, 2:32 PM
Alexander Romanov (a.romanov) added a comment to T51198: Crash with new Datablock ID Properties.

I've found the reason for this crash, and also found forward compatibility issue. I'm working on it.

Apr 14 2017, 10:39 AM · BF Blender

Apr 13 2017

Alexander Romanov (a.romanov) committed rB6f268ac55d83: Merge branch 'master' into blender2.8 (authored by Alexander Romanov (a.romanov)).
Merge branch 'master' into blender2.8
Apr 13 2017, 12:05 PM
Alexander Romanov (a.romanov) committed rBf5bc8ad4ce87: Add red alert in UI controls for datablock pointer properties (authored by Alexander Romanov (a.romanov)).
Add red alert in UI controls for datablock pointer properties
Apr 13 2017, 11:58 AM
Alexander Romanov (a.romanov) committed rBa7b3047cefcb: Datablock ID Properties (authored by Alexander Romanov (a.romanov)).
Datablock ID Properties
Apr 13 2017, 11:36 AM
Alexander Romanov (a.romanov) closed D113: Datablock ID Properties by committing rBa7b3047cefcb: Datablock ID Properties.
Apr 13 2017, 11:36 AM
Alexander Romanov (a.romanov) updated the diff for D113: Datablock ID Properties.
  • fix harmless mistake in copy paste
Apr 13 2017, 11:27 AM
Alexander Romanov (a.romanov) updated the diff for D113: Datablock ID Properties.
  • Remove red alert (will be added in separate commit)
Apr 13 2017, 11:12 AM

Apr 12 2017

Alexander Romanov (a.romanov) updated the diff for D2425: Object Info node support for GLSL mode and the internal render.

Update for the current state of master branch

Apr 12 2017, 7:46 PM
Alexander Romanov (a.romanov) updated the diff for D113: Datablock ID Properties.

fix incorrect indentation in abort_if_false + lowercase start symbol of comments

Apr 12 2017, 7:29 PM
Alexander Romanov (a.romanov) updated the diff for D113: Datablock ID Properties.
  • fix tests' names + comments corrections
Apr 12 2017, 6:55 PM
Alexander Romanov (a.romanov) updated the diff for D113: Datablock ID Properties.

Updated for the current state of master branch

Apr 12 2017, 5:35 PM

Apr 11 2017

Alexander Romanov (a.romanov) updated the diff for D2425: Object Info node support for GLSL mode and the internal render.

Minor fix of comment

Apr 11 2017, 10:48 AM
Alexander Romanov (a.romanov) updated the diff for D2425: Object Info node support for GLSL mode and the internal render.

Using expanded random_id in Cycles

Apr 11 2017, 10:43 AM

Apr 10 2017

Alexander Romanov (a.romanov) added a comment to D2425: Object Info node support for GLSL mode and the internal render.

Do you know how to make Cycles to use this RNA value?

First, I don't know how to return it as unsigned to Python.

Apr 10 2017, 2:39 PM
Alexander Romanov (a.romanov) updated the diff for D2425: Object Info node support for GLSL mode and the internal render.
  1. Fixed style
  2. random_id added to RNA. Now it is interpreted as signed int on Python side (regardless PROP_UNSIGNED). We can leave it as is, or make convertion to float [0,1]. What could be the best solution?
Apr 10 2017, 1:50 PM
Alexander Romanov (a.romanov) updated the diff for D113: Datablock ID Properties.
  1. point to correct test file in cmake config
  2. fix test portability by replacing read_home_file with read_factory_settings
Apr 10 2017, 11:33 AM
Duarte Farrajota Ramos (duarteframos) awarded D2425: Object Info node support for GLSL mode and the internal render a Love token.
Apr 10 2017, 5:19 AM

Apr 5 2017

Alexander Romanov (a.romanov) edited P460 D113 speed test.
Apr 5 2017, 5:52 PM
Alexander Romanov (a.romanov) edited P460 D113 speed test.
Apr 5 2017, 5:50 PM
Alexander Romanov (a.romanov) added a comment to D113: Datablock ID Properties.

Checked the patch and generally seems OK.

Some questions:

  • Did anyone test this patch on a complex file? Are there slowdowns, if so how much?:
    • Deleting an object in a file with ~1k objects.
    • Deleting all objects.
    • Undo.

Here are my results: https://docs.google.com/spreadsheets/d/1S_vwTViBw0IPcyeN6Og7htXr38qLn722q38Gxk1n6Mk/edit?usp=sharing
Source: P460

Apr 5 2017, 5:43 PM
Alexander Romanov (a.romanov) created P460 D113 speed test.
Apr 5 2017, 5:27 PM
Alexander Romanov (a.romanov) updated the diff for D113: Datablock ID Properties.
  1. Updated from the datablock_idprops branch
  2. Taken into account the comments of @Campbell Barton (campbellbarton)
Apr 5 2017, 12:45 PM

Apr 3 2017

Alexander Romanov (a.romanov) updated the diff for D2425: Object Info node support for GLSL mode and the internal render.

Update for the current master

Apr 3 2017, 1:31 PM
Alexander Romanov (a.romanov) abandoned D2597: update for the current master.

created by mistake

Apr 3 2017, 1:17 PM
Alexander Romanov (a.romanov) created D2597: update for the current master.
Apr 3 2017, 1:15 PM

Mar 31 2017

Alexander Romanov (a.romanov) created T51099: object.to_mesh returns incorrect result.
Mar 31 2017, 5:53 PM · Modifiers, BF Blender
Alexander Romanov (a.romanov) committed rB27d20a04b54e: Fix unreported bug in Blender Render: using unnormalized normal in normal map… (authored by Alexander Romanov (a.romanov)).
Fix unreported bug in Blender Render: using unnormalized normal in normal map…
Mar 31 2017, 4:53 PM

Mar 30 2017

Alexander Romanov (a.romanov) created T51088: Custom normals are changed after triangulation..
Mar 30 2017, 11:15 AM · BF Blender

Mar 29 2017

Alexander Romanov (a.romanov) added a comment to D113: Datablock ID Properties.

Thinking you are not using up-to-date branch? IDP_id_unregister() has been removed (see rBaae70f182b1477dc9f ).

Mar 29 2017, 6:00 PM
Alexander Romanov (a.romanov) added a comment to D113: Datablock ID Properties.

I've patched id_us_min to print the name of objects

void id_us_min(ID *id)
{
	if (id) {
		fprintf(stderr, "%s\n", id->name);
		const int limit = ID_FAKE_USERS(id);
....
Mar 29 2017, 5:47 PM
Alexander Romanov (a.romanov) added a comment to D113: Datablock ID Properties.

I still cannot reproduce… you’r using CTest right? ctest --output-on-failure -R "idprop" … works fine for me :/

Mar 29 2017, 4:40 PM
Alexander Romanov (a.romanov) added a comment to rB67ffad8cd2b4: OpenGL: remove several glMatrixMode calls.

It seems that this commit breaks the drawing of nodes.

Mar 29 2017, 11:55 AM
Alexander Romanov (a.romanov) added a comment to D113: Datablock ID Properties.
  1. Still not clear why you always remap in BKE_libblock_free_ex, https://developer.blender.org/D113#inline-25153 does not help me much here… I consider this a show stopper, we cannot accept this in master.

You can reproduce the issue if you will run the test in Blender, compilled with asan, without libblock_remap_data call. It will crash during Main release. Passing do_id_user to IDP_FreeProperty is verbose. Using of some global flag is dirty hack...

Can’t confirm that here, with current branch both 'idprop' tests pass OK with this line disabled for me.

Mar 29 2017, 9:52 AM

Mar 28 2017

Alexander Romanov (a.romanov) updated the diff for D113: Datablock ID Properties.

Updated with changes from datablock_idprops branch

Mar 28 2017, 6:51 PM
Alexander Romanov (a.romanov) added a comment to D113: Datablock ID Properties.
  1. Still not clear why you always remap in BKE_libblock_free_ex, https://developer.blender.org/D113#inline-25153 does not help me much here… I consider this a show stopper, we cannot accept this in master.

You can reproduce the issue if you will run the test in Blender, compilled with asan, without libblock_remap_data call. It will crash during Main release. Passing do_id_user to IDP_FreeProperty is verbose. Using of some global flag is dirty hack...

Mar 28 2017, 6:43 PM

Mar 24 2017

Duarte Farrajota Ramos (duarteframos) awarded D2577: Shader PyNodes for Blender 2.8 a Like token.
Mar 24 2017, 6:12 PM · BF Blender: 2.8

Mar 23 2017

Alexander Romanov (a.romanov) created D2577: Shader PyNodes for Blender 2.8.
Mar 23 2017, 5:12 PM · BF Blender: 2.8
Alexander Romanov (a.romanov) committed rBf98d9baea9e8: Revert own previous commit, the bug is already fixed a fiew commits before. (authored by Alexander Romanov (a.romanov)).
Revert own previous commit, the bug is already fixed a fiew commits before.
Mar 23 2017, 2:36 PM
Alexander Romanov (a.romanov) committed rB0b9041905faf: Fix (unreported) assertion in immBegin. Zerro number of points (Ctrl+LMouse… (authored by Alexander Romanov (a.romanov)).
Fix (unreported) assertion in immBegin. Zerro number of points (Ctrl+LMouse…
Mar 23 2017, 1:53 PM

Mar 22 2017

Alexander Romanov (a.romanov) committed rB8563d3b254cd: Create correct node after image file drag&drop for Blender Render (authored by Alexander Romanov (a.romanov)).
Create correct node after image file drag&drop for Blender Render
Mar 22 2017, 10:00 AM

Mar 21 2017

Tom Edwards (artfunkel) awarded rBa3f48d65df19: Datablock ID Properties a Like token.
Mar 21 2017, 9:38 PM
Alexander Romanov (a.romanov) committed rBa3f48d65df19: Datablock ID Properties (authored by Alexander Romanov (a.romanov)).
Datablock ID Properties
Mar 21 2017, 3:31 PM
Alexander Romanov (a.romanov) updated the diff for D113: Datablock ID Properties.

Atavistic changes in test_pointer_array have been reverted.
Handling idprops for sockets and bones in BKE_library_foreach_ID_link has been added.
Cleanup has been made.

Mar 21 2017, 3:09 PM

Mar 20 2017

Alexander Romanov (a.romanov) added a comment to D113: Datablock ID Properties.

I will update the patch and then will create a branch.

Mar 20 2017, 2:48 PM

Mar 1 2017

Alexander Romanov (a.romanov) updated D2425: Object Info node support for GLSL mode and the internal render.
Mar 1 2017, 4:46 PM
Alexander Romanov (a.romanov) updated the diff for D2467: Automatic scripts reload after path editing.

Implemented as automatic SCRIPT_OT_reload call in update callback.

Mar 1 2017, 4:25 PM · User Interface
Alexander Romanov (a.romanov) updated the diff for D113: Datablock ID Properties.

My previous thoughts were not correct. The crash was during scene switch with TemplateID after undo. This happened in RNA_property_pointer_set where RNA and IDProp were set simultaneously. This led to a bad pointer in C.screen["scene"] after undo. At the same time C.screen.scene was restored correctly.

Mar 1 2017, 3:26 PM

Feb 21 2017

Alexander Romanov (a.romanov) updated the diff for D113: Datablock ID Properties.
  1. The HashTable has been removed
  2. Scene copying has been improved
Feb 21 2017, 1:20 PM

Feb 13 2017

Alexander Romanov (a.romanov) updated the diff for D113: Datablock ID Properties.

minor fix: replace id_type_can_have_animdata -> BKE_animdata_from_id in BKE_library_id_can_use_idtype

Feb 13 2017, 2:45 PM