Fix breaking of apply pose OT

• Only initialise slider if event==NULL
• Move blend op text help to modal func

• Remove comments as per diff review

• Merge branch 'master' into T90182-blend-pose-slider
• Start blend at 0%

• Respond to comments:
• Check for socket input/output type

Respond to comments:

Still WIP, only had time to make a couple of changes! Probably shouldve kept them local..

Don't have time to do it now but todo:

Respond to comments:

Yeah, I'm not happy with how it looks even with reducing the threshold a lot.
I did these quick mockups, what do you think? I removed the icons from the headers to make it clearer they're headers, not buttons. I think I should've kept the icons for instances n volume grids so that they're consistent with the buttons?

In T46809#1341424, @Matheus Cavazotti (mmc) wrote:

@Campbell Barton (campbellbarton) How do I ask for someone to review my patch? I couldn't find the details about it in the wiki...

Is there a design task being worked on for this? I thought I'd start implementing it but it seems a bit confused. Will the nodes appear in the add menu as: asset_libary -> catalog -> node group, or will it be as @Julian Eisel (Severin) said with the more asset library-esque UI? I got it working to a basic level in the add menu, but without the add menu refactorings mentioned in T92825 .

@Hans Goudey (HooglyBoogly) I think this is all good to go, if my change fixed your null id crash

Thought I'd just ping @Hans Goudey (HooglyBoogly) , is this good to go?

In D14615#393096, @Hans Goudey (HooglyBoogly) wrote:

Do you mind updating the description to describe the change and the reasoning for moving the operator to C? I'll use that as the commit message then.

In D14615#393060, @Hans Goudey (HooglyBoogly) wrote:

Is this WIP for a specific reason? It looks pretty good to me. I just added a few comments about formatting inline.

• Address Comments

I'm trying to look into this but am struggling to find the link between geometry nodes and subd w/ gpu subdivision. Those are the two scenarios that cause the bug and I'm assuming they're linked, however I feel like I don't have enough knowledge about blender to investigate what both modifiers could be doing to corrupt the vertices. I did research it, and the drawing does still try to render the vertices, however it doesn't draw anything. I'm assuming then that it's an error with the data being passed the uv vert vertex shader?

• Check for id == NULL in poll

• Remove unnecessary update flags and RNA props

Not sure whether this code should be in object_modifier.c or a node operator in say node_add.cc. The only thing stopping me put it as a node operator is that 1. It assigns the node group to the object, and 2. It's specific to geo nodes, not generic for all node trees

Does this stop happening if you disable GPU subdivision? If so then I assume it's related to https://developer.blender.org/T96729 ?

• Use RNA_int_get instead of RNA_property_int_get

• Address more comments

• Address comments

• Format

• Increment id us, change tooltip

• Update tooltip to better represent functionality

• Use default value for all uses of get_mutable_attribute

• Overload get_mutable_attribute to accept default value

In D14588#391597, @Jacques Lucke (JacquesLucke) wrote:

Thanks for the patch. I think this should be generalized a bit, i.e. the expected default value should be passed to get_mutable_attribute.

• Remove WITH_OPENVDB definition

• Remove all build files, oops

• Merge branch 'master' into T85898-points-in-volume
• add keep Point cloud keep only
• Merge branch 'master' into T85898-points-in-volume
• Add node size to node declaration
• Add stable id output to grid mode

In D12636#349097, @Hans Goudey (HooglyBoogly) wrote:

• Did you verify that the stable ID didn't work with the grid mode? It seems like a straightforward idea to hash the positions, similarly to the distribute on faces node.

• fix rest of merge conflict shenanigans
• update to use modify_geometry_sets, removed shallow transform stuff :(
• update to work with latest master, remove stable id

Update diff to use modify_geometry_sets.

So the functionality of this when using a curve as target should accomplish the exact same as curve -> curve to mesh -> attribute proximity right? But be more efficient as it would skip the mesh conversion step?