I have tested and don't see any problem removing these lines.

NO idea now....maybe it was something old that it was in the code by error. If you can do transformations and modifiers are working without these lines, I guess must be safe to remove it.

Then maybe @Bastien Montagne (mont29) can help here with the Undo system.

• Update after first review

@Falk David (filedescriptor) any update with this High priority bug?

@Matias Mendiola (mendio) If you agree with the UI, we can approve the patch.

@Amélie Fondevilla (afonde) IIRC all icons definitions are done in anim_channels_defines.c

• Merge branch 'master' into asset-greasepencil

This is a design limitation. Every time you edit the parameter the object is recreated, so what you can do it's create a new material as you want and after changing the parameter, assign again manually your materials instead to try use the "default" material created.

Good Job! Code LGTM, but we need a review of Tooltips by @Matias Mendiola (mendio) and also a test by @Daniel Martinez Lara (pepeland) to be sure is doing what we expect.

Better fix in line 112:

@Aleš Jelovčan (frogstomp) Do you want to look at this?

@Aleš Jelovčan (frogstomp) Can you test?

LGTM

• Show option only for Strip Scene type

This issue has been solved in commit 9e9895b055d4 following the idea of @Matias Mendiola (mendio) described above. Now the closed strokes never are merged because it's not logic.

In T98235#1361303, @Matias Mendiola (mendio) wrote:

As you said @Antonio Vazquez (antoniov) the tool is intended to use only on opened strokes, can we just ignore closed strokes in the algorithm to avoid undesired results?

@Weronika Emilia Baran (soapydoll) I have tested with your file and I can convert it.... check your Outliner and you will see after the conversion a new Curve object. Remember that conversion uses the center line of the stroke, not the perimeter, so maybe you will need change the extrude value of the curve.

@Falk David (filedescriptor) IIRC you had a patch to fix this, no?

This is a limitation of the algorithm. When you use automerge, the main factor to merge is the distance, and depending of that, the stroke is merged. In general, automerge is not designed to merge with closed shapes, it's more to join a group of strokes that form a full stroke (for example, draw a curved shape drawing small strokes as it's done with a clasic pencil).

Yes, Timming was a very old feature but now I'm not sure is relevant.

Code LGTM... I would like a test from @Matias Mendiola (mendio) or @Daniel Martinez Lara (pepeland) before moving to master

• Cleanup function

• VSE: Cleanup review comments

@YimingWu (NicksBest) the bug was in 3.1... maybe you need apply the fix to 3.1 branch too, no?

@Sybren A. Stüvel (sybren) Could you help to @Amélie Fondevilla (afonde) in the problem she has.

I have tested the patch in Windows Visual Studio 2022 17.2.0 and the warnings are gone... still 3 warnings.

@Pablo Vazquez (pablovazquez) Thanks for the feedback...changes done!

• Replace and Data with & Data