Brecht Van Lommel (brecht)Administrator
Rendering Software Engineer

Projects (15)

User Details

User Since
Jan 3 2003, 6:23 PM (746 w, 3 d)
Roles
Administrator

Recent Activity

Yesterday

Brecht Van Lommel (brecht) added a comment to D2625: Cycles: Split vectorized types and math into separate files.

I'd say go ahead, we can always change directory layout later.

Mon, Apr 24, 9:59 PM
Brecht Van Lommel (brecht) updated subscribers of T51311: Support Alembic export/import of curve objects.
Mon, Apr 24, 9:30 PM · Alembic, BF Blender

Sun, Apr 23

Brecht Van Lommel (brecht) added a comment to rB14a4ce6d7fb4: CMake: move some Apple specific code into platform_apple_xcode.cmake..

Fixed by rBda82f6542460: CMake: Fix CMake for non Apple systems.

Sun, Apr 23, 7:22 PM
Brecht Van Lommel (brecht) committed rB14a4ce6d7fb4: CMake: move some Apple specific code into platform_apple_xcode.cmake. (authored by Brecht Van Lommel (brecht)).
CMake: move some Apple specific code into platform_apple_xcode.cmake.
Sun, Apr 23, 6:25 PM
Brecht Van Lommel (brecht) committed rBa192d5b81c8f: CMake: disable WITH_CODEC_QUICKTIME for macOS > 10.11 for configurations. (authored by Romain Foyard <romain_f>).
CMake: disable WITH_CODEC_QUICKTIME for macOS > 10.11 for configurations.
Sun, Apr 23, 6:25 PM
Brecht Van Lommel (brecht) closed D2645: Disable WITH_CODEC_QUICKTIME for macOS > 10.11 by committing rBa192d5b81c8f: CMake: disable WITH_CODEC_QUICKTIME for macOS > 10.11 for configurations. (authored by Romain Foyard <romain_f>).
Sun, Apr 23, 6:25 PM
Brecht Van Lommel (brecht) committed rBcedb1915fe82: CMake: fix wrong alembic test name on Windows. (authored by Brecht Van Lommel (brecht)).
CMake: fix wrong alembic test name on Windows.
Sun, Apr 23, 6:25 PM
Brecht Van Lommel (brecht) accepted D2645: Disable WITH_CODEC_QUICKTIME for macOS > 10.11.

Looks good to me, thanks!

Sun, Apr 23, 6:24 PM
Brecht Van Lommel (brecht) added a comment to rBL61849: Attempted fix for macOS 10.9 libraries missing _getentropy symbol error..

Great, thanks!

Sun, Apr 23, 5:38 PM
Brecht Van Lommel (brecht) abandoned D2646: Alembic unit test failed to configure on macOS.

Solver by rB20c9c1b44e13: OSX: satisfy macro to also apply alembic tests before I could review this..

Sun, Apr 23, 5:27 PM
Brecht Van Lommel (brecht) requested changes to D2593: Cycles Denoising: Part 4: Host side of the denoiser code.

Looks generally fine, mostly minor comments.

Sun, Apr 23, 5:16 PM
Brecht Van Lommel (brecht) accepted D2592: Cycles Denoising: Part 3: Denoiser Kernels.

Only quite superficially reviewed, but looks ok to commit.

Sun, Apr 23, 4:00 PM

Sat, Apr 22

Brecht Van Lommel (brecht) added inline comments to rBe6ee3fd9240b: Alembic unit tests: don't depend on ALEMBIC_ROOT_DIR being defined by user.
Sat, Apr 22, 4:23 PM
Brecht Van Lommel (brecht) added inline comments to rB6af131fa5cd9: Added simple unittests for Alembic exporter.
Sat, Apr 22, 4:19 PM
Brecht Van Lommel (brecht) closed T51224: Installation Error as "Invalid".

No reply for a week, closing unless more information is provided.

Sat, Apr 22, 3:20 PM · BF Blender
Brecht Van Lommel (brecht) closed T51238: X Mirror as "Invalid".

X Mirror seems to be working fine here. I think this is more a user support question for blender.stackexchange.com or blenderartists.org. X Mirror requires a mesh to be symmetric over the X axis, probably it's not exactly in your case.

Sat, Apr 22, 3:18 PM · BF Blender
Brecht Van Lommel (brecht) triaged T51287: MatrixUtils LERP incorrect interpolation as "Confirmed" priority.

@Campbell Barton (campbellbarton), the issue is that blend_m4_m4m4 assumes there is no shearing in the matrix, only scaling. Switching to interp_m4_m4m4 solves the problem but relies on Eigen, which means it can't work with MATH_STANDALONE.

Sat, Apr 22, 2:49 PM · BF Blender
Brecht Van Lommel (brecht) closed T51225: PNG Blender as "Invalid".

Closing due to lack of information, we can reopen if enough to redo the issue is provided.

Sat, Apr 22, 2:47 PM · BF Blender
Brecht Van Lommel (brecht) removed projects from T51239: On 2.80 open Data-Blocks for object, causes crash: Platform: Mac OS X, BF Blender.
Sat, Apr 22, 2:41 PM · Restricted Project
Brecht Van Lommel (brecht) merged T51250: Bone Heat Weighting: failed to find solution for one or more bones into T45493: Bone Heat weighting: failed.
Sat, Apr 22, 2:40 PM · BF Blender
Brecht Van Lommel (brecht) merged task T51250: Bone Heat Weighting: failed to find solution for one or more bones into T45493: Bone Heat weighting: failed.
Sat, Apr 22, 2:40 PM · BF Blender
Brecht Van Lommel (brecht) added a comment to T50383: Mouse jumps monitors on middle button release.

I don't know if works anywhere, just that all the OSes tested use the same xorg-server code. In the implemention of XIWarpPointer we find this comment, indicating Xinerama multi monitor support is missing.

/* FIXME: panoramix stuff is missing, look at ProcWarpPointer */
Sat, Apr 22, 5:56 AM · BF Blender
Brecht Van Lommel (brecht) requested changes to D2592: Cycles Denoising: Part 3: Denoiser Kernels.

Much better, thanks!

Sat, Apr 22, 2:49 AM
Brecht Van Lommel (brecht) added a comment to T50383: Mouse jumps monitors on middle button release.

The libxi/xorg implementation is the same on all those operating systems. We'll have to see if there is actually a bug there, it's just something we have to consider given how simple change the from XWarpPointer to XIWarpPointer is and the fact that this is a rarely used function which will not have been tested much.

Sat, Apr 22, 2:22 AM · BF Blender
Brecht Van Lommel (brecht) accepted D2591: Cycles Denoising: Part 2: Generating the feature passes in the kernel.

Looks good to me then.

Sat, Apr 22, 2:05 AM
Brecht Van Lommel (brecht) accepted D2590: Cycles Denoising: Part 1: Preparation changes.
Sat, Apr 22, 1:47 AM
Brecht Van Lommel (brecht) added a comment to T50383: Mouse jumps monitors on middle button release.

I don't have multiple monitors to test this, but some notes.

Sat, Apr 22, 12:04 AM · BF Blender

Fri, Apr 21

Brecht Van Lommel (brecht) merged T50870: 2.78a/2.78c problem with multiple xscreens (cursor capture broken while navigating in blender) into T50383: Mouse jumps monitors on middle button release.
Fri, Apr 21, 11:46 PM · BF Blender
Brecht Van Lommel (brecht) merged task T50870: 2.78a/2.78c problem with multiple xscreens (cursor capture broken while navigating in blender) into T50383: Mouse jumps monitors on middle button release.
Fri, Apr 21, 11:46 PM · Platform: Linux, BF Blender
Brecht Van Lommel (brecht) removed a reviewer for D2639: Axial Orientation: Brecht Van Lommel (brecht).
Fri, Apr 21, 4:50 AM
Brecht Van Lommel (brecht) removed a reviewer for D2640: Multiple Orientation for the Local manipulator: Brecht Van Lommel (brecht).
Fri, Apr 21, 4:50 AM
Brecht Van Lommel (brecht) removed a reviewer for D2641: Multiple Orientation for the Local manipulator: Brecht Van Lommel (brecht).
Fri, Apr 21, 4:49 AM

Thu, Apr 20

Brecht Van Lommel (brecht) added a comment to rB92d7b4b1c2b4: merging in master.

It's not committed to master, rather master was merged into this branch.

Thu, Apr 20, 9:38 PM
Brecht Van Lommel (brecht) requested changes to D2443: Render API/Cycles: Identify Render Passes by their Name instead of a type flag.

This seems to be working well in my testing.

Thu, Apr 20, 9:35 PM
Brecht Van Lommel (brecht) committed rB6c26911c3df6: Fix T51248: user preferences window size not adapted to DPI. (authored by Brecht Van Lommel (brecht)).
Fix T51248: user preferences window size not adapted to DPI.
Thu, Apr 20, 1:23 AM
Brecht Van Lommel (brecht) closed T51248: Default size of the User Preferences window does not account for DPI scale as "Resolved" by committing rB6c26911c3df6: Fix T51248: user preferences window size not adapted to DPI..
Thu, Apr 20, 1:23 AM · BF Blender

Tue, Apr 18

Brecht Van Lommel (brecht) added a comment to rBL61849: Attempted fix for macOS 10.9 libraries missing _getentropy symbol error..

I didn't get direct confirmation but also no further complaints. It would help if you could test 10.9 at some point.

Tue, Apr 18, 1:01 PM
Brecht Van Lommel (brecht) added a comment to D2313: Cycles Disney BRDF.

I think it would be good to rebase/squash everything together into one commit. No need to go through patches for that though, the easiest way to do that is to merge the branch into master like this:

git checkout master
git merge --squash cycles_disney_brdf
git commit
Tue, Apr 18, 11:37 AM · Cycles

Sun, Apr 16

Brecht Van Lommel (brecht) added a comment to T51231: OpenEXR DWA compression should not apply to non-color data passes.

Perhaps the best solution here would not be to change anything in Blender, but to fix OpenEXR to only apply lossy compression to the Y channel when it is the only channel or if it goes along with BY and RY channels.

Sun, Apr 16, 8:58 PM · BF Blender
Brecht Van Lommel (brecht) added a comment to T51231: OpenEXR DWA compression should not apply to non-color data passes.

Blender uses the default compression level of 45.

Sun, Apr 16, 8:53 PM · BF Blender
Brecht Van Lommel (brecht) closed T51226: Microdisplacement in cycles works with only one value in a particle system despite of passing different values per particle as "Archived".

Thanks for the report, but this is just a missing feature at this point, one of the reasons this feature is still marked as experimental.

Sun, Apr 16, 7:45 PM · BF Blender
Brecht Van Lommel (brecht) placed T51231: OpenEXR DWA compression should not apply to non-color data passes up for grabs.
Sun, Apr 16, 7:42 PM · BF Blender
Brecht Van Lommel (brecht) added a comment to T51231: OpenEXR DWA compression should not apply to non-color data passes.

I agree there is a bug here, renamed the title to reflect that. I don't think we need manual control, just for some passes with vector/ID/.. types instead of color we need to tell OpenEXR not to apply lossy compression.

Sun, Apr 16, 7:40 PM · BF Blender
Brecht Van Lommel (brecht) renamed T51231: OpenEXR DWA compression should not apply to non-color data passes from "Important missing Feature Request for DWAA and DWAB. " to "OpenEXR DWA compression should not apply to non-color data passes".
Sun, Apr 16, 7:35 PM · BF Blender

Sat, Apr 15

Brecht Van Lommel (brecht) added a comment to D2572: Fix T51023 by adding a separate (internal) clamp node.

Here's a simpler fix, to still execute the full mix node but avoid evaluating the other inputs. Any objections to doing this instead?

Sat, Apr 15, 2:03 AM · Cycles
Brecht Van Lommel (brecht) closed T51170: Program won't start I think its an opengl error as "Archived".

This sounds almost definitely like a driver installation issue, if other software is having similar issues it's unlikely this is something we can fix in Blender.

Sat, Apr 15, 12:58 AM · BF Blender
Brecht Van Lommel (brecht) closed T51171: Progress with the mouse cursor not working properly MacOS as "Archived".

The busy cursor appears when any program is not drawing or reacting to user input, and this script blocks Blender execution. The solution would be to avoid blocking the rest of Blender, by for example running tasks in a separate thread or using a modal operator.

Sat, Apr 15, 12:54 AM · User Interface, BF Blender
Brecht Van Lommel (brecht) added a comment to T51216: SSAO doesn't scale gracefully.

The issue is that the Strength needs to be set that high to compensate for the Attenuation being broken. After the fix it should be possible to get good results by only adjusting the Distance.

Sat, Apr 15, 12:47 AM · BF Blender
Brecht Van Lommel (brecht) committed rBe280c70aa942: Fix T51216: SSAO attenuation not being scale invariant. (authored by Brecht Van Lommel (brecht)).
Fix T51216: SSAO attenuation not being scale invariant.
Sat, Apr 15, 12:47 AM
Brecht Van Lommel (brecht) closed T51216: SSAO doesn't scale gracefully as "Resolved" by committing rBe280c70aa942: Fix T51216: SSAO attenuation not being scale invariant..
Sat, Apr 15, 12:46 AM · BF Blender

Fri, Apr 14

Brecht Van Lommel (brecht) added a comment to D2628: Cycles: Allow to render curve object as hair system.

So assuming Alembic has no concept of hair attached to a surface, I think that means:

  • The curves are already baked onto a deformed, subdivided and displaced surface. Maybe pushed a little into the surface to be sure it's connected.
  • UVs and other data are attributes on the curves, which ideally would be imported as curves custom data (which we do not support currently).
Fri, Apr 14, 8:01 PM
Brecht Van Lommel (brecht) accepted D2569: Cycles: Remove meaningless volume shaders.

Ok, looks good to me then.

Fri, Apr 14, 7:28 PM
Brecht Van Lommel (brecht) added a comment to D2443: Render API/Cycles: Identify Render Passes by their Name instead of a type flag.

@Stefan Werner (swerner), not sure if you already discussed this further with other Cycles devs, but I guess talk to Lukas about taking over this patch if it's important to you?

Fri, Apr 14, 5:26 PM
Brecht Van Lommel (brecht) requested changes to D2569: Cycles: Remove meaningless volume shaders.
Fri, Apr 14, 5:01 PM
Brecht Van Lommel (brecht) committed rB6fc7521adeec: Fix T49429: incorrect Blender internal viewport border render with DrawPixels… (authored by Brecht Van Lommel (brecht)).
Fix T49429: incorrect Blender internal viewport border render with DrawPixels…
Fri, Apr 14, 4:39 PM
Brecht Van Lommel (brecht) closed T49429: Using render border with real-time viewport Blender Internal rendering and DrawPixels Images Draw Method results in the wrong area being rendered as "Resolved" by committing rB6fc7521adeec: Fix T49429: incorrect Blender internal viewport border render with DrawPixels….
Fri, Apr 14, 4:39 PM · BF Blender
Brecht Van Lommel (brecht) accepted D2425: Object Info node support for GLSL mode and the internal render.

Great, looks good to me now. I confirmed the random values in Cycles stayed the same.

Fri, Apr 14, 4:13 PM
Brecht Van Lommel (brecht) accepted D2608: Allow HDR picking from Compositor background.

Fix looks good to me.

Fri, Apr 14, 4:06 PM
Brecht Van Lommel (brecht) accepted D2607: Switch eye dropper to use linear color space internally.

Looks good to me, patch seems to working as expected.

Fri, Apr 14, 4:03 PM
Brecht Van Lommel (brecht) added a comment to D2625: Cycles: Split vectorized types and math into separate files.

I meant intern/cycles/math/, containing both the type and math files, but it would indeed be a more intrusive change. Personally I prefer a flatter hierarchy, but don't mind conforming to the majority opinion if it's different.

Fri, Apr 14, 3:46 PM
Brecht Van Lommel (brecht) accepted D2626: GPU Matrix API: stick to a single 4x4 matrix stick for 2D and 3D.

Agreed, the fewer modes and states we need to keep track of the better.

Fri, Apr 14, 3:19 PM · Restricted Project
Brecht Van Lommel (brecht) accepted D2625: Cycles: Split vectorized types and math into separate files.

Looks good to me. I think a top level math/ folder would be good, to contain these types and other math functions, regardless if we make the private/public distinction.

Fri, Apr 14, 3:19 PM

Thu, Apr 13

Brecht Van Lommel (brecht) added a comment to D2313: Cycles Disney BRDF.

@Pascal Schön (VanCantus), do you have time to commit this to master and handle possible bug reports?

Thu, Apr 13, 5:58 PM · Cycles

Wed, Apr 12

Brecht Van Lommel (brecht) added a comment to T51178: "Restrict Render" doesn't keep objects from being rendered in Cycles Preview (CTRL+Z).

Note that pressing the RenderLayer button in the 3D view header gives results closer to what you get in a final render in the active render layer, including render visibility. In the Blender 2.8 design this can hopefully be solved better though.

Wed, Apr 12, 9:44 PM · BF Blender

Mon, Apr 10

Brecht Van Lommel (brecht) added a comment to D2425: Object Info node support for GLSL mode and the internal render.

We don't have an unsigned int type in RNA, but exposing it as an int should be fine. In practice casting unsigned int -> int -> unsigned int is a no-op.

Mon, Apr 10, 9:46 PM
Brecht Van Lommel (brecht) accepted D2280: Add missing UV tools in the UV/Image Editor Window > Tools tab.
Mon, Apr 10, 3:32 AM · User Interface, BF Blender

Sun, Apr 9

Brecht Van Lommel (brecht) added a comment to D2280: Add missing UV tools in the UV/Image Editor Window > Tools tab.

The panels weren't showing up for me when applying the patch, probably due to recent changes from rB9bdda427e6ff. They needed to be added to the classes list at the bottom of the file.

Sun, Apr 9, 7:59 PM · User Interface, BF Blender
Brecht Van Lommel (brecht) added inline comments to D2613: Cycles: Implement persistent storage for all scene data.
Sun, Apr 9, 7:30 PM
Brecht Van Lommel (brecht) closed T51121: Material ID and Object ID artifacts using Depth of Field or Motion blur as "Archived".

Correct, this is a known limitation. It's possible to do things like get the ID value for the closest object, but that's still almost equally useless in practice.

Sun, Apr 9, 7:23 PM · BF Blender
Brecht Van Lommel (brecht) added a comment to D2613: Cycles: Implement persistent storage for all scene data.

Nice, this is a feature I've always wantend, as evidenced by the optimistic persistent_data property name. Also for future network rendering this should be nice, where scene export can more easily become the bottleneck even for final frames.

Sun, Apr 9, 7:22 PM
Brecht Van Lommel (brecht) requested changes to D2425: Object Info node support for GLSL mode and the internal render.

Looks generally fine to me, always nice to have more complete GLSL support.

Sun, Apr 9, 6:52 PM
Brecht Van Lommel (brecht) requested changes to D2592: Cycles Denoising: Part 3: Denoiser Kernels.

Why aren't the filters kernels in kernel/? All this duplicated code in CMakeLists.txt, filter_compat_*.h, kernel_config.h is going to make it harder to maintain things.

Sun, Apr 9, 6:37 PM
Brecht Van Lommel (brecht) added inline comments to D2591: Cycles Denoising: Part 2: Generating the feature passes in the kernel.
Sun, Apr 9, 6:33 PM
Brecht Van Lommel (brecht) added a comment to D2590: Cycles Denoising: Part 1: Preparation changes.

What is the reason for moving N from the specific BSDFs to all of them? Hair and transparent do not have a valid normal, and since they are not really meaningful in those cases it seems better not to have them at all, so that they can't be used accidentally.

Sun, Apr 9, 5:39 PM

Sat, Apr 8

Brecht Van Lommel (brecht) added a comment to T51154: Decline in performance, an increase of over 209% in the rendering.

No problem, thanks for testing. Still kind of interesting that the 32 bit build is so much slower.

Sat, Apr 8, 10:36 PM · BF Blender, Cycles
Brecht Van Lommel (brecht) added a comment to T51154: Decline in performance, an increase of over 209% in the rendering.

The system info indicates you are using a 32 bit version (i686) though, so I think you might have downloaded the wrong build from builder.blender.org?

Sat, Apr 8, 9:05 PM · BF Blender, Cycles
Brecht Van Lommel (brecht) added a comment to T51154: Decline in performance, an increase of over 209% in the rendering.

Factory settings doesn't affect CPU device capabilities as far as I know.

Sat, Apr 8, 8:14 PM · BF Blender, Cycles

Wed, Apr 5

Brecht Van Lommel (brecht) committed rBL61849: Attempted fix for macOS 10.9 libraries missing _getentropy symbol error..
Attempted fix for macOS 10.9 libraries missing _getentropy symbol error.
Wed, Apr 5, 3:58 AM
Brecht Van Lommel (brecht) committed rBL61848: macOS 10.9 libraries updated to:.
macOS 10.9 libraries updated to:
Wed, Apr 5, 2:45 AM

Tue, Apr 4

Brecht Van Lommel (brecht) added a comment to D2313: Cycles Disney BRDF.

Looks good to commit.

Tue, Apr 4, 12:35 AM · Cycles

Mon, Apr 3

Brecht Van Lommel (brecht) accepted D2595: [Cycles/msvc] Get cycles_kernel compile time under control..

Great find, looks good to me.

Mon, Apr 3, 11:31 PM · Cycles

Sat, Apr 1

Brecht Van Lommel (brecht) added a comment to T51101: Icon Viewer broken in master.

Neither the old nor the new code worked correctly on high DPI displays, fixed now.

Sat, Apr 1, 12:36 AM · Addons
Brecht Van Lommel (brecht) committed rBAe0c236644bc9: Fix T51101: icon viewer addon not working correctly on high DPI displays. (authored by Brecht Van Lommel (brecht)).
Fix T51101: icon viewer addon not working correctly on high DPI displays.
Sat, Apr 1, 12:34 AM
Brecht Van Lommel (brecht) added a commit to T51101: Icon Viewer broken in master: rBAe0c236644bc9: Fix T51101: icon viewer addon not working correctly on high DPI displays..
Sat, Apr 1, 12:34 AM · Addons

Fri, Mar 31

Brecht Van Lommel (brecht) added inline comments to rB7c094f6079ac: Collada - Added some helper functions into collada_utils, for common usage in….
Fri, Mar 31, 7:36 PM
Brecht Van Lommel (brecht) added a comment to D2313: Cycles Disney BRDF.

The last patch worked with OpenCL and CUDA for me. I didn't try updating it to latest master, but I don't foresee a problem there.

Fri, Mar 31, 8:52 AM · Cycles

Thu, Mar 30

Brecht Van Lommel (brecht) closed T51084: Color display in Node Editor is not corresponding to its RGB values in Cycles as "Invalid".

Cycles works in a linear color space for physically based rendering, while Photoshop works in different color spaces like sRGB. See here for some info:
https://docs.blender.org/manual/en/dev/render/post_process/color_management.html#scene-linear-color-space

Thu, Mar 30, 1:40 PM · BF Blender
Brecht Van Lommel (brecht) added a comment to D2313: Cycles Disney BRDF.

Multiplying doesn't seem all that useful to me, for typical 0..1 textures it will just make the subsurface part darker than the diffuse part, for which there is no good justification I think. Controlling the result of two textures multiplied together also isn't very intuitive. A case could be made for having just a base color and no subsurface color at all, but having the separate subsurface color there is useful too. Since we're trying to match an existing standard we might as well follow it here and use blending.

Thu, Mar 30, 2:23 AM · Cycles

Wed, Mar 29

Brecht Van Lommel (brecht) merged T51053: Please help. Emergency into T50650: Windows10 breaks NVidia GPUs drivers after recent update - makes Blender UI very slow.
Wed, Mar 29, 10:56 AM · Platform: Windows, BF Blender
Brecht Van Lommel (brecht) added a comment to T51053: Please help. Emergency.

See T50650, there is a bug in the automatic Windows update of NVidia drivers. Uninstalling and reinstalling drivers manually should solve the problem.

Wed, Mar 29, 10:56 AM · BF Blender
Brecht Van Lommel (brecht) merged task T51053: Please help. Emergency into T50650: Windows10 breaks NVidia GPUs drivers after recent update - makes Blender UI very slow.
Wed, Mar 29, 10:56 AM · BF Blender
Brecht Van Lommel (brecht) closed T51076: Cycles transparent shader not providing ObjectID render layer if through a Mix node as "Invalid".

There can be only one object ID per pixel, so when objects are partially transparent it's unclear if it should use the object in front, behind, or the background. The Passes tab contains an Alpha Threshold to control this, which is set to 0.5 by default.

Wed, Mar 29, 10:54 AM · Cycles, BF Blender

Mon, Mar 27

Brecht Van Lommel (brecht) added a comment to D2530: Implementation of UV unwrapping with SLIM as disdussed on T48036..

I've pushed a bunch of changes to the rBuv_unwrapping_slim_algorithm branch:

  • Code refactoring to match code style
  • Transfer weights in construction, fix subsurf weights.
  • Avoid using scene toolsettings, this was old mechanism from before 2.5x.
  • Move SLIM integration behind into param_* API, reuse more LSCM code.
  • Fix issue with live unwrap and multiple pinned/non-pinned charts.
Mon, Mar 27, 10:48 PM
Brecht Van Lommel (brecht) committed rB58caf3121e9b: SLIM: reuse LSCM logic for pinning, to fix issue with multiple charts. (authored by Brecht Van Lommel (brecht)).
SLIM: reuse LSCM logic for pinning, to fix issue with multiple charts.
Mon, Mar 27, 10:44 PM
Brecht Van Lommel (brecht) committed rBbf2603baf6f4: SLIM: transfer weights in construction, fix subsurf case. (authored by Brecht Van Lommel (brecht)).
SLIM: transfer weights in construction, fix subsurf case.
Mon, Mar 27, 10:44 PM
Brecht Van Lommel (brecht) committed rB183ca1af3fcd: SLIM: move most SLIM integration behind param_* API, reuse more code. (authored by Brecht Van Lommel (brecht)).
SLIM: move most SLIM integration behind param_* API, reuse more code.
Mon, Mar 27, 10:44 PM
Brecht Van Lommel (brecht) committed rB2e662bbca477: SLIM: use operator history instead of toolsettings for remembering settings. (authored by Brecht Van Lommel (brecht)).
SLIM: use operator history instead of toolsettings for remembering settings.
Mon, Mar 27, 10:44 PM
Brecht Van Lommel (brecht) committed rB21bccefd1238: SLIM: move code around, no functional changes. (authored by Brecht Van Lommel (brecht)).
SLIM: move code around, no functional changes.
Mon, Mar 27, 10:44 PM
Brecht Van Lommel (brecht) committed rB65f32e105f44: SLIM: match code style. (authored by Brecht Van Lommel (brecht)).
SLIM: match code style.
Mon, Mar 27, 10:44 PM

Mar 25 2017

Brecht Van Lommel (brecht) added a comment to D2539: Add support for “Per monitor DPI scaling” on Windows 8.1 and later using a “Use system DPI” preference.

@Luca Rood (LucaRood), here is fine, I committed a possible fix now in rB393efccb19e4: Fix GHOST crash on X11 with recent DPI changes on some systems..

Mar 25 2017, 7:46 PM · BF Blender, User Interface