Brecht Van Lommel (brecht)Administrator
Rendering Software Engineer

Projects (16)

User Details

User Since
Jan 3 2003, 6:23 PM (768 w, 3 h)
Roles
Administrator

Recent Activity

Yesterday

Brecht Van Lommel (brecht) committed rB07ec0effb61e: Code cleanup: simplify kernel side work stealing code. (authored by Brecht Van Lommel (brecht)).
Code cleanup: simplify kernel side work stealing code.
Thu, Sep 21, 10:36 PM
Brecht Van Lommel (brecht) added a comment to rB01dfaac77b82: [cmake_deps/msvc] Move llvm/clang harvest to their individual cmake files..

We don't even even harvest clang for darwin currently, it's not used by anything. Latest OSL master started using clang libs for the preprocessor though, so it will be needed.

Thu, Sep 21, 9:44 PM
Brecht Van Lommel (brecht) added a comment to D2851: Collection enable/disable: use camera visibility as behaviour.

My opinion on all this is quite different from the design docs, but here it is.

Thu, Sep 21, 4:08 PM
Brecht Van Lommel (brecht) committed rBM3770: Fix broken canonical link (helps put latest version at top of search)..
Fix broken canonical link (helps put latest version at top of search).
Thu, Sep 21, 3:26 PM
Brecht Van Lommel (brecht) closed T52792: Spelling difference as "Resolved".

That new manual is already correct, just the old wiki manual had the mistake which I've fixed now.

Thu, Sep 21, 2:43 PM · User Interface, BF Blender

Wed, Sep 20

Brecht Van Lommel (brecht) added a reverting commit for rB8ad479a3227e: Fix T52792: Typo in UI label of a HairInfo node socket.: rB78c2242db5ae: Revert "Fix T52792: Typo in UI label of a HairInfo node socket.".
Wed, Sep 20, 10:06 PM
Brecht Van Lommel (brecht) committed rB78c2242db5ae: Revert "Fix T52792: Typo in UI label of a HairInfo node socket." (authored by Brecht Van Lommel (brecht)).
Revert "Fix T52792: Typo in UI label of a HairInfo node socket."
Wed, Sep 20, 10:06 PM
Brecht Van Lommel (brecht) added a commit to T52792: Spelling difference: rB78c2242db5ae: Revert "Fix T52792: Typo in UI label of a HairInfo node socket.".
Wed, Sep 20, 10:06 PM · User Interface, BF Blender
Brecht Van Lommel (brecht) added a comment to T52792: Spelling difference.

That was not a typo, it's this definition:

Wed, Sep 20, 9:33 PM · User Interface, BF Blender
Brecht Van Lommel (brecht) added a comment to T52852: Assert in looptri calculation after recent changes.

The difference is that Cycles uses the standard assert() which will abort, while Blender uses BLI_assert() which doesn't. I guess building with WITH_ASSERT_ABORT is ok. For the popups D2850 is a solution.

Wed, Sep 20, 9:15 PM · BF Blender
Brecht Van Lommel (brecht) added a comment to D2850: Windows: for background mode, don't show error popups for crashes..

I didn't test this by the way, but I believe it should help.

Wed, Sep 20, 9:13 PM
Brecht Van Lommel (brecht) created D2850: Windows: for background mode, don't show error popups for crashes..
Wed, Sep 20, 9:12 PM
Brecht Van Lommel (brecht) added a revision to T52852: Assert in looptri calculation after recent changes: D2850: Windows: for background mode, don't show error popups for crashes..
Wed, Sep 20, 9:12 PM · BF Blender
Brecht Van Lommel (brecht) added a revision to T52853: [ctest/Cycles_render_test] autosmooth_custom_normals test failing.: D2850: Windows: for background mode, don't show error popups for crashes..
Wed, Sep 20, 9:12 PM · Restricted Project, Cycles
Brecht Van Lommel (brecht) added a comment to T52852: Assert in looptri calculation after recent changes.

Right, it will only crash when building with WITH_ASSERT_ABORT. Not sure what the best way is to solve that, perhaps a --debug-abort command line option to enable aborting at runtime?

Wed, Sep 20, 8:39 PM · BF Blender
Brecht Van Lommel (brecht) closed T52854: [ctest/cycles_reports] T52368 fails on x86 as "Resolved".

This should be fixed by rB18a353dd2422: Fix T52368: Cycles OSL trace() failing on Windows 32 bit., I mentioned the wrong report number in that commit.

Wed, Sep 20, 8:14 PM · Restricted Project, Cycles
Brecht Van Lommel (brecht) renamed T52852: Assert in looptri calculation after recent changes from "[Ctest/cycles_report_test] Assert fires, test still succeeds." to "Assert in looptri calculation after recent changes".
Wed, Sep 20, 8:12 PM · BF Blender
Brecht Van Lommel (brecht) reassigned T52852: Assert in looptri calculation after recent changes from Sergey Sharybin (sergey) to Bastien Montagne (mont29).

This is new code from rB9591b5f6182f: Fix T52816: regression can't open file in 2.79 (crash)..

Wed, Sep 20, 8:11 PM · BF Blender
Brecht Van Lommel (brecht) committed rBL61940: Cycles tests: update for defensive and other sampling changes..
Cycles tests: update for defensive and other sampling changes.
Wed, Sep 20, 8:04 PM
Brecht Van Lommel (brecht) committed rB18a353dd2422: Fix T52368: Cycles OSL trace() failing on Windows 32 bit. (authored by Brecht Van Lommel (brecht)).
Fix T52368: Cycles OSL trace() failing on Windows 32 bit.
Wed, Sep 20, 8:01 PM
Brecht Van Lommel (brecht) committed rB14223357e593: Fix T52853: harmless Cycles test failure in debug mode. (authored by Brecht Van Lommel (brecht)).
Fix T52853: harmless Cycles test failure in debug mode.
Wed, Sep 20, 8:01 PM
Brecht Van Lommel (brecht) added a commit to T52368: OSL trace not working in 2.79 RC!: rB18a353dd2422: Fix T52368: Cycles OSL trace() failing on Windows 32 bit..
Wed, Sep 20, 8:01 PM · Cycles, BF Blender: Regressions, BF Blender
Brecht Van Lommel (brecht) committed rB90d4b823d729: Cycles: use defensive sampling for picking BSDFs and BSSRDFs. (authored by Brecht Van Lommel (brecht)).
Cycles: use defensive sampling for picking BSDFs and BSSRDFs.
Wed, Sep 20, 8:01 PM
Brecht Van Lommel (brecht) committed rB095a01a73a35: Cycles: slightly improve BSDF sample stratification for path tracing. (authored by Brecht Van Lommel (brecht)).
Cycles: slightly improve BSDF sample stratification for path tracing.
Wed, Sep 20, 8:01 PM
Brecht Van Lommel (brecht) closed T52853: [ctest/Cycles_render_test] autosmooth_custom_normals test failing. as "Resolved" by committing rB14223357e593: Fix T52853: harmless Cycles test failure in debug mode..
Wed, Sep 20, 8:01 PM · Restricted Project, Cycles
Brecht Van Lommel (brecht) committed rBd029399e6b6d: Code cleanup: remove SOBOL_SKIP hack, seems no longer needed. (authored by Brecht Van Lommel (brecht)).
Code cleanup: remove SOBOL_SKIP hack, seems no longer needed.
Wed, Sep 20, 8:00 PM
Brecht Van Lommel (brecht) committed rBb3afc8917cde: Code cleanup: refactor BSSRDF closure sampling, for next commit. (authored by Brecht Van Lommel (brecht)).
Code cleanup: refactor BSSRDF closure sampling, for next commit.
Wed, Sep 20, 8:00 PM
Brecht Van Lommel (brecht) committed rBd750d182e58f: Code cleanup: remove hack to avoid seeing transparent objects in noise. (authored by Brecht Van Lommel (brecht)).
Code cleanup: remove hack to avoid seeing transparent objects in noise.
Wed, Sep 20, 8:00 PM
Brecht Van Lommel (brecht) committed rB8289b47e3a42: Fix Cycles test report not closing files properly. (authored by Brecht Van Lommel (brecht)).
Fix Cycles test report not closing files properly.
Wed, Sep 20, 7:34 PM
Brecht Van Lommel (brecht) added a comment to rBL61938: macOS 10.9, add python 3.6.2 with numpy 1.13.1.

If you want to leave the 3.5 libs for a while that's fine with me.

Wed, Sep 20, 6:03 PM
Brecht Van Lommel (brecht) edited P533 (An Untitled Masterwork).
Wed, Sep 20, 5:54 PM
Brecht Van Lommel (brecht) edited P533 (An Untitled Masterwork).
Wed, Sep 20, 5:40 PM
Brecht Van Lommel (brecht) created P533 (An Untitled Masterwork).
Wed, Sep 20, 5:29 PM
Brecht Van Lommel (brecht) added a comment to rBL61938: macOS 10.9, add python 3.6.2 with numpy 1.13.1.

It seems libpython3.6m.a is missing from this commit? Also I think we can remove all the 3.5 files.

Wed, Sep 20, 5:03 PM
Brecht Van Lommel (brecht) added a comment to T52669: Wrong shadow direction with 1-sided material.

If the floor was a mirror, you'd expect the reflection to show the front side of the text. If you increase the roughness of the floor that reflection gradually turns into a shadow.

Wed, Sep 20, 12:50 AM · BF Blender

Tue, Sep 19

Brecht Van Lommel (brecht) added a comment to T52669: Wrong shadow direction with 1-sided material.

Link Is Shadow Ray and Backfacing to an Invert node, link the output of that to the Mix Shader.

Tue, Sep 19, 11:13 PM · BF Blender
Brecht Van Lommel (brecht) closed T52695: Error render as "Archived".

Closing due to lack of steps to redo the issue, we can reopen if the requested info is provided.

Tue, Sep 19, 10:50 PM · BF Blender
Brecht Van Lommel (brecht) reopened T52645: Cycles: OpenCL compiler crashes with new AMD drivers as "Open".

Reopening since this is not solved.

Tue, Sep 19, 10:44 PM · BF Blender
Brecht Van Lommel (brecht) renamed T52645: Cycles: OpenCL compiler crashes with new AMD drivers from "Cycles: OpenCL compiler crashes sometimes while building kernels" to "Cycles: OpenCL compiler crashes with new AMD drivers".
Tue, Sep 19, 10:43 PM · BF Blender
Brecht Van Lommel (brecht) merged T52821: Blender 2.79 - GPU Rendering - Loading Render Kernels (This can take a few minutes the first time) - CRASH into T52645: Cycles: OpenCL compiler crashes with new AMD drivers.
Tue, Sep 19, 10:43 PM · BF Blender
Brecht Van Lommel (brecht) merged task T52821: Blender 2.79 - GPU Rendering - Loading Render Kernels (This can take a few minutes the first time) - CRASH into T52645: Cycles: OpenCL compiler crashes with new AMD drivers.
Tue, Sep 19, 10:43 PM · BF Blender
Brecht Van Lommel (brecht) added a comment to T52669: Wrong shadow direction with 1-sided material.

I understand, you can do this with Light Path > Is Shadow Ray, flipping what's considered the backside. We will not change the default behavior.

Tue, Sep 19, 10:36 PM · BF Blender
Brecht Van Lommel (brecht) added a comment to T52827: Proposal, RNA API direct memory access for arrays via buffer protocol.

There's RNA_property_collection_raw_array for this, which if it succeeds means it's safe to read and write values I think.

Tue, Sep 19, 2:16 PM · BF Blender: 2.8
Brecht Van Lommel (brecht) added a comment to T52725: Branched path unification.

Here's a comparison using a shot from Agent, where branched path is the clear winner:

PathBranched Path
Tue, Sep 19, 1:50 AM · Cycles
Brecht Van Lommel (brecht) added a comment to D2726: Principled BSDF as default shader in Cycles.

Yes, you can change the default in master and blender2.8 now, but note:

Tue, Sep 19, 1:15 AM · Cycles

Mon, Sep 18

Brecht Van Lommel (brecht) committed rBd0d9360a6663: Fix T52800: fix UI flickering with Mesa on Linux. (authored by Brecht Van Lommel (brecht)).
Fix T52800: fix UI flickering with Mesa on Linux.
Mon, Sep 18, 1:22 PM
Brecht Van Lommel (brecht) closed T52800: Wrong interface with Mesa 17.2.0 as "Resolved" by committing rBd0d9360a6663: Fix T52800: fix UI flickering with Mesa on Linux..
Mon, Sep 18, 1:22 PM · BF Blender
Brecht Van Lommel (brecht) committed rBab9079f45986: Fix Cycles adaptive compile without volumes broken after recent changes. (authored by Carlo Andreacchio (candreacchio)).
Fix Cycles adaptive compile without volumes broken after recent changes.
Mon, Sep 18, 1:09 PM
Brecht Van Lommel (brecht) closed D2847: Fix compiling cycles without Volumetrics enabled by committing rBab9079f45986: Fix Cycles adaptive compile without volumes broken after recent changes. (authored by Carlo Andreacchio (candreacchio)).
Mon, Sep 18, 1:09 PM · Cycles
Brecht Van Lommel (brecht) committed rB6bf3dfbcdb93: Fix T52801: reload scripts causes Cycles viewport render crash. (authored by Brecht Van Lommel (brecht)).
Fix T52801: reload scripts causes Cycles viewport render crash.
Mon, Sep 18, 1:09 PM
Brecht Van Lommel (brecht) closed T52801: Cycles Rendered Viewport + Reload Scripts = Crash as "Resolved" by committing rB6bf3dfbcdb93: Fix T52801: reload scripts causes Cycles viewport render crash..
Mon, Sep 18, 1:09 PM · BF Blender
Brecht Van Lommel (brecht) accepted D2847: Fix compiling cycles without Volumetrics enabled.

Thanks, I'll commit this.

Mon, Sep 18, 12:45 PM · Cycles
Brecht Van Lommel (brecht) added a comment to T52802: Denoise artifacts with Direct Glossy.

Perhaps the denoising should work on log(glossy) or some other kind of remapping to bring the extreme values into a smaller range.

Mon, Sep 18, 12:37 PM · Cycles, BF Blender
Brecht Van Lommel (brecht) renamed T52800: Wrong interface with Mesa 17.2.0 from "Wrong interface with Mesa 1.7.2" to "Wrong interface with Mesa 17.2.0".
Mon, Sep 18, 4:08 AM · BF Blender
Brecht Van Lommel (brecht) triaged T52800: Wrong interface with Mesa 17.2.0 as "Incomplete" priority.

To be clear, the Mesa versions you are referring to are 17.1.8 and 17.2.0.

Mon, Sep 18, 4:07 AM · BF Blender
Brecht Van Lommel (brecht) claimed T52801: Cycles Rendered Viewport + Reload Scripts = Crash.
Mon, Sep 18, 3:48 AM · BF Blender

Sun, Sep 17

Brecht Van Lommel (brecht) closed T52787: Blender not working correctly once streaming program xSplit or OBS opened. Multiple restart of both (often not working together!) required to fix it temporarly. as "Archived".

Thanks for the report, but this sounds like an issue for OBS or xSplit to solve, better report it to them because it's unlikely we can fix this in Blender. There may also be options in them that you could try tweaking to see if it makes things works with Blender.

Sun, Sep 17, 1:40 AM · BF Blender
Brecht Van Lommel (brecht) merged T52790: Flip Names keep Number Extension into T52685: Flip names for bones its not working .
Sun, Sep 17, 1:27 AM · BF Blender
Brecht Van Lommel (brecht) merged task T52790: Flip Names keep Number Extension into T52685: Flip names for bones its not working .
Sun, Sep 17, 1:27 AM · BF Blender
Brecht Van Lommel (brecht) triaged T52788: 2.79 Cuda crash as "Incomplete" priority.

Also if this doesn't happen with the default start .blend, please attach the .blend for us to repro the issue.

Sun, Sep 17, 1:20 AM · BF Blender
Brecht Van Lommel (brecht) added a comment to T52783: Blender zoom problem.

This is a bug in the Intel graphics driver, the latest drivers from the Intel website apparently solved this (see T51521: Incorrect windows scaling - mouse offset from view - menu bar invisible).

Sun, Sep 17, 1:19 AM · BF Blender
Brecht Van Lommel (brecht) merged T52783: Blender zoom problem into T51521: Incorrect windows scaling - mouse offset from view - menu bar invisible.
Sun, Sep 17, 1:19 AM · BF Blender
Brecht Van Lommel (brecht) merged task T52783: Blender zoom problem into T51521: Incorrect windows scaling - mouse offset from view - menu bar invisible.
Sun, Sep 17, 1:19 AM · BF Blender
Brecht Van Lommel (brecht) added a comment to T52773: Isn't in the exact resolution, and doesn't show full screen.

This is a bug in the Intel graphics driver, the latest drivers from the Intel website apparently solved this (see T51521: Incorrect windows scaling - mouse offset from view - menu bar invisible).

Sun, Sep 17, 1:18 AM · Platform: Windows, BF Blender
Brecht Van Lommel (brecht) merged T52773: Isn't in the exact resolution, and doesn't show full screen into T51521: Incorrect windows scaling - mouse offset from view - menu bar invisible.
Sun, Sep 17, 1:18 AM · BF Blender
Brecht Van Lommel (brecht) merged task T52773: Isn't in the exact resolution, and doesn't show full screen into T51521: Incorrect windows scaling - mouse offset from view - menu bar invisible.
Sun, Sep 17, 1:18 AM · Platform: Windows, BF Blender
Brecht Van Lommel (brecht) added a comment to T52789: I cant see the menu bar.

This is a bug in the Intel graphics driver, the latest drivers from the Intel website apparently solved this (see T51521: Incorrect windows scaling - mouse offset from view - menu bar invisible).

Sun, Sep 17, 1:18 AM · BF Blender
Brecht Van Lommel (brecht) merged T52789: I cant see the menu bar into T51521: Incorrect windows scaling - mouse offset from view - menu bar invisible.
Sun, Sep 17, 1:18 AM · BF Blender
Brecht Van Lommel (brecht) merged task T52789: I cant see the menu bar into T51521: Incorrect windows scaling - mouse offset from view - menu bar invisible.
Sun, Sep 17, 1:18 AM · BF Blender

Fri, Sep 15

Brecht Van Lommel (brecht) added a comment to D2842: Bring engines to workspace and UI sanitize.

Actually, per the current design, the window is what unifies things. That's why we need a top bar. We want the entire Blender talking about the same data, on the same state.
The window then pick a workspace and a scene. The scene is used to expose layers for the workspace. The workspace is what defines the engine + layer + settings that will be "followed" by the rest of the UI.

Fri, Sep 15, 8:16 PM
Brecht Van Lommel (brecht) added a comment to D2842: Bring engines to workspace and UI sanitize.

The "use_scene_settings" is affecting the layer[*], engine and settings. It's something that affects the entire window, and all the editors. If you add a new node, the poll should take the engine into consideration. If you are looking at visible objects in the dopesheet, it should take the layer into consideration. If you change the material and want to see the material preview in the properties editor, you are using it render settings.

By staying away frow viewport specific settings we end up allowing the whole window to work in a unified way, following the data as determined by the workspace/topbar.

Fri, Sep 15, 1:36 PM

Thu, Sep 14

Brecht Van Lommel (brecht) added a comment to D2842: Bring engines to workspace and UI sanitize.

Thanks for the explanation.

Thu, Sep 14, 3:00 PM
Brecht Van Lommel (brecht) added a comment to D2842: Bring engines to workspace and UI sanitize.

Making engines workspace data is very surprising to me, was there some design discussion or document about this that I missed?

Thu, Sep 14, 1:11 PM
Brecht Van Lommel (brecht) added a comment to T52725: Branched path unification.

Here's a few initial equal time renders from benchmark scenes, rendered on the CPU. The branched path settings have been tweaked to try to reduce noise, but there may exist better settings. The difficulty of tuning the settings is part of the reason we want to unify this though.

Thu, Sep 14, 3:05 AM · Cycles

Wed, Sep 13

Brecht Van Lommel (brecht) created T52725: Branched path unification.
Wed, Sep 13, 3:32 PM · Cycles
Brecht Van Lommel (brecht) committed rB9e258fc641e9: Code cleanup: avoid used of uninitialized value in case of precision issue. (authored by Brecht Van Lommel (brecht)).
Code cleanup: avoid used of uninitialized value in case of precision issue.
Wed, Sep 13, 3:31 PM
Brecht Van Lommel (brecht) committed rB32449e1b2135: Code cleanup: store branch factor in PathState. (authored by Brecht Van Lommel (brecht)).
Code cleanup: store branch factor in PathState.
Wed, Sep 13, 3:31 PM
Brecht Van Lommel (brecht) committed rBf77cdd1d59f6: Code cleanup: deduplicate some branched and split kernel code. (authored by Brecht Van Lommel (brecht)).
Code cleanup: deduplicate some branched and split kernel code.
Wed, Sep 13, 3:31 PM
Brecht Van Lommel (brecht) committed rB37d9e65ddfe0: Code cleanup: abstract shadow catcher logic more into accumulation code. (authored by Brecht Van Lommel (brecht)).
Code cleanup: abstract shadow catcher logic more into accumulation code.
Wed, Sep 13, 3:31 PM
Brecht Van Lommel (brecht) committed rBc4c450045d07: Code cleanup: tweak inlining for 2% better CUDA performance with hair. (authored by Brecht Van Lommel (brecht)).
Code cleanup: tweak inlining for 2% better CUDA performance with hair.
Wed, Sep 13, 3:30 PM
Brecht Van Lommel (brecht) triaged T52719: Version 2.79 for macOS is not code signed as "Normal" priority.

CC @Arto Kitula (akitula), @Martijn Berger (juicyfruit).

Wed, Sep 13, 12:11 PM · Platform: Mac OS X, BF Blender
Brecht Van Lommel (brecht) added a comment to T52695: Error render.

You can check that you have a valid path in the Output panel of the Render properties, the path may not exists or you might not have permission to write to that location.

Wed, Sep 13, 12:09 PM · BF Blender
Brecht Van Lommel (brecht) triaged T52722: vertex colors node issue as "Incomplete" priority.

Please give exact steps to reproduce the issue, ideally just a .blend that we can render. Vertex colors seems to be working fine here.

Wed, Sep 13, 12:07 PM · BF Blender
Brecht Van Lommel (brecht) reopened T52720: Matrix lost many float's precision in last column only? as "Open".

@Bastien Montagne (mont29), didn't see your reply before I commented, if you think there's a bug here will let you handle it.

Wed, Sep 13, 12:06 PM · Python, BF Blender
Brecht Van Lommel (brecht) closed T52720: Matrix lost many float's precision in last column only? as "Archived".

This is normal. Single precision floats only have 6-7 digits of precision, so for large numbers like in the last column there will be loss of precision. Python uses double precision but for Blender itself this would have a significant performance / memory impact.

Wed, Sep 13, 12:04 PM · Python, BF Blender

Tue, Sep 12

Brecht Van Lommel (brecht) added a comment to T52593: Eevee: viewport issues before toggling AO support.

I think that's just something we have to follow, we've encountered that issue before. Either you bind all the textures or compile a different shader that doesn't have those textures. I don't know if the specification requires it, but there's enough drivers that just don't work otherwise.

Tue, Sep 12, 4:18 PM · BF Blender: 2.8
Brecht Van Lommel (brecht) added a comment to D2818: 1.5x to 2x faster interiors rendering with optimized AO approx for cycles.

Thanks for the changes, committed now.

Tue, Sep 12, 3:40 PM
Brecht Van Lommel (brecht) committed rBL61935: Cycles tests: update for AO approximation changes..
Cycles tests: update for AO approximation changes.
Tue, Sep 12, 3:39 PM
Brecht Van Lommel (brecht) committed rB659ba012b0f3: Cycles: change AO bounces approximation to do more glossy and transmission. (authored by Mathieu Menuet <bliblubli>).
Cycles: change AO bounces approximation to do more glossy and transmission.
Tue, Sep 12, 3:38 PM
Brecht Van Lommel (brecht) closed D2818: 1.5x to 2x faster interiors rendering with optimized AO approx for cycles by committing rB659ba012b0f3: Cycles: change AO bounces approximation to do more glossy and transmission. (authored by Mathieu Menuet <bliblubli>).
Tue, Sep 12, 3:38 PM
Brecht Van Lommel (brecht) committed rBL61932: Cycles tests: update for RR fix and area light sample stratification..
Cycles tests: update for RR fix and area light sample stratification.
Tue, Sep 12, 1:07 PM
Brecht Van Lommel (brecht) added a comment to rBcd6c9e9e5f47: Cycles: improve sample stratification on area lights for path tracing..

Multiple area lights example from the tests:

OldNew
Tue, Sep 12, 1:06 PM
Brecht Van Lommel (brecht) committed rBde6ecc82ed2d: Fix rare firefly in volume equiangular sampling when sampling short distance. (authored by Brecht Van Lommel (brecht)).
Fix rare firefly in volume equiangular sampling when sampling short distance.
Tue, Sep 12, 1:01 PM
Brecht Van Lommel (brecht) committed rB28532f18672b: Cycles tests: add environment variable to update references renders. (authored by Brecht Van Lommel (brecht)).
Cycles tests: add environment variable to update references renders.
Tue, Sep 12, 1:01 PM
Brecht Van Lommel (brecht) committed rBcd6c9e9e5f47: Cycles: improve sample stratification on area lights for path tracing. (authored by Brecht Van Lommel (brecht)).
Cycles: improve sample stratification on area lights for path tracing.
Tue, Sep 12, 1:01 PM
Brecht Van Lommel (brecht) committed rBd454a44e9664: Fix Cycles bug in RR termination, probability should never be > 1.0. (authored by Brecht Van Lommel (brecht)).
Fix Cycles bug in RR termination, probability should never be > 1.0.
Tue, Sep 12, 1:01 PM
Brecht Van Lommel (brecht) accepted D2837: \0;115;0cFix T52679: Hole in bake normal.

Makes sense to me.

Tue, Sep 12, 12:39 PM

Mon, Sep 11

Brecht Van Lommel (brecht) added a comment to T52680: Alpha difference Viewport/F12 .

I'm fine with making Cycles viewport render consistent with the image editor, even if it looks worse for fire, and then do further improvements later.

Mon, Sep 11, 11:09 PM · BF Blender
Brecht Van Lommel (brecht) added a comment to T52610: Paint line stroke - interpolation steps/aliasing.

I've added it to the list here:
https://wiki.blender.org/index.php/Dev:Source/Development/Todo/Tools#Painting

Mon, Sep 11, 3:25 PM · Sculpting and Painting, BF Blender
Brecht Van Lommel (brecht) added a comment to T52680: Alpha difference Viewport/F12 .

The inconsistency comes from passing false for predivide in engine_bind_display_space_shader, whereas the image editor works as if it's set to true.

Mon, Sep 11, 2:00 PM · BF Blender